29153 Commits

Author SHA1 Message Date
Jonah Williams
1c779442a0
Add null checks to coverage collection (#31092) 2019-04-15 17:33:28 -07:00
xster
364d73c7d8
Make CupertinoNavigationBarBackButton correctly return an assert error (#30815) 2019-04-15 15:33:33 -07:00
engine-flutter-autoroll
d628537172
Roll engine c3824f06933a..324b8403e8a6 (13 commits) (#31082)
c3824f0693...324b8403e8

git log c3824f06933af54b54d1094594c0159828dd1a45..324b8403e8a67db7376f85ed29e0a5792174cca0 --no-merges --oneline
324b8403e Remove the flutter_aot GN argument. (flutter/engine#8581)
571ce945b Roll src/third_party/skia 1875353110d1..bf15b6676843 (8 commits) (flutter/engine#8582)
b7d484e4f Roll src/third_party/skia 1fe0b86f17f3..1875353110d1 (5 commits) (flutter/engine#8580)
73f455a3c Roll src/third_party/skia e1c5ea6779f4..1fe0b86f17f3 (1 commits) (flutter/engine#8579)
42d06b370 Roll src/third_party/skia 3611ee1bb157..e1c5ea6779f4 (3 commits) (flutter/engine#8578)
eb575e24a Roll src/third_party/skia c9f55de2ed39..3611ee1bb157 (1 commits) (flutter/engine#8577)
40473d39a Roll src/third_party/skia b5e57e9a3d0f..c9f55de2ed39 (1 commits) (flutter/engine#8576)
dc952bcd4 Roll src/third_party/skia 5c6b565bdfb9..b5e57e9a3d0f (1 commits) (flutter/engine#8575)
14a1db2b6 Roll src/third_party/skia 12cf258193dc..5c6b565bdfb9 (1 commits) (flutter/engine#8573)
dcd0209bd Roll src/third_party/skia 33233a09fef8..12cf258193dc (1 commits) (flutter/engine#8572)
e0b9bc18f Roll src/third_party/skia 69f54f8f0f22..33233a09fef8 (1 commits) (flutter/engine#8571)
9f9d5d6da Roll src/third_party/skia 990bfc785891..69f54f8f0f22 (1 commits) (flutter/engine#8570)
7c7df0d58 Add null check in FLETextInputPlugin (flutter/engine#8538)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-15 18:16:18 -04:00
Justin McCandless
ec7f3f0956
2d transforms UX improvements (#30932)
Small usability fixes for pan and zoom demo. Title and instruction dialog.
2019-04-15 15:11:26 -07:00
liyuqian
a8116e9ea3
Allow profile widget builds in profile mode (#30990)
## Description

Previously, such function is only available in the debug mode. But the
performance information is very noisy in debug mode with JIT. I feel
that such function is as important and useful as the performance overlay
and the `--trace-skia` option for the GPU thread.  So we should give it
the same ability to run in both profile and debug mode.

I've tested it using flutter_gallery in the profile mode. There's no
observable difference in the performance overlay between toggling widget
build profiling.

## Related Issues

https://github.com/flutter/flutter/issues/30984
2019-04-15 13:57:43 -07:00
Dan Field
330dc94c0f Check that ErrorWidget.builder is not modified after test (#30898) 2019-04-15 12:38:51 -07:00
Jonah Williams
28cb589cd3
make flutterProject option of CoverageCollector optional (#31074) 2019-04-15 12:26:43 -07:00
liyuqian
b0937a1e89
Fix the warning test by checking stderr (#30997)
Previously, I used the Android emulator for testing and everything
seemed to work fine with stdout (if I remember correctly). But our
devicelab uses real Android devices and the warnings are routed to
stderr. Hence change stdout to stderr in the test.
2019-04-15 10:19:36 -07:00
Christopher Fujino
be5f345f33
New flag to flutter drive to skip installing fresh app on device (#30818)
* add a --build/--no-build flag to flutter drive command
2019-04-15 09:31:51 -07:00
engine-flutter-autoroll
259fe4494d
Roll engine 9aa7c9a48e93..c3824f06933a (13 commits) (#31002)
9aa7c9a48e...c3824f0693

git log 9aa7c9a48e9342a450c3078e15c8d7923a338ede..c3824f06933af54b54d1094594c0159828dd1a45 --no-merges --oneline
c3824f069 Roll src/third_party/skia e62bf561638c..990bfc785891 (2 commits) (flutter/engine#8569)
49a72e1e4 Roll src/third_party/skia 8be917af4313..e62bf561638c (5 commits) (flutter/engine#8568)
7292d62ef Revert Versions API (flutter/engine#7828)
9336671a8 Revert "Roll src/third_party/dart a8f3a5dae6..c2eb9a9860 (8 commits)" (flutter/engine#8567)
a54354349 Roll src/third_party/dart a8f3a5dae6..c2eb9a9860 (8 commits)
23b0e02ec Android Embedding PR29: Improve FlutterFragment construction API + engine config API. (flutter/engine#8540)
e6c822db9 Roll src/third_party/skia 25071cc52b4b..8be917af4313 (6 commits) (flutter/engine#8564)
1bb2c0cf0 Remove unused import in FlutterActivityDelegate (flutter/engine#8563)
ad04340e5 Add missing <memory> include to text_input_model.h (flutter/engine#8562)
fcd717e28 Update README.md to point to flutter.dev (flutter/engine#8557)
501892a92 Roll src/third_party/skia 35f1c154c5e5..25071cc52b4b (7 commits) (flutter/engine#8560)
db99c86ab Roll src/third_party/skia 41476708db86..35f1c154c5e5 (1 commits) (flutter/engine#8559)
a88cd8032 Roll src/third_party/skia f74fff660084..41476708db86 (1 commits) (flutter/engine#8558)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-04-15 12:03:24 -04:00
Dan Field
99bd2795b0 Add rrect contains microbenchmark (#30985) 2019-04-15 09:01:40 -07:00
Jonah Williams
715cb5132e
Fix bugs in contrast guideline and improve heuristic (#31000) 2019-04-15 09:01:09 -07:00
Jonah Williams
301eaa8c32
Make coverage, like, really fast (#30811) 2019-04-15 08:59:28 -07:00
Jonah Williams
27b058a414
Revert "revert last 2 engine rolls (#30995)" (#30998) 2019-04-12 17:42:25 -07:00
Jonah Williams
a3a3623027
revert last 2 engine rolls (#30995) 2019-04-12 17:04:20 -07:00
engine-flutter-autoroll
6c7b6833c9
9aa7c9a48 Export extern constants in embedder.h (flutter/engine#8550) (#30951)
f804c293f3...9aa7c9a48e

git log f804c293f3baaec9ccec1e251293f6a3509223b8..9aa7c9a48e9342a450c3078e15c8d7923a338ede --no-merges --oneline
9aa7c9a48 Export extern constants in embedder.h (flutter/engine#8550)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
v1.4.19
2019-04-12 10:40:18 -04:00
engine-flutter-autoroll
404f66d968
Roll engine 72986c39ea36..f804c293f3ba (23 commits) (#30948)
72986c39ea...f804c293f3

git log 72986c39ea3669ef26d4d7d7cd0c44f513fcd117..f804c293f3baaec9ccec1e251293f6a3509223b8 --no-merges --oneline
f804c293f Roll src/third_party/skia 3b60397fd35d..f74fff660084 (3 commits) (flutter/engine#8556)
1b448e555 Roll Dart 15b11b018364ce032eae50d78fc8a52b541e2bce...a8f3a5dae6203d1064726a5953cf06a7d484249c (flutter/engine#8555)
99259aef5 Roll src/third_party/skia 36477b49c2ef..3b60397fd35d (6 commits) (flutter/engine#8554)
f37220d40 Roll src/third_party/skia c33e6dcc700b..36477b49c2ef (8 commits) (flutter/engine#8552)
d84d204c7 Android Embedding PR30: Make FlutterView focusable so that the keyboard can interact with it. (flutter/engine#8551)
a344015e9 [fuchsia] Add flutter:: to scene_host.cc (flutter/engine#8549)
711d8431d Roll src/third_party/skia 76e626d9bb55..c33e6dcc700b (4 commits) (flutter/engine#8547)
82e6d6899 Eliminate unused write to local (flutter/engine#8541)
f53e477a6 Correct nullability for FlutterStandardReader (flutter/engine#8537)
c00364a6c [font_collection] Add missing semicolon (flutter/engine#8546)
ae4df6fd1 Revert "Change Rect internal representation from Float32List to Float64List (#8524)" (flutter/engine#8545)
ffdddb07e Roll src/third_party/skia 6d60534e95d8..76e626d9bb55 (1 commits) (flutter/engine#8544)
5ac728eb6 Roll src/third_party/skia 4d657d5e894a..6d60534e95d8 (3 commits) (flutter/engine#8543)
ee462ff68 Roll src/third_party/skia 99d792276740..4d657d5e894a (1 commits) (flutter/engine#8542)
18816c50f Roll src/third_party/skia 42280f8961fa..99d792276740 (8 commits) (flutter/engine#8539)
892591da8 Android Embedding PR28: Report app is active to Flutter in FlutterFragment.onResume() instead of onPostResume() forwarded from Activity. (flutter/engine#8536)
330c6c168 Use code cache dir for engine cache on API >= 21 (#14704). (flutter/engine#8534)
c10ae2be2 Add an option to build the GLFW shell on macOS (flutter/engine#8531)
29aa5fca0 Roll src/third_party/skia b5c685991faa..42280f8961fa (32 commits) (flutter/engine#8535)
0a2869e5c Added support for authentication codes for the VM service (flutter/engine#8527)
36d2135ad Redo a fix for cull rect calculation on TransformLayers with a perspective transform (flutter/engine#8528)
0b36d3e2f Change Rect internal representation from Float32List to Float64List (flutter/engine#8524)
b1ae0ccb7 Roll src/third_party/skia 10bf7020aa15..b5c685991faa (3 commits) (flutter/engine#8526)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-04-12 03:01:18 -04:00
Emily Fortuna
ce6fbcea20
Allow mouse hover to only respond to some mouse events but not all. (#30886)
* Allow mouse hover to only respond to some mouse events but not all.
2019-04-11 16:29:21 -07:00
chunhtai
fbeb5e0cf5
Fix issue 23527: Exception: RenderViewport exceeded its maximum number of layout cycles (#30809) 2019-04-11 16:23:11 -07:00
Greg Spencer
8bea3fb2eb
Keep hover annotation layers in sync with the mouse detector. (#30829)
Adds a paint after detaching/attaching hover annotations to keep the annotation layers in sync with the annotations attached to the mouse detector.

Fixes #30744
v1.4.18
2019-04-11 13:11:22 -07:00
Siva
e7c7a58d5d
Use identical instead of '==' in a constant expression. (#30921)
* Use identical instead of '==' in a constant expression.

* Fix analyzer warnings.

* Fix analyzer warnings.
2019-04-11 13:08:00 -07:00
Jonah Williams
cadde2459b
Add toggle for debugProfileWidgetBuilds (#30867) 2019-04-11 12:44:33 -07:00
Jonah Williams
b4edfb1511
Revert "Manual engine roll with disabled service authentication codes (#30919)" (#30930)
This reverts commit 19d6e7b61390311f0b285662ba5e977bae7b0382.
2019-04-11 12:18:39 -07:00
Ben Konyi
19d6e7b613
Manual engine roll with disabled service authentication codes (#30919) 2019-04-11 12:08:13 -07:00
Justin McCandless
ecb468f335
Baseline Aligned Row (#30746)
Text in a baseline aligned row now works, and the height of the row is properly calculated.
v1.4.17
2019-04-11 09:32:22 -07:00
MH Johnson
3bbb8d8b77
[Material] Fix showDialog crasher caused by old contexts (#30754)
* Fix bug, add regression test.

* remove unnecessary space
2019-04-11 09:48:35 -04:00
Dan Field
42d3464d2e
Let sliver.dart _createErrorWidget work with other Widgets (#30880)
Credit to @ymback
2019-04-11 00:31:06 -07:00
xster
2736c8c19f
Add more dialog doc cross-reference (#30887) 2019-04-10 22:38:34 -07:00
Jonah Williams
259641c4b3
Allow downloading of desktop embedding artifacts (#30648) 2019-04-10 22:08:44 -07:00
LongCatIsLooong
1a3201bc74
CupertinoDatePicker initialDateTime accounts for minuteInterval (#30862)
initialDateTime should account for minuteInterval
2019-04-10 20:14:35 -07:00
LongCatIsLooong
b8a1870d92
add golden tests for CupertinoDatePicker (#30828)
Add golden tests for CupertinoDatePicker
2019-04-10 19:46:23 -07:00
liyuqian
8ca7c4cbbd
Simplify toImage future handling (#30876)
Thanks to cbracken@'s suggestion on another Google-internal change.
2019-04-10 19:19:30 -07:00
champeauxr
a5dd074b0d Fixed Table flex column layout error #30437 (#30470)
RenderTable._computeColumnWidths() had a logic error that caused flex columns to be collapsed to their minimum widths in certain situations dependent on the layout width constraint and the number of flex columns.
2019-04-10 18:53:27 -07:00
xster
054e8870eb
Fix iTunes Transporter quirk (#30883) 2019-04-10 18:33:43 -07:00
Greg Spencer
7b39269fe8
Bump Android build tools to 28.0.3 in Dockerfile (#30832)
Bumps the Android build tools to 28.0.3 instead of 28.0.0 in the Dockerfile, since that is what flutter doctor wants.
2019-04-10 16:57:35 -07:00
xster
e8c14e639d
Update the upload key which seems to have trouble for some reason (#30871) 2019-04-10 15:49:11 -07:00
Dan Field
d2790bd2bb
Check for invalid elevations (#30215)
* Check for invalid elevation usage in the layer tree
v1.4.16
2019-04-10 14:57:46 -07:00
Sam Rawlins
83ddd98849 Fix additional @mustCallSuper indirect overrides and mixins (#30667) 2019-04-10 14:54:51 -07:00
Todd Volkert
499004779b
Revert "Add Form.onSaved (#30643)" (#30793)
This reverts commit 949023b27686fb80a0047157490d6c4c61995cef.
2019-04-10 14:49:10 -07:00
Tong Mu
f34c2ef0a3
Revert "Remove pressure customization from some pointer events (#30414)" (#30873)
This reverts commit a821136997b600f0cd39cbcd3d993c54a15f4686.
2019-04-10 14:14:12 -07:00
Tong Mu
a821136997
Remove pressure customization from some pointer events (#30414)
* Remove pressure from PointerHoverEvent ctor
2019-04-10 12:40:33 -07:00
Jonah Williams
316d44989a
warn on uncomitted changes (#30235) 2019-04-10 12:24:53 -07:00
Jonah Williams
f66ee3e470
Add semanticsLabel parameter to TextSpan (#30837) 2019-04-10 12:24:01 -07:00
engine-flutter-autoroll
676fcc4b4b
Roll engine 905c571db50d..72986c39ea36 (2 commits) (#30861)
905c571db5...72986c39ea

git log 905c571db50d5eb3b10eaa4d3c43c99321032223..72986c39ea3669ef26d4d7d7cd0c44f513fcd117 --no-merges --oneline
72986c39e Move constant definitions out embedder.h (flutter/engine#8498)
e356dbca2 Merge flutter/synchronization contents into fml. (flutter/engine#8525)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-04-10 14:55:18 -04:00
Justin McCandless
ed91a3be49
Fix cursor outside of input width (#30525)
* Disallow cursor from appearing beyond the width of the input.

* Test that verifies the cursor can't exceed the width of the input

* Use constant from editable.dart to explain 1 pixel difference in test

* Fix failing test that tested the case of overflowing spaces
v1.4.15
2019-04-10 10:35:03 -05:00
xster
5a6c140d0d
Cupertino localization step 7: modularize material specific things out of gen_localizations.dart (#29822) 2019-04-10 01:24:58 -07:00
engine-flutter-autoroll
421f16a6b9
Roll engine eec74e5c9231..905c571db50d (9 commits) (#30833)
eec74e5c92...905c571db5

git log eec74e5c92313f01a28dfbeb78d96e81231edab7..905c571db50d5eb3b10eaa4d3c43c99321032223 --no-merges --oneline
905c571db Add windows host_debug_unopt build (flutter/engine#8515)
39e1d00f3 Remove redundant specification of the |flutter| namespace in the engine. (flutter/engine#8523)
56052c70a Rename the shell namespace to flutter. (flutter/engine#8520)
ca1d163d4 Support message loops whose tasks are executed concurrently. (flutter/engine#8419)
8ae84ec3d Roll src/third_party/skia de8362c6f212..10bf7020aa15 (5 commits) (flutter/engine#8522)
2dbd981d3 Roll src/third_party/dart 06ed3f598c..1490a90bc1 (8 commits)
527913268 Android Embedding PR27: Fix SurfaceView flicker in Fragment transactions (flutter/engine#8504)
86ab45cd5 Remove the unused EnableBlink flag. (flutter/engine#8518)
d5880a609 Roll src/third_party/skia b5d8c634f95b..de8362c6f212 (14 commits) (flutter/engine#8519)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
2019-04-09 23:15:18 -04:00
Shi-Hao Hong
b3bb5cd6b0
Fix StatefulWidget and StatelessWidget Sample Documentation (#30814) 2019-04-09 19:32:00 -07:00
liyuqian
eb30745faf
Print warning if flutter drive is run in debug (#30747)
## Description

Print actionable warnings if `flutter drive` (where most of our performance benchmarks come from) is run in debug mode and it tries to gather benchmarks using `traceAction`.

## Related Issues

https://github.com/flutter/flutter/issues/30625

## Tests

I added the following tests:
* drive_perf_debug_warning devicelab test
2019-04-09 18:55:42 -07:00
xster
5a4eaabaf1
Cupertino localization step 11: add more translation clarifications in the instructions (#30527) v1.4.14 2019-04-09 17:47:44 -07:00