Pierre-Louis
e71eb183d8
Use curly_braces_in_flow_control_structures for rendering ( #104611 )
...
* Use `curly_braces_in_flow_control_structures` for `rendering`
* fix comments
* fix dangling
2022-05-25 19:57:57 +02:00
Michael Goderbauer
d5fbc3750e
Remove unused code from tests ( #104550 )
2022-05-25 09:38:09 -07:00
Casey Hillers
da105b2b24
Revert "[framework] inline AbstractNode into RenderObject" ( #104257 )
2022-05-20 11:43:11 -07:00
Jonah Williams
24bd28f696
[framework] inline AbstractNode into RenderObject ( #103832 )
2022-05-19 14:28:09 -07:00
Dan Field
1662a14bc8
More missing clipBehavior respects ( #103931 )
2022-05-17 11:32:11 -07:00
Michael Goderbauer
51bcdb9407
super parameters for framework ( #100905 )
2022-04-13 22:38:40 -07:00
Kate Lovett
cb9e9a3786
Remove deprecated RenderEditable.onSelectionChanged ( #98582 )
2022-03-09 14:45:21 -08:00
chunhtai
1178c8e9d3
Revert "Remove redundant hide handles API from TextSelectionDelegate ( #98944 )" ( #99008 )
...
This reverts commit 94f6fd6ea8934407452853405835b92fec0d7ad9.
2022-02-23 09:48:53 -08:00
chunhtai
94f6fd6ea8
Remove redundant hide handles API from TextSelectionDelegate ( #98944 )
2022-02-22 14:44:18 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. ( #89451 )
2022-02-03 14:55:15 -08:00
sigmundch
f51d3d7e0c
[Web] Detect when running under Dart HHH Web and skip tests under investigation ( #93692 )
2021-11-18 22:33:04 -08:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Mouad Debbar
870cc27f0c
Unskip some editable tests on web ( #90526 )
2021-09-22 15:03:05 -07:00
Sam Rawlins
bcb5db7758
Remove "unnecessary" imports from packages/ ( #89795 )
2021-09-15 01:27:02 -07:00
Justin McCandless
2382b4c046
Text Editing Model Refactor ( #86736 )
...
Simplifying and refactoring parts of RenderEditable. Functionality is the same.
2021-09-07 14:12:38 -07:00
Darren Austin
a1cd3f45e0
Updated some skip test comments that were missed in the audit. ( #88893 )
2021-08-25 11:49:04 -07:00
sigmundch
7a21bd1000
reland disable ideographic script test on web ( #88383 )
2021-08-18 21:32:04 -07:00
LongCatIsLooong
b3d12ebd77
Revert "[EditableText] call onSelectionChanged only when there're actual selection/cause changes ( #87971 )" ( #88183 )
2021-08-13 17:17:04 -07:00
LongCatIsLooong
6e224ee0e6
[EditableText] call onSelectionChanged only when there're actual selection/cause changes ( #87971 )
2021-08-12 17:27:03 -07:00
Darren Austin
225a43d941
Updated skipped tests for rendering directory. ( #87700 )
2021-08-05 11:32:48 -07:00
Justin McCandless
c5866c5e20
Explicitly set affinity when moving left/right by line ( #87133 )
2021-07-29 16:49:06 -07:00
Tong Mu
caf876cf40
Reland: Keyboard events ( #87174 )
2021-07-29 14:24:03 -07:00
Tong Mu
2f4f170dd2
Revert "Keyboard events ( #83752 )" ( #87171 )
...
This reverts commit 5f792ba17088b356bf0d030844ab09fd7f2b812e.
2021-07-28 02:32:08 -07:00
Greg Spencer
738ce43d97
Randomize tests, exclude tests that fail with randomization. ( #86793 )
...
* Randomize tests, exclude tests that fail with randomization.
* Disable some more tool tests
2021-07-26 23:40:49 -07:00
Tong Mu
5f792ba170
Keyboard events ( #83752 )
2021-07-26 12:28:05 -07:00
Greg Spencer
6adea05276
Revert "Randomize Framework tests, opt out some tests that currently fail. ( #85159 )" ( #85673 )
...
This reverts commit b5f9612 because it is taking about 40% longer to run the tests, which is causing timeouts.
2021-06-30 19:38:09 -07:00
Greg Spencer
b5f9612cac
Randomize Framework tests, opt out some tests that currently fail. ( #85159 )
...
This turns on order shuffling for all tests that don't fail with it on, marking those tests that do fail with a tag so that they will be run without shuffling on.
To determine which tests fail with it on, I ran all the tests 100 times with different random shuffle seeds, and then also ran it with the date seeds from today until the end of July, and tagged all of the test suites (files) that fail, with a seed that caused them to fail.
2021-06-29 13:46:13 -07:00
Dan Field
025397ae3f
Release retained resources from layers/dispose pictures ( #84740 )
2021-06-25 12:01:03 -07:00
LongCatIsLooong
2b9fdada88
[RenderEditable] fix crash & remove TextPainter.layout short-circuiting ( #85008 )
2021-06-24 09:21:04 -07:00
Gary Qian
e70a1d1d7a
Support WidgetSpan in RenderEditable ( #83537 )
2021-06-09 21:54:02 -07:00
Alexandre Ardhuin
0ef0f0ba5e
fix lint from an improved unnecessary_parenthesis ( #83433 )
2021-05-27 13:39:03 -07:00
Yegor
a05076e45b
disable ideographic script test on web ( #83130 )
2021-05-21 17:18:41 -07:00
YeungKC
64765d8672
done ( #82286 )
2021-05-13 06:09:06 -07:00
LongCatIsLooong
b970f40646
Let RenderEditable.delete directly delete from the controller text. ( #82215 )
2021-05-11 13:44:03 -07:00
creativecreatorormaybenot
5e2f8631f8
Fix Hit Tests in RenderEditable when Scrolled ( #81040 )
2021-04-26 10:54:04 -07:00
Ren You
e170ea521c
Revert "[RenderEditable] Dont paint caret when selection is invalid ( #79607 )" ( #81076 )
...
This reverts commit 0f8148ec16325493b1b48a21367b839167f940b9.
2021-04-23 16:00:11 -07:00
Alexandre Ardhuin
59fc92168a
add missing trailing commas ( #81065 )
2021-04-23 22:47:40 +02:00
Justin Hutchins
dca07d2a8a
Enable previously skipped Editable test ( #80761 )
2021-04-22 13:19:03 -07:00
LongCatIsLooong
0f8148ec16
[RenderEditable] Dont paint caret when selection is invalid ( #79607 )
2021-04-18 09:14:02 -07:00
Ricardo Canastro
136da59e6b
Support block delete with word and line modifiers ( #79973 )
...
Adds support for overridable delete/backspace keyboard shortcuts
2021-04-07 13:29:37 -07:00
Jenn Magder
a637fcd344
Revert "Support block delete with word and line modifiers ( #79695 )" ( #79968 )
...
This reverts commit 0ba2f6a87fbfd857c0a4e01a47e824dcab5462de.
2021-04-07 11:44:30 -07:00
Ricardo Canastro
0ba2f6a87f
Support block delete with word and line modifiers ( #79695 )
...
Support for keyboard backspace/delete shortcuts
2021-04-07 10:54:28 -07:00
chunhtai
303ce76d85
Fix RenderEditable register the raw keyboard listener twice ( #79877 )
...
* Fix RenderEditable register the raw keyboard listener twice
* skip web test
2021-04-06 11:27:31 -07:00
Greg Spencer
8859f7a799
Revert "Support block delete with word and line modifiers ( #77172 )" ( #79674 )
...
This reverts commit 75453e6ac6647e014765ae6d863e199efc152a16 because it breaks flutter/test/rendering/editable_test.dart
Landing on red to fix the build.
2021-04-02 15:08:13 -07:00
Ricardo Canastro
75453e6ac6
Support block delete with word and line modifiers ( #77172 )
2021-04-02 14:39:03 -07:00
chunhtai
2369d76a1d
Makes text selection match the native behavior ( #79308 )
2021-04-02 12:09:05 -07:00
chunhtai
bed88a1a5e
Fix rendereditable to check the latest text before setting the selection ( #78919 )
...
* Fix rendereditable to check the latest text before setting the selection
* add regression comment
* addressing comments and fix tests
2021-03-25 11:49:44 -07:00
Justin McCandless
541bff4058
Text Editing Movement Keys via Shortcuts ( #75032 )
...
Text editing shortcuts involving the arrow keys are no longer handled by RenderEditable's RawKeyboardListener, they use the new Shortcuts setup. First PR in a plan to port all text editing keyboard handling to shortcuts.
2021-03-11 15:52:04 -08:00
