136 Commits

Author SHA1 Message Date
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements (#126320) 2023-05-15 11:07:30 +02:00
Qun Cheng
4e7e4512b6
Reorder materialStateProperty defaults (#125905)
Fixes #122250. This PR is to make sure all the MaterialStateProperty defaults are able to correctly resolve different states. 
* When a widget is pressed, it is also hovered, so we need to put the `MaterialState.pressed` check before `MaterialState.hovered`. 
* When a widget is focused, the widget should still be able to be hovered, so we should check `MaterialState.hovered` before `MaterialState.focused`.
* There are also cases like in _InputDecoratorDefaultsM3, the `MaterialState.disabled` should be checked before `MaterialState.error`.

 the order should be disabled, (error), pressed, hovered, focused.
2023-05-11 00:03:09 +00:00
Qun Cheng
c1c2513ac9
Add Switch.trackOutlineWidth property (#125848) 2023-05-05 13:34:08 -07:00
Taha Tesser
ad009fb7ac
Fix Material 3 tab indicator weight and position (#125883)
fixes https://github.com/flutter/flutter/issues/123112

### Description
1. Add proper M3 indicator height aka`IndictorWeight` from the M3 specs for the primary tab bar with label indicator size.
db6074ade4/dev/tools/gen_defaults/data/navigation_tab_primary.json (L9)
(this was held due to `indicatorWeight` having a hard-coded value) 

and added a secondary tab bar indicator height.
2. Set a minimum value for the rounded indicator to maintain the indicator shape.
3. With proper indicator height, the rounded indicator position is also fixed.
4. Fix round indicator is shown for the primary tab bar with tab indicator size.
5. Above changes fix https://github.com/flutter/flutter/issues/123112.
6. Fix the `startOffset` const value from https://github.com/flutter/flutter/pull/125036  to match docs and move it to a variable.
2023-05-05 14:09:18 +00:00
Taha Tesser
a732a74888
Introduce TabBar.tabAlignment (#125036)
fixes https://github.com/flutter/flutter/issues/124195

This introduces `TabBar.tabAlignment` while keeping the default alignment for both M2 and M3.
2023-05-01 16:59:55 +00:00
Qun Cheng
a433f88d16
Checkbox.fillColor should be applied to checkbox's background color when it is unchecked. (#125643) 2023-04-28 12:05:31 -07:00
Pierre-Louis
1f602cb6ca
Provide default constraints for M3 bottom sheets (#120065)
This PR constrains M3 bottom sheets to 640dp max width by default.
`constraints` can be used to provide different `minWidth` and
`maxWidth`.

This is not a breaking change per the breaking change policy.

Part of https://github.com/flutter/flutter/issues/118619
Part of https://github.com/flutter/flutter/issues/111448

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-27 09:28:11 +02:00
Kate Lovett
3dfc60c0d1
Revert "Fix divider width in scrollable TabBar for Material 3 and add dividerHeight parameter (#123127)" (#123616)
Revert "Fix divider width in scrollable `TabBar` for  Material 3 and add `dividerHeight` parameter"
2023-03-28 16:45:15 +00:00
Qun Cheng
0300cfa603
Create SearchAnchor and SearchViewTheme Widget (#123256) 2023-03-27 23:31:11 -07:00
Taha Tesser
3512c2cd76
Fix divider width in scrollable TabBar for Material 3 and add dividerHeight parameter (#123127)
Fix divider width in scrollable `TabBar` for  Material 3 and add `dividerHeight` parameter
2023-03-27 22:52:59 +00:00
Pierre-Louis
02d5c7595b
Add support for secondary tab bar (#122756)
Add support for secondary tab bar
2023-03-23 22:49:59 +00:00
hangyu
9fc1fd15f6
Update Material 3 bottom sheet (#122445)
* M3 bottomsheet

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update bottom_sheet.dart

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

* Update bottom_sheet.dart

Update bottom_sheet_test.dart

Update bottom_sheet.dart

* showDragHandle defaults to false

* fix test

---------

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
2023-03-18 20:13:08 -07:00
Renzo Olivares
358d79cb0d
TextField should support disabled input text style (#119216)
Co-authored-by: Renzo Olivares <roliv@google.com>
2023-03-17 10:09:49 -07:00
Qun Cheng
5180e45080
Create SearchBar and SearchBarTheme (#122309) 2023-03-16 15:04:19 -07:00
Taha Tesser
d24a28b806
Cleanup M3 token templates for theme lookups (#122601)
Cleanup M3 token templates for theme lookups
2023-03-14 17:01:13 +00:00
Pierre-Louis
598ebfbd66
Update Material tokens to 0.162 (#122388)
Update Material tokens to 0.162
2023-03-13 16:16:07 +00:00
Eilidh Southren
d696b05165
Bottom appbar/sheet shadow property (#121406)
* add shadowColor property

* add to bottom app bar

* add test

* update m2/m3 diffs

* reorder debug test

* finalize

* remove crswap

* update doc comments

* add m2 shadow back

* add const

* update docs

* update docs

* comment replies

* make param non-null

* indentation fix

* doc fix
2023-03-06 11:41:59 +00:00
Qun Cheng
b114654947
Add IconButton.filled, IconButton.filledTonal, IconButton.outlined (#121884) 2023-03-03 19:59:39 -08:00
Qun Cheng
d33125687b
Reland: Add visual density for menu default style (#114878) 2023-03-03 18:08:27 -08:00
Qun Cheng
c7fa8e5f7d
Revert "Add visual density for menu default style (#114878)" (#121810)
This reverts commit 37be384205778c94f0d34e92499ae0766f842f8a.
2023-03-02 10:34:15 -08:00
Qun Cheng
37be384205
Add visual density for menu default style (#114878)
Add visual density for menu default style
2023-03-01 23:01:49 +00:00
Taha Tesser
219ff64574
Reland "Update ExpansionTile to support Material 3 & add an example" (#121212) 2023-02-24 06:30:33 -08:00
Taha Tesser
56e1bddc59
Fix SliverAppBar.medium & SliverAppBar.large title overlap with leading/actions widgets, leading width, and title spacing (#120780)
* Fix `SliverAppBar.medium` & `SliverAppBar.large` title overlap with leading/actions widgets, leading width, and title spacing

* Add `titleSpacing` theme tests and consolidate multiple tests for the same widgets
2023-02-23 17:12:11 +00:00
Eilidh Southren
0c1ed75915
Remove newline (#121090)
* remove newline

* update crswap

* add const constructor

* update const
2023-02-23 10:39:41 +00:00
Eilidh Southren
ae8d05184e
[M3] Update checkbox shape value (#120976)
* update m3 values

* update test formatting

* update crswap

* update test

* update token value

* update tests
2023-02-20 11:38:26 +00:00
Renzo Olivares
9367641ce2
clean up (#120934)
Co-authored-by: Renzo Olivares <roliv@google.com>
2023-02-17 18:42:09 +00:00
Qun Cheng
6029de2fb2
Update switch template (#120919) 2023-02-16 14:27:51 -08:00
Eilidh Southren
17b4c70ff5
[M3] Add customizable overflow property to Snackbar's action (#120394)
* add actionOverflowThreshold param

* analyzer tings

* https://www.youtube.com/watch?v=NPwyyjtxlzU

* remove erroneous switch changes

* rename test

* remove unwanted switch.dart diff

* remove redundant values

* review changes
2023-02-14 10:07:02 +00:00
Taha Tesser
402caec2e6
Fix ListTile's default iconColor token used & update examples (#120444) 2023-02-13 23:52:32 +00:00
Eilidh Southren
9996126740
Add proper disabled values for input chips (#120192)
* add proper disabled values for input chips

* added test
2023-02-09 16:51:26 +00:00
Hans Muller
212bac80d1
Revert "Update ExpansionTile to support Material 3 & add an example (#119712)" (#120300)
This reverts commit e8eac0d047cd44feabf0a62ab06bcecbbcf24b1b.
2023-02-08 10:53:55 -08:00
Hans Muller
75ca31b0e4
Correct Badge interpretation of its alignment parameter (#119853) 2023-02-08 08:52:41 -08:00
Qun Cheng
1c225675c5
Update to v0.158 of the token database. (#120149)
* Update to v0.158 of the token database.

* Update checkbox template

* Fix DatePickerTheme test

---------

Co-authored-by: Qun Cheng <quncheng@google.com>
2023-02-07 19:16:24 +00:00
Taha Tesser
e8eac0d047
Update ExpansionTile to support Material 3 & add an example (#119712) 2023-02-07 08:21:18 -08:00
Eilidh Southren
7a6f1d81d6
M3 segmented buttons token fixes (#120095)
* add icon button property override

* Revert "add icon button property override"

This reverts commit 6c7f4d30671f417d0f4a311bdb186bd4ebc456c8.

* segmented button updates

* button changes

* fix

* put that thing back where it came from

* template updates

* analyzer fixes

* rename parameter

* analyzer fixes

* string interpolation fix

* template updates

* test updates
2023-02-07 10:53:36 +00:00
Hans Muller
198a51ace9
Migrate the Material Date pickers to M3 Reprise (#119033) 2023-01-31 15:31:06 -08:00
Darren Austin
6fafbc33f2
Updated tokens to v0.152 (#118594) 2023-01-17 12:32:47 -08:00
Taha Tesser
0d91c0343b
Fix M3 Drawer default shape in RTL (#118185) 2023-01-12 14:22:53 +00:00
Taha Tesser
fa1a4eebf3
Update ListTile to support Material 3 (#117965)
* Update `ListTile` to support Material 3

* Update `Default ListTile debugFillProperties`

* Add #99933 HTML workaround.
2023-01-09 21:01:07 +00:00
Xilai Zhang
c089c19f16
Revert "[reland] Add Material 3 support for ListTile - Part 1 (#116963)" (#117756)
This reverts commit 57fb36ee0ad1b2203698e47abf01e68cf1e558e6.
2022-12-29 05:36:21 +00:00
Darren Austin
d8b7eb6e29
Updated token templates to sync with master code. (#117097) 2022-12-14 21:32:12 +00:00
Taha Tesser
57fb36ee0a
[reland] Add Material 3 support for ListTile - Part 1 (#116963)
* [reland] Add Material 3 support for `ListTile` - Part 1

* Update doc
2022-12-14 21:13:59 +00:00
Greg Spencer
fae458b925
Convert TimePicker to Material 3 (#116396)
* Make some minor changes in preparation for updating the Time Picker to M3

* Revert OutlineInputBorder.borderRadius type change

* Revert more OutlineInputBorder.borderRadius changes.

* Convert TimePicker to Material 3

* Add example test

* Revert OutlineInputBorder.borderRadius type change

* Fix test

* Review Changes

* Merge changes

* Some sizing and elevation fixes

* Fix localization tests
2022-12-14 00:09:52 +00:00
Hans Muller
882e105a4c
Revert "Add Material 3 support for ListTile - Part 1 (#116194)" (#116908)
This reverts commit e57b7f4ea8ab8b348810d0a76f7bcf4aeabbe6d2.
2022-12-12 20:06:21 +00:00
Taha Tesser
e57b7f4ea8
Add Material 3 support for ListTile - Part 1 (#116194)
* Add Material 3 support for `ListTile` - Part 1

* minor refactor

* Add `useMaterial3: false` to M2 tests
2022-12-09 20:05:12 +00:00
Greg Spencer
31719941c0
Time picker precursors (#116450)
* Make some minor changes in preparation for updating the Time Picker to M3

* Revert OutlineInputBorder.borderRadius type change

* Revert more OutlineInputBorder.borderRadius changes.
2022-12-07 02:07:25 +00:00
Eilidh Southren
29422d25fe
M3 snackbar [re-land] (#116218)
* Add M2 defaults and template skeleton

* add MaterialStateColor functionality to ActionTextColor (issue #110402)

* Add M2 defaults and template skeleton

* updated material 3 tokens

* Updated snackbar demo

* add theme tests

* add gen defaults

* formatting

* more whitespace fixes

* add widget type

* update docs

* code review changes

* Add line overflow functionality

* whitespace fixes

* update M3 animation

* whitespace fixes

* add insetPadding param

* Modifed icon parameter to showCloseIcon

* white space fixes

* test fixes

* rename iconColor to closeIconColor

* debug test fix

* de-britishification

* g3fix

* g3fix

* debug test fix
2022-11-30 19:13:00 +00:00
Taha Tesser
a52293843c
[Reland] Add Material 3 support for TabBar (#116283)
* Add Material 3 support for `TabBar`

* M3 `TabBar` revert fix and tests
2022-11-30 17:58:07 +00:00
Pierre-Louis
b2672fe835
Revert "Add Material 3 support for TabBar (#116110)" (#116273)
This reverts commit 900b395451bb29748b07ac45467b93b2f5490102.
2022-11-30 13:20:19 +00:00
Taha Tesser
900b395451
Add Material 3 support for TabBar (#116110) 2022-11-29 22:36:37 +00:00