46 Commits

Author SHA1 Message Date
mpcomplete
2c84154b75 Merge pull request #211 from mpcomplete/rm.builder.3
Make SnackBar animate itself.

This introduces a bit of a regression - the FloatingActionButton no longer animates. I'm not sure yet how to animated the FAB along with the SnackBar. Maybe some notion of anchoring a node to another.

Also remove last use of AnimationBuilder.
2015-07-22 12:29:57 -04:00
Hixie
74575775bd Introduce an explicit Key type.
This fixes some theoretical bugs whereby we were using hashCode to try
to get unique keys for objects, but really we wanted object identity.
It also lays the groundwork for a new GlobalKey concept.

I tried to keep the impact on the code minimal, which is why the "Key"
constructor is actually a factory that returns a StringKey. The code
has this class hierarchy:

```
   KeyBase
    |
   Key--------------+---------------+
    |               |               |
   StringKey    ObjectKey       UniqueKey
```

...where the constructors are Key and Key.stringify (StringKey),
Key.fromObjectIdentity (ObjectKey), and Key.unique (UniqueKey).

We could instead of factory methods use regular constructors with the
following hierarchy:

```
   KeyBase
    |
   LocalKey---------+---------------+
    |               |               |
   Key      ObjectIdentityKey   UniqueKey
```

...with constructors Key, Key.stringify, ObjectIdentityKey, and
UniqueKey, but I felt that that was maybe a more confusing hierarchy.
I don't have a strong opinion on this.
2015-07-22 09:14:06 -07:00
Viktor Lidholt
bb0c8bb13e Merge pull request #202 from vlidholt/master
Fixes issues with invalidating matrix for SpriteBox & adds HUD to demo game
2015-07-22 09:01:39 -07:00
Viktor Lidholt
6a6567d776 Fixes formatting and removes redundant code in sprites 2015-07-22 08:59:14 -07:00
Matt Perry
b31e06a5d6 Make SnackBar animate itself. 2015-07-22 11:53:57 -04:00
Matt Perry
839e997e78 rebase 2015-07-22 11:52:34 -04:00
Ian Hickson
b215e4d6c0 Merge pull request #205 from Hixie/minedigger
Many code improvements to Mine Digger.
2015-07-22 08:23:55 -07:00
Adam Barth
73123a3c08 Merge pull request #201 from eseidelGoogle/fuzz_crashes
Fix 2 crashes found by Hixie's fuzzer.
2015-07-21 19:59:24 -07:00
Hixie
4d2902f219 Many code improvements to Mine Digger.
Text styles are now a global constant instead of being initialised dynamically.
There are now sufficient text styles for 8 mines around a square.
I coallesced Game and MineDiggerApp.
Used an enum instead of constants for the cell state.
Used setState() instead of scheduleBuild().
Used an O(N) algorithm for mine laying instead of the previous potentially-never-ending algorithm.
Moved the listener on the cells to the app, so that the logic survives a rebuild.
Various other minor changes.
2015-07-21 17:24:51 -07:00
Viktor Lidholt
972417f54e Merge branch 'master' of github.com:domokit/sky_engine 2015-07-21 16:46:14 -07:00
Viktor Lidholt
271812259b Fixes issues in demo game and adds heads up display 2015-07-21 16:45:53 -07:00
Viktor Lidholt
b26bae8a45 Fixes issues with invalidating matrix for SpriteBox 2015-07-21 16:42:51 -07:00
Eric Seidel
8f85f34d27 Fix 2 crashers found by Hixie's fuzzer.
The first one is that we weren't setting up a
FontCachePurgePreventer during drawText.  It's not clear
that this is the correct fix, since Blink doesn't have
this FontCachePurgePreventer here either, but it's also
possible that they would hit this same ASSERT and just
not care (since ASSERTs are disabled on clusterfuzz).

The second fix is making ExceptionState actually track
whether it has thrown an exception or not. The c++ code
was depending on this working in order to return early
from dom functions and not crash!

R=abarth@google.com
2015-07-21 16:29:04 -07:00
Hixie
6d304c03ac Remove redundant operator== and hashCode functions in card example.
It turns out that we aren't really using these. The identity logic is sufficient.

Also, add some asserts for a crash I had once but couldn't reproduce, in case that helps catch it next time.
2015-07-21 15:26:54 -07:00
Hixie
9da399b0e1 Rationalise usage of keys in navigator.dart.
Route (named routes) no longer have a key, and have their own storage for their names.
RouseState no longer has a key, and uses an owner field pointing to a StatefulComponent instead.
As such, RouteBase no longer has a key.

HistoryEntry no longer uses a global int to ensure uniqueness.

Propagated this to stocks app.
2015-07-21 14:58:48 -07:00
Adam Barth
ed82572205 Roll version to 20 2015-07-21 14:56:54 -07:00
Adam Barth
6b748e653e Fix more analyzer warnings 2015-07-21 13:59:18 -07:00
Adam Barth
53efc748e1 Merge pull request #191 from abarth/image_height_width
Separate width and height parameters for Image widgets
2015-07-21 13:54:56 -07:00
Adam Barth
d5f3168982 Merge pull request #192 from abarth/fix_warnings
Fix analyzer warnings
2015-07-21 13:52:37 -07:00
Adam Barth
3ac4c6c998 Fix analyzer warnings 2015-07-21 13:51:27 -07:00
Adam Barth
012b915704 Separate width and height parameters for Image widgets
This change makes it easier to defined only the width or the height of an image
and let the other value be filled in from the image's intrinsic aspect ratio.

Fixes #175
2015-07-21 13:46:10 -07:00
mpcomplete
4a0bdf1bba Merge pull request #188 from mpcomplete/animated_value
Renamed AnimatedType to AnimatedValue
2015-07-21 13:45:50 -07:00
Viktor Lidholt
1eff5b8c94 Merge pull request #184 from vlidholt/master
Updates sprite widget to handle changes to renderbox
2015-07-21 13:32:22 -07:00
Viktor Lidholt
6c510fb558 Minor formatting fixes 2015-07-21 13:30:30 -07:00
Matt Perry
0fd3302ebe Renamed AnimatedType to AnimatedValue 2015-07-21 12:55:16 -07:00
Hixie
310412fde5 Minor style changes around demo cards. 2015-07-21 12:18:10 -07:00
Viktor Lidholt
90363ee956 Merge branch 'master' of github.com:domokit/sky_engine into HEAD 2015-07-21 11:30:52 -07:00
Viktor Lidholt
1b4923a2a6 Adds main screen to game and graphics for game UI 2015-07-21 11:30:17 -07:00
Viktor Lidholt
88afaefbaf Updates sprite widget to handle changes to renderbox 2015-07-21 11:26:57 -07:00
Hixie
ddef380875 This demo is a fuzzer of sorts, testing in particular our text layout system and painting. 2015-07-21 10:56:08 -07:00
Collin Jackson
40b2a4e53f Merge pull request #166 from collinjackson/fitness
Measurement tracking for fitness app.

There is an issue with the input control that prevents actually creating a measurement. Working on this with eseidel.

R=eseidel
2015-07-20 16:25:19 -07:00
Collin Jackson
d8cbbc68f3 Add basic measurement functionality to fitness app 2015-07-20 16:20:59 -07:00
Hans Muller
b954e020c6 Make it possible to identify BlockViewport children whose size or type has changed 2015-07-20 15:41:21 -07:00
Collin Jackson
af7c5f8e5a Tweaks to launcher 2015-07-20 11:20:47 -07:00
Collin Jackson
4604021dd3 Support for non-alphabetic baselines 2015-07-17 17:06:08 -07:00
Collin Jackson
65d47af75c Fix layout of stocks row 2015-07-17 16:10:10 -07:00
Collin Jackson
695a13583b Update example 2015-07-17 14:29:05 -07:00
Collin Jackson
7a7110b2a0 Fix #57 Flex needs to understand baselines 2015-07-17 12:46:51 -07:00
Collin Jackson
0e129498c0 Merge pull request #86 from collinjackson/avoid_building
Navigator improvements, avoid building invisible routes

R=abarth
2015-07-17 09:54:34 -07:00
Collin Jackson
f9697a5cd7 Fix issue #34 Clicking on "Autorefresh" menu item does not click checkbox 2015-07-17 09:48:49 -07:00
Collin Jackson
cc29757eee Navigator improvements, avoid building invisible routes 2015-07-17 09:38:22 -07:00
Collin Jackson
e075988fe0 Make example look more beautiful 2015-07-16 17:36:25 -07:00
Collin Jackson
38cbf9b5d3 Support for settings fly-in animation 2015-07-16 17:22:20 -07:00
Eric Seidel
e70a5c94e5 Roll versions in perparation for another APK release.
Also fixed roll_versions to no longer roll mojo paths
since those are not part of the sky_engine repository.

R=abarth@google.com
2015-07-16 15:42:57 -07:00
Collin Jackson
3501bb6359 center the hello world text so it isn’t covered up by the status bar 2015-07-16 14:11:12 -07:00
Collin Jackson
633b65010c After running filter-branch, move root directory into sky/ 2015-07-16 11:54:25 -07:00