49 Commits

Author SHA1 Message Date
Michael Goderbauer
a4b1fccdaa
Fix traversal order for a11y scrolling (#4726)
Fixes https://github.com/flutter/flutter/issues/14987, but why?
2018-03-01 04:53:58 -08:00
Greg Spencer
f5a4a93787
Swap setTraversalBefore to setTraversalAfter, since setTraversalBefore is broken. (#4656)
It seems that setTraversalBefore doesn't work as well as setTraversalAfter for some reason, although I'm using them the same way. Some apps would lock up TalkBack when traversing if setTraversalBefore was set, but not with the equivalent setTraversalAfter.

It's not entirely clear why this is, but I'm going with this to at least get it fixed for apps we know about.

Addresses flutter/flutter#14600

See also flutter/flutter#14607
2018-02-12 10:02:25 -08:00
Michael Goderbauer
a00f94582b
Add accessibilityFocus and loseAccessibilityFocus as a11y actions (#4655) 2018-02-09 17:47:52 -08:00
Michael Goderbauer
8ac6f6efa1
Encode scrolling status into tree (#4647) 2018-02-09 15:39:58 -08:00
Greg Spencer
96acd1a383
Adding semantics traversal order support (#4540)
This adds support for semantics traversal ordering.

It is a companion to flutter/flutter#14060, adding support for a sortIndex in the semantics data passed to the engine.

Addresses flutter/flutter#12187
2018-01-30 13:42:12 -08:00
Michael Goderbauer
3107f167dc
Remove unnecessary trim (#4616)
... which caused trouble for a11y "select all".
2018-01-29 18:12:29 -08:00
Michael Goderbauer
a1e4f2f991
Add semantic actions for copy, cut, and paste (#4592) 2018-01-26 12:11:38 -08:00
Michael Goderbauer
7c34dfafc9
Adds a11y action for selecting text (and moving cursor) (#4589)
See https://github.com/flutter/flutter/pull/14275 for framework side change.

Also includes some minor clean-ups for consistency. 

Required for https://github.com/flutter/flutter/issues/13469.
2018-01-25 15:00:29 -08:00
Michael Goderbauer
4c82c566ed
a11y: Announce changes to cursor position on Android (#4587) 2018-01-24 16:54:14 -08:00
Michael Goderbauer
e4cabae56f
Add a11y support for selected text (#4584) 2018-01-24 15:08:29 -08:00
Michael Goderbauer
c98443ee37
Echo letters and words typed into TextField back (#4574)
Fixes https://github.com/flutter/flutter/issues/13392.
2018-01-22 11:14:12 -08:00
Michael Goderbauer
7173a158db
Announce when checked status changes on Android (#4557)
Fixes https://github.com/flutter/flutter/issues/14092
2018-01-16 23:10:17 -08:00
Michael Goderbauer
e7e94c6307
Properly identify CheckBox and RadioButton on Android (#4547) 2018-01-12 15:27:55 -08:00
Jason Simmons
e1b01d7d7b
API version check for AccessibilityNodeInfo.setEditable call (#4522)
Fixes https://github.com/flutter/flutter/issues/13896
2018-01-05 14:45:35 -08:00
Michael Goderbauer
12e0e38a8b
Split SemanticsFlags.isDisabled into two (#4517) 2018-01-04 15:15:54 -08:00
Michael Goderbauer
26010cf483
Add SemanticsFlag.isDisabled (#4503) 2018-01-02 15:57:52 -08:00
Michael Goderbauer
937bde8f98
A11y nodes with only value or hint are focusable (#4481) 2017-12-20 11:15:10 -08:00
Michael Goderbauer
e07eafae1d
Roll forward: Parameters for SemanticActions; a11y text selection (#4452)
Reverts the revert in #4448 with fixes to pass on the bot.

This change will require framework changes in flutter/flutter#13490.
2017-12-12 14:25:45 -08:00
Michael Goderbauer
056fd4597f
Revert " Add parameters to SemanticActions; implement extend selection for a11y (#4444)" (#4448)
This reverts commit 59c3a37e6436d60381d9708113228c83ccc6b7f9.
2017-12-12 10:53:15 -08:00
Michael Goderbauer
59c3a37e64
Add parameters to SemanticActions; implement extend selection for a11y (#4444) 2017-12-12 10:06:04 -08:00
Michael Goderbauer
fb44dce8c2
A11y cursor movements for text fields on Android (#4419)
* a11y cursor movement by character

* focus fixes

* doc fixes
2017-12-06 15:46:35 -08:00
Michael Goderbauer
88cf09ffe6
Identify text fields as such to a11y on Android (#4299)
* Identify text fields as such to a11y on Android

* Add focus flag
2017-11-01 12:59:03 -07:00
Michael Goderbauer
b3d345e323
Android SeekBars announce their value (#4289)
* Android SeekBars announce their value

* style
2017-10-31 10:03:30 -07:00
Michael Goderbauer
91071f817b Support for accessibility label and hint (#4264)
* Support for accessibility label and hint

* review comments
2017-10-23 16:46:01 -07:00
amirh
3d013382e6 Add a semantic isButton flag (#4254)
https://github.com/flutter/flutter/issues/11992
2017-10-20 13:15:20 -07:00
Michael Goderbauer
b9ad2393cf Set AccessibilityFocus (#4249)
This ensures that accessibility hints are played properly.
2017-10-19 15:09:37 -07:00
amirh
64fb5d0126 make AccessibilityBridge#mOwner final (#4235) 2017-10-18 13:25:07 -07:00
amirh
879c1fb8e1 Support accessibility announcements in the Android AccessibilityBridge (#4232) 2017-10-18 11:10:14 -07:00
Michael Goderbauer
0448bf9bd7 Proper horizontal a11y scrolling on Android (#4163) 2017-10-02 15:46:38 -07:00
Michael Goderbauer
45b11f742d Send scroll progress with a11y event TYPE_VIEW_SCROLLED (#4144) 2017-09-27 11:18:50 -07:00
Michael Goderbauer
afcc1d1e1f a11y improvements for iOS (#4079)
* Various iOS a11y fixes

* undo

* review comments

* review comments
2017-09-11 14:44:17 -07:00
Michael Goderbauer
81e3f8b86f refactor accessibility channel to use StandardMessageCodec (#4073) 2017-09-07 15:24:47 -07:00
Michael Goderbauer
ccf68cdcb6 Tell Android which SemanticsNodes are focusable (#4067)
A node is considered focusable if it contains information that is interesing to the user. A node that doesn't add any semantic information of its own should not be focusable. It's expected that such a node has children, who have smeantics information and are therefore focusable.

Fixes https://github.com/flutter/flutter/issues/11179
2017-09-06 16:56:23 -07:00
Michael Goderbauer
ceb6d05c2f Adapt semantics event handling to framework changes (#4066) 2017-09-05 16:31:24 -07:00
Michael Goderbauer
d60d630ec6 Wire up basic a11y channel for a11y events (#4054) 2017-09-01 16:40:04 -07:00
Ian Hickson
60bce44c9f Implement i18n features in the a11y API. (#4029) 2017-08-28 16:12:39 -07:00
Michael Goderbauer
32447c72fc Traverse children from top left to bottom right for a11y (#4017)
* order

* comment fix

* review comments
2017-08-28 12:02:07 -07:00
Michael Goderbauer
8cfa97609c Only expose available semantic scroll actions (#4010)
* Only expose available scroll actions

* formatting

* more formatting
2017-08-25 16:12:50 -07:00
Michael Goderbauer
1a4bffc4ba Wire up SemanticsAction Increase and Decrease on Android (#3876) 2017-07-17 16:48:50 -07:00
Michael Goderbauer
63bf1d282f a11y: Add SemanticsAction "showOnScreen" (#3856)
This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen.

iOS implementation to follow.
2017-07-12 15:52:30 -07:00
Michael Goderbauer
d2d152f201 Fix a11y scroll direction (#3841)
See also https://github.com/flutter/engine/pull/3701
2017-06-29 15:56:17 -07:00
Jason Simmons
1009e9c097 Remove warning about a deprecated accessibility API (#3837) 2017-06-28 12:47:15 -07:00
Jason Simmons
b0dee695ec Revert to API level 16 compatible variant of AccessibilityNodeInfo.addAction (#3810)
Fixes https://github.com/flutter/flutter/issues/10855
2017-06-21 12:31:08 -07:00
Michael Goderbauer
1787c3fb1e Adding SemanticsFlag.isSelected (#3764)
* Adding SemanticsFlag.isSelected

* typo
2017-06-09 15:58:30 -07:00
Ian Hickson
0d94214df4 Fix a11y an Android (#3694)
The core problem was multiplying matrices the wrong way around.

While I was there I did some minor cleanup. I think that may have
fixed another bug relating to A11Y turning on or off improperly, but
since I never figured out the steps to reproduce, it's hard to tell.

Fixes https://github.com/flutter/flutter/issues/7205
Fixes https://github.com/flutter/flutter/issues/10059 (maybe)
2017-05-16 10:31:53 -07:00
Mikkel Nygaard Ravn
c4edec7417 Remove old flutter messaging API (#3482)
Breaking change: removed facilities for JSON and string messaging from FlutterView/FlutterViewController, leaving only binary messaging there. All other use of flutter communication now goes through FlutterMessageChannel and FlutterMethodChannels. Retained use of String and JSON codecs for now.

Companion flutter PR: flutter/flutter#8837
2017-03-17 09:04:59 +01:00
Adam Barth
e8f57e74a1 Improve new semantics backend (#3113)
TalkBack still isn't fully working, but this patch gets us much closer.
2016-10-11 13:27:11 -07:00
Adam Barth
2dc88cc6a5 Switch backend to consume new semantics API (#3103) 2016-10-11 10:52:48 -07:00
Chinmay Garde
9eb446e0d5 Move shell to //flutter and split shell/BUILD.gn into smaller pieces for each subcomponent. (#3053)
* Namespaces have been updated to reflect the move from //flutter/sky/shell to //flutter/shell.
* shell/BUILD.gn file has been split into smaller GN files for each subcomponent of the shell (common, GPU, diagnostic, testing).
* GN dependencies have been rewritten to stop exposing common shell dependencies as public. Duplicates have also been removed.
* GPU subcomponent has been updated make it more suitable for Vulkan integration.
* The GLFW backend has been resurrected.
2016-09-23 15:33:25 -07:00