Shi-Hao Hong
dee8e4211e
[Material] Implement TooltipTheme and Tooltip.textStyle, update Tooltip defaults ( #36856 )
...
* Implement TooltipThemeData and TooltipTheme
* Add text style property
* Updated tooltip default colors for light and dark theme to match Material specification
2019-07-25 09:09:24 -07:00
Tong Mu
9cbac2a4ce
Revert "Dismiss modal with any button press ( #32770 )" ( #36877 )
...
This reverts commit 1aa4628fa27034deb68743d636be5aba04b4ad6f.
2019-07-24 14:26:46 -07:00
Shi-Hao Hong
aa6384cbac
Revert "[Material] Implement TooltipTheme and Tooltip.textStyle, fix Tooltip debugLabel, update Tooltip defaults ( #36030 )" ( #36851 )
...
This reverts commit 62158a1bae83aedcc88d66694010911a98fff84a.
2019-07-24 08:55:51 -07:00
Shi-Hao Hong
62158a1bae
[Material] Implement TooltipTheme and Tooltip.textStyle, fix Tooltip debugLabel, update Tooltip defaults ( #36030 )
...
* Implement TooltipThemeData and TooltipTheme
* Add tooltip text style property
* Update default tooltip text style and decoration to match Material specification
* Fix debugLabel incorrectly labeling "white" as "black", and vice versa by default
2019-07-24 08:24:09 -07:00
brandondiamond
e08538c38f
Update visual style of CupertinoSwitch to match iOS 13 ( #36087 )
2019-07-24 08:20:19 -07:00
K. P. Sroka
1b57006c82
Prevents infinite loop in Table._computeColumnWidths ( #36262 )
2019-07-23 19:51:57 -07:00
Jim Graham
9946f7cff9
Optimize the transformRect and transformPoint methods in matrix_utils. ( #36396 )
...
Primarily these methods no longer allocate any objects other than their
return values.
Additionally, the math in the methods is reduced compared to the general
case math based on known input conditions.
2019-07-23 17:25:39 -07:00
Devon Carew
d708d9deb2
add an error count field to the Flutter.Error event ( #36768 )
...
* add an error count field to the Flutter.Error event
* review comments; more tests
* normalize comments
2019-07-23 17:01:14 -07:00
Alexander Aprelev
d28f3c7cbb
Unskip date_picker_test on Windows as underlying issue 19696 was fixed. ( #36546 )
2019-07-22 13:55:49 -07:00
chunhtai
1cb6b8bb0d
fixes iphone force press keybaord select crashes ( #36698 )
2019-07-22 13:20:21 -07:00
Devon Carew
45ae4f6dbe
use sentence case in error message titles ( #35750 )
...
* use sentence case in error message titles
* add a test
2019-07-22 12:49:53 -07:00
Todd Volkert
fbd4bb91f6
Revert "AsyncSnapshot.data to throw if error or no data ( #34626 )" ( #36618 )
...
This reverts commit b61fcfd25d0b32ec3791d09493d0235bb9a2b43f.
2019-07-20 22:10:59 -07:00
Yegor
ecd89fb7ad
fix message codecs for the Web ( #36549 )
2019-07-19 13:49:15 -07:00
chunhtai
a52f0f773c
Fixes sliver list does not layout firstchild when child reordered ( #36493 )
2019-07-19 12:19:05 -07:00
chunhtai
2338576aa6
implement selectable text ( #34019 )
2019-07-19 12:17:41 -07:00
Kate Lovett
38e41f5aee
SliverFillRemaining accounts for child size when hasScrollBody is false ( #35810 )
...
Fixes the hasScrollBody flag not accounting for child size. Adds the ability to specify over-scroll behavior.
2019-07-19 11:35:31 -07:00
Darren Austin
252491f8ac
Updated ColorScheme.dark() colors to match the Material Dark theme specification ( #36106 )
...
Updated ColorScheme.dark() primaryVariant, surface, background and error
colors to match the spec.
2019-07-19 11:31:29 -07:00
Todd Volkert
b61fcfd25d
AsyncSnapshot.data to throw if error or no data ( #34626 )
...
This updates `AsyncSnapshot.data` to act as `AsyncSnapshot.requireData`
used to -- and it removes `AsyncSnapshot.requireData`. Correspondingly,
this adds a `StreamBuilder.withoutInitialData()` constructor, makes the
`initialData` argument to the default `StreamBuilder()` constructor required,
and deprecates the `initialData` argument to the `FutureBuilder()` constructor.
See the breaking change announcement for more info.
https://github.com/flutter/flutter/issues/34545
https://groups.google.com/forum/#!topic/flutter-announce/H6Od0QdsdrI
2019-07-18 16:26:13 -07:00
Tong Mu
1aa4628fa2
Dismiss modal with any button press ( #32770 )
...
This PR makes ModalBarrier dismiss modal with any button press instead of primary button up, by making it use a private recognizer _AnyTapGestureRecognizer that claims victor and calls onAnyTapDown immediately after it receives any PointerDownEvent.
2019-07-18 15:33:49 -07:00
Shi-Hao Hong
db6c362bef
Implement InputDecorationTheme copyWith, ==, hashCode ( #36411 )
...
* Implement InputDecorationTheme copyWith, ==, hashCode
2019-07-18 14:40:39 -07:00
Dan Field
b7a49c4afe
fix sliver fixed pinned appbar ( #36333 )
2019-07-18 10:37:08 -07:00
Mouad Debbar
9c9b71a0fb
Add multi-line flag to semantics ( #36297 )
2019-07-18 10:36:22 -07:00
Matan Shukry
0ab7047b72
Using custom exception class for network loading error ( #35335 )
...
Using custom exception class for network loading error
2019-07-17 14:23:03 -07:00
chunhtai
4eb11c9f52
Fixes RenderSliverFixedExtentBoxAdaptor correctly calculates leadingGarbage and trailingGarbage. ( #36302 )
2019-07-17 10:40:07 -07:00
伯言
b2cc97013d
Fix FocusTraversalPolicy makes focus lost ( #34153 ) ( #34712 )
...
FocusTraversalPolicy keep the previously visited node to avoid hysteresis. But even if the visited focus has been disposed, FocusTraversalPolicy will still use it to requestFocus, which will cause FocusManger to get an abandoned node to get the focus.
2019-07-17 10:00:06 -07:00
chunhtai
7992e3242d
Fix nested scroll view can rebuild if mark dirty during scheduleWarmUpFrame ( #36097 )
2019-07-17 09:29:08 -07:00
Dan Field
5923f34ce4
Revert "Fix semantics for floating pinned sliver app bar ( #35574 )" ( #36319 )
...
This reverts commit 39baa0995c53cd1378c7a9ede791543ad1e2e711.
2019-07-17 09:24:51 -07:00
Dan Field
c96806ec88
Allow semantics labels to be shorter or longer than raw text ( #36243 )
2019-07-16 20:40:36 -07:00
Dan Field
93a3ce7a8d
Disable flaky tests on Windows ( #36317 )
2019-07-16 16:26:15 -07:00
Darren Austin
e17f8d367d
Support for elevation based dark theme overlay color in the Material widget ( #35560 )
...
Added support for a semi-transparent white overlay color for `Material` widgets to indicate their elevation in a dart theme. A new `ThemeData.applyElevationOverlayColor` flag was added to control this behavior, which is off by default for backwards compatibility reasons.
2019-07-16 10:50:44 -07:00
Jonah Williams
a8c4da22d9
add a kIsWeb constant to foundation ( #36135 )
2019-07-16 09:12:21 -07:00
Kate Lovett
8809f698cb
Revert "Part 1: Skia Gold Testing ( #33688 )" ( #36094 )
...
This reverts commit eb0b17902876f1a75eb7180c0b9f3571efb312b8.
Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
2019-07-12 13:35:36 -07:00
Kate Lovett
eb0b179028
Part 1: Skia Gold Testing ( #33688 )
...
* Fresh PR for Gold integration.
* Nits
* WIP
* Artifacts from merge
* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.
* Updating for CI implementation
* Write out service account
* Writing to skip out
* WIP
* ++
* Fixing depot tools deps
* Windows depot_tools
* Fixing setup scripts
* ++
* depot tools
* ++
* WIP
* Tracing depot_tools clone
* WIP
* ++
* analyzer
* WIP
* chrome typo
* copy artifact
* Working on tests
* Code cleanup
* ++
* Code cleanup, updated tests
* ++ review feedback
* Review
* Analyzer
* Review feedback
* Nits from review
* PRogress
* ++
* Fixing tests
* ++
* Testing repo route
* Just needing documention around new structures.
* cleanup
* Analyzer
* Documentation updates
* Documentation updates
* Cirrus updates
* cirrus nit
* Review feedback
* Review feedback
* Fixing skip comparator
* Fix base directory for Skia Gold case
* ++
* Feedback
* ++
* Fixed uri assertion
* Made GoldensClient abstract, altered SkiaGoldClient constructor
* Analyzer
2019-07-12 12:23:04 -07:00
chunhtai
fc7bd6ad24
refactor out selection handlers ( #35207 )
2019-07-12 12:13:50 -07:00
Dan Field
7a20148548
Add colorFilterLayer/Widget ( #35468 )
2019-07-11 15:49:51 -07:00
LongCatIsLooong
539f09f801
Remove _debugWillReattachChildren assertions from _TableElement ( #34202 )
2019-07-11 13:54:51 -07:00
Dan Field
735352a8c0
Deflake ImageProvider.evict test ( #35999 )
2019-07-11 13:09:30 -07:00
Justin McCandless
ff53fbe194
Text selection menu show/hide cases ( #35219 )
...
Show and hide the text selection menu at the correct time with various gestures in the text field.
2019-07-10 14:08:14 -07:00
rami-a
70bb5d1d5a
Add flag to use root navigator for showModalBottomSheet ( #35878 )
...
* Add flag to use root navigator for showModalBottomSheet
* Add documentation
* Add tests
* Address feedback and fix analyzer issues
* Address feedback
* Update comments
2019-07-10 16:07:15 -04:00
Shi-Hao Hong
e7ef75680e
Update Dark Theme disabledColor to White38 ( #35136 )
...
* Add Colors.white38
* Update ThemeData.disabledColor and ButtonThemeData.disabledColor to Colors.white38
* Update pre-existing tests to expect Colors.white38 instead of Colors.white30
* Update API documentation to reflect these changes
2019-07-10 08:50:24 -07:00
Darren Austin
af1bd09c78
Added MaterialApp.themeMode to control which theme is used. ( #35499 )
...
Added support for a themeMode property to the MaterialApp to control
how the light or dark theme is selected.
2019-07-09 15:26:42 -07:00
Anthony
aae50f541a
[Material] Text scale and wide label fixes for Slider and Range Slider value indicator shape ( #35496 )
...
Various bug fixes for Slider and Range Slider value indicator around accessibility and wide labels.
2019-07-09 13:26:10 -04:00
chunhtai
a76e39f984
Rendering errors with root causes in the widget layer should have a reference to the widget ( #32511 )
2019-07-09 10:18:30 -07:00
Kate Lovett
97b2c98642
Navigator pushAndRemoveUntil Fix ( #35223 )
...
* Initial work
* ++
* Updated tests
* Moved TestObserver out for access across tests.
* ++
* Added hero tests
* Review feedback
* simplified preceding route overlay
* Review feedback
* trailing doc slash
2019-07-09 10:17:30 -07:00
Hiroki Matsue
0e7cfc1e41
Add missing [applicationIcon] property to LicensePage widget ( #34906 )
...
* Add missing [applicationIcon] property to LicensePage widget
2019-07-08 17:30:28 -07:00
Dan Field
39baa0995c
Fix semantics for floating pinned sliver app bar ( #35574 )
2019-07-08 14:02:42 -07:00
Dan Field
f85630b18a
Fix RenderFittedBox when child.size.isEmpty ( #35487 )
2019-07-03 12:40:06 -07:00
chunhtai
f143fd6a4f
fix Selection handles position is off ( #34665 )
2019-07-03 10:50:10 -07:00
Michael Goderbauer
d41eeeb50d
Include tags in SemanticsNode debug properties ( #35491 )
2019-07-03 09:13:37 -07:00
Michael Goderbauer
4ca7bfa0c2
Re-apply 'Add currentSystemFrameTimeStamp to SchedulerBinding' ( #35492 )
2019-07-03 09:13:09 -07:00
