Dan Field
473358d93d
Revert dispose images when done ( #67100 )
...
* Revert "docs for image disposal (#67066 )"
This reverts commit bcb2ac5a55b90b2ccfd50de4684c0cbb8aca9290.
* Revert "Dispose of images after using them (#66688 )"
This reverts commit a7954691dad4788f985cf17e81ce6c474a72e84e.
2020-10-01 16:53:50 -07:00
Jason Simmons
c9392da6a4
Relax the bounds of some Cupertino text field tests ( #67020 )
...
SkParagraph may calculate slightly different metrics for text layouts
2020-10-01 13:46:17 -07:00
Dan Field
a7954691da
Dispose of images after using them ( #66688 )
...
* Dispose of images after using them
Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
Makes all stateful holders of ui.Image objects properly clone and dispose of them.
Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
2020-10-01 09:48:54 -07:00
Rami
79400b2462
[Material] Update some semantics for time picker controls ( #66652 )
2020-10-01 09:06:46 -04:00
Dan Field
25f44bb271
test ( #67021 )
2020-09-30 18:02:04 -07:00
Michael Goderbauer
19e07d2beb
Migrate flutter_test ( #66663 )
2020-09-30 17:03:40 -07:00
Anhad Singh
64a23504bb
Added transformAlignment for container ( #66201 )
2020-09-30 14:55:58 -07:00
Pedro Massango
f800a67ee4
[fix] once errorBuilder is called Image widget stops loading images ( #65180 )
2020-09-30 14:53:05 -07:00
Jason Simmons
e5de2b08b8
Text test should check that a paragraph's longest line is not greater than the width constraint ( #67000 )
2020-09-30 14:52:08 -07:00
Dan Field
e8812c409b
Revert "Improve the behavior of Scrollable.ensureVisible when Scrollable nested ( #65226 )" ( #66918 )
...
This reverts commit 73b6398932b3142a6e2f479327c50c5aa613a680.
2020-09-29 16:11:30 -07:00
Daniel Edrisian
6501f1b5cf
Allow modifying barrier color and barrier dismissible for Cupertino Modal Popup ( #66692 )
2020-09-29 15:37:04 -07:00
Alexander Brusher
d693d2b9d2
Adds getter/setter for slider semantics flag. ( #65766 )
2020-09-29 09:29:36 -07:00
Yuqian Li
9d7bdb5903
Default FittedBox's clipBehavior to none ( #66700 )
...
This is a continuation of https://github.com/flutter/flutter/pull/61366
after cl/333620714
See also https://flutter.dev/go/clip-behavior
2020-09-28 22:46:21 -07:00
LongCatIsLooong
cd6279c1ec
fix _getPixelPerfectCursorOffset logic when infinite ( #66845 )
2020-09-28 20:37:04 -07:00
Jonah Williams
2d37e086ca
[desktop] default to shrink wrap on desktop platforms ( #66754 )
2020-09-28 14:27:02 -07:00
Pieter van Loon
fa109c49b1
Sliver padding overlap fix ( #65323 )
2020-09-28 12:22:07 -07:00
Pedro Massango
10f6284426
Add back the autovalidate class property ( #66267 )
...
* Add back autovalidate property
* Add autovalidate property back (include tests)
* Fix typos
* One more test :)
2020-09-28 09:27:16 -07:00
xubaolin
73b6398932
Improve the behavior of Scrollable.ensureVisible when Scrollable nested ( #65226 )
2020-09-27 20:07:32 -07:00
Michael Goderbauer
062e469f1b
Page-subclasses to take children instead of builder ( #66694 )
2020-09-27 15:32:07 -07:00
Nguyễn Thanh Hải
693c4a7ccc
Fix last month not being displayed if last date is selected in DateRangePicker ( #66542 )
2020-09-25 17:02:04 -07:00
Hans Muller
6b04937292
Replaced use of obsolete RaisedButton with ElevatedButton in widget_inspector_test ( #66603 )
2020-09-25 08:26:04 -07:00
MH Johnson
7d89f21613
[Material] Remove opacity from dark theme overlay check ( #66596 )
...
* Remove opacity from check and add test
2020-09-25 10:41:27 -04:00
Hans Muller
fd93576856
Replaced obsolete use of FlatButton with TextButton in scroll_activity_test ( #66602 )
2020-09-25 07:32:17 -07:00
Hans Muller
890e6ccea6
Replaced obsolete use of FlatButton with TextButton ( #66597 )
2020-09-25 07:31:56 -07:00
LongCatIsLooong
c412fd9967
Length formatter minor fix ( #66567 )
2020-09-24 22:47:03 -07:00
Jonah Williams
90d83e37a6
[flutter_tools] register service worker after first frame event ( #66082 )
...
Registering the service worker immediately after the documented has loaded may cause SW initialization to compete with framework initialization. It was recommended to us that we defer the service worker setup until after the framework is done with setup, which should be sometime after the first frame.
To implement this, I augmented the binding setup to dispatch an event on the document after the binding has initialized. I don't see any obvious risks with this setup.
Fixes #66066
2020-09-23 18:58:05 -07:00
Yash Johri
9bfab77835
Changed title to label ( #66186 )
2020-09-23 18:57:03 -07:00
Greg Spencer
bbd7b97664
Change the default visual density to be adaptive based on platform. ( #66370 )
...
Based on feedback from various desktop developers, and to be consistent between the defaults and the sample code, this PR switches the default for visual density in desktop themes to be compact instead of standard.
It also removes the same setting from the sample code generated by "flutter create" because it is no longer needed now that it is the default.
2020-09-23 11:14:58 -07:00
TheBiirb
1a9ea39ad7
Make Dismissible's HitTestBehavior an argument ( #64379 )
2020-09-23 10:02:05 -07:00
LongCatIsLooong
525e76bc7c
Positioning IME bars on iOS ( #61981 )
2020-09-22 18:32:05 -07:00
Gary Qian
eb5cc495b3
Provide defaulting for textScaleFactor when passing to dart:ui ( #66375 )
2020-09-22 17:17:04 -07:00
Yuqian Li
8e8acaac7a
Add Overflow back with deprecation ( #66305 )
2020-09-22 17:07:04 -07:00
Juyeong Lee
33d015199f
Fix CupertinoAlertDialog TextStyle ( #64468 )
2020-09-22 17:02:04 -07:00
Dan Field
2102bb0364
Remove last FakeImage implementation ( #66379 )
2020-09-22 15:24:37 -07:00
xubaolin
1906218092
SliverList perform layout start from the initial child when there is no valid layout offset ( #66262 )
2020-09-22 12:12:03 -07:00
Dan Field
7eb8447485
Allow new methods to be added to ui.Image for tests ( #65876 )
...
Remove fake image implementations, add createTestImage to flutter_test
2020-09-22 11:55:39 -07:00
Justin McCandless
4c7f746374
TextField intrinsic height layout bug ( #66291 )
...
Fixes a bug when TextField is wrapped in IntrinsicHeight and visual density is below standard.
2020-09-21 15:29:00 -07:00
Ian Hickson
cb232ddad5
Prevent a potential infinite loop. ( #66073 )
2020-09-21 11:22:07 -07:00
Raouf Rahiche
e0afee5b13
add ScrollViewKeyboardDismissBehavior to CustomScrollView constructor ( #66014 )
2020-09-21 11:12:06 -07:00
Justin McCandless
2c163e6e95
InteractiveViewer onInteractionUpdate focalPoint ( #66065 )
2020-09-19 11:17:04 -07:00
Jonah Williams
a19f5baccc
[flutter_tools] connect widget cache from frontend_server ( #65951 )
2020-09-19 11:02:04 -07:00
Justin McCandless
e00b1531af
Reland "TextField constrained layout bug ( #65966 )" ( #66055 )
2020-09-18 15:02:04 -07:00
xubaolin
73194cd9f2
Fix bug when updating the divisions and value of the slider at the same time ( #65998 )
2020-09-18 14:52:03 -07:00
Yash Johri
8fb807a4d3
Changed title to label in bottom_navigation_bar_test.dart ( #65918 )
2020-09-18 14:47:05 -07:00
Dan Field
78929661fb
Fix test file name (continous -> continuous) ( #66081 )
2020-09-18 08:08:30 -07:00
GodHyum
d26268bb9e
Change LicensePage's loading color from scaffoldBackgroundColor to cardColor ( #64639 )
...
* wrap LicensePage's loading widget with cardColor
* Set AnimatedSwitcer's duration in LicensePage to zero
* Remove AnimatedSwitcher
* Add test code for checking color is same
2020-09-17 17:06:26 -07:00
chunhtai
70f21de9de
reland always adds alert label for alert dialog in Android ( #66057 )
2020-09-17 16:17:05 -07:00
Alexandre Ardhuin
0cf1b407f2
remove non-nullability on Navigator methods ( #65997 )
2020-09-17 16:12:06 -07:00
Darren Austin
1f62776935
Reland ##65044 ( #66061 )
...
Turn the opt-in default for ThemeData.useTextSelectionTheme to true so that everything uses the new TextSelectionTheme by default.
2020-09-17 15:55:45 -07:00
Mouad Debbar
5024e1ea02
[web] Inform the engine when read-only flag is flipped ( #65499 )
2020-09-17 15:52:04 -07:00
