8233 Commits

Author SHA1 Message Date
Dan Field
473358d93d
Revert dispose images when done (#67100)
* Revert "docs for image disposal (#67066)"

This reverts commit bcb2ac5a55b90b2ccfd50de4684c0cbb8aca9290.

* Revert "Dispose of images after using them (#66688)"

This reverts commit a7954691dad4788f985cf17e81ce6c474a72e84e.
2020-10-01 16:53:50 -07:00
Dan Field
bcb2ac5a55
docs for image disposal (#67066) 2020-10-01 14:14:15 -07:00
Jason Simmons
c9392da6a4
Relax the bounds of some Cupertino text field tests (#67020)
SkParagraph may calculate slightly different metrics for text layouts
2020-10-01 13:46:17 -07:00
Jacob MacDonald
b95c3d7d56
update stack_trace dep (and others) (#67057) 2020-10-01 09:54:07 -07:00
Dan Field
a7954691da
Dispose of images after using them (#66688)
* Dispose of images after using them
Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
Makes all stateful holders of ui.Image objects properly clone and dispose of them.
Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
2020-10-01 09:48:54 -07:00
Rami
79400b2462
[Material] Update some semantics for time picker controls (#66652) 2020-10-01 09:06:46 -04:00
Alexandre Ardhuin
9d41ddcbac
migrate some material files to nullsafety (#66985)
* migrate some material files to nullsafety

* fix test_private

* address review comments

* fix private test on windows

* use uri in include entry of analysis_options
2020-10-01 08:01:58 +02:00
Phil Quitslund
d3155658bc
API docs for typedefs. (#67003) 2020-09-30 19:32:02 -07:00
Dan Field
25f44bb271
test (#67021) 2020-09-30 18:02:04 -07:00
Michael Goderbauer
19e07d2beb
Migrate flutter_test (#66663) 2020-09-30 17:03:40 -07:00
Madhur Maurya
2de1c8da47
Nested Scaffolds Documentation Improvement (#66972) 2020-10-01 07:55:15 +08:00
Anhad Singh
64a23504bb
Added transformAlignment for container (#66201) 2020-09-30 14:55:58 -07:00
Pedro Massango
f800a67ee4
[fix] once errorBuilder is called Image widget stops loading images (#65180) 2020-09-30 14:53:05 -07:00
Jason Simmons
e5de2b08b8
Text test should check that a paragraph's longest line is not greater than the width constraint (#67000) 2020-09-30 14:52:08 -07:00
Dan Field
e8812c409b
Revert "Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226)" (#66918)
This reverts commit 73b6398932b3142a6e2f479327c50c5aa613a680.
2020-09-29 16:11:30 -07:00
Daniel Edrisian
6501f1b5cf
Allow modifying barrier color and barrier dismissible for Cupertino Modal Popup (#66692) 2020-09-29 15:37:04 -07:00
Alexandre Ardhuin
e605b7c225
migrate some material files to nullsafty (#66858)
* migrate some material files to nullsafty

* address review comments
2020-09-29 22:51:21 +02:00
Konstantin Scheglov
d227788a53
Move assert(s) that reference 'this' to the constructor bodies. (#66914) 2020-09-29 11:47:21 -07:00
Alexander Brusher
d693d2b9d2
Adds getter/setter for slider semantics flag. (#65766) 2020-09-29 09:29:36 -07:00
Justin McCandless
d2c47acdaa
GlobalKey docs improvement (#66834)
Improve GlobalKey docs by mentioning a pitfall that some users had where the instantiated it in the build method.
2020-09-29 08:40:26 -07:00
Yuqian Li
9d7bdb5903
Default FittedBox's clipBehavior to none (#66700)
This is a continuation of https://github.com/flutter/flutter/pull/61366
after cl/333620714

See also https://flutter.dev/go/clip-behavior
2020-09-28 22:46:21 -07:00
LongCatIsLooong
cd6279c1ec
fix _getPixelPerfectCursorOffset logic when infinite (#66845) 2020-09-28 20:37:04 -07:00
Jonah Williams
2d37e086ca
[desktop] default to shrink wrap on desktop platforms (#66754) 2020-09-28 14:27:02 -07:00
Alexandre Ardhuin
a01113de88
migration of material files to nullsafety (#66633) 2020-09-28 13:57:04 -07:00
Pieter van Loon
fa109c49b1
Sliver padding overlap fix (#65323) 2020-09-28 12:22:07 -07:00
Pedro Massango
10f6284426
Add back the autovalidate class property (#66267)
* Add back autovalidate property

* Add autovalidate property back (include tests)

* Fix typos

* One more test :)
2020-09-28 09:27:16 -07:00
Jose Alba
8db31a556b
Divider with subheader example update (#65944)
* Divider with subheader example update

* fixed issues

* Addressed comments

* fixed issues
2020-09-28 14:32:00 +02:00
xubaolin
73b6398932
Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226) 2020-09-27 20:07:32 -07:00
Michael Goderbauer
062e469f1b
Page-subclasses to take children instead of builder (#66694) 2020-09-27 15:32:07 -07:00
Alexandre Ardhuin
eca0cf38ca
fix the tree (#66783) 2020-09-27 23:04:30 +02:00
Alexandre Ardhuin
c2e43403af
apply upcoming lint cast_nullable_to_non_nullable (#66455)
* apply upcoming lint cast_nullable_to_non_nullable

* make RenderObjectElement.renderObject non-nullable
2020-09-27 21:29:42 +02:00
Nguyễn Thanh Hải
693c4a7ccc
Fix last month not being displayed if last date is selected in DateRangePicker (#66542) 2020-09-25 17:02:04 -07:00
Justin McCandless
0bca44cf8d
Update docs about complex character support (#66582)
Simple docs fix for characters.
2020-09-25 16:06:32 -07:00
Chinmoy
21ad3e7af0
Changed TickerProviderStateMixin to SingleTickerProviderStateMixin in ScrollbarState (#66653) 2020-09-25 09:51:26 -07:00
Hans Muller
6b04937292
Replaced use of obsolete RaisedButton with ElevatedButton in widget_inspector_test (#66603) 2020-09-25 08:26:04 -07:00
MH Johnson
7d89f21613
[Material] Remove opacity from dark theme overlay check (#66596)
* Remove opacity from check and add test
2020-09-25 10:41:27 -04:00
Hans Muller
fd93576856
Replaced obsolete use of FlatButton with TextButton in scroll_activity_test (#66602) 2020-09-25 07:32:17 -07:00
Hans Muller
890e6ccea6
Replaced obsolete use of FlatButton with TextButton (#66597) 2020-09-25 07:31:56 -07:00
LongCatIsLooong
c412fd9967
Length formatter minor fix (#66567) 2020-09-24 22:47:03 -07:00
Alexandre Ardhuin
19078b1a02
migrate cupertino to nullsafety (#66493) 2020-09-24 14:07:03 -07:00
Will Larche
ee6d4c6590
[Docs] [Material] Fix Icons api docs (#66508)
* [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs.

* Better documentation and that special awful case.

* Couple more places to remove.
2020-09-24 15:18:10 -04:00
Darren Austin
11f7ff0049
Complete the migration to the TextSelectionTheme by deprecating the opt-in flag and text selection properties in ThemeData. (#66482) 2020-09-24 12:13:00 -07:00
Michael Goderbauer
506998cff6
Allow futures that resolve to null in Future/StreamBuilder (#66506) 2020-09-24 10:04:11 -07:00
TheBiirb
2adb91895c
Fixes typos in showDialog documentation (#66213)
* Fixes typos in showDialog documentation
2020-09-24 23:28:39 +08:00
Greg Spencer
4fad739bf6
Change emoji in About dialog to be a divider (#66409) 2020-09-23 20:42:03 -07:00
Jonah Williams
90d83e37a6
[flutter_tools] register service worker after first frame event (#66082)
Registering the service worker immediately after the documented has loaded may cause SW initialization to compete with framework initialization. It was recommended to us that we defer the service worker setup until after the framework is done with setup, which should be sometime after the first frame.

To implement this, I augmented the binding setup to dispatch an event on the document after the binding has initialized. I don't see any obvious risks with this setup.

Fixes #66066
2020-09-23 18:58:05 -07:00
Yash Johri
9bfab77835
Changed title to label (#66186) 2020-09-23 18:57:03 -07:00
Alexandre Ardhuin
29fae79c72
migrate some cupertino files to nullsafety (#66424)
* migrate some cupertino files to nullsafety

* address review comments
2020-09-23 23:12:42 +02:00
Greg Spencer
bbd7b97664
Change the default visual density to be adaptive based on platform. (#66370)
Based on feedback from various desktop developers, and to be consistent between the defaults and the sample code, this PR switches the default for visual density in desktop themes to be compact instead of standard.

It also removes the same setting from the sample code generated by "flutter create" because it is no longer needed now that it is the default.
2020-09-23 11:14:58 -07:00
Jacob MacDonald
9cee75ba61
update to the latest null safe packages (#66384)
Updates all null safe dependencies to versions that allow 2.10 stable and 2.11 dev releases.

Also updates flutter_goldens and flutter_goldens_client to allow 2.11 dev.
2020-09-23 11:03:29 -07:00