13 Commits

Author SHA1 Message Date
Hixie
9f174def11 Lots of trivial warning fixes
Add type annotations in many places.
Fix some identifiers to have more lint-satisfying names.
Make all operator==s consistent in style.
Reorder some functions for consistency.
Make ParentData no longer dynamic, and fix all the code around that.
2015-10-12 16:31:20 -07:00
Hixie
203db4ac6a Remove workarounds that avoided 'super' in mixins
Dart supports this properly now.
2015-10-09 11:24:50 -07:00
Jason Simmons
d0668c002e Some cleanup of the Sky analyzer script
* If no source path is provided, then run the analyzer on the Sky unit tests
* Fix the filter for errors found in pub cache packages
* Generalize the filter for the analyzer's "xx errors/warnings/hints found" status message

Also fix a test that caused a warning in the analyzer.
2015-09-21 14:14:30 -07:00
Adam Barth
b04cb30609 Remove a number of unneeded filters from skyanalyzer
The dartanalyzer no longer emits these warnings (or the code has been cleaned
up).
2015-09-01 16:13:44 -07:00
Hixie
d96b1e84ca Silence skyanalyzer's complaints about third-party packages. 2015-09-01 13:22:44 -07:00
Hixie
3cc25bb255 Fix analyzer to not change the working directory.
I didn't understand what was going on before. Now I do. This is a better fix that making the path absolute.
2015-08-17 16:57:08 -07:00
Hixie
108f3b6b75 Analyzer updates
- Remove shelldb analyze, since we want to remove shelldb.
- Make skyanalyzer pass the absolute path to dartanalyzer. I'm not
  sure why this is sometimes needed, but without it, I sometimes get
  file not found errors.
- Remove some of the patterns we were ignoring, since either the
  errors have been fixed or the analyzer has been fixed.

There's still hundreds of warnings in the mojo and sky packages (the
ones in the sky packages are all bogus, I believe).
2015-08-17 15:42:34 -07:00
Adam Barth
6942e9557e Fix skyanalyzer
Our supressions for the generated mojom.dart files weren't working after we
deleted the mojom package. This CL updates the filters to catch mojom.dart
files again.
2015-08-03 10:00:52 -07:00
Adam Barth
54a744e9e1 Fix spurious skyanalyzer failures
We need to update our regexps because we moved the mojom and mojo packages.
2015-07-29 16:37:02 -07:00
Hans Muller
36813aff27 add --fatal-warnings to dartanalyzer command line 2015-07-28 14:34:54 -07:00
Hans Muller
ba99e9582c specify --package-root 2015-07-28 12:35:15 -07:00
Adam Barth
b74c187eda Teach skyanalyzer about workbench
Hopefully this will make Travis green again.
2015-07-27 20:54:19 -07:00
Collin Jackson
a64559ab70 After running filter-branch, move root directory into sky/ 2015-07-16 11:54:25 -07:00