Add type annotations in many places.
Fix some identifiers to have more lint-satisfying names.
Make all operator==s consistent in style.
Reorder some functions for consistency.
Make ParentData no longer dynamic, and fix all the code around that.
* If no source path is provided, then run the analyzer on the Sky unit tests
* Fix the filter for errors found in pub cache packages
* Generalize the filter for the analyzer's "xx errors/warnings/hints found" status message
Also fix a test that caused a warning in the analyzer.
- Remove shelldb analyze, since we want to remove shelldb.
- Make skyanalyzer pass the absolute path to dartanalyzer. I'm not
sure why this is sometimes needed, but without it, I sometimes get
file not found errors.
- Remove some of the patterns we were ignoring, since either the
errors have been fixed or the analyzer has been fixed.
There's still hundreds of warnings in the mojo and sky packages (the
ones in the sky packages are all bogus, I believe).
Our supressions for the generated mojom.dart files weren't working after we
deleted the mojom package. This CL updates the filters to catch mojom.dart
files again.