DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
6,285 Commits 882 Branches 1,069 Tags
Commit Graph

4937 Commits

Author SHA1 Message Date
Chris Bracken
9fcc2f0a94 [License] Enable prefer_final_fields lint 2018-12-20 14:56:23 -08:00
Chris Bracken
daa400f0ef [License] Enable prefer_asserts_in_initializer_lists lint 2018-12-20 14:56:23 -08:00
Chris Bracken
7f63386418 [License] Enable prefer_equal_for_default_values lint 2018-12-20 14:56:23 -08:00
Chris Bracken
4e9eed6141 [License] Enable empty_catches lint 2018-12-20 14:56:23 -08:00
Chris Bracken
f1d81a6960 [License] Enable unnecessary_this lint 2018-12-20 14:56:23 -08:00
Chris Bracken
5fd7a23242 [License] Enable prefer_single_quotes lint 2018-12-20 14:56:23 -08:00
Justin McCandless
bfed1287d6 Clarify TextAffinity docs (flutter/engine#7238) 
* Clarify TextAffinity docs

* Clarify TextPosition and the definition of upstream/downstream

* Docs fixes from code review, less redundant with 'string in code'
 2018-12-20 14:14:04 -08:00
Chris Bracken
33a144cbc5 [License] Assert license filename is non-null, non-empty (flutter/engine#7270) 2018-12-20 13:50:21 -08:00
Chris Bracken
16949aab71 [License] Eliminate duplicate case in switch (flutter/engine#7269) 
This changes behaviour, but we should treat diffs as binary for the
reasons outlined in the comment on the remaining diff case.
 2018-12-20 13:22:30 -08:00
Chris Bracken
a3bb2045a4 Mark all unreassigned locals final in license tool (flutter/engine#7267) 
Marks locals final where possible, and enables the prefer_final_locals
lint.
 2018-12-20 12:27:50 -08:00
skia-flutter-autoroll
ea8e7013a4 Roll src/third_party/skia 44539be30ef8..b03e024a4034 (7 commits) (flutter/engine#7268) 
https://skia.googlesource.com/skia.git/+log/44539be30ef8..b03e024a4034


Created with:
  gclient setdep -r src/third_party/skia@b03e024a4034

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-20 15:19:47 -05:00
Stanislav Baranov
f4e41b41ae Document native functions for compilation trace (flutter/engine#7256) 2018-12-20 11:48:59 -08:00
Chris Bracken
30f4d14d6b Eliminate use of new keyword in licence tool (flutter/engine#7266) 
This eliminates the use of the now-optional new keyword and enforces the
unnecessary_new lint.
 2018-12-20 11:29:28 -08:00
skia-flutter-autoroll
36596bbc50 Roll src/third_party/skia 428ec1e55c05..44539be30ef8 (1 commits) (flutter/engine#7265) 
https://skia.googlesource.com/skia.git/+log/428ec1e55c05..44539be30ef8


Created with:
  gclient setdep -r src/third_party/skia@44539be30ef8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-20 10:44:33 -05:00
skia-flutter-autoroll
a5e54f3a85 Roll src/third_party/skia 21ee517391bc..428ec1e55c05 (3 commits) (flutter/engine#7264) 
https://skia.googlesource.com/skia.git/+log/21ee517391bc..428ec1e55c05


Created with:
  gclient setdep -r src/third_party/skia@428ec1e55c05

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-20 05:57:53 -05:00
Chris Bracken
7c7a5cc412 Re-run license tool on all source when it changes (flutter/engine#7260) 
The license tool includes an optimization whereby it skips re-running on
components (flutter, third_party, skia, currently) when it detects that
no changes have occurred to the sources in that component.

When the license script itself changes, we now force re-run it on all
components in order to verify the tool still works and output is as
expected.
 2018-12-19 23:15:44 -08:00
skia-flutter-autoroll
a57b7097fb Roll src/third_party/skia 7757bba636d8..21ee517391bc (1 commits) (flutter/engine#7263) 
https://skia.googlesource.com/skia.git/+log/7757bba636d8..21ee517391bc


Created with:
  gclient setdep -r src/third_party/skia@21ee517391bc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-20 01:35:24 -05:00
skia-flutter-autoroll
9a3a4d100f Roll src/third_party/skia ce9a901a76eb..7757bba636d8 (4 commits) (flutter/engine#7262) 
https://skia.googlesource.com/skia.git/+log/ce9a901a76eb..7757bba636d8


Created with:
  gclient setdep -r src/third_party/skia@7757bba636d8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-19 21:31:15 -05:00
Jason Simmons
2e112a7904 Add a system message channel for controlling the Skia resource cache size (flutter/engine#7257) 
See https://github.com/flutter/flutter/issues/25244
 2018-12-19 17:40:16 -08:00
Jason Simmons
4f52895770 Update usage of some Android APIs that are deprecated in API level 28 (flutter/engine#7261) 2018-12-19 17:39:53 -08:00
Jason Simmons
3c3ddb0a37 Remove unused GrContext in AndroidSurfaceGL (flutter/engine#7258) 2018-12-19 15:06:58 -08:00
skia-flutter-autoroll
f66774427d Roll src/third_party/skia 8d23a584fc43..ce9a901a76eb (10 commits) (flutter/engine#7259) 
https://skia.googlesource.com/skia.git/+log/8d23a584fc43..ce9a901a76eb


Created with:
  gclient setdep -r src/third_party/skia@ce9a901a76eb

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-19 17:24:44 -05:00
Stanislav Baranov
c85ef14c19 Update dynamic patching terminilogy to match that of the flutter tool (flutter/engine#7248) 2018-12-19 10:31:54 -08:00
skia-flutter-autoroll
e7d872fea7 Roll src/third_party/skia 1a237195b527..8d23a584fc43 (8 commits) (flutter/engine#7255) 
https://skia.googlesource.com/skia.git/+log/1a237195b527..8d23a584fc43


Created with:
  gclient setdep -r src/third_party/skia@8d23a584fc43

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-19 13:31:02 -05:00
Dan Field
e12c087f9e Fix javadoc for Android-28 (flutter/engine#7254) 
* Fix javadoc for Android-28

* build javadoc as part of pre-submit
 2018-12-19 09:24:02 -08:00
skia-flutter-autoroll
ee6078eead Roll src/third_party/skia 192d66440910..1a237195b527 (1 commits) (flutter/engine#7253) 
https://skia.googlesource.com/skia.git/+log/192d66440910..1a237195b527


Created with:
  gclient setdep -r src/third_party/skia@1a237195b527

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-19 08:29:05 -05:00
skia-flutter-autoroll
73800db30d Roll src/third_party/skia b933285ebb4e..192d66440910 (3 commits) (flutter/engine#7252) 
https://skia.googlesource.com/skia.git/+log/b933285ebb4e..192d66440910


Created with:
  gclient setdep -r src/third_party/skia@192d66440910

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-19 03:05:23 -05:00
Chris Bracken
50f04cdc63 Fix a misspelling (flutter/engine#7234) 
Change funciton to function in a doc comment.
 2018-12-18 20:08:46 -08:00
Chris Bracken
548657787a Extract function to collect licenses for component (flutter/engine#7250) 
Extracts _collectLicensesForComponent() from main, which collects the
licenses for the specified component (e.g. flutter, third_party, skia).

This is pre-factoring related to a fix for flutter/flutter#25519.
 2018-12-18 20:08:15 -08:00
skia-flutter-autoroll
9268e50483 Roll src/third_party/skia 67761eb35f97..b933285ebb4e (1 commits) (flutter/engine#7251) 
https://skia.googlesource.com/skia.git/+log/67761eb35f97..b933285ebb4e


Created with:
  gclient setdep -r src/third_party/skia@b933285ebb4e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-18 22:56:43 -05:00
Dan Field
5a59304379 Roll buildroot to support Android SDK 28 (flutter/engine#7245) 
* Roll to buildroot and support Android SDK 28

* Ubuntu 16 for android build test
 2018-12-18 19:38:28 -08:00
skia-flutter-autoroll
d4e13a25c4 Roll src/third_party/skia 4b75254560d4..67761eb35f97 (6 commits) (flutter/engine#7249) 
https://skia.googlesource.com/skia.git/+log/4b75254560d4..67761eb35f97


Created with:
  gclient setdep -r src/third_party/skia@67761eb35f97

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-18 18:40:26 -05:00
skia-flutter-autoroll
17a114e8c2 Roll src/third_party/skia e6f635476da3..4b75254560d4 (61 commits) (flutter/engine#7247) 
https://skia.googlesource.com/skia.git/+log/e6f635476da3..4b75254560d4


Created with:
  gclient setdep -r src/third_party/skia@4b75254560d4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-18 16:07:27 -05:00
Jason Simmons
9eae3293a3 Update iOS unit test for the removal of hex string encoding of uint64 data (flutter/engine#7246) 2018-12-18 11:16:38 -08:00
liyuqian
3f5e53a4c7 Compute cull_rect and optimize in Layer::Preroll (flutter/engine#6923) 
This PR replaces the unused `PrerollContext::child_paint_bounds` with `PrerollContext::cull_rect` so we can prune unnecessary preroll tasks (especially cache) based on clips. This PR fixes https://github.com/flutter/flutter/issues/24712

Performance test has been added (https://github.com/flutter/flutter/pull/25381) to make sure that we won't regress again in the future.

Note that the cull_rect here is very similar to those removed in https://github.com/flutter/engine/pull/6352 .     We can't compute cull rects in SceneBuilder because of retained layers. But we can still compute and use them to optimize performance in Preroll.
 2018-12-18 09:54:52 -08:00
Todd Volkert
70a7f91e86 Fix linter errors in ResourceUpdater (flutter/engine#7240) 2018-12-18 07:40:57 -08:00
Chris Bracken
0435cdb920 Revert spelling correction in licence matcher (flutter/engine#7242) 
In 0e73c0f16da78665b8786e0eb559da11b787ae11 (#7179), the word
'publically' was altered to 'publicly', causing the licence aggregator
to fail to match the licence text included in many BoringSSL source
files.

The original licence includes several misspellings (e.g. 'rouines'
rather than 'routines') which we need to faithfully reproduce in our
match regex.

The failure this triggered went unnoticed during pre-/post-submit
due to the fact that the contents of the third_party directory didn't
change, so hash of the list of files used as a signature matched the
signature in the golden file, causing the run to be skipped.
 2018-12-17 18:57:04 -08:00
Todd Volkert
cf3c281533 Allow inferred types using diamond syntax (flutter/engine#7237) 2018-12-17 16:35:10 -08:00
Todd Volkert
2d383262d7 Simplify nested try-with-resources statements (flutter/engine#7239) 2018-12-17 16:34:54 -08:00
Jason Simmons
1449f3af36 Fix destruction of the child object list in the iOS accessibility bridge (flutter/engine#7108) 
Fixes https://github.com/flutter/flutter/issues/22206
 2018-12-17 16:05:23 -08:00
Jason Simmons
5463140ef4 Simplify conversion of numeric types in the message codec on iOS (flutter/engine#7097) 
Consistently handle Int32/Int64 types on both 32-bit and 64-bit versions
of iOS.  Drop usage of the obsolete hex string encoding for BigInt types.

Fixes https://github.com/flutter/flutter/issues/21313
 2018-12-17 15:54:57 -08:00
Chris Bracken
fff4720f2c Verify RunConfiguration is valid before running (flutter/engine#6922) 
In cases where a valid IsolateConfiguration cannot be inferred, (e.g.,
settings.kernel_list_asset is missing) RunConfiguration can be created
with a null IsolateConfiguration. In such cases, bail out early with
kInvalidSettings.

Also adds a redundant paranoid check to EmbedderEngine::Run.
 2018-12-16 14:07:42 -08:00
Jimmy Casey
0e73c0f16d Correct spelling in doc comments (flutter/engine#7179) 
Applies spelling corrections to accessibility-related doc comments and in the
license tool.
 2018-12-16 12:51:00 -08:00
Chris Bracken
8a0cc94b1a Compile embedder unit test Dart to kernel (flutter/engine#7231) 
As of the migration to Dart 2, it has been necessary to compile Dart to
kernel prior to execution. The embedder currently requires that the
resulting kernel file be named `kernel_blob.bin` and be located at the
root of the assets directory passed to the embedder API.

This patch updates the test_fixtures build rule to perform a kernel
compile using frontend_server, outputting `kernel_blob.bin` to
`fixtures/test_target_name` directory, and updates the embedder
unittests to specify the kernel file rather than the Dart source file.

Since the kernel compiler requires a `main()` function to be defined, it
also updates `simple_main.dart` from runtime_unittests to define
`main()` rather than `simple_main()`.

This also updates all existing sub-targets to be testonly.

This relands commit 4e4fb4608da95d198b0e796478462285ab974a3c, which was
reverted in commit 566db0ecb8f293bb9f7ff1fc39076b08336e0148. Rather than
running as prebuilt_dart_action, we use dart_action to ensure the
frontend snapshot it compatible with the VM on which it's executed.
 2018-12-16 12:23:18 -08:00
skia-flutter-autoroll
1097bc02e1 Roll src/third_party/skia cb8157e6266c..e6f635476da3 (1 commits) (flutter/engine#7233) 
https://skia.googlesource.com/skia.git/+log/cb8157e6266c..e6f635476da3


Created with:
  gclient setdep -r src/third_party/skia@e6f635476da3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-16 05:57:53 -05:00
skia-flutter-autoroll
30d881fa44 Roll src/third_party/skia 2e6db18c4309..cb8157e6266c (1 commits) (flutter/engine#7232) 
https://skia.googlesource.com/skia.git/+log/2e6db18c4309..cb8157e6266c


Created with:
  gclient setdep -r src/third_party/skia@cb8157e6266c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-16 01:56:15 -05:00
Chris Bracken
566db0ecb8 Revert "Compile embedder unit test Dart to kernel (#7227)" (flutter/engine#7230) 
This reverts commit 4e4fb4608da95d198b0e796478462285ab974a3c.

This broke dynamic release mode builds of
//flutter/runtime:runtime_fixtures_kernel (likely all product-mode
builds).
 2018-12-15 14:43:26 -08:00
skia-flutter-autoroll
1ff3da8881 Roll src/third_party/skia 282ec5dc6ca7..2e6db18c4309 (1 commits) (flutter/engine#7228) 
https://skia.googlesource.com/skia.git/+log/282ec5dc6ca7..2e6db18c4309


Created with:
  gclient setdep -r src/third_party/skia@2e6db18c4309

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-15 17:13:05 -05:00
Chris Bracken
4e4fb4608d Compile embedder unit test Dart to kernel (flutter/engine#7227) 
Compile embedder unit test Dart to kernel

As of the migration to Dart 2, it has been necessary to compile Dart to
kernel prior to execution. The embedder currently requires that the
resulting kernel file be named `kernel_blob.bin` and be located at the
root of the assets directory passed to the embedder API.

This patch updates the test_fixtures build rule to perform a kernel
compile using frontend_server, outputting `kernel_blob.bin` to
`fixtures/test_target_name` directory, and updates the embedder
unittests to specify the kernel file rather than the Dart source file.

Since the kernel compiler requires a `main()` function to be defined, it
also updates `simple_main.dart` from runtime_unittests to define
`main()` rather than `simple_main()`.

This also updates all existing sub-targets to be testonly.
 2018-12-15 13:59:58 -08:00
skia-flutter-autoroll
ba8ff96c34 Roll src/third_party/skia d4962e7e07c0..282ec5dc6ca7 (1 commits) (flutter/engine#7226) 
https://skia.googlesource.com/skia.git/+log/d4962e7e07c0..282ec5dc6ca7


Created with:
  gclient setdep -r src/third_party/skia@282ec5dc6ca7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
 2018-12-15 13:21:32 -05:00