11814 Commits

Author SHA1 Message Date
chunhtai
978d9b5514
Issues/111931 reland (#121576)
* Revert "Revert "Fix text.rich to merge widget span (#113461)" (#121562)"

This reverts commit c8d80163b03f76e0cfde15567d065b6d1903cf8d.

* Fixes tag to not pollute cached semantics configuration in rendering object
2023-03-01 08:33:03 -08:00
Bruno Leroux
b66a547439
Fix _TextEditingHistoryState reentrant calls (#120889)
Fix text history undo/redo should not add a new entry to the history
2023-03-01 08:52:46 +00:00
Daniel Austin
b10f25c603
implement override of toString() in order to print useful message in release mode as well as debug mode (#118263)
Added `_ErrorDescription.toString()`
2023-03-01 01:08:52 +00:00
James Lee
3c70fb2667
Add typically used parameter name to the builder used in layout_builder (#119877)
Add  typically used parameter name to the builder used in layout_builder
2023-03-01 00:25:55 +00:00
Michael Goderbauer
6de42a70f1
Fix how tests count open SemanticsHandles (#121571)
Fix how tests count open SemanticsHandles
2023-02-28 23:55:58 +00:00
Xilai Zhang
153fce4d45
Revert "Fix ExpansionTile hint for Android (#120881)" (#121624)
This reverts commit fd65fd1b161277cec815ea2b10d63976b7d0da6d.
2023-02-28 13:15:47 -08:00
Dan Field
c8aa37d1ea
Fix for #112403 and b/249091367 (#121615)
Fix monodrag gestures for #112403 and b/249091367
2023-02-28 20:14:33 +00:00
Jim Gerth
0a1af28a8b
Use AnimatedSwitcher's _childNumber as Key in layoutBuilder's Stack (#121408)
Use AnimatedSwitcher's _childNumber as Key in layoutBuilder's Stack
2023-02-28 18:37:29 +00:00
Greg Price
e13677450c
Make ClampingScrollSimulation ballistic and more like Android (#120420)
Make ClampingScrollSimulation ballistic and more like Android
2023-02-28 17:38:29 +00:00
Ben Konyi
ecd7518df5
Reland "Remove references to Observatory (#118577)" (#121606)
This reverts commit 275ab9c69bc15113003b77637ea90031df8ed348.
2023-02-28 11:57:04 -05:00
Michael Goderbauer
df66fecdcf
showOnScreen does not crash if target node doesn't exist anymore (#121575)
showOnScreen does not crash if target node doesn't exist anymore
2023-02-28 03:06:28 +00:00
Hans Muller
cd0030cc27
Removed "typically non-null" API doc qualifiers from ScrollMetrics min,max extent getters (#121572)
Removed "typically non-null" API doc qualifiers from ScrollMetrics min,max extent getters
2023-02-28 01:53:52 +00:00
Skandar Munir
681b72c304
fixes Show Week Day in CupertinoDatePicker with CupertinoDatePickerMo… (#120052)
fixes Show Week Day in CupertinoDatePicker with CupertinoDatePickerMo…
2023-02-28 01:52:51 +00:00
Kate Lovett
677971828d
Fix scrolled under for 2D scrolling (#121297)
Fix AppBar scrolled under for 2D scrolling
2023-02-28 01:13:51 +00:00
Hans Muller
1bfba7564b
Added identical(a,b) short circuit to rendering library lerp methods (#121566)
Added identical(a,b) short circuit to rendering library lerp methods
2023-02-28 00:55:56 +00:00
Flutter GitHub Bot
2c3fa08253
roll packages (#121556)
Roll pub packages
2023-02-28 00:11:26 +00:00
Michael Goderbauer
275ab9c69b
Revert "Reland "Remove references to Observatory (#118577)" (#121215)" (#121555)
Revert "Reland "Remove references to Observatory (#118577)""
2023-02-27 23:46:53 +00:00
chunhtai
c8d80163b0
Revert "Fix text.rich to merge widget span (#113461)" (#121562)
This reverts commit 660992a161ba04de706cd3931c32d3123e6e1228.
2023-02-27 15:38:43 -08:00
Mahan
14a9c23020
Separate theme logic (#117818)
Separate theme logic
2023-02-27 22:34:46 +00:00
Bruno Leroux
fa49db31f1
Cleanup material/tabs.dart documentation (#121524)
Cleanup material/tabs.dart documentation
2023-02-27 22:34:44 +00:00
Tomohiko Tanihata
6175937565
Update scroll paging logic in Scrollbar (#121481)
Update scroll paging logic in Scrollbar
2023-02-27 21:06:29 +00:00
Taha Tesser
fd65fd1b16
Fix ExpansionTile hint for Android (#120881)
Fix `ExpansionTile` double tap to collapse/expanded and expanded/collapsed states semantics announcements
2023-02-27 18:40:17 +00:00
ivirtex
edba606974
Fix text color not resolving when CupertinoThemeData.brightness is null (#115026)
* Fix text color not resolving in `CupertinoApp`

* Make linter happy

* Create cupertinoBuilder for theming

* Make linter happy

* Fix tests

* Fix regression

* Delete whitespace

* Resolve color passed to the `WidgetsApp`

* Revert "Resolve color passed to the `WidgetsApp`"

This reverts commit 6994719a564c476dcb6d389e4547bff3ded08203.

* Resolve selection colors

* Kick tests

* Delete doubled test
2023-02-27 10:36:11 -08:00
Bruno Leroux
a297cb368b
Fix Ink decoration image does not render (#121521) 2023-02-27 08:51:21 -08:00
Rulong Chen(陈汝龙)
a5c60f4128
Limit the PlatformView ID within the range of 32-bit integers. (#121203)
Limit the PlatformView ID within the range of 32-bit integers.
2023-02-27 14:52:40 +00:00
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory (#118577)" (#121215)
This reverts commit 298d8c76ba78007deb5b96f320a11ccefe97a794.
2023-02-27 09:26:43 -05:00
Michael Goderbauer
b1b7284a72
Move semantic-related bindings to SemanticsBinding (#121289)
Move semantic-related bindings to SemanticsBinding
2023-02-24 19:30:57 +00:00
Mitchell Goodwin
cb67ecd97d
Add adaptive RefreshIndicator (#121249) 2023-02-24 10:51:37 -08:00
Bruno Leroux
5d99748c7a
Remove accessibleNavigation reference from BottomSheet (#121132)
Remove accessibleNavigation reference from BottomSheet
2023-02-24 17:22:28 +00:00
Taha Tesser
219ff64574
Reland "Update ExpansionTile to support Material 3 & add an example" (#121212) 2023-02-24 06:30:33 -08:00
Hans Muller
1c753635b1
Added identical(a,b) short circuit to painting Library lerp methods (#121346) 2023-02-23 14:23:39 -08:00
Qun Cheng
07b0252da4
Change mouse cursor to be SystemMouseCursors.click when not focusable (#121353)
Co-authored-by: Qun Cheng <quncheng@google.com>
2023-02-23 14:23:11 -08:00
Greg Spencer
b1d8a4e4c7
Modify focus traversal policy search to use focus tree instead of widget tree (#121186)
* Modify focus traversal policy search to use focus tree instead of widget tree

* Eliminate unnecessary inherited widget

* Remove unintentional change

* Look for focus nodes without creating a dependency.

* Add test

* Review Changes

* Fix debug_test.dart

* Rebase onto master
2023-02-23 21:15:54 +00:00
Flutter GitHub Bot
5d36cb77fb
roll packages (#121358) 2023-02-23 20:20:25 +00:00
Lioness100
26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
David Neuy
3681b27a47
Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. (#114338)
* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props.

* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props - add tests.

* Fix analysis errors

* Review changes.

* Add asserts for dataRowMinHeight and dataRowMaxHeight

* Add asserts for dataRowMinHeight and dataRowMaxHeight

* Make dataRowHeight a computed getter

* Remove get only dataRowHeight from hashCode...

* Update deprecated after

* Add new line at end of AUTHORS

* Apply suggestions from code review

* Update packages/flutter/test/material/data_table_test.dart

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 19:32:29 +00:00
Greg Price
97938859e0
Fix buggy formula for critically-damped springs (#120488)
Fixes #109675.

This formula would produce an initial velocity quite different
from the one specified as an argument.

To update the test, I computed the expected results separately
by using the physical formula.

Happily, the framework by default never ends up actually exercising
this code.  Of the four SpringDescription call sites within the
framework, two are explicitly overdamped; the other two are by
design critically damped, but due to rounding they end up being
treated as (very slightly) overdamped too.  Details here:
  https://github.com/flutter/flutter/issues/109675#issuecomment-1423674855

So the only way an app could be affected by this bug is if it called
a SpringDescription constructor itself, and managed to create a spring
description where the distinguishing formula in _SpringSolution comes
out exactly equal to zero.  It's likely nobody has ever shipped such
an app, because the behavior this produces would be so wildly wrong
that it'd be hard to miss when exercised.

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 19:29:32 +00:00
Flutter GitHub Bot
8080becadf
roll packages (#120951) 2023-02-23 19:21:53 +00:00
chunhtai
660992a161
Fix text.rich to merge widget span (#113461)
* Fix text.rich to merge widget span

* migrate to new API

* update

* addressing comment

* addressing comments

* update

* addressing comment

* Update
2023-02-23 17:38:52 +00:00
Taha Tesser
56e1bddc59
Fix SliverAppBar.medium & SliverAppBar.large title overlap with leading/actions widgets, leading width, and title spacing (#120780)
* Fix `SliverAppBar.medium` & `SliverAppBar.large` title overlap with leading/actions widgets, leading width, and title spacing

* Add `titleSpacing` theme tests and consolidate multiple tests for the same widgets
2023-02-23 17:12:11 +00:00
Eilidh Southren
0c1ed75915
Remove newline (#121090)
* remove newline

* update crswap

* add const constructor

* update const
2023-02-23 10:39:41 +00:00
Bruno Leroux
046d907f53
Fix TextSelectionGestureDetectorBuilder wrong cause for onDoubleTapDown (#121093)
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2023-02-23 09:24:17 +00:00
Todd Volkert
71c4570932
Add ResizeImage.policy (#121154)
* Add ResizeImage.policy

This adds a new `ResizeImage.policy` property that controls how `ResizeImage`
will interpret its `width` and `height` properties. The existing behavior is
preserved via `ResizeImagePolicy.exact` (default), but there is now the option
to use `ResizeImagePolicy.fit`, which satisfies the use case outlined in
flutter/flutter#118543.

The API doc assets were added in flutter/assets-for-api-docs#209

Fixes flutter/flutter#118543

* Docuemnt public member

* Remove protected annotation from overrides - was failing tests

* Fixed analysis of code in Dartdoc

* More dartdoc code analysis fixes

* One more fix

* Review comments
2023-02-23 03:53:05 +00:00
suragch
9619c33348
Remove obsolete comment (#120265)
* Remove obsolete comment

The method `_stopCursorTimer` no longer exists.

* Add edited comment back in

Addresses these comments:
- https://github.com/flutter/flutter/pull/120265#discussion_r1101673834
- https://github.com/flutter/flutter/pull/120265#discussion_r1102120022

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:16 +00:00
codiss
156c6614bf
Fix Material3 TabBarTheme.dividerColor not working (#119690)
* Fixed Material3 TabBarTheme.dividerColor not working

* Add 'Material3 - TabBar inherits the dividerColor of TabBarTheme' test

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:11 +00:00
Michael Goderbauer
4ef1fe4434
Work-around for channels flake (#121261) 2023-02-23 02:46:08 +00:00
Michael Goderbauer
1737233567
Fix typo (#121291) 2023-02-23 02:46:06 +00:00
Greg Spencer
a50bdcfd18
Add getInheritedWidgetOfExactType to BuildContext (#121276)
* Add getInheritedWidgetOfExactType to BuildContext

* Use the new API in all the places

* Fix doc error

* Review Changes
2023-02-23 01:09:51 +00:00
David Skelly
368537b910
Add padding to DropdownButton (#115806)
* add padding param to DropdownButton

* improve padding comment

* update test

* Add more context to documentation

* update padding documentation with more detail

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 01:07:51 +00:00
Casey Hillers
8f7ccd4c41
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)" (#121220)
This reverts commit e3db0488adaf1ca1330c800bef9aa06749d30a7a.
2023-02-23 00:13:33 +00:00