100 Commits

Author SHA1 Message Date
Chinmay Garde
16999258f7 Simplify the fallback waiter and add traces for vsync scheduling overhead. (flutter/engine#8185) 2019-03-18 15:49:16 -07:00
Chinmay Garde
9ada55b844 Add frame and target time metadata to vsync events and connect platform vsync events using flows. (flutter/engine#8172)
This will allow us to easily visualize the time the platform informed the engine of a vsync event, its arguments, and when the engine began its UI thread workload using this information.
2019-03-14 16:48:01 -07:00
Chinmay Garde
8fc02f5b1d Add an allocator specific check to ensure that strings passed to the timeline are not heap allocated. (flutter/engine#8168)
Verified that the tests fail on issues like https://github.com/flutter/engine/pull/8166. Unfortunately, there is no x-platform way to perform this check but this should gate incorrect traces being added to the engine.
2019-03-14 14:15:46 -07:00
Jason Simmons
4670858e8f Do not pass short-lived buffers as labels to Dart_TimelineEvent (flutter/engine#8166)
Dart no longer makes a copy of the label string when recording events.

See https://github.com/flutter/engine/pull/8152
2019-03-14 12:49:42 -07:00
Chinmay Garde
0809280550 Reland ""Add support for trace counters with variable arguments and instrument the raster cache." (flutter/engine#8145)
This reverts commit da6e460c67c34d34eef1e9ec87b8534a379fe1f5 and fixes the
discovered on Windows builds.
2019-03-13 13:53:22 -07:00
liyuqian
6b28290f44 Typo "fast an inline" to "fast and inline" (flutter/engine#8142) 2019-03-12 15:27:33 -07:00
Chinmay Garde
da6e460c67 Revert "Add support for trace counters with variable arguments and instrument the raster cache. (#8094)" (flutter/engine#8122)
This reverts commit 9f384e3e4cbfdf23381509a62c7023e77edcbfd8.
2019-03-11 15:09:24 -07:00
Chinmay Garde
9f384e3e4c Add support for trace counters with variable arguments and instrument the raster cache. (flutter/engine#8094) 2019-03-11 14:44:43 -07:00
Chinmay Garde
c20c3c47f4 Remove redundant thread checker in FML. (flutter/engine#8053)
There is already fml/memory/thread_checker.h
2019-03-05 20:07:10 -08:00
Chinmay Garde
eccfd67b6c Remove unused FML file export.h (flutter/engine#7926)
We should not be exporting anything from FML anyway.
2019-02-22 12:44:09 -08:00
Alexander Aprelev
adc3ca0e31 Add fml::FileExists implementation for Windows (flutter/engine#7845) 2019-02-15 12:42:41 -08:00
Jason Simmons
8a941d7b3c Embed ICU data inside libflutter.so on Android (flutter/engine#7588)
Prior to this the Android embedder code would extract the icudtl.dat asset out
of the APK and write it to local disk during the first startup of the app.

This change will make that work unnecessary and eliminate the risk of ICU
failures due to errors in the extraction process.
2019-01-30 11:56:17 -08:00
Chris Bracken
23db336526 [Fuchsia] Depend on libtrace when that is what's really meant (flutter/engine#7214)
libtrace-provider has libtrace listed as a dependency when really it
does not have any such dependency. This lets trace clients use
libtrace-provider as a dependency when what they really mean is libtrace.

This errant dependency in trace-provider is being fixed, which
means we need to fix these clients.
2018-12-13 13:13:38 -08:00
Alexander Aprelev
839fd8348a Guard the service protocol's global handlers list with a reader/writer lock. (flutter/engine#6900)
* Revert "Revert "Guard the service protocol's global handlers list with a reader/writer lock (#6888) #6895" (#6899)"

This reverts commit bcf5e1eae123478564468b77251a2674bd0e773e and applies fix for tests on Windows.

* Reland guard the service protocol's global handlers list with a reader/writer lock.

* Remove blank line
2018-11-18 14:36:15 -08:00
Todd Volkert
bcf5e1eae1 Revert "Guard the service protocol's global handlers list with a reader/writer lock (#6888) #6895" (flutter/engine#6899) 2018-11-18 09:28:26 -08:00
Jason Simmons
f5496c0977 Guard the service protocol's global handlers list with a reader/writer lock (#6888) (flutter/engine#6895)
The service protocol holds the lock while waiting for completion of service
RPC tasks.  These tasks (specifically hot restart/RunInView) may need to
modify a handler's description data.

Task execution and ServiceProtocol::SetHandlerDescription will obtain a shared
lock to make this possible.  AddHandler and RemoveHandler will obtain an
exclusive lock in order to guard against a handler being deleted while a
service task is running.
2018-11-17 22:04:37 -08:00
Jason Simmons
7449dc427e Revert "Guard the service protocol's global handlers list with a reader/writer lock (#6888)" (flutter/engine#6893)
This reverts commit e740d7f1dbdb69dc4fd38e39c887dd3cccae7c3d.

(shared_timed_mutex is unavailable in the iOS build)
2018-11-17 12:27:06 -08:00
Jason Simmons
e740d7f1db Guard the service protocol's global handlers list with a reader/writer lock (flutter/engine#6888)
The service protocol holds the lock while waiting for completion of service
RPC tasks.  These tasks (specifically hot restart/RunInView) may need to
modify a handler's description data.

Task execution and ServiceProtocol::SetHandlerDescription will obtain a shared
lock to make this possible.  AddHandler and RemoveHandler will obtain an
exclusive lock in order to guard against a handler being deleted while a
service task is running.
2018-11-17 10:53:26 -08:00
Michael Goderbauer
e9bfd56271 Fix Windows Engine Bot (flutter/engine#6844)
Follow-up to https://github.com/flutter/engine/pull/6833
2018-11-13 09:46:30 -08:00
Michael Goderbauer
082336e7c2 Fix code smells reported by chrome's clang plugin (flutter/engine#6833) 2018-11-12 19:59:29 -08:00
Michael Goderbauer
0def82ddb0 Unify copyright lines (flutter/engine#6757) 2018-11-07 12:24:35 -08:00
Chinmay Garde
ddd0b8887a Handle Windows headers defining ERROR to 0 in log levels. (flutter/engine#6677) 2018-10-26 16:47:14 -07:00
Chinmay Garde
9e7967d181 Add a CountDownLatch to fml with tests. (flutter/engine#6574) 2018-10-17 17:20:44 -07:00
Chinmay Garde
74c44fa72a Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278)
Also teaches FML to create files and directories.
2018-09-26 14:54:09 -07:00
Chinmay Garde
b1b2a1cc3f Add support for counter timeline traces from the engine. (flutter/engine#6315) 2018-09-26 13:26:23 -07:00
Chinmay Garde
7cebfdf58e Ensure that objects on stack that close traces have unique variable names. (flutter/engine#6298) 2018-09-22 14:46:29 -07:00
Mehmet Fidanboylu
c43e79d938 Don't use unix or win namespaces (flutter/engine#6277) 2018-09-18 19:43:26 -07:00
Jason Simmons
5ecda4b710 Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
See https://github.com/flutter/flutter/issues/21348
2018-09-07 09:34:45 -07:00
Michael Goderbauer
441b84f24c Update to latest clang (flutter/engine#6174)
* Roll buildroot to be483cb1cd3a9c4313b2e534034d23a05c3d849e
* Rolls buildtools to c1408453246f0475547b6fe634c2f3dad71c6457
2018-09-06 15:29:04 -07:00
Michael Goderbauer
4d7e7d21c9 Roll buildroot to pick up new NDK r17b (flutter/engine#6131) 2018-08-31 11:28:18 -07:00
Chinmay Garde
e2448720ae Add message encoding/decoding utility to FML. (flutter/engine#6017) 2018-08-15 12:30:02 -07:00
Chinmay Garde
f352631388 Make FML task runner methods virtual so that FXL adaptors in Fuchsia are possible. (flutter/engine#5921) 2018-08-01 14:18:33 -07:00
Chinmay Garde
3e5e79b737 Fix sundry Fuchsia build issues after the tonic/fxl migration. (flutter/engine#5920) 2018-08-01 13:29:45 -07:00
Chinmay Garde
050b93b822 Update GetDirectoryName namespace to the one in FML on Linux. (flutter/engine#5879) 2018-07-26 13:40:29 -07:00
Chinmay Garde
6ab2c166fd Remove all dependencies on Garnet. (flutter/engine#5869) 2018-07-26 12:49:34 -07:00
liyuqian
e1465ff214 Unify trailing spaces / new lines (flutter/engine#5871) 2018-07-26 00:14:43 -07:00
Chinmay Garde
62289623fc Remove //flutter/glue and use FML directly. (flutter/engine#5862) 2018-07-25 13:20:48 -07:00
Joshua Seaton
4543efbb38 [fml] Remove unused ResourceMapping code. (flutter/engine#5811)
ResourceMapping-related code is no longer used.Moreover, there is an
ASan related-error in ResourceMappingDarwin:
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8940466063445826656/+/steps/test_results/0/steps/s___out_release-x64_host_tests_dart_schema_tests/0/logs/stdio/0
2018-07-20 10:53:27 -07:00
Joshua Seaton
967a473c6d [fml][fxl] Migrate AutoResetWaitableEvent to fml version. (flutter/engine#5808)
Thanks Jason for the speedy review
2018-07-20 10:12:38 -07:00
李少杰
e4a03611ff Implement UniqueFDTraits::Free on non-win system (flutter/engine#5705) 2018-07-10 17:12:57 -07:00
Ben Konyi
a3b839a0bf IsolateNameServer reland (flutter/engine#5519)
* Reland "Added IsolateNameServer functionality (#5410)"

This reverts commit 1598c7ad7b830b298647c17a0c85f3648f6b737d.

* Fixed issue with isolate_name_server_test which caused test to timeout

* Disabled thread_annotations on Android as they aren't supported in the
NDK headers for std::mutex. Readded thread annotations to
IsolateNameServer.
2018-06-13 11:57:10 -07:00
Chinmay Garde
490c678b90 Fix file flags for directories and backslashes on Windows. (flutter/engine#5387) 2018-05-25 15:28:36 -07:00
Ryan Macnak
e0e92ecd24 Reduce log spam: failing to find an instructions buffer isn't an error for ordinary core snapshots. (flutter/engine#5370) 2018-05-25 10:31:56 -07:00
Chinmay Garde
1dddd111f6 Remove the only user of fxl::StringView in FML. (flutter/engine#5314) 2018-05-18 16:43:13 -07:00
Chinmay Garde
407cfd2aa9 Import synchronization utilities into FML. (flutter/engine#5312) 2018-05-18 16:25:29 -07:00
Chinmay Garde
6583de47ac Fix missing include on Windows. (flutter/engine#5313) 2018-05-18 16:22:48 -07:00
Chinmay Garde
93b02cf2f9 Import FXL timing utilities into FML. (flutter/engine#5311) 2018-05-18 16:02:01 -07:00
Chinmay Garde
16bc51e056 Import logging utilities from FXL. (flutter/engine#5310) 2018-05-18 15:43:49 -07:00
Chinmay Garde
7293d4cef9 Fixup Fuchsia content handler post shell refactor. (flutter/engine#5072) 2018-04-23 20:16:01 -07:00
Chinmay Garde
e25af6f85e Apply unaddressed comments in pull/5062 (flutter/engine#5065) 2018-04-23 12:16:15 -07:00