9799 Commits

Author SHA1 Message Date
Tong Mu
4771605c39
Fix KeyboardManager's synthesization (#88967)
This PR fixes KeyboardManager's key event synthesization logic, which were dispatching events with incorrect keys, making subsequent key events crash the app.
2021-08-29 17:26:49 -07:00
Ian Hickson
d32ad1f973
Prevent exceptions in _describeRelevantUserCode from hiding other exceptions. (#89073) 2021-08-28 03:36:02 -07:00
Craig Labenz
3a1b04952b
fix: refactor Stepper.controlsBuilder to use ControlsDetails (#88538)
* changed controlsBuilder signature

combined all parameters into ControlsDetails class

* sample fixes

* updates to docstrings

* switched to positional argument for stepper.controlsbuilder

* Merge branch 'master' into stepper-builder-fix
2021-08-27 11:26:29 -07:00
moko256
2086f99abc
update mouse_cursor.dart docs for winuwp cursor (#89011) 2021-08-27 09:26:04 -07:00
xubaolin
a05b1fffe7
TextField.autofocus should skip the element that never layout (#87109) 2021-08-26 18:11:04 -07:00
Justin McCandless
91ef92d2b2
hasStrings support for eliminating clipboard notifications (#87678)
Use the hasStrings clipboard method when possible instead of reading the contents of the clipboard.
2021-08-26 17:10:18 -07:00
Justin McCandless
b2adffa9fe
Keyboard text selection and wordwrap (#85653)
Keyboard shortcuts near wordwrapped lines could be buggy before this fix.
2021-08-26 17:08:52 -07:00
nt4f04uNd
8863296d66
Add missing parameters to DecorationImage (#88453)
* Add missing parameters to DecorationImage

* tune docs

* fix test
2021-08-26 13:28:49 -07:00
creativecreatorormaybenot
162d914d45
Fix typos and formatting in framework.dart (#88926) 2021-08-26 12:56:02 -07:00
Kate Lovett
426121c4f1
Add no-shuffle tag (#88989) 2021-08-26 14:19:59 -05:00
chunhtai
74ac7c476c
Fix empty textspan with spell out crashes (#88738) 2021-08-25 23:01:03 -07:00
Mohammad Ghalayini
bb278d1da2
[new feature] Add support for a RawScrollbar.shape (#85652) 2021-08-25 17:21:02 -07:00
nt4f04uNd
59f3f23a72
Fix precision error in NestedScrollView (#87801) 2021-08-25 15:46:03 -07:00
Darren Austin
a1cd3f45e0
Updated some skip test comments that were missed in the audit. (#88893) 2021-08-25 11:49:04 -07:00
Greg Spencer
33403bd28e
Extract Sample code into examples/api (#87280)
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
2021-08-25 09:45:12 -07:00
chunhtai
527d868391
Revert "Fixes listview shrinkwrap and hidden semantics node gets updated incorrectly. (#88814)" (#88886)
This reverts commit 0e9665e4ef59fca7d5c2eeed178cdd98d4a09fa0.
2021-08-25 09:42:43 -07:00
xubaolin
72289ec8cf
Fix the showBottomSheet controller leaking (#87775)
* Fix the showBottomSheet controller leaking

* codereview feedback
2021-08-25 11:35:46 +08:00
chunhtai
0e9665e4ef
Fixes listview shrinkwrap and hidden semantics node gets updated incorrectly. (#88814) 2021-08-24 18:09:04 -07:00
creativecreatorormaybenot
38186c8971
Add WidgetsFlutterBinding Assertion to setMethodCallHandler (#88819) 2021-08-24 17:04:03 -07:00
Deepak Penaganti
6dc18ef74e
Blurstyle for boxshadow v2 (#88697) 2021-08-23 22:39:04 -07:00
chunhtai
b9908f6b86
Fixes renderparagraph crashes due to truncated semantics node (#88190)
* Fixes renderparagraph crashes due to truncated semantics node

* add period
2021-08-23 16:03:49 -07:00
chunhtai
93a1484ae0
Add a hook for scroll position to notify scrolling context when dimen… (#87076) 2021-08-23 15:39:18 -07:00
Alexander Dahlberg
02bb8a4355
Fixed leak and removed no-shuffle tag in platform_channel_test.dart (#88432)
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>

This PR fixed the problem that prevented platform_channel_test.dart being shuffled. Part of #85160.

A couple of tests sets up callbacks through setMethodCallHandler() that gets unresolved and breaks other tests.

This PR clears those callbacks by passing null to setMethodCallHandler.
2021-08-23 15:32:44 -07:00
Alexander Dahlberg
86d7ec4548
Fixed leak and removed no-shuffle tag in ticker_test.dart (#88426) 2021-08-23 15:22:06 -07:00
Alexander Dahlberg
04de2ed3d5
Fixed leak and removed no-shuffle tag on scaffold_test.dart (#88375) 2021-08-23 15:17:05 -07:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
Iman khoshabi
adb25e1801
Correct PointerExitEvent class documentation (#88650) 2021-08-23 12:22:07 -07:00
Abhishek Ghaskata
49bf933b59
add margin to vertical stepper (#86067)
* add marging to vertical stepper

* Remove tralling spaces

* Update docstring
2021-08-23 12:02:02 -07:00
Alexander Dahlberg
1a5692b722
Fixed leak and removed no-shuffle tag in widgets/app_overrides_test.dart (#88469)
This PR fixed the problem that has prevented app_overrides_test.dart being shuffled. Part of #85160.

This test is testing WidgetsApp.showPerformanceOverlayOverride and WidgetsApp.debugAllowBannerOverride.

The problem: There was a strong dependecy to the default ordering of the tests. The value of showPerformanceOverlayOverride or debugAllowBannerOverride was expected to be the value that was set in previous test.

The fix: Make the values be set to default values after each test:
WidgetsApp.showPerformanceOverlayOverride=false
WidgetsApp.debugAllowBannerOverride=true
Set the expected value at the start of the test, if the default value is not expected.
2021-08-23 10:03:49 -07:00
Alexander Dahlberg
83b9e99cfb
Fixed leak and removed no-shuffle tag in scheduler_test.dart (#88423)
Co-authored-by: Alexander Dahlberg <alexander.dahlberg@sigma.se>

This PR fixed the problem that has prevented scheduler_test.dart being shuffled. Part of #85160.

One test schedules a task, but events are locked so the scheduled task does not execute and this messes up other tests.
This PR adds a teardown that executes the scheduled task after the test, when events are unlocked.
2021-08-23 10:03:21 -07:00
Alexander Dahlberg
2ee0234471
Fixed leak and removed no-shuffle tag in image_stream_test.dart (#88376)
Fixes test/painting/image_stream_test.dart of #85160

The problem: The timeDilation was changed to 2.0 but not restored. The changed timeDilation carried on to following tests which messed up some of them when using test ordering seed 456.

The Fix: Restore timeDilation to 1.0 at the end of test.
2021-08-23 10:03:03 -07:00
Alexander Dahlberg
60ed5cc8e4
Fixed leak and removed no-shuffle tag in long_press_test.dart (#88373)
Fixes test/gestures/long_press_test.dart of #85160

The LongPressGestureRecognizer in test 'non-allowed pointer does not inadvertently reset the recognizer' was not disposed breaking a lot of other tests.
2021-08-23 10:02:21 -07:00
nt4f04uNd
b5932065fa
Ensure RawImage render object updates (#88369) 2021-08-20 15:03:37 -07:00
Jonah Williams
01d0c53571
partial revert of gesture config (#88534)
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-08-20 13:43:16 -07:00
nt4f04uNd
17f0d2e5de
init (#88391) 2021-08-20 09:42:05 -07:00
Dan Field
c02961256a
Reland remove DefaultShaderWarmup (#88455) 2021-08-18 21:37:03 -07:00
sigmundch
7a21bd1000
reland disable ideographic script test on web (#88383) 2021-08-18 21:32:04 -07:00
Hans Muller
afe58fbab5
Revert "Reland "Android Q transition by default (#82670)" (#88409)" (#88482) 2021-08-18 20:22:04 -07:00
chunhtai
89d1b9e4c5
Makes PlatformInformationProvider aware of the browser default route … (#88122) 2021-08-18 13:37:02 -07:00
ColdPaleLight
33f5ac6650
ImageInfo adds a new getter named sizeBytes to decouple ImageCache and ui.Image (#86555) 2021-08-18 09:21:12 -07:00
Alex Li
df399f9a8d
Reland "Android Q transition by default (#82670)" (#88409)
* Reland "Android Q transition by default (#82670)"

This reverts commit 4053b4b16cbec129f03cd7201ab1b8250bda72e8.

* Fix `overall_experience_test.dart` for flutter_tools
2021-08-18 09:11:27 -07:00
Michael Goderbauer
922b70dda6
Typo fixes (#88379) 2021-08-17 18:52:05 -07:00
Christopher Fujino
81eb54bf78
update-packages (#88387) 2021-08-17 18:49:32 -07:00
Kate Lovett
3a9e7e3bef
New PR (#88365) 2021-08-17 18:42:03 -07:00
Jenn Magder
4053b4b16c
Revert "Android Q transition by default (#82670)" (#88394)
This reverts commit a1ae4feac518dbce2862760ff5ceb7f3992c8d43.
2021-08-17 17:48:52 -07:00
chunhtai
71948b72db
Enable soft transition for tooltip (#88318) 2021-08-17 16:07:03 -07:00
Alexandre Daigle
ddfaec19ad
Fix null check for content dimensions in page getter (#87824) 2021-08-17 15:57:06 -07:00
Alex Li
a1ae4feac5
Android Q transition by default (#82670) 2021-08-17 15:47:07 -07:00
Swiftaxe
2f46d36bf4
Fixed leak and removed no-shuffle tag in test/gestures/tap_test.dart (#88342) 2021-08-17 10:07:05 -07:00
Jonah Williams
060e4608b1
clean up stale or unnecessary TODOS (#88308) 2021-08-16 21:37:03 -07:00