81 Commits

Author SHA1 Message Date
Michael Goderbauer
bf5fdb9f96
Reland "Inject current FlutterView into tree and make available via View.of(context) (#116924)" (#117244)
* Reland "Inject current `FlutterView` into tree and make available via `View.of(context)` (#116924)"

This reverts commit 9102f2fe0bd26db6074ac4a17785296cd341ecb9.

* remove window placeholder
2022-12-17 06:14:19 +00:00
Casey Hillers
9102f2fe0b
Revert "Inject current FlutterView into tree and make available via View.of(context) (#116924)" (#117214)
This reverts commit a34e41948461de77bdec3dcc884900cd4544abb1.
2022-12-16 17:48:23 +00:00
Michael Goderbauer
a34e419484
Inject current FlutterView into tree and make available via View.of(context) (#116924)
* enable View.of

* tests

* ++

* greg review

* rewording

* hide view from public
2022-12-16 00:13:56 +00:00
Michael Goderbauer
9dd30878d9
Add LookupBoundary to Material (#116736) 2022-12-09 15:48:00 -08:00
Eilidh Southren
22cbef3050
[CP] Fix Snackbar TalkBack regression (#116417)
* Add M2 defaults and template skeleton

* add MaterialStateColor functionality to ActionTextColor (issue #110402)

* Add M2 defaults and template skeleton

* updated material 3 tokens

* Updated snackbar demo

* add theme tests

* add gen defaults

* formatting

* more whitespace fixes

* add widget type

* update docs

* code review changes

* Add line overflow functionality

* whitespace fixes

* update M3 animation

* whitespace fixes

* add insetPadding param

* Modifed icon parameter to showCloseIcon

* white space fixes

* test fixes

* rename iconColor to closeIconColor

* debug test fix

* de-britishification

* g3fix

* g3fix

* debug test fix

* Fix Snackbar talkback regression

* fix merge weirdness

* test fix

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error
2022-12-02 20:17:20 +00:00
Eilidh Southren
29422d25fe
M3 snackbar [re-land] (#116218)
* Add M2 defaults and template skeleton

* add MaterialStateColor functionality to ActionTextColor (issue #110402)

* Add M2 defaults and template skeleton

* updated material 3 tokens

* Updated snackbar demo

* add theme tests

* add gen defaults

* formatting

* more whitespace fixes

* add widget type

* update docs

* code review changes

* Add line overflow functionality

* whitespace fixes

* update M3 animation

* whitespace fixes

* add insetPadding param

* Modifed icon parameter to showCloseIcon

* white space fixes

* test fixes

* rename iconColor to closeIconColor

* debug test fix

* de-britishification

* g3fix

* g3fix

* debug test fix
2022-11-30 19:13:00 +00:00
Kate Lovett
8b32ac7a51
Revert "Update SnackBar to support Material 3" (#116199)
* Revert "Update SnackBar to support Material 3 (#115750)"

This reverts commit d58855c49986d46588b0e2b1bf2f8b2bb97e3932.

* Kick ci.yaml

Co-authored-by: Jenn Magder <magder@google.com>
2022-11-29 19:11:43 +00:00
Eilidh Southren
d58855c499
Update SnackBar to support Material 3 (#115750)
* Add M2 defaults and template skeleton

* add MaterialStateColor functionality to ActionTextColor (issue #110402)

* Add M2 defaults and template skeleton

* updated material 3 tokens

* Updated snackbar demo

* add theme tests

* add gen defaults

* formatting

* more whitespace fixes

* add widget type

* update docs

* code review changes

* Add line overflow functionality

* whitespace fixes

* update M3 animation

* whitespace fixes

* add insetPadding param

* Modifed icon parameter to showCloseIcon

* white space fixes

* test fixes

* rename iconColor to closeIconColor

* debug test fix

* de-britishification
2022-11-29 18:02:34 +00:00
Greg Spencer
0cb9f70460
Menu bar accelerators (#114852)
* Add MenuMenuAcceleratorLabel to support accelerators.

* Review Changes

* Review Changed

* Fix default label builder to use characters

* Remove golden test that shouldn't have been there.
2022-11-29 00:27:20 +00:00
Greg Spencer
77b41ba844
Remove the FocusScopeNode in the navigator (#109702) 2022-08-22 17:27:32 +00:00
xubaolin
4e2b648069
[Dismissible]Fix a state lose issue (#108971) 2022-08-19 02:47:10 +00:00
Greg Spencer
f5e4d2b427
Replace FocusTrap with TapRegionSurface (#107262) 2022-07-29 16:00:07 +00:00
Taha Tesser
8fe82bbe60
Add Scaffold drawers escape dismiss action. (#106186) 2022-06-29 07:16:05 +00:00
Greg Spencer
3e7e01c893
Remove extraneous InheritedWidget (#104676)
When I removed Shortcuts.of and Shortcuts.maybeOf, I forgot to also remove the associated InheritedWidget. This does that.
2022-05-26 15:25:48 -07:00
Greg Spencer
0a417c3b49
A bunch of cleanups and a missing ShortcutRegistar in WidgetsApp (#104560)
A bunch of random cleanup things I found while doing MenuBar development.

Changes an if test to an assert in binding.dart, since the if should always be true.
Adds the default ShortcutRegistrar that should have been in the ShortcutRegistry PR.
Moves a debug message in the FocusManager to print the result after the focus change instead of before.
Reorders the test parameters in theme_data_test.dart to match the order of the theme data fields everywhere else.
2022-05-25 09:32:46 -07:00
chunhtai
533816d116
Refactor web text editing shortcuts (#103377) 2022-05-12 13:09:06 -07:00
Kate Lovett
6eb601bc3e
Fix AppBar scrolledUnder initial state - the third (#102582) 2022-04-27 15:34:08 -07:00
Pierre-Louis
9644aa8d76
Fixes documentation inconsistencies around 'material' and 'material design' (#102632) 2022-04-27 09:29:06 -07:00
Kate Lovett
a75743e80e
Revert "Re-land reverse case for AppBar scrolled under" (#102580) 2022-04-26 11:14:06 -07:00
Kate Lovett
558016455a
Re-land reverse case for AppBar scrolled under (#102343) 2022-04-25 13:54:05 -07:00
Taha Tesser
900e5405c2
Replace ListTile with Chip in the debugCheckHasMaterial control test (#102311) 2022-04-21 12:59:07 -07:00
chunhtai
52fd2412f4
Reland "Add default selection style (#100719)" (#101954) 2022-04-15 16:44:07 -07:00
Kate Lovett
ea26272e2a
Revert "Fix reverse cases for App Bar scrolled under behavior (#101460)" (#101929)
merging now since it blocks flutter roll for too long
2022-04-14 15:58:05 -07:00
chunhtai
95e52dac76
Revert "Add default selection style (#100719)" (#101921)
* Revert "Add default selection style (#100719)"

This reverts commit c8057bc5064f54c04cbe054f00904722a7233a63.

* update

* update
2022-04-14 11:31:39 -07:00
Jonah Williams
08a23498c1
Revert changes to opacity/fade transition repaint boundary and secondary change (#101844) 2022-04-13 13:24:06 -07:00
chunhtai
c8057bc506
Add default selection style (#100719) 2022-04-13 11:49:09 -07:00
Jonah Williams
33e540a92e
fix test from opacity/repaint change (#101774) 2022-04-12 11:18:48 -07:00
Jonah Williams
6def1596cd
[framework] introduce repaint boundary in Opacity widgets (#101601) 2022-04-12 10:34:11 -07:00
Kate Lovett
135bb5d4f2
Remove deprecated Scaffold SnackBar API (#98549) 2022-04-08 14:27:07 -07:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Hans Muller
f4f23ecb59
Added SharedAppData to the widgets library (#93175) 2021-11-08 12:27:14 -08:00
Hans Muller
0815da4d38
Revert "Added widgets/AppModel" (#93161) 2021-11-05 16:13:03 -07:00
Hans Muller
389a12f4e0
Added widgets/AppModel (#92297) 2021-11-03 20:23:02 -07:00
LongCatIsLooong
ffcd32ebb6
Move text editing Actions to EditableTextState (#90684) 2021-11-03 11:11:32 -07:00
Jonah Williams
2900347afe
[flutter] prevent errant text field clicks from losing focus (#86041) 2021-07-13 16:46:04 -07:00
Greg Spencer
1ac209c222
Turn on avoid_dynamic_calls lint, make appropriate changes. (#84478) 2021-06-23 16:36:03 -07:00
Jonah Williams
85be4f6c96
[flutter] when primary mouse pointers don't contact a focused node, reset the focus (#82575) 2021-06-08 17:39:05 -07:00
chunhtai
97dfafbb62
Make tooltip hoverable and dismissible (#83830) 2021-06-03 17:49:05 -07:00
Alexandre Ardhuin
fa19b3d3bd
add missing trailing commas (#81329) 2021-04-27 17:09:03 -07:00
Justin McCandless
541bff4058
Text Editing Movement Keys via Shortcuts (#75032)
Text editing shortcuts involving the arrow keys are no longer handled by RenderEditable's RawKeyboardListener, they use the new Shortcuts setup.  First PR in a plan to port all text editing keyboard handling to shortcuts.
2021-03-11 15:52:04 -08:00
Kate Lovett
f4a0511e8b
Re-land 'Default Keyboard ScrollActions with PrimaryScrollController' (#70893) 2020-11-19 17:48:04 -08:00
Jim Graham
e803b13f01
Revert "Re-land 'Default Keyboard ScrollActions with PrimaryScrollController' (#70401)" (#70675)
This reverts commit 9b56241eef3a81bfe4e1ff72cc453a7693861944.
2020-11-16 22:55:59 -08:00
Kate Lovett
9b56241eef
Re-land 'Default Keyboard ScrollActions with PrimaryScrollController' (#70401) 2020-11-16 14:47:04 -06:00
Todd Volkert
f8d2f58b52
Ignore DismissIntent when barrier is not dismissible (#70156) 2020-11-12 11:45:32 -08:00
Zachary Anderson
3fce16c329
Revert "Default Keyboard ScrollActions with PrimaryScrollController (#69795)" (#70391)
This reverts commit 1f0df54553bab852026a2801ce3921a2ba493fab.
2020-11-12 09:49:12 -08:00
Kate Lovett
1f0df54553
Default Keyboard ScrollActions with PrimaryScrollController (#69795) 2020-11-11 15:29:05 -08:00
Darren Austin
3c21775c94
Migrate Material framework tests to null safety (#67556)
Migrate Material framework tests to null safety.
2020-10-07 16:44:00 -07:00
Tong Mu
0fbc95df21
Remove the extra wrapping of Listener (#67340) 2020-10-07 13:12:05 -07:00
Kate Lovett
64c845c579
Re-land ScaffoldMessenger (#66504) 2020-10-05 18:59:12 -05:00
Michael Goderbauer
fc85492d7c
Make Navigator restorable (inkl. WidgetsApp, MaterialApp, CupertinoApp) (#65658) 2020-10-02 11:42:02 -07:00