DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
389 Commits 882 Branches 1,069 Tags
Commit Graph

22 Commits

Author SHA1 Message Date
Ojan Vafai
ec084dc47a Make paddingBoxRect less dumb. 
It was calling contentWidth, which did clientWidth - padding,
and then adding the padding back in.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/715053004
 2014-11-11 16:58:33 -08:00
Ojan Vafai
aadd9d43cf Remove some more assorted code from RenderBox. 
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/691223003
 2014-11-11 10:16:03 -08:00
Ojan Vafai
eec7ede796 Remove assorted dead code from RenderBox. 
-overrideContainingBlock sizes were only used by RenderGrid.
-percendicular containing blocks were a vertical writing mode feature.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/704413008
 2014-11-10 19:43:04 -08:00
Rafael Weinstein
c0ffe6fb23 remove updateTouchEventTargetRectsIfNeeded 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/713073003
 2014-11-10 13:08:21 -08:00
Ojan Vafai
1fad59d33b Remove OverlayScrollbarSizeRelevancy. 
It doesn't do anything anymore.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/715453002
 2014-11-07 18:13:42 -08:00
Ojan Vafai
b44392daf4 Remove scrollbar width/height computations from layout. 
Scrollbars never take up layout space or participate in hit-testing.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/707233006
 2014-11-07 17:54:41 -08:00
Rafael Weinstein
f6b3a8cb02 Remove usesCompositedScrolling 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/712573003
 2014-11-07 13:59:11 -08:00
Ojan Vafai
2793661b5a Remove scroll corners and resizers. 
We never paint scroll corners. The only thing we need them
for is so that the vertical and horizontal scrollbars don't
overlap each other. So, that's the only place left that
still computes a scroll corner rect.

We don't support resizers. Remove the code for them as well
as the CSS resize property.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/689283003
 2014-11-07 09:46:16 -08:00
Ojan Vafai
4ecaa91c6c Remove margin collapsing. 
Margin collapsing is a document-oriented feature. For applications
it just causes confusion and slowness.

margins.sky has failure output because offsetTop is returning the
wrong values. That's not new with this patch though. When I look
at it visually in skydb, everything seems to be in the right place.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700743002
 2014-11-03 21:30:40 -08:00
Elliott Sprehn
59454159a3 Remove shape-outside. 
Since we don't have floats this doesn't do anything now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/703563002
 2014-11-03 18:01:57 -08:00
Ojan Vafai
29ff7e21fd Remove more float machinery. 
Also removed the clear property since it's only purpose was
to clear floats.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700703002
 2014-11-03 17:00:27 -08:00
Ojan Vafai
ab8e1f98d5 Remove more support for floats from RenderBlockFlow. 
This doesn't change any behavior. Floats were already removed.
This is just removing effectively noop code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/692563004
 2014-11-03 12:40:09 -08:00
Ojan Vafai
ed0c01cdca Remove CSS Grid Layout and grid media queries. 
The two are unrelated, but it was easier to just grep for grid
and remove them all. Aside from the media query change, there
isn't any change in behavior since grid was behind a flag.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689853003
 2014-10-31 16:40:03 -07:00
Ojan Vafai
86ed666dc2 Get rid of isWritingModeRoot. 
This function always returns false now that we don't have writing modes.

TBR=esprehn@chromium.org

Remove flipForWritingMode.

It's a noop now that we don't have writing modes.

Review URL: https://codereview.chromium.org/688223002
 2014-10-29 19:53:05 -07:00
Ojan Vafai
13ffe46a43 Remove flipForWritingMode. 
It's a noop now that we don't have writing modes.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684393002
 2014-10-29 19:45:15 -07:00
Ojan Vafai
3b628f7d39 Delete a ton more dead vertical writing mode code. 
No change in behavior.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/684383002
 2014-10-29 19:08:09 -07:00
Ojan Vafai
afa0148e0b First pass at removing dead vertical writing mode code. 
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.

The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/688213002
 2014-10-29 19:06:59 -07:00
Ojan Vafai
959c404854 Remove all writing mode function arguments and remove writing mode from RenderStyle. 
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/683803006
 2014-10-29 12:18:30 -07:00
Ojan Vafai
42ea48b379 Remove a bunch of fixed position dead code. 
There is not change in behavior here. Just removing dead
code now that we no longer support position:fixed.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/686653002
 2014-10-28 09:34:19 -07:00
Adam Barth
969ccf4282 Remove compiler feature detection for = delete 
All supported compilers have this feature. Also remove unused macros for
OVERRIDE now that override are broadly supported.

R=esprehn@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/673403002
 2014-10-24 23:19:08 -07:00
Adam Barth
e8c9ecc556 Use override and final instead of OVERRIDE and FINAL 2014-10-24 15:15:13 -07:00
Adam Barth
ae72930937 Open the Sky 2014-10-23 11:17:19 -07:00