DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
389 Commits 882 Branches 1,069 Tags
Commit Graph

84 Commits

Author SHA1 Message Date
Matt Perry
465846c37d Sky: Move iframe geometry updates to FrameView::updateLayout instead of 
RenderView::invalidateTree.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/737523002
 2014-11-17 15:49:40 -05:00
Matt Perry
eee39ec5ad Sky: update the HTMLIFrameElement's geometry during paint invalidation rather 
than layout.

This ends up being much smoother and only triggers once per layout cycle.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/730653002
 2014-11-17 14:20:17 -05:00
Elliott Sprehn
42d362ff6b Remove tons of OILPAN. 
This removes ::trace, traceAfterDispatch and finalizeGarbageCollectedObject.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/723253004
 2014-11-13 16:56:13 -08:00
Matt Perry
037ca1b039 Rename RenderRemote to RenderIFrame. 
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/723143003
 2014-11-13 18:19:28 -05:00
Ojan Vafai
ec084dc47a Make paddingBoxRect less dumb. 
It was calling contentWidth, which did clientWidth - padding,
and then adding the padding back in.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/715053004
 2014-11-11 16:58:33 -08:00
Ojan Vafai
8510cca8ad Remove alt text from images. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/715963003
 2014-11-11 16:46:57 -08:00
Rafael Weinstein
f973fd339e Removed ScrollingCoordinator and a bunch of composited scrolling' 
BUG=
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/721473002
 2014-11-11 16:42:00 -08:00
Eric Seidel
66bad10810 Remove a bunch of OS(MACOSX) code 
This code is unused in sky.

Amazing how much code we had for dealing with old
versions of MSVC.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/709603006
 2014-11-11 15:33:38 -08:00
Ojan Vafai
0f803f8d3c Remove ResourceLoadPriorityOptimizer. 
We want to expose the ability to do this in the framework,
not bake it into the platform.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/710743006
 2014-11-11 14:53:02 -08:00
Elliott Sprehn
5f8f626d7d Fix margins and paddings on flex boxes. 
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/693353003
 2014-11-11 13:10:25 -08:00
Ojan Vafai
aadd9d43cf Remove some more assorted code from RenderBox. 
R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/691223003
 2014-11-11 10:16:03 -08:00
Matt Perry
d4ddbf836c Add a separate call to initialize the bounds for a sky <iframe> element. 
Also rename the methods to refer to "frames" not "views".

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/682413006
 2014-11-11 11:11:59 -05:00
Ojan Vafai
eec7ede796 Remove assorted dead code from RenderBox. 
-overrideContainingBlock sizes were only used by RenderGrid.
-percendicular containing blocks were a vertical writing mode feature.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/704413008
 2014-11-10 19:43:04 -08:00
Ojan Vafai
637d077ba2 Remove some straggling zoom-related code. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/714783003
 2014-11-10 19:17:32 -08:00
Ojan Vafai
5f945bf69f Remove some more zoom-related code. 
-Remove all references to zoomFactor.
-Remove zoomLevels.
-Remove unused m_zoom on StyleVisualData.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/714013002
 2014-11-10 18:08:46 -08:00
Ojan Vafai
275c5e291c Remove zoom() and effectiveZoom(). 
No change in behavior since we already removed the zoom setters.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/711203002
 2014-11-10 17:32:52 -08:00
Ojan Vafai
167513d855 Speculative fix for android compile. 
This broke with ccaf3a65fb

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/716673002
 2014-11-10 15:59:54 -08:00
Rafael Weinstein
c0ffe6fb23 remove updateTouchEventTargetRectsIfNeeded 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/713073003
 2014-11-10 13:08:21 -08:00
Ojan Vafai
e00f34ccf6 Initial step of removing CSS zoom related properties. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/710113003
 2014-11-10 13:07:29 -08:00
Ojan Vafai
9b654433ea Deduplicate part of RenderLayerScrollableArea/ScrollableArea. 
ScrollableArea only has one subclass now. Make all it's virtual
methods be pure virtual and delete any methods that
RenderLayerScrollableArea overrides.

Eventually we should probably merge the two classes into one,
but ScrollableArea is in platform and RenderLayerScrollableArea
is in core/rendering, so it's non-trivial figuring out what the
end result should look like. Hopefully it will become more clear
as we delete more of the scrolling code.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/711483003
 2014-11-07 20:06:09 -08:00
Elliott Sprehn
283fa5f78a Remove ContentData. 
This was to support CSS generated content.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/709213002
 2014-11-07 18:47:39 -08:00
Ojan Vafai
1fad59d33b Remove OverlayScrollbarSizeRelevancy. 
It doesn't do anything anymore.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/715453002
 2014-11-07 18:13:42 -08:00
Elliott Sprehn
d1e3759806 Remove more oilpan. 
I also unraveled lots of transitive deps from Handle.h

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/709203002
 2014-11-07 18:11:03 -08:00
Ojan Vafai
b44392daf4 Remove scrollbar width/height computations from layout. 
Scrollbars never take up layout space or participate in hit-testing.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/707233006
 2014-11-07 17:54:41 -08:00
Elliott Sprehn
e9073fbdc0 Remove PODIntervalTree and machinery. 
This was for floats and shapes which we removed.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/705373003
 2014-11-07 17:01:02 -08:00
Elliott Sprehn
d11b95703b Remove many attributes. 
This removes many attributes we don't want from HTMLAttributeNames.in
and the associated code.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/708233002
 2014-11-07 16:48:59 -08:00
Elliott Sprehn
70b80e3c64 Remove all the now dead Locale code. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/706403002
 2014-11-07 15:26:23 -08:00
Rafael Weinstein
f6b3a8cb02 Remove usesCompositedScrolling 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/712573003
 2014-11-07 13:59:11 -08:00
Matt Perry
694cabc454 Initial work on a new <view> element backed by a mojo::View. 
This CL introduces an HTMLViewElement which, when inserted into a document,
causes a mojo::View to be created and navigated to the provided URL. No
compositing is done, but the view manager handles the rendering (as I
understand it).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/708903002
 2014-11-07 14:34:07 -05:00
Ojan Vafai
2793661b5a Remove scroll corners and resizers. 
We never paint scroll corners. The only thing we need them
for is so that the vertical and horizontal scrollbars don't
overlap each other. So, that's the only place left that
still computes a scroll corner rect.

We don't support resizers. Remove the code for them as well
as the CSS resize property.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/689283003
 2014-11-07 09:46:16 -08:00
Rafael Weinstein
2c84a77f5e Remove sparsity tolerance check when considering squashing layers 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/709623002
 2014-11-06 18:45:23 -08:00
Rafael Weinstein
fa52a2cb76 Remove RenderObject::isVideo 
BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/709503003
 2014-11-06 17:59:08 -08:00
Ojan Vafai
94ca1025cb Remove -webkit-auto, -webkit-center, -webkit-left, -webkit-right. 
These are values for text-align that align blocks in addition to
inline content. You can get the same centering affect with margin:auto.
If we want this functionality, we should implement it with the
same alignment APIs that we use for flexbox.

Delete unused methods/arguments from RenderBlockFlow.

No change in behavior. Just deleting dead code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/708843002
 2014-11-06 11:55:49 -08:00
Ojan Vafai
aae0aab814 Delete unused methods/arguments from RenderBlockFlow. 
No change in behavior. Just deleting dead code.
Removes hit testing and paint phase for floats. They
bottomed out into empty functions.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/706953003
 2014-11-06 11:17:20 -08:00
Ojan Vafai
4ecaa91c6c Remove margin collapsing. 
Margin collapsing is a document-oriented feature. For applications
it just causes confusion and slowness.

margins.sky has failure output because offsetTop is returning the
wrong values. That's not new with this patch though. When I look
at it visually in skydb, everything seems to be in the right place.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700743002
 2014-11-03 21:30:40 -08:00
Elliott Sprehn
8c0a714beb Remove most of the media stack. 
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/689373003
 2014-11-03 20:21:19 -08:00
Elliott Sprehn
93af62d3e7 Remove HTMLVideoElement. 
This also removes some compositor related code, but there's not much of
it anyway so we can just add it back later when we do <iframe>.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/701663002
 2014-11-03 18:02:22 -08:00
Elliott Sprehn
59454159a3 Remove shape-outside. 
Since we don't have floats this doesn't do anything now.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/703563002
 2014-11-03 18:01:57 -08:00
Ojan Vafai
29ff7e21fd Remove more float machinery. 
Also removed the clear property since it's only purpose was
to clear floats.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/700703002
 2014-11-03 17:00:27 -08:00
Ojan Vafai
ab8e1f98d5 Remove more support for floats from RenderBlockFlow. 
This doesn't change any behavior. Floats were already removed.
This is just removing effectively noop code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/692563004
 2014-11-03 12:40:09 -08:00
Ojan Vafai
ed0c01cdca Remove CSS Grid Layout and grid media queries. 
The two are unrelated, but it was easier to just grep for grid
and remove them all. Aside from the media query change, there
isn't any change in behavior since grid was behind a flag.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/689853003
 2014-10-31 16:40:03 -07:00
Ojan Vafai
7d3feb3952 Remove line breaking to avoid window. 
Now that we don't have multi-column or pagination, this
is dead code. This also means we don't need to call
layoutBlockFlow in a loop.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/697713002
 2014-10-31 12:41:40 -07:00
Ojan Vafai
20dd8466c7 Remove border-fit. 
This just lets you size an element to it's content. We should
do this in a more generic way or let you override layout
and do it yourself.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/698613002
 2014-10-31 10:59:40 -07:00
Elliott Sprehn
c384b62ef1 Remove lots of dead virtuals from Element. 
Mostly form related things we don't need now.

R=ojan@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/694703002
 2014-10-30 23:03:02 -04:00
Ojan Vafai
80efab4680 Remove straggling bits of listboxes. 
Also remove some straggling bits of textareas along the way.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/653993007
 2014-10-30 16:46:17 -07:00
Ojan Vafai
31c4826beb Remove createsAnonymousWrapper. It's dead code. 
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/696493003
 2014-10-30 14:41:47 -07:00
Adam Barth
fc451b47eb Unfork Sky's trace events 
This CL remove the body of Sky's TraceEvent.h in favor of the version in base.
There's still some more of the system to unwind before we can remove all the
other boilerplate.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/691663002
 2014-10-30 09:39:46 -07:00
Ojan Vafai
0dfbf8aa38 Remove writing mode code from the linebox tree. 
Yo dawg, I heard you like ternaries.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/688233002
 2014-10-29 20:29:59 -07:00
Ojan Vafai
21bde7479d Remove final instances of WritingMode in Sky. 
After this patch, the only instance of WritingMode is in a comment.
No change in behavior.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/674073005
 2014-10-29 19:58:14 -07:00
Ojan Vafai
86ed666dc2 Get rid of isWritingModeRoot. 
This function always returns false now that we don't have writing modes.

TBR=esprehn@chromium.org

Remove flipForWritingMode.

It's a noop now that we don't have writing modes.

Review URL: https://codereview.chromium.org/688223002
 2014-10-29 19:53:05 -07:00