6564 Commits

Author SHA1 Message Date
Chris Yang
92ae45a714 make EmbeddedViewParams a unique ptr (flutter/engine#9640) 2019-07-02 13:27:12 -07:00
skia-flutter-autoroll
106c4f7450 Roll src/third_party/skia bd3d8d39b3e7..215ff3325230 (4 commits) (flutter/engine#9648)
https://skia.googlesource.com/skia.git
/%2Blog/bd3d8d39b3e7..215ff3325230

git log bd3d8d39b3e73398ab37e4a58bd9de6dd462008c..215ff3325230557a35dce26174b3294b570afbf9 --date=short --no-merges --format=%ad %ae %s
2019-07-02 csmartdalton@google.com Don't attempt mixed samples on "borrowed" render targets
2019-07-02 egdaniel@google.com Add ColorTypeInfo struct to FormatInfo in GrGLCaps.
2019-07-01 brianosman@google.com Reland "Test MSAA on Gen9 Intel GPUs"
2019-07-01 thestig@chromium.org Make SkFloatToDecimal() param name match declaration.

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jvanverth@google.com), and stop
the roller if necessary.
2019-07-02 14:05:15 -04:00
Chris Yang
102825d288 iOS PlatformView clip path (flutter/engine#9478) 2019-07-02 10:56:59 -07:00
skia-flutter-autoroll
01460faf4a Roll src/third_party/skia effee2065796..bd3d8d39b3e7 (1 commits) (flutter/engine#9647)
https://skia.googlesource.com/skia.git
/%2Blog/effee2065796..bd3d8d39b3e7

git log effee206579608fad40658e608db4aa13910f76f..bd3d8d39b3e73398ab37e4a58bd9de6dd462008c --date=short --no-merges --format=%ad %ae %s
2019-07-02 bsalomon@google.com Remove GrPixelConfig from GrColorSpaceInfo.

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jvanverth@google.com), and stop
the roller if necessary.
2019-07-02 10:25:53 -04:00
skia-flutter-autoroll
fc09a30e89 Roll src/third_party/skia 2ef826576819..effee2065796 (1 commits) (flutter/engine#9646)
https://skia.googlesource.com/skia.git
/%2Blog/2ef826576819..effee2065796

git log 2ef826576819224d94691d9167d16b951fe1dce7..effee206579608fad40658e608db4aa13910f76f --date=short --no-merges --format=%ad %ae %s
2019-07-01 csmartdalton@google.com Use mixed samples internally for default coverage AA

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jvanverth@google.com), and stop
the roller if necessary.
2019-07-02 05:38:27 -04:00
skia-flutter-autoroll
98849aec22 Roll src/third_party/skia f2c52efce52b..2ef826576819 (2 commits) (flutter/engine#9645)
https://skia.googlesource.com/skia.git
/%2Blog/f2c52efce52b..2ef826576819

git log f2c52efce52b2c395be877d25fe0f4999a35754a..2ef826576819224d94691d9167d16b951fe1dce7 --date=short --no-merges --format=%ad %ae %s
2019-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f116aa9c158b..5faff91af499 (3 commits)
2019-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src d38e9bb41f04..fb906fa57d41 (308 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jvanverth@google.com), and stop
the roller if necessary.
2019-07-02 01:58:39 -04:00
Matt Carroll
ff8b678e99 Android Embedding Refactor PR31: Integrate platform views with the new embedding and the plugin shim. (flutter/engine#9206) 2019-07-01 17:34:37 -07:00
Chinmay Garde
3b0adbc646 Fix warning about settings unavailable GN arg build_glfw_shell (flutter/engine#9642)
This is only available on Darwin & Linux host targets. On Android target builds, the logic amounted to says “Don’t build GLFW on Android targets”. Since GLFW on Android does not make sense and the target does not exist, GN was generating a warning.
2019-07-01 16:58:00 -07:00
skia-flutter-autoroll
9acd04b02f Roll src/third_party/skia 21a486d04ae0..9fb7fa537d93 (21 commits) (flutter/engine#9639)
https://skia.googlesource.com/skia.git
/%2Blog/21a486d04ae0..9fb7fa537d93

git log 21a486d04ae034a9f4dcdc874a59b41391174db8..9fb7fa537d938618991922bfffa627e442db67f0 --date=short --no-merges --format=%ad %ae %s
2019-07-01 brianosman@google.com Fix asserts in EllipticalRRectOp::Make to match logic of make_rrect_op
2019-07-01 jvanverth@google.com Re-enable Metal buffer suballocation with extra mutex guard.
2019-07-01 mtklein@google.com more --loops 1
2019-06-28 herb@google.com Use bulk metrics call in SkFont
2019-07-01 robertphillips@google.com Add GrProtected parameter to all createBackendTexture variants
2019-07-01 bsalomon@google.com Reenable GPU ReadPixels tests on ANGLE ES2
2019-07-01 bsalomon@google.com Make GrCaps::surfaceSupportsReadPixels return distinct values rather than flags.
2019-07-01 fmalita@chromium.org [skottie] Cleanup: split off layers into own CUs
2019-07-01 ethannicholas@google.com SkSL now respects layout(key) on all variables
2019-07-01 brianosman@google.com Revert "Test MSAA on Gen9 Intel GPUs"
2019-07-01 mtklein@google.com move SkVM interpreter back to SkVM.cpp
2019-07-01 bsalomon@google.com Pass alpha type to GrSurfaceContext::read/writePixels and remove flags.
2019-07-01 mtklein@google.com finish up arm64 ops
2019-06-28 brianosman@google.com Test MSAA on Gen9 Intel GPUs
2019-07-01 mtklein@google.com auto-tune nanobench in all builds
2019-07-01 robertphillips@google.com Add SkSurfaceCharacterization::isCompatible
2019-07-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 923c30fba116..f116aa9c158b (14 commits)
2019-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 40495290dceb..52edb176f1bd (7 commits)
2019-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9ef8c105f0dc..d38e9bb41f04 (418 commits)
2019-07-01 michaelludwig@google.com Revert "Switch drawTexture calls to use attemptQuadOptimization"

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jvanverth@google.com), and stop
the roller if necessary.
2019-07-01 18:51:32 -04:00
Chris Bracken
e2358a3ab6 Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9638)
This is a reland of #9364 with fixes for Fuchsia.

000cf0560c clean up type_literal_test
0f20911022 Improve type_literal_test
a108bef7fb [vm, bytecode] Interpreter support for newer recognized natives.
2a15d38759 Revert "[llvm] Add initial scaffolding"
13b470ac46 Parse error expectations in tests.
b71d2d9996 [llvm] Add initial scaffolding
5f2bcd9d6c [vm/bytecode] Reuse flow graph building for recognized methods

This includes a breaking change: https://dart-review.googlesource.com/c/sdk/+/105241
```
  Dart_CreateIsolate -> Dart_CreateIsolateGroup
  Dart_IsolateCreateCallback -> Dart_IsolateGroupCreateCallback
  Dart_IsolateCleanupCallback -> Dart_IsolateGroupShutdownCallback
  Dart_CreateIsolateFromKernel -> Dart_CreateIsolateGroupFromKernel
  Dart_CurrentIsolateData -> Dart_CurrentIsolateGroupData
  Dart_IsolateData -> Dart_IsolateGroupData
  Dart_GetNativeIsolateData -> Dart_GetNativeIsolateGroupData
  Dart_InitializeParams.create -> Dart_InitializeParams.create_group
  Dart_InitializeParams.cleanup -> Dart_InitializeParams.shutdown_group
  Dart_InitializeParams.shutdown -> Dart_InitializeParams.shutdown_isolate
```
2019-07-01 15:47:49 -07:00
Matt Carroll
1596cc6c63 Fixes a plugin overwrite bug in the plugin shim system. (flutter/engine#9589) 2019-07-01 15:26:22 -07:00
gaaclarke
3e1981ede2 Added Doxyfile. (flutter/engine#9632)
Added Doxyfile.
2019-07-01 14:32:38 -07:00
Chris Bracken
f78c2ef4e3 Revert "Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (#9634)" (flutter/engine#9637)
This broke the Fuchsia build.

This reverts commit aa7bc7923cb2a7811d49c3de8ce5fbe5bed96779.
2019-07-01 14:28:35 -07:00
Chris Bracken
aa7bc7923c Roll Dart to 67ab3be10d35d994641da167cc806f20a7ffa679 (flutter/engine#9634)
000cf0560c clean up type_literal_test
0f20911022 Improve type_literal_test
a108bef7fb [vm, bytecode] Interpreter support for newer recognized natives.
2a15d38759 Revert "[llvm] Add initial scaffolding"
13b470ac46 Parse error expectations in tests.
b71d2d9996 [llvm] Add initial scaffolding
5f2bcd9d6c [vm/bytecode] Reuse flow graph building for recognized methods

This includes a breaking change: https://dart-review.googlesource.com/c/sdk/+/105241
```
  Dart_CreateIsolate -> Dart_CreateIsolateGroup
  Dart_IsolateCreateCallback -> Dart_IsolateGroupCreateCallback
  Dart_IsolateCleanupCallback -> Dart_IsolateGroupShutdownCallback
  Dart_CreateIsolateFromKernel -> Dart_CreateIsolateGroupFromKernel
  Dart_CurrentIsolateData -> Dart_CurrentIsolateGroupData
  Dart_IsolateData -> Dart_IsolateGroupData
  Dart_GetNativeIsolateData -> Dart_GetNativeIsolateGroupData
  Dart_InitializeParams.create -> Dart_InitializeParams.create_group
  Dart_InitializeParams.cleanup -> Dart_InitializeParams.shutdown_group
  Dart_InitializeParams.shutdown -> Dart_InitializeParams.shutdown_isolate
```
2019-07-01 12:55:57 -07:00
skia-flutter-autoroll
71469e504c Roll fuchsia/sdk/core/linux-amd64 from Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C to I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C (flutter/engine#9625)
Roll fuchsia/sdk/core/linux-amd64 from Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C to I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-30 17:57:51 -04:00
Tamir Duberstein
d648992aa4 [all] add fuchsia.{net.NameLookup,posix.socket.Provider} (flutter/engine#9546)
These services will replace fuchsia.net.SocketProvider.

Note that dart_{aot,jit}_product_runner.cmx were invalid before this
change. I'm not sure how that was allowed to happen.
2019-06-30 13:07:41 -07:00
Jason Simmons
a55cd21da3 Fix a race in the embedder accessibility unit test (flutter/engine#9585) 2019-06-30 12:50:44 -07:00
skia-flutter-autoroll
9fad73b247 Roll fuchsia/sdk/core/linux-amd64 from xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC to Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C (flutter/engine#9623)
Roll fuchsia/sdk/core/linux-amd64 from xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC to Efv1uHDvhLYgT8mvQmdAiJv7HiLix2L_kDRkK6P9ER4C


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-30 14:19:01 -04:00
skia-flutter-autoroll
b2339a611f Roll fuchsia/sdk/core/linux-amd64 from O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC to xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC (flutter/engine#9622)
Roll fuchsia/sdk/core/linux-amd64 from O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC to xtoj1ola0unTQOetly-V77CgpT6g8L1JUKWDqS8SuAQC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-30 09:12:13 -04:00
skia-flutter-autoroll
c304af22c0 Roll fuchsia/sdk/core/linux-amd64 from gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC to O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC (flutter/engine#9620)
Roll fuchsia/sdk/core/linux-amd64 from gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC to O1niQGtIRghvjuMMCmxevRA1Y6seUn6onOao6Wii9hQC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-30 05:34:34 -04:00
skia-flutter-autoroll
e3a4cc58ad Roll src/third_party/skia 161f47dfbf6a..21a486d04ae0 (2 commits) (flutter/engine#9619)
https://skia.googlesource.com/skia.git
/%2Blog/161f47dfbf6a..21a486d04ae0

git log 161f47dfbf6ae5641263d8c95a421d2e82ae4a36..21a486d04ae034a9f4dcdc874a59b41391174db8 --date=short --no-merges --format=%ad %ae %s
2019-06-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-06-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jvanverth@google.com), and stop
the roller if necessary.
2019-06-30 04:53:32 -04:00
Chinmay Garde
d90e42e020 Fix uninitialized variables and put tests in flutter namespace. (flutter/engine#9613)
Also enabled the tests previously disabled due to flakiness caused by these
uninitialized variables.

Fixes https://github.com/flutter/flutter/issues/35338
2019-06-29 21:05:42 -07:00
skia-flutter-autoroll
cb45f737fa Roll fuchsia/sdk/core/linux-amd64 from ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC to gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC (flutter/engine#9612)
Roll fuchsia/sdk/core/linux-amd64 from ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC to gMVpYn1cxQ0LeU-TSryUCg2o3rNcf7JWvlOqY6G00MYC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-29 23:28:07 -04:00
Chinmay Garde
0d8f0955d5 Wire up custom event loop interop for the GLFW embedder. (flutter/engine#9089) 2019-06-29 19:35:22 -07:00
skia-flutter-autoroll
bd7d13bfe4 Roll fuchsia/sdk/core/linux-amd64 from xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC to ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC (flutter/engine#9610)
Roll fuchsia/sdk/core/linux-amd64 from xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC to ur0ah3sh2atct83EqYX28SjG3fKt-7Driu48GbpdxmMC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-29 19:50:22 -04:00
Chinmay Garde
83b4d5a0d5 Document various classes in //flutter/shell/common. (flutter/engine#9591) 2019-06-29 14:08:02 -07:00
skia-flutter-autoroll
7c7ac0fd24 Roll fuchsia/sdk/core/linux-amd64 from XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC to xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC (flutter/engine#9607)
Roll fuchsia/sdk/core/linux-amd64 from XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC to xmxDtsnD0sfj7wxUaiMMhUwh72prBvMcYHY07lgTotcC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-29 16:12:38 -04:00
Chris Yang
ef172e2250 disable mysterious failing tests (flutter/engine#9608) 2019-06-29 12:38:49 -07:00
skia-flutter-autoroll
989389d6f4 Roll fuchsia/sdk/core/linux-amd64 from jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC to XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC (flutter/engine#9605)
Roll fuchsia/sdk/core/linux-amd64 from jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC to XRYatTY5OvCnQ-5rGC8AnYltKa68CBxmnEK8QO0fpvQC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-29 10:26:26 -04:00
skia-flutter-autoroll
5526356a9d Roll fuchsia/sdk/core/linux-amd64 from Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC to jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC (flutter/engine#9601)
Roll fuchsia/sdk/core/linux-amd64 from Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC to jXpdljb7CHe8PEpUGGYqGvx6vFar6QRUh6HmpxMoS9sC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-29 06:25:54 -04:00
Chris Bracken
682f2e53e1 [trace clients] Remove fuchsia.tracelink.Registry (flutter/engine#9593)
... replaced by fuchsia.tracing.provider.Registry.

PT-127

Change-Id: I8e1243e28292a2442c1ceb3b685a79979bd0bd42

This is a followup to 76599141095069c12160b0c079d1dddf9809552c.
Ported from the Topaz tree.
2019-06-29 00:58:15 -07:00
skia-flutter-autoroll
9ac31e011e Roll fuchsia/sdk/core/linux-amd64 from w7VVL0dntMhd75uB9Yby88ecIJkWGhBsr8mqCMNKurcC to Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC (flutter/engine#9599)
Roll fuchsia/sdk/core/linux-amd64 from w7VVL0dntMhd75uB9Yby88ecIJkWGhBsr8mqCMNKurcC to Y3kUPtfq2frI60zx7VssO-WG733jtODCmnESyz0UGdEC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-29 02:53:49 -04:00
skia-flutter-autoroll
c7f502f2a6 Roll src/third_party/skia 0d8c1aefd127..161f47dfbf6a (1 commits) (flutter/engine#9598)
https://skia.googlesource.com/skia.git
/%2Blog/0d8c1aefd127..161f47dfbf6a

git log 0d8c1aefd127fe4a4e7e28aba433f5ee8a2d6faa..161f47dfbf6ae5641263d8c95a421d2e82ae4a36 --date=short --no-merges --format=%ad %ae %s
2019-06-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (djsollen@google.com), and stop
the roller if necessary.
2019-06-29 02:18:57 -04:00
skia-flutter-autoroll
ba6d5a60c9 Roll fuchsia/sdk/core/linux-amd64 from d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC to w7VVL0dntMhd75uB9Yby88ecIJkWGhBsr8mqCMNKurcC (flutter/engine#9596)
Roll fuchsia/sdk/core/linux-amd64 from d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC to w7VVL0dntMhd75uB9Yby88ecIJkWGhBsr8mqCMNKurcC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-28 23:11:49 -04:00
skia-flutter-autoroll
81b5f4715a Roll src/third_party/skia 1ddee025229a..0d8c1aefd127 (1 commits) (flutter/engine#9594)
https://skia.googlesource.com/skia.git
/%2Blog/1ddee025229a..0d8c1aefd127

git log 1ddee025229a18fe6c6d1a35e6d0b70d50689846..0d8c1aefd127fe4a4e7e28aba433f5ee8a2d6faa --date=short --no-merges --format=%ad %ae %s
2019-06-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (djsollen@google.com), and stop
the roller if necessary.
2019-06-28 22:20:45 -04:00
Chris Bracken
ab721c3db7 [crash] switch to async crash analysis
with the synchronous call, this actually blocks the Flutter component
from serving its out/directory and prevents the Inspect synchronous
discovery

DX-1568 #done #comment

TESTED=`fx shell run fuchsia-pkg://fuchsia.com/crasher_dart#meta/crasher_dart.cmx` (report id 0b59643af026bc37)
TESTED=`fx shell sessionctl add_mod fuchsia-pkg://fuchsia.com/crasher_flutter#meta/crasher_flutter.cmx` then clicked on "Th

Change-Id: I8b0abd1034dba66cd7bb1d6768322cab36ed453b

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
c58d26f718 [dart/flutter_runner] Copy package.resolved_url for TRACE_DURATION
Ensure that the string data backing package.resolved_url is not modified
or moved by making a copy to pass as the argument value for
TRACE_DURATION.

PT-169 #comment

Change-Id: I1ef6ab9b1ecf350e82134d1d616a841611ac19c6

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
9dc7ebcdf4 [meta] add fuchsia.{net.NameLookup,posix.socket.Provider}
These protocols will replace fuchsia.net.SocketProvider.

Change-Id: I1425aa8b32c82e68f6176f5ffd8d8a9149b52de6

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
b3c911c9fc [flutter] Re-enable unhandled error reporting
This re-enables unhandled Dart error handling in Flutter applications,
which was removed in a76b958.

The error handling as originally landed was unsafe. Specifically, in the
case where the unhandled error handler was triggered during shutdown,
there was a race condition which could cause a crash in the following
scenario:
1. Runner::OnApplicationTerminate() is triggered, which posts a task to
   the application's platform thread will free the Application instance
   and terminate the platform thread.
2. Before that task is serviced, the unhandled error handler is called
   (by hooks.dart -> window.cc -> ui_dart_state.cc) on the UI thread.
3. The kill task is serviced and the Application dtor and Thread::Quit()
   are called, terminating the platform thread.
4. The unhandled error handler attempts to post a task to the platform
   thread, whose thread was killed in step 3. This triggers a crash.

Fixing this requires a mechanism for the message loop to know that the
associated thread has been terminated out from under it.

This patch adds mitigation for this scenario, but remains
non-threadsafe/racy. We pass the unhandled error handler a weak pointer
to the Application and check it before posting a task to the platform
thread. This has two issues:
1. WeakPtr isn't threadsafe, and assumes that all operations occur on a
   single thread. We're checking its value (which is mutated on the
   platform thread) on the UI thread without synchronization.
2. Even with a guarantee that the WeakPtr state were synchronized,
   there's a window between when we check the weak pointer and when we
   post to the platform thread in which application shutdown and thread
   destruction may occur.

This unsafe mitigation is being landed in order to unblock a high
priority bug (FL-256) on a short schedule, and a proper refactoring will
be required to make this properly threadsafe.

Change-Id: If60d1d3ca5799d82597f8a3acc4ddd3871058972

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
d4ee1f4c3b [flutter_runner] Rename outgoing 'public' to 'svc'.
This is the topaz counterpart to
https://fuchsia-review.googlesource.com/c/fuchsia/+/277254.

This is a backwards-incompatible ABI change that will be landed together
with that CL. All clients have been migrated to be compatible with the
new ABI.

Change-Id: I07bb460ce3c6971eb671874db1f90e8c4906e656

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
7659914109 [trace clients] Remove fuchsia.tracelink.Registry
... replaced by fuchsia.tracing.provider.Registry.

PT-127

Change-Id: I8e1243e28292a2442c1ceb3b685a79979bd0bd42

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
e369245671 [flutter_runner] use external image create info
DX-939 #progress
MA-394 #progress

This informs the vulkan driver that we're creating an image
that will be backed by external memory. The driver driver can
decide to use different memory requirements based on the if
memory for the image can be exported or not.

No change in behavior. Existing tests (modular_tests,
scenic_tests, etc.) are sufficient and regressions will be
prevented by running these tests on aemu.

Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#
Change-Id: I489318c2e31f752f76c80a81245e203861d44d94

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
03d65cc0c5 [trace clients] Add fuchsia.tracing.provider.Registry to cmx files
... being renamed from fuchsia.tracelink.Register.
fuchsia.tracelink.Registry will be removed after change lands in fuchsia.

PT-127

Change-Id: Ie876228cf9d1e6fb052877e65b47918fdd0b9696

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
Chris Bracken
51327088f6 [trace clients] Replace trace-provider with trace-provider-with-fdio
PT-63

Change-Id: I9acd5aeba5f82e6d58ec324f0f64bf109a413410

Ported from Topaz tree.
2019-06-28 17:40:00 -07:00
skia-flutter-autoroll
4fcc58153a Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (flutter/engine#9586)
https://skia.googlesource.com/skia.git
/%2Blog/e4c88bb1f848..1ddee025229a

git log e4c88bb1f8488782f4072cf7bf0068ead49821e0..1ddee025229a18fe6c6d1a35e6d0b70d50689846 --date=short --no-merges --format=%ad %ae %s
2019-06-28 herb@google.com Remove preparePath from the SkStrikeInterface
2019-06-27 egdaniel@google.com Move GL caps textureable and fbocolorattachment flags to FormatInfo.
2019-06-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-06-27 michaelludwig@google.com Switch drawTexture calls to use attemptQuadOptimization
2019-06-28 jvanverth@google.com Disable some code to handle Metal TSAN errors.
2019-06-27 michaelludwig@google.com Remove old texture op factories
2019-06-27 brianosman@google.com Reland "DM: Add a per-sink MemoryCache to all GPU sinks"

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (djsollen@google.com), and stop
the roller if necessary.
2019-06-28 18:38:09 -04:00
skia-flutter-autoroll
37ca5c079f Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (flutter/engine#9583)
Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2019-06-28 18:14:41 -04:00
Amir Hardon
77a2f1c89b Revert "Avoid a full screen overlay within virtual displays (#9343)" (flutter/engine#9581)
This reverts commit 2b66f64511df7de1404802aab5ccbdbb8587244e.
2019-06-28 13:43:23 -07:00
Yegor
34839e477a Adds API for retaining intermediate engine layers (flutter/engine#9461)
Add new optional named oldLayer arguments to all push* methods of the SceneBuilder class.

When not null oldLayer signals to the engine that the intent is to update a layer rendered in a previous frame. The engine may optionally use that signal to reuse the resources allocated for that layer in the previous frame. For example, on the Web we can reuse existing DOM nodes and some of their properties and move fewer nodes around the tree.

The return type of each push method has been tightened up. Instead of having all methods return the same EngineLayer type, each method has its own unique layer type, e.g. OffsetEngineLayer. oldLayer parameters match the returned type. This prevents the framework (and other developers using dart:ui directly) from accidentally supplying an engine layer of the wrong type.
2019-06-28 12:56:03 -07:00
gaaclarke
579cc2d83f Fixed memory leak by way of accidental retain on implicit self (flutter/engine#9329)
Fixed memory leak by way of accidental retain on implicit self.
2019-06-28 10:22:51 -07:00
skia-flutter-autoroll
5092a40b5d Roll src/third_party/skia afd2c10c989c..e4c88bb1f848 (1 commits) (flutter/engine#9577)
https://skia.googlesource.com/skia.git
/%2Blog/afd2c10c989c..e4c88bb1f848

git log afd2c10c989ce85cb9e7f8e05cb0df0ae50a1cfd..e4c88bb1f8488782f4072cf7bf0068ead49821e0 --date=short --no-merges --format=%ad %ae %s
2019-06-27 brianosman@google.com Prevent caching path-rendering programs

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (djsollen@google.com), and stop
the roller if necessary.
2019-06-28 13:01:41 -04:00