12790 Commits

Author SHA1 Message Date
skia-flutter-autoroll
8e91c23ed5 Roll Skia from 21c8ad62cd82 to 55aaefe687c7 (2 revisions) (flutter/engine#24779) 2021-03-04 06:34:01 -08:00
skia-flutter-autoroll
670e919b4d Roll Skia from 4db57264955f to 21c8ad62cd82 (2 revisions) (flutter/engine#24774) 2021-03-03 22:39:01 -08:00
Chris Bracken
a15f44a9e2 Revert "[web] Fix painting of last placeholder in paragraph (#24716)" (flutter/engine#24773)
This broke the Linux Web Tests target in the framework tests.

Example failure:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tests/11335/overview

Failure log:
```
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: WidgetSpan calculate correct intrinsic heights [E]
  Test failed. See exception logs above.
  The test description was: WidgetSpan calculate correct intrinsic heights

01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
Assertion failed: file:///b/s/w/ir/k/flutter/packages/flutter/lib/src/rendering/box.dart:2237:16
!RenderObject.debugCheckingIntrinsics
is not true

The relevant error-causing widget was:
  Text file:///b/s/w/ir/k/flutter/packages/flutter_test/lib/src/binding.dart:567:12

When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49  throw_
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3    assertFailed
../packages/flutter/src/rendering/layer.dart.js 4485:79                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4551:26                          debugAssertDoesMeetConstraints
../packages/flutter/src/rendering/layer.dart.js 4380:14                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4382:26                          set size
../packages/flutter/src/rendering/paragraph.dart.js 786:17                       performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/shifted_box.dart.js 451:36                     performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/layer.dart.js 4875:58                          performLayout
../packages/flutter/src/rendering/layer.dart.js 3279:14                          [_layoutWithoutResize]
../packages/flutter/src/rendering/layer.dart.js 6876:107                         flushLayout
../packages/flutter_test/src/_matchers_web.dart.js 3990:30                       drawFrame
../packages/flutter/src/rendering/layer.dart.js 6128:12                          [_handlePersistentFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 764:9                          [_invokeFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 732:37                         handleDrawFrame
../packages/flutter_test/src/_matchers_web.dart.js 3954:12                       scheduleWarmUpFrame
../packages/flutter/src/widgets/widget_span.dart.js 52123:11                     <fn>
../packages/flutter/src/widgets/widget_span.dart.js 52125:7                      runApp
../packages/flutter_test/src/_matchers_web.dart.js 3647:18                       _runTestBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54            runBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5            _async
../packages/flutter_test/src/_matchers_web.dart.js 3644:20                       [_runTestBody]
../dart-sdk/lib/async/zone.dart 1386:13                                          _rootRunBinary
../dart-sdk/lib/async/zone.dart 1272:19                                          runBinary
../packages/flutter_test/src/_matchers_web.dart.js 3636:16                       [_runTest]
../packages/flutter_test/src/_matchers_web.dart.js 4072:44                       <fn>
../packages/fake_async/fake_async.dart.js 141:96                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/clock/src/stopwatch.dart.js 364:18                                   withClock
../packages/fake_async/fake_async.dart.js 141:55                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/fake_async/fake_async.dart.js 141:20                                 run
../packages/flutter_test/src/_matchers_web.dart.js 4067:17                       runTest
../packages/flutter_test/src/_matchers_web.dart.js 5312:24                       <fn>
../packages/test_api/src/frontend/async_matcher.dart.js 862:17                   <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50            <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 179:98              <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 179:80              <fn>
../dart-sdk/lib/async/zone.dart 1362:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1265:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 155:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 707:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 736:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 406:9                                     <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 170:71              <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1162:7                                           runGuarded
../dart-sdk/lib/async/zone.dart 1202:23                                          callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11                              _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5                               _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15           <fn>

The following RenderObject was being processed when the exception was fired: RenderParagraph#e6e8f relayoutBoundary=up1 NEEDS-PAINT:
  creator: RichText ← Text ← Center ← Container-[#9a020] ← [root]
  parentData: offset=Offset(0.0, 0.0) (can use size)
  constraints: BoxConstraints(0.0<=w<=800.0, 0.0<=h<=600.0)
  size: Size(640.0, 40.0)
  textAlign: start
  textDirection: ltr
  softWrap: wrapping at box width
  overflow: clip
  maxLines: unlimited
This RenderObject had the following child:
    text: TextSpan
```

This reverts commit bcba78b6829849ffe7c4638bd69b3ceeb7631666.
2021-03-03 22:27:07 -08:00
skia-flutter-autoroll
220589533f Roll Skia from e4ef35caa1bc to 4db57264955f (1 revision) (flutter/engine#24772) 2021-03-03 21:14:01 -08:00
Chris Bracken
5a99033ec9 Added dependency on CppWinRT for UWP builds (flutter/engine#24770)
CppWinRT is a tool that generates standard C++17 header-file libraries
for Windows Runtime (WinRT) APIs. A more detailed introduction to
C++/WinRT can be found in the Microsoft documentation at
https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/.

The source code is available under an MIT license, from
https://github.com/microsoft/cppwinrt.

Bug: https://github.com/flutter/flutter/issues/70205
2021-03-03 20:51:13 -08:00
skia-flutter-autoroll
4b8cb89a08 Roll Fuchsia Linux SDK from _0kewDFPJ... to _vRi_XkB7... (flutter/engine#24771) 2021-03-03 19:14:01 -08:00
chunhtai
935384301f Enables semantics when voice control is turned on (flutter/engine#24640) 2021-03-03 17:24:02 -08:00
skia-flutter-autoroll
2f060559e5 Roll Skia from 46d9bb255df4 to e4ef35caa1bc (9 revisions) (flutter/engine#24769) 2021-03-03 16:49:01 -08:00
Chris Bracken
e77d5ec898 Move CIPD package creation tools under tools/cipd (flutter/engine#24766)
This moves tooling related to the creation of the Android embedding
bundle CIPD package under tools/cipd. Having a single location for CIPD
package creation tooling avoids spreading these around the tree and aids
in discovery.

This does not change the path within the CIPD package repo, nor does it
change the path to which we download it via gclient as specified in the
DEPS file.

This will be followed by a patch to add a new Windows CIPD package
necessary for UWP builds.
2021-03-03 15:21:28 -08:00
skia-flutter-autoroll
8e4f16f6ec Roll Skia from f0de96f7b82a to 46d9bb255df4 (2 revisions) (flutter/engine#24762) 2021-03-03 12:34:01 -08:00
skia-flutter-autoroll
be220fded6 Roll Skia from a1e30a3a280a to f0de96f7b82a (7 revisions) (flutter/engine#24760) 2021-03-03 11:14:01 -08:00
skia-flutter-autoroll
7c96772c83 Roll Skia from acf26501fb5a to a1e30a3a280a (5 revisions) (flutter/engine#24753) 2021-03-03 08:24:01 -08:00
skia-flutter-autoroll
3ac8b777f9 Roll Skia from e80e169ba4c1 to acf26501fb5a (4 revisions) (flutter/engine#24752) 2021-03-03 06:59:01 -08:00
skia-flutter-autoroll
0bbc63ef60 Roll Fuchsia Linux SDK from YhRvbuj9c... to _0kewDFPJ... (flutter/engine#24750) 2021-03-03 05:54:01 -08:00
James Clarke
9beda3c62b Fix UWP build for UpdateCursorRect rename (flutter/engine#24697) 2021-03-02 19:34:53 -08:00
skia-flutter-autoroll
f53077b6c6 Roll Skia from 12e760e958a7 to e80e169ba4c1 (1 revision) (flutter/engine#24740) 2021-03-02 16:59:01 -08:00
skia-flutter-autoroll
9f265df27c Roll Fuchsia Linux SDK from tJbtmEE4Q... to YhRvbuj9c... (flutter/engine#24739) 2021-03-02 16:34:02 -08:00
skia-flutter-autoroll
75c5e97430 Roll Skia from 786d42c6dac4 to 12e760e958a7 (10 revisions) (flutter/engine#24738) 2021-03-02 15:34:02 -08:00
Emmanuel Garcia
e0a4751112 Fix memory leak and bug in the RunsOnCreationTaskRunner check (flutter/engine#24690) 2021-03-02 12:39:02 -08:00
skia-flutter-autoroll
57e7470908 Roll Skia from 036ba86489d7 to 786d42c6dac4 (1 revision) (flutter/engine#24733) 2021-03-02 12:34:01 -08:00
skia-flutter-autoroll
cde8f87dc9 Roll Skia from d863ae52d4bb to 036ba86489d7 (3 revisions) (flutter/engine#24732) 2021-03-02 10:49:01 -08:00
Mouad Debbar
7e1da11b95 [web] Fix pointer events for Wacom pen (flutter/engine#24719) 2021-03-02 10:47:41 -08:00
Mouad Debbar
bcba78b682 [web] Fix painting of last placeholder in paragraph (flutter/engine#24716) 2021-03-02 10:30:21 -08:00
Chris Bracken
ee19dbeb1b Win32: Support Korean input (flutter/engine#24713)
This change fixes a bug in Korean input whereby WM_IME_COMPOSITION
messages of type GCS_RESULTSTR were assumed to end composing mode.

This change breaks out an additional handler for "commit composing text"
events. In Japanese/Chinese IMEs, these events typically occur on
selection of a candidate from the candidates list and are mostly
synonymous with an "end composing" event.

In Korean text input, there is no candidates list, but rather a
character is built up as keypresses are handled, and committed as soon
as the character is unambiguously complete; in other words, when either
space/return is pressed or a keypress is received that cannot be
interpreted as a modification of the character being composed and
therefore must be the first keystroke of a new character. In these
cases, we want to commit the previous character without ending the
composition.

To illustrate with an example:
1. User focuses on a text field and sets input mode to Hangul.
2. User presses 'ㄱ'. Composing region contains 'ㄱ'.
3. User presses 'ㅏ'. Composing region is updated to '가'.
4. User presses 'ㄴ'. Composing region is updated to '간'.
5. User presses 'ㅏ'. Result string '가' is committed. Composing region is
   updated to '나'.
6. User presses 'ㄷ'. Composing string is updated to '낟'.
7. User presses 'ㅏ'. Result string '나' is committed. Composing region is
   updated to '다'.
8. User presses space or enter. Result string '다' is committed.
   Composing is ended.

On a non-Korean QWERTY keyboard the following key mappings serve to
perform the above input:
* r -> ㄱ
* k -> ㅏ
* s -> ㄴ
* e -> ㄷ

To support the above, we break out a separate "commit composing" method
and commit on WM_IME_COMPOSITION events of type GCS_RESULTSTR and end
composing on WM_IME_ENDCOMPOSITION events. Further, we eliminate the
workaround in the GCS_RESULTSTR handler for continued composition on
Chinese/Japanese IMEs now that we're no longer ending composition on
that event type.
2021-03-02 10:14:27 -08:00
Chris Bracken
263d0d1734 Add RAII wrapper for Win32 IMM context (flutter/engine#24699)
Wraps Win32 IME context management in an RAII container that automates
management via ImmGetContext() and ImmReleaseContext().
2021-03-02 10:01:40 -08:00
skia-flutter-autoroll
9928fca616 Roll Skia from 232b4ce8886b to d863ae52d4bb (4 revisions) (flutter/engine#24731) 2021-03-02 09:24:01 -08:00
skia-flutter-autoroll
341a27c937 Roll Skia from 0676317b1f7f to 232b4ce8886b (1 revision) (flutter/engine#24729)
https://skia.googlesource.com/skia.git/+log/0676317b1f7f..232b4ce8886b

2021-03-02 johnstiles@google.com Allow ForLoopIsValidForES2 to run before creating a ForStatement.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2021-03-02 08:01:08 -08:00
skia-flutter-autoroll
50bb98dd7f Roll Skia from e32ace76ec8d to 0676317b1f7f (1 revision) (flutter/engine#24728) 2021-03-02 06:10:01 -08:00
Matej Knopp
9a425c81af Switch to correct OpenGL context before deleting framebuffers. (flutter/engine#24679)
https://github.com/flutter/flutter/issues/76920
2021-03-02 04:57:44 -08:00
skia-flutter-autoroll
0f454d3335 Roll Fuchsia Linux SDK from 50gZrG82q... to tJbtmEE4Q... (flutter/engine#24726) 2021-03-02 03:05:00 -08:00
skia-flutter-autoroll
ae4bf43308 Roll Skia from d29e500ece41 to e32ace76ec8d (1 revision) (flutter/engine#24724) 2021-03-01 23:40:02 -08:00
skia-flutter-autoroll
e8991c9ef1 Roll Skia from 67808983c677 to d29e500ece41 (1 revision) (flutter/engine#24723) 2021-03-01 22:15:01 -08:00
skia-flutter-autoroll
e62f143282 Roll Skia from 9ca065e2fdb5 to 67808983c677 (6 revisions) (flutter/engine#24720) 2021-03-01 17:35:01 -08:00
Yegor
ba5ca8be29 Revert "remove _getRRect: fixes assertion error (#24688)" (flutter/engine#24718)
This reverts commit 3a5c7654ab16d35c26e43f49eba437a537361585.

The commit broke golden tests.
2021-03-01 15:08:56 -08:00
LongCatIsLooong
deec3a0d07 Reland "TextStyle level leadingDistribution (#24025)" reverted in #24665 (flutter/engine#24668) 2021-03-01 14:55:03 -08:00
skia-flutter-autoroll
2430d59887 Roll Skia from 135500d33dc7 to 9ca065e2fdb5 (6 revisions) (flutter/engine#24714) 2021-03-01 14:26:01 -08:00
skia-flutter-autoroll
07439b0855 Roll Fuchsia Linux SDK from 1jbCxKA9Y... to 50gZrG82q... (flutter/engine#24709) 2021-03-01 13:46:01 -08:00
Yegor
3a5c7654ab remove _getRRect: fixes assertion error (flutter/engine#24688) 2021-03-01 12:12:50 -08:00
skia-flutter-autoroll
e052a1b163 Roll Skia from 9b510a31561f to 135500d33dc7 (2 revisions) (flutter/engine#24710) 2021-03-01 10:26:02 -08:00
skia-flutter-autoroll
d8e83e78ff Roll Skia from 0b750f2ef534 to 9b510a31561f (4 revisions) (flutter/engine#24708) 2021-03-01 09:01:01 -08:00
skia-flutter-autoroll
92942a8417 Roll Skia from 104e20f5b2b3 to 0b750f2ef534 (1 revision) (flutter/engine#24706) 2021-03-01 07:36:02 -08:00
skia-flutter-autoroll
99690cae06 Roll Skia from 5fa369787b21 to 104e20f5b2b3 (1 revision) (flutter/engine#24704) 2021-03-01 01:36:02 -08:00
skia-flutter-autoroll
544f853ff0 Roll Skia from 1f33ec568b3f to 5fa369787b21 (1 revision) (flutter/engine#24703) 2021-03-01 00:11:01 -08:00
skia-flutter-autoroll
dc5281f53b Roll Skia from 56a1f06db241 to 1f33ec568b3f (4 revisions) (flutter/engine#24702) 2021-02-28 22:26:01 -08:00
skia-flutter-autoroll
c02334953b Roll Fuchsia Linux SDK from RTXXU6CwW... to 1jbCxKA9Y... (flutter/engine#24700) 2021-02-28 19:56:01 -08:00
skia-flutter-autoroll
f414fb5174 Roll Skia from 59b389a407de to 56a1f06db241 (1 revision) (flutter/engine#24693) 2021-02-28 08:51:03 -08:00
skia-flutter-autoroll
5358c1d0df Roll Fuchsia Linux SDK from oJPqi5jbV... to RTXXU6CwW... (flutter/engine#24691) 2021-02-28 06:36:00 -08:00
Chris Bracken
ead87f659d Consistent naming for Win32 emebedder (flutter/engine#24686)
Under shell/platform/windows, we have a mix of two naming schemes:
   * foo_bar_win32.h
   * win32_foo_bar.h

This renames files and identifiers to consistently use a Win32
suffix-based approach.
2021-02-28 01:13:02 -08:00
skia-flutter-autoroll
1ec8477938 Roll Skia from 202420e0147b to 59b389a407de (1 revision) (flutter/engine#24689) 2021-02-28 00:01:01 -08:00
skia-flutter-autoroll
87a4d68d52 Roll Fuchsia Linux SDK from oOI7Iq5ER... to oJPqi5jbV... (flutter/engine#24685) 2021-02-27 17:16:01 -08:00