9881 Commits

Author SHA1 Message Date
liyuqian
8ca7c4cbbd
Simplify toImage future handling (#30876)
Thanks to cbracken@'s suggestion on another Google-internal change.
2019-04-10 19:19:30 -07:00
champeauxr
a5dd074b0d Fixed Table flex column layout error #30437 (#30470)
RenderTable._computeColumnWidths() had a logic error that caused flex columns to be collapsed to their minimum widths in certain situations dependent on the layout width constraint and the number of flex columns.
2019-04-10 18:53:27 -07:00
Dan Field
d2790bd2bb
Check for invalid elevations (#30215)
* Check for invalid elevation usage in the layer tree
2019-04-10 14:57:46 -07:00
Sam Rawlins
83ddd98849 Fix additional @mustCallSuper indirect overrides and mixins (#30667) 2019-04-10 14:54:51 -07:00
Todd Volkert
499004779b
Revert "Add Form.onSaved (#30643)" (#30793)
This reverts commit 949023b27686fb80a0047157490d6c4c61995cef.
2019-04-10 14:49:10 -07:00
Tong Mu
f34c2ef0a3
Revert "Remove pressure customization from some pointer events (#30414)" (#30873)
This reverts commit a821136997b600f0cd39cbcd3d993c54a15f4686.
2019-04-10 14:14:12 -07:00
Tong Mu
a821136997
Remove pressure customization from some pointer events (#30414)
* Remove pressure from PointerHoverEvent ctor
2019-04-10 12:40:33 -07:00
Jonah Williams
316d44989a
warn on uncomitted changes (#30235) 2019-04-10 12:24:53 -07:00
Jonah Williams
f66ee3e470
Add semanticsLabel parameter to TextSpan (#30837) 2019-04-10 12:24:01 -07:00
Justin McCandless
ed91a3be49
Fix cursor outside of input width (#30525)
* Disallow cursor from appearing beyond the width of the input.

* Test that verifies the cursor can't exceed the width of the input

* Use constant from editable.dart to explain 1 pixel difference in test

* Fix failing test that tested the case of overflowing spaces
2019-04-10 10:35:03 -05:00
xster
5a6c140d0d
Cupertino localization step 7: modularize material specific things out of gen_localizations.dart (#29822) 2019-04-10 01:24:58 -07:00
Shi-Hao Hong
b3bb5cd6b0
Fix StatefulWidget and StatelessWidget Sample Documentation (#30814) 2019-04-09 19:32:00 -07:00
liyuqian
eb30745faf
Print warning if flutter drive is run in debug (#30747)
## Description

Print actionable warnings if `flutter drive` (where most of our performance benchmarks come from) is run in debug mode and it tries to gather benchmarks using `traceAction`.

## Related Issues

https://github.com/flutter/flutter/issues/30625

## Tests

I added the following tests:
* drive_perf_debug_warning devicelab test
2019-04-09 18:55:42 -07:00
xster
5a4eaabaf1
Cupertino localization step 11: add more translation clarifications in the instructions (#30527) 2019-04-09 17:47:44 -07:00
Shi-Hao Hong
c7d7ba1c2b
Update ExpansionPanelList Samples with Scaffold template (#30805) 2019-04-09 14:01:47 -07:00
Shi-Hao Hong
1835aac558
Update ListTile sample snippets to use Material Scaffold Template (#30800) 2019-04-09 13:46:31 -07:00
ShaLi Shaltiel
a018264131 Updated package template .gitignore file (#27034) 2019-04-09 10:12:32 -07:00
Shi-Hao Hong
9f9c5c29ec
Embedded images and variations to ListTile sample code (#30537)
Also includes counter-examples for list items that differ from ListTile.
2019-04-09 10:10:57 -07:00
Michael Thomsen
811f1ad98f
Forward missing pub commands (#30115) 2019-04-09 17:03:09 +02:00
Jonah Williams
03817a995a
fix cast NPE in invokeListMethod and invokeMapMathod (#30760) 2019-04-09 07:22:25 -07:00
Jonah Williams
ed49122aa3
register gradle wrapper as universal artifact (#30755) 2019-04-08 20:22:34 -07:00
xster
e2b6a3a7a8
Cupertino localization step 6: add a GlobalCupertinoLocalizations base class with date time formatting (#29767) 2019-04-08 16:56:58 -07:00
Jonah Williams
9baffb97ca
Reland: Ensure that flutter run/drive/test/update_packages only downloads required artifacts (#30254) 2019-04-08 13:49:09 -07:00
Jonah Williams
99b4459944
Allow disabling experimental commands, devices on stable branch (#30153) 2019-04-08 13:48:21 -07:00
Lau Ching Jun
294d7ea0cf
Mark ios-deploy version 2.0.0 as bad (#30578)
Mark ios-deploy version 2.0.0 as bad.

ios-deploy before version 1.9.4 declares itself as v2.0.0
https://github.com/ios-control/ios-deploy/commits/master/src/ios-deploy/version.h
2019-04-08 12:37:43 -07:00
Todd Volkert
0b8403b61c
Add const Border.uniform() (#30640)
`Border.all()` is a factory constructor and thus not const
constructible. This change adds a `const Border.uniform()`
constructor and makes `Border.all()` delegate to it. This allows
callers to more likely be able to make their widget tree const
constructible.
2019-04-07 21:29:32 -07:00
Todd Volkert
949023b276
Add Form.onSaved (#30643)
When submitting data to a server, callers need a callback that will
get invoked after all the individual form fields are saved. If they
have a button that submits the form, they could just do this logic
in the click handler for the button (save the form, then submit to
the server), but if they have more ways than one to submit the form
(i.e. hitting enter while in a text form field), then it becomes
more convoluted and calls for a unified callback that will get
notified when the form is submitted.
2019-04-07 21:02:09 -07:00
Todd Volkert
cb78274c3f
Make FormField._validate() return void (#30644)
None of its callers were using the return value, so no need to
invoke the `isValid` getter unnecessarily.
2019-04-07 21:01:33 -07:00
Todd Volkert
535523dbe0
Add docs to FormFieldValidator (#30645)
To describe what its return value represents
2019-04-07 21:00:53 -07:00
Dan Field
d42db56b52
Add sample for ValueListenableBuilder (#30626)
* Add sample for ValueListenableBuilder
2019-04-06 20:14:41 -07:00
Hans Muller
ab06d033ca
Fixed a typo in the Expanded API doc (#30563) 2019-04-05 17:40:38 -07:00
LongCatIsLooong
e153883d43
Provide a default IconTheme in CupertinoTheme (#30521)
-* Inserted an `IconTheme` widget under `CupertinoTheme` to provide a default icon color when using `CupertinoTheme`.
* Changed `CupertinoTheme` to a `StatelessWidget`, to match the implementation of `Theme`
* Changed the nesting order of `Theme`'s sub widgets, to let `Theme.iconTheme` take precedence, so that `Theme`'s behavior is kept as is.
2019-04-05 15:57:29 -07:00
Tim Sneath
529189791c
Replace flutter.io with flutter.dev (#30562) 2019-04-05 11:39:30 -07:00
chunhtai
2b7e98973a
Fix issue 21640: Assertion Error : '_listenerAttached': is not true (#30513) 2019-04-05 11:31:40 -07:00
Alexandre Ardhuin
32f1b810ae shorter nullable list duplications (#30305) 2019-04-05 10:23:35 -07:00
Tong Mu
1ae32facfe
Correctly synthesise event buttons (#30535)
* Correctly synthesise buttons, and add tests
2019-04-05 09:53:40 -07:00
Justin McCandless
566ac3ce2f
Trackpad mode crash fix (#30475)
Fixes a crash that happened when attempting to select text in trackpad mode on iOS.
2019-04-05 09:35:26 -07:00
Wai Hon Law
e8d968ed8d Update repair command for Arch Linux (#30428)
The current repair command for Arch Linux is no longer valid because
`lib32-libstdc++5` had been removed from multilib.

Actually, `lib32-gcc-libs` from core just work.
Also see https://github.com/flutter/flutter/issues/25035
2019-04-05 07:55:29 -07:00
Hans Muller
73687a9771
Correct MaterialButton disabledColor (#30531) 2019-04-04 18:05:55 -07:00
xster
d15b3b1c8b
Cupertino localization step 5: add french arb as translated example (#29708) 2019-04-04 15:14:46 -07:00
Tong Mu
13101c1a86
Touching the screen adds 0x01 to buttons (#30457)
* Add constants `kPrimaryButton`, `kTouchContact` and `kStylusContact`
* PointerDownEvent and PointerMoveEvent will always set the 0x01 bit on buttons
2019-04-04 15:11:29 -07:00
Morgan
74ee010b7b Fix MaterialApp's _navigatorObserver when only builder used (#29413)
Fix MaterialApp's _navigatorObserver so it doesn't cause WidgetApp's assertion to fail when using custom navigator, fixes #18904
2019-04-04 15:02:11 -07:00
Kate Lovett
05d1a10592
Embedding the diagram for BottomNavigationBar. (#30468) 2019-04-04 14:17:14 -07:00
Tong Mu
423cf223d9
Fix edge cases of PointerEventConverter (#29998)
* Fix: ui.PointerChange.remove might contain position change, but we used to expand it into a Cancel and Remove, neither of which allows position change. A Hover event is added, and a test is updated accordingly.
* Fixed the issue where a PointerMoveEvent and a PointerCancelEvent do not receive the correct pressure.
* Refactor the calculation of delta into deltaTo.
2019-04-04 10:27:07 -07:00
Shi-Hao Hong
1e50518cdc
Add ExpansionPanelList and ExpansionPanelList.radio Examples (#30343) 2019-04-04 07:12:56 -07:00
Nikita
88d50f78f3 Implement compute for async function (#16265) (#30275) 2019-04-04 00:17:26 -07:00
Kate Lovett
0c01a557df Embedding new raised button diagram. (#30398) 2019-04-04 00:14:40 -07:00
Kate Lovett
31086faa28 Updating sample code for BottomNavigationBar class for diagram. (#30453) 2019-04-04 00:14:12 -07:00
Michael Goderbauer
77bbd28c62
Random trivial fixes in the animation packages (#30276) 2019-04-04 00:13:34 -07:00
Michael Goderbauer
3c8dabefe7
Be more explicit when ValueNotifier notifies (#30461) 2019-04-04 00:13:07 -07:00