DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,489 Commits 882 Branches 1,069 Tags
Commit Graph

23939 Commits

Author SHA1 Message Date
skia-flutter-autoroll
8a87d088b7 Roll Fuchsia Linux SDK from wWzXsy6kx1sp8Km34... to ZhY53WD7bFJSA3xoO... (flutter/engine#45919) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-16 04:12:10 +00:00
Matan Lurey
5e0a53255f Add a single MacOS+Vulkan+SwiftShader CI test (flutter/engine#45918) 
Closes https://github.com/flutter/flutter/issues/133708.

Will track why it's (a) blank and (b) times out in async presentation in https://github.com/flutter/flutter/issues/134852.
 2023-09-16 03:55:06 +00:00
skia-flutter-autoroll
64f6d56862 Roll Skia from 696ac041ea82 to a1f8fb54299a (1 revision) (flutter/engine#45917) 
https://skia.googlesource.com/skia.git/+log/696ac041ea82..a1f8fb54299a

2023-09-16 johnstiles@google.com Fix Vulkan depth format flags for VK_FORMAT_D32_SFLOAT_S8_UINT.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-16 03:46:49 +00:00
skia-flutter-autoroll
2081fa7754 Roll Skia from 4851cd29e1dd to 696ac041ea82 (1 revision) (flutter/engine#45915) 
https://skia.googlesource.com/skia.git/+log/4851cd29e1dd..696ac041ea82

2023-09-16 michaelludwig@google.com [graphite] Add TRACE_EVENTS throughout

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-16 03:02:07 +00:00
Jonah Williams
83f48da122 Revert "[Impeller] construct text frames on UI thread." (flutter/engine#45910) 
Reverts flutter/engine#45418

Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia.

Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down.
 2023-09-16 01:22:13 +00:00
skia-flutter-autoroll
080410ad70 Roll Skia from 7c179932cc06 to c19cc483c619 (1 revision) (flutter/engine#45911) 
https://skia.googlesource.com/skia.git/+log/7c179932cc06..c19cc483c619

2023-09-16 michaelludwig@google.com Update SetTraceValue() to use a template, remove bitpun union

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-16 01:20:11 +00:00
skia-flutter-autoroll
39c160cc30 Roll Skia from 0057898979a1 to 917fd16e6f26 (1 revision) (flutter/engine#45906) 
https://skia.googlesource.com/skia.git/+log/0057898979a1..917fd16e6f26

2023-09-15 johnstiles@google.com Add device-name to Caps when test-utils is active.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 22:56:27 +00:00
Matan Lurey
8ec1692298 Do not convert an open path to a closed rect. (flutter/engine#45903) 
Fixes https://github.com/flutter/flutter/issues/134816.

---

Confirmed this only happens when utilizing `DisplayListBuilder`.
Consider:

```cc
TEST_P(DisplayListTest, CanDrawAnOpenPath) {
  flutter::DisplayListBuilder builder;
  flutter::DlPaint paint;

  paint.setColor(flutter::DlColor::kRed());
  paint.setDrawStyle(flutter::DlDrawStyle::kStroke);
  paint.setStrokeWidth(10);

  builder.Translate(300, 300);

  // Move to (50, 50) and draw lines from:
  // 1. (50, height)
  // 2. (width, height)
  // 3. (width, 50)
  SkPath path;
  path.moveTo(50, 50);
  path.lineTo(50, 100);
  path.lineTo(100, 100);
  path.lineTo(100, 50);
  builder.DrawPath(path, paint);

  ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
}
```

![Screenshot 2023-09-15 at 2 06 53
PM](https://github.com/flutter/flutter/assets/168174/3a3868e1-f1d1-4e29-affa-4bd32d26ccdc)

---

The bug is in `dl_dispatcher.cc`:

```cc
// |flutter::DlOpReceiver|
void DlDispatcher::drawPath(const SkPath& path) {
  SkRect rect;
  SkRRect rrect;
  SkRect oval;

  if (path.isRect(&rect)) {
    canvas_.DrawRect(skia_conversions::ToRect(rect), paint_);
  } else if (path.isRRect(&rrect) && rrect.isSimple()) {
    canvas_.DrawRRect(skia_conversions::ToRect(rrect.rect()),
                      rrect.getSimpleRadii().fX, paint_);
  } else if (path.isOval(&oval) && oval.width() == oval.height()) {
    canvas_.DrawCircle(skia_conversions::ToPoint(oval.center()),
                       oval.width() * 0.5, paint_);
  } else {
    canvas_.DrawPath(skia_conversions::ToPath(path), paint_);
  }
}
```

Note the documentation for `isRect`:

```cc
/** Returns true if SkPath is equivalent to SkRect when filled.
    If false: rect, isClosed, and direction are unchanged.
    If true: rect, isClosed, and direction are written to if not nullptr.

    rect may be smaller than the SkPath bounds. SkPath bounds may include kMove_Verb points
    that do not alter the area drawn by the returned rect.

    @param rect       storage for bounds of SkRect; may be nullptr
    @param isClosed   storage set to true if SkPath is closed; may be nullptr
    @param direction  storage set to SkRect direction; may be nullptr
    @return           true if SkPath contains SkRect

    example: https://fiddle.skia.org/c/@Path_isRect
*/
bool isRect(SkRect* rect, bool* isClosed = nullptr, SkPathDirection* direction = nullptr) const;
```

... the `isClosed` is critical, without checking that we're doing an
incorrect optimization.

I'll send a fix and test.
 2023-09-15 15:29:13 -07:00
Matan Lurey
9859e989e1 [Impeller] Test FenceWaiterVK and fix termination bugs (flutter/engine#45870) 
Fixes https://github.com/flutter/flutter/issues/134751, and @jonahwilliams suspects it could be related to a number of other flaky/texture leak scenarios (https://github.com/flutter/flutter/issues/133506#issuecomment-1720275749) that only happen sometimes (i.e. on CI but not real devices), i.e. stuff like:

```txt
--- Vulkan Debug Report  ----------------------------------------
|                Severity: Error
|                    Type: { Validation }
|                 ID Name: VUID-vkDestroyBuffer-buffer-00922
|               ID Number: -464217071
|       Queue Breadcrumbs: [NONE]
|  CMD Buffer Breadcrumbs: [NONE]
|         Related Objects: Device [94498356231456] [ImpellerDevice]
|                 Trigger: Validation Error: [ VUID-vkDestroyBuffer-buffer-00922 ] Object 0: handle = 0x55f21cf47d20, name = ImpellerDevice, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xe4549c11 | Cannot call vkDestroyBuffer on VkBuffer 0xbb00000000bb[] that is currently in use by a command buffer. The Vulkan spec states: All submitted commands that refer to buffer, either directly or via a VkBufferView, must have completed execution (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkDestroyBuffer-buffer-00922)
-----------------------------------------------------------------
```

---

~~This PR will look a bit like a mess until the last 2 PRs merge in, but locally it appears to fix fence races/segfaults that I was seeing on CI, including on Linux with validations enabled. We can test it further tomorrow.~~ EDIT: Updated.
 2023-09-15 22:08:05 +00:00
skia-flutter-autoroll
1eff2d604e Roll Dart SDK from a5ee0055cf20 to e9452310189b (1 revision) (flutter/engine#45902) 
https://dart.googlesource.com/sdk.git/+log/a5ee0055cf20..e9452310189b

2023-09-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-169.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 21:36:23 +00:00
skia-flutter-autoroll
2ec372d9be Roll Skia from 4f26f22daa4b to 7f88bda24f7f (5 revisions) (flutter/engine#45901) 
https://skia.googlesource.com/skia.git/+log/4f26f22daa4b..7f88bda24f7f

2023-09-15 robertphillips@google.com [graphite] Make Blend helper take an addBlendToKey parameter
2023-09-15 egdaniel@google.com [Graphite] Fix setting depth load/store ops in Vulkan.
2023-09-15 michaelludwig@google.com [skif] Guard case when dst range starts and ends before src range
2023-09-15 jvanverth@google.com [graphite] Add rasterization and uploading to SoftwarePathAtlas.
2023-09-15 jvanverth@google.com [graphite] Move testing ContextOptions to private struct

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 21:30:21 +00:00
Jonah Williams
93cea4d0af [Impeller] dont cache failed render target allocations. (flutter/engine#45895) 
Otherwise we'll null de-ref when trying to create a texture with the same descriptor later on.
 2023-09-15 20:15:23 +00:00
skia-flutter-autoroll
6926f92358 Roll Skia from c79441fc8016 to 4f26f22daa4b (1 revision) (flutter/engine#45893) 
https://skia.googlesource.com/skia.git/+log/c79441fc8016..4f26f22daa4b

2023-09-15 brianosman@google.com Return transparent black when sampling null shader children

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 19:39:10 +00:00
skia-flutter-autoroll
99adc1cc30 Roll Skia from 58c509b1a24a to c79441fc8016 (1 revision) (flutter/engine#45892) 
https://skia.googlesource.com/skia.git/+log/58c509b1a24a..c79441fc8016

2023-09-15 michaelludwig@google.com Delete unused SkSpecialSurface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 18:26:14 +00:00
skia-flutter-autoroll
b52af18839 Roll Skia from fffef1047640 to 58c509b1a24a (2 revisions) (flutter/engine#45888) 
https://skia.googlesource.com/skia.git/+log/fffef1047640..58c509b1a24a

2023-09-15 robertphillips@google.com [graphite] Add Compose helper
2023-09-15 kjlubick@google.com Add SkSerialProcs and SkDeserialProcs to Slug serialization

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 17:40:05 +00:00
skia-flutter-autoroll
201cd45a73 Roll Skia from de56f293eb41 to fffef1047640 (2 revisions) (flutter/engine#45885) 
https://skia.googlesource.com/skia.git/+log/de56f293eb41..fffef1047640

2023-09-15 egdaniel@google.com [Graphite] Fix Graphite Vk depth stencil.
2023-09-15 fmalita@chromium.org [mesh2d demo] Patch controls

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 16:50:06 +00:00
Zachary Anderson
191e0417ef Adds a --quiet flag to run_tests.py (flutter/engine#45880) 
This PR changes run_tests.py to use the python logging library to report
results instead of direct prints or writes to stdout/stderr. This change
simplifies adding a `--quiet` flag that causes the script to only
generate output if a log is emitted at WARNING or above.

Overall this is a bit of progress toward landing something like
https://github.com/flutter/engine/pull/45595
 2023-09-15 09:31:55 -07:00
Reid Baker
a43cae2515 Update AGP and Kotlin for scenario app (flutter/engine#45549) 
flutter/flutter/#134220

Command required to update lock files required not using the custom task and required matching the version of gradle in ci and passing a custom version of java. 
`~/.gradle/wrapper/dists/gradle-7.5.1-bin/7jzzequgds1hbszbhq3npc5ng/gradle-7.5.1/bin/gradle -D=org.gradle.java.home=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home  app:dependencies --write-locks` for app:dependencies and dependencies.
 2023-09-15 15:54:04 +00:00
Kevin Lubick
7da278b05b Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881) 
Skia's Graphite and Ganesh backend coalesced two enums regarding mipmaps
into one and deprecated the public Ganesh version. This migrates Flutter
to use the preferred type.

No functional changes expected. See also
https://skia-review.googlesource.com/c/skia/+/753567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-15 11:48:20 -04:00
gaaclarke
30d0cf868d [Impeller] Introduce mock vulkan context builder (flutter/engine#45834) 
This allows us to have better control over the mock context and allows us to test situations like having the validations available, versus not available.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-15 15:42:03 +00:00
skia-flutter-autoroll
56b19ab7ec Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 15:22:18 +00:00
skia-flutter-autoroll
184c377ce5 Roll Skia from 3492fc567816 to de56f293eb41 (1 revision) (flutter/engine#45878) 
https://skia.googlesource.com/skia.git/+log/3492fc567816..de56f293eb41

2023-09-15 johnstiles@google.com Optimize 'expr ? 1 : 0' into 'cast(expr)'.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 14:34:27 +00:00
skia-flutter-autoroll
fa05b7cc00 Roll Skia from c0cabb0f93c9 to 4f7aafd0c853 (1 revision) (flutter/engine#45868) 
https://skia.googlesource.com/skia.git/+log/c0cabb0f93c9..4f7aafd0c853

2023-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 5f6a13cae14e to 18fd0925a396 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 05:27:12 +00:00
skia-flutter-autoroll
63536433cf Roll Fuchsia Linux SDK from MzLcTzBiWJ7o3Q2_Z... to ES0r-mYplPOBYHvUQ... (flutter/engine#45865) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 02:37:26 +00:00
skia-flutter-autoroll
5147e816ba Roll Dart SDK from 7e4d9f4d8e52 to c0a505f9d1dd (1 revision) (flutter/engine#45864) 
https://dart.googlesource.com/sdk.git/+log/7e4d9f4d8e52..c0a505f9d1dd

2023-09-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-166.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-15 01:37:38 +00:00
skia-flutter-autoroll
24a609ad03 Roll Skia from 8c9e378c4902 to 37ea783440ea (1 revision) (flutter/engine#45859) 
https://skia.googlesource.com/skia.git/+log/8c9e378c4902..37ea783440ea

2023-09-14 kjlubick@google.com Remove some unused path effects

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 23:28:12 +00:00
XuanTung95
f95e3baebc Reduce unnecessary Dart_TimelineGetMicros call (flutter/engine#45637) 
Minor changes that reduce unnecessary Dart_TimelineGetMicros calls.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-14 22:46:56 +00:00
skia-flutter-autoroll
f6891113bc Roll Skia from 9b7c116ed6c2 to 8c9e378c4902 (3 revisions) (flutter/engine#45858) 
https://skia.googlesource.com/skia.git/+log/9b7c116ed6c2..8c9e378c4902

2023-09-14 brianosman@google.com Clamp alpha after doing CPU color filtering
2023-09-14 johnstiles@google.com Add support for mesh programs to sksl-minify.
2023-09-14 jamesgk@google.com [graphite] Be more defensive in attempting dst samples

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 22:41:23 +00:00
Victoria Ashworth
855ec2065c Set tests to run on macOS 12 (flutter/engine#45855) 
We recently upgraded a bot in the try pool to macOS 13 and I noticed a couple of tests have leaked through to it and we're not ready for tests to run on macOS 13 yet.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-14 22:19:57 +00:00
skia-flutter-autoroll
5567466854 Roll Dart SDK from d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854) 
https://dart.googlesource.com/sdk.git/+log/d25e8d682c8f..7e4d9f4d8e52

2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-165.0.dev
2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-164.0.dev
2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 21:40:13 +00:00
Martin Kustermann
c6be35d532 Remove @pragma('vm:entry-point') annotations on members that aren't accessed from C++ (flutter/engine#45697) 
The `@pragma('vm:entry-point')` annotation serves as an annotation
telling our AOT compiler that the member is needed and cannot be
tree-shaken because it may be accessed from the outside (i.e. C++).

There are seemingly entry-point annotations on members that aren't
actually used from C++.
=> We remove the annotation from those members in this CL.
 2023-09-14 23:33:29 +02:00
skia-flutter-autoroll
26262a8b47 Roll Skia from 6bc9f5886ddf to 9b7c116ed6c2 (1 revision) (flutter/engine#45853) 
https://skia.googlesource.com/skia.git/+log/6bc9f5886ddf..9b7c116ed6c2

2023-09-14 michaelludwig@google.com [skif] FilterResult::draw() operates on SkDevice instead of SkSpecialSurface+SkCanvas

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 21:32:11 +00:00
keyonghan
e7ac9ff327 Switch linux_android_debug_engine from goma to reclient (flutter/engine#45345) 
Part of https://github.com/flutter/flutter/issues/132701.
 2023-09-14 21:30:00 +00:00
keyonghan
cbb1d3dc41 Switch goma to reclient fro standalone targets (flutter/engine#45804) 
Part of https://github.com/flutter/flutter/issues/132701.
 2023-09-14 21:28:02 +00:00
yaakovschectman
52ce8f488d Handle external window's WM_CLOSE in lifecycle manager (flutter/engine#45840) 
Handle the close messages from non-Flutter windows similarly to how we
handle our own, for graceful app exit purposes.

https://github.com/flutter/flutter/issues/131497

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-14 17:07:14 -04:00
Michael Goderbauer
efc22ee283 Enable private field promotion (flutter/engine#45722) 
New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2.

Part of https://github.com/flutter/flutter/issues/134476.
 2023-09-14 21:02:03 +00:00
Brandon DeRosier
563857b00e [Impeller] Add Entity::RenderingMode enum. (flutter/engine#45845) 
Resolves https://github.com/flutter/flutter/issues/134681.

For the various places where we track if a rendered entity is a subpass or not. After landing this, I think the next winning move is to make this an Entity field and remove the `SetRenderingMode` junk from the filter graph. That refactor is a bit more risky, so I plan to do that separately.
 2023-09-14 20:56:33 +00:00
Brandon DeRosier
5b5853f4dc [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848) 
Noticed we had a residual unguarded import of scene_contents.h while investigating https://github.com/flutter/flutter/issues/134745.
 2023-09-14 20:21:05 +00:00
Brandon DeRosier
8b53654118 [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838) 
Part of https://github.com/flutter/flutter/issues/134681.
 2023-09-14 20:01:17 +00:00
skia-flutter-autoroll
ff8e6854db Roll Skia from 9bdf01416042 to 0f003d5748bc (4 revisions) (flutter/engine#45841) 
https://skia.googlesource.com/skia.git/+log/9bdf01416042..0f003d5748bc

2023-09-14 michaelludwig@google.com Reland "Reland "Add epsilon to texture effect clamping at pixel centers""
2023-09-14 cmumford@google.com [infra] Stop building legacy Skottie Docker image
2023-09-14 robertphillips@google.com [graphite] Expand usage of Blend helper
2023-09-14 lovisolo@google.com [bazel] Add "bazel clean" step to all Bazel task drivers.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 19:26:19 +00:00
Jackson Gardner
67ce410bd6 Declare the js context as nullable in skwasm surface callback (flutter/engine#45810) 
Declaring this as non-nullable causes breakage with an incoming JS interop change from the SDK. Marking this as nullable fixes the issue.

This doesn't actually change any behavior. The breakages were in `test/ui/image_golden_test.dart`. No changes to the test are required (they did catch the issue when the dart roll happened).
 2023-09-14 18:50:48 +00:00
Matan Lurey
6211b68cff [Impeller] Release a texture during Playground teardown (flutter/engine#45832) 
Closes https://github.com/flutter/flutter/issues/134678.

Partial work towards https://github.com/flutter/flutter/issues/133708, https://github.com/flutter/flutter/issues/133506.

This gets us closer to being able to run `aiks_unittests` with validations enabled, removing a VMA allocation error:

## Before

```txt
Note: Google Test filter = Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Play/AiksTest
[ RUN      ] Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[INFO:capabilities_vk.cc(50)] Vulkan validations are enabled.
[FATAL:third_party/vulkan_memory_allocator/include/vk_mem_alloc.h(6179)] Check failed: (false && "Unfreed dedicated allocations found!"). Vulkan Memory Allocator Failure!
```

## After

```txt
Note: Google Test filter = Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Play/AiksTest
[ RUN      ] Play/AiksTest.ReleasesTextureOnTeardown/Vulkan
[INFO:capabilities_vk.cc(50)] Vulkan validations are enabled.
[       OK ] Play/AiksTest.ReleasesTextureOnTeardown/Vulkan (1192 ms)
[----------] 1 test from Play/AiksTest (1192 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (1192 ms total)
[  PASSED  ] 1 test.
```

---

Added a test that will catch regressions.
 2023-09-14 18:39:01 +00:00
Matan Lurey
0f4cb0b4c8 Make fml::ScopedCleanupClosure std::move-able and add unit tests. (flutter/engine#45772) 
Fixes https://github.com/flutter/flutter/issues/134568.
 2023-09-14 18:37:49 +00:00
skia-flutter-autoroll
53bcc75ea6 Manual roll Dart SDK from 1ee7ef8bbc65 to d25e8d682c8f (22 revisions) (flutter/engine#45836) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/1ee7ef8bbc65..d25e8d682c8f

2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-162.0.dev
2023-09-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-161.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-160.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-159.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-158.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-157.0.dev
2023-09-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-156.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-155.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-154.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-153.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-152.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-151.0.dev
2023-09-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-150.0.dev
2023-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-149.0.dev
2023-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-148.0.dev
2023-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-147.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-146.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-145.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-144.0.dev
2023-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-143.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-142.0.dev
2023-09-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-141.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 18:36:05 +00:00
godofredoc
c9ce9f7fd5 Update webdriver imports. (flutter/engine#45816) 
This is to be able to update the webdriver dependency.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-14 18:26:42 +00:00
skia-flutter-autoroll
0941b57131 Roll Skia from 54253f58533d to 87025d1e162c (1 revision) (flutter/engine#45833) 
https://skia.googlesource.com/skia.git/+log/54253f58533d..87025d1e162c

2023-09-14 robertphillips@google.com [graphite] Add Blend method to assist paint key creation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 17:31:43 +00:00
Brandon DeRosier
9294f00715 [Impeller] Incorporate filters in subpass coverage. (flutter/engine#45778) 
I adjusted the size of the matrix filtered circle in both SaveLayer
Matrix filter test variants (post-filter and backdrop filter) to move
the transformed circle outside the coverage area that would be computed
if subpass filters aren't being accounted for. Further, we need to avoid
intersecting with the pass coverage hint when the transformation being
applied by the paint's filter graph causes the Entity's space basis to
deviate from the parent pass basis. We're still able to apply it for
simple translations, though.
 2023-09-14 10:07:19 -07:00
skia-flutter-autoroll
75caba9561 Roll Skia from 91d5a781ebaf to 54253f58533d (2 revisions) (flutter/engine#45829) 
https://skia.googlesource.com/skia.git/+log/91d5a781ebaf..54253f58533d

2023-09-14 johnstiles@google.com Add gcloud login step to ASAN documentation.
2023-09-14 johnstiles@google.com Initialize 'fIsWrappedOnly' member variable.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 16:12:06 +00:00
skia-flutter-autoroll
d9123e52f1 Roll Skia from 08fb9768d1b8 to 91d5a781ebaf (3 revisions) (flutter/engine#45828) 
https://skia.googlesource.com/skia.git/+log/08fb9768d1b8..91d5a781ebaf

2023-09-14 brianosman@google.com Fully remove legacy SK_VULKAN code from GrBackendSurface.h
2023-09-14 jvanverth@google.com [graphite] Rename AtlasShapeRenderStep to CoverageMaskRenderStep
2023-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from b4c3435d2fba to 27be2a276618 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 15:26:22 +00:00
skia-flutter-autoroll
850034b037 Roll Skia from 45ba26fae9cd to 08fb9768d1b8 (2 revisions) (flutter/engine#45825) 
https://skia.googlesource.com/skia.git/+log/45ba26fae9cd..08fb9768d1b8

2023-09-14 egdaniel@google.com Reland "Add option for clients to set default gpu staging buffer size."
2023-09-14 johnstiles@google.com Clarify build documentation.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-14 14:43:19 +00:00