2117 Commits

Author SHA1 Message Date
Kate Lovett
dd7d4b9521
Fix docs and error messages for scroll directions + sample code (#123819)
Fix docs and error messages for scroll directions + sample code
2023-03-31 23:46:59 +00:00
nt4f04uNd
3a7daaba78
Fix ListWheelScrollView gestures and paint coordinates in tests (#121342)
Fix ListWheelScrollView gestures and paint coordinates in tests
2023-03-30 08:15:26 +00:00
Kate Lovett
659ba386f6
Fix SliverGridRegularTileLayout.computeMaxScrollOffset for 0 children (#123348)
Fix SliverGridRegularTileLayout.computeMaxScrollOffset for 0 children
2023-03-29 00:13:50 +00:00
Greg Price
48111197ac
Fix out-of-bounds and reversed TextBox queries in computing caret metrics (#122480)
Fix out-of-bounds and reversed TextBox queries in computing caret metrics
2023-03-28 03:16:20 +00:00
Loïc Sharma
8f62e34267
[Focus] Add run key command to dump the focus tree (#123473)
[Focus] Add run key command to dump the focus tree
2023-03-28 00:33:39 +00:00
Bernardo Ferrari
100cf21e27
Prefer enum over class. (#123312)
Convert `AndroidSemanticsAction` to enum.
2023-03-23 19:46:37 +00:00
Michael Goderbauer
31798757e7
replace some ._() constructors with class modifiers (#122765) 2023-03-23 12:29:18 -07:00
Jacob MacDonald
b212e7b32b
implement Iterator and Comparable instead of extending them (#123282)
implement Iterator and Comparable instead of extending them
2023-03-23 17:10:31 +00:00
Michael Goderbauer
fda9ecfef7
Remove 1745 decorative breaks (#123259)
Remove 1745 decorative breaks
2023-03-22 21:12:22 +00:00
Ian Hickson
3fe5740153
Documentation improvements (#122787)
Documentation improvements
2023-03-22 18:58:57 +00:00
Kate Lovett
484c22682b
Fix error message for unbounded viewports (#123035)
Fix error message for unbounded viewports
2023-03-20 21:34:00 +00:00
Michael Goderbauer
a599c08c32
Remvoe last few references to window singleton (#122644)
Remove last few references to window singleton
2023-03-15 00:34:34 +00:00
LongCatIsLooong
1306d7f158
Fix Caret Height On Empty Lines (#120834)
* improve caret caching, fix caret for empty text/line, `getLocalRectForCaret` now reports the real rect that will be painted.
move caret x-coordinate clamping to RenderEditable since TextPainter doesn't know about clipping.

* comments

* review
2023-03-13 15:37:42 -07:00
Michael Goderbauer
12ef7535a8
Reland "Introduce the PipelineOwner tree (#122231)" (#122452)
Reland "Introduce the PipelineOwner tree (#122231)"
2023-03-13 17:58:56 +00:00
Jim Graham
670f9d2037
Revert "Introduce the PipelineOwner tree (#122231)" (#122425)
This reverts commit f73c358e43df7c123e6d0141b3bc822877a1855d.
2023-03-10 13:15:46 -08:00
Michael Goderbauer
f73c358e43
Introduce the PipelineOwner tree (#122231)
Introduce the PipelineOwner tree
2023-03-10 19:57:17 +00:00
LongCatIsLooong
e7ab3b07f8
OverlayPortal (#105335)
`OverlayPortal`
2023-03-02 17:34:01 +00:00
chunhtai
978d9b5514
Issues/111931 reland (#121576)
* Revert "Revert "Fix text.rich to merge widget span (#113461)" (#121562)"

This reverts commit c8d80163b03f76e0cfde15567d065b6d1903cf8d.

* Fixes tag to not pollute cached semantics configuration in rendering object
2023-03-01 08:33:03 -08:00
Hans Muller
1bfba7564b
Added identical(a,b) short circuit to rendering library lerp methods (#121566)
Added identical(a,b) short circuit to rendering library lerp methods
2023-02-28 00:55:56 +00:00
chunhtai
c8d80163b0
Revert "Fix text.rich to merge widget span (#113461)" (#121562)
This reverts commit 660992a161ba04de706cd3931c32d3123e6e1228.
2023-02-27 15:38:43 -08:00
Michael Goderbauer
b1b7284a72
Move semantic-related bindings to SemanticsBinding (#121289)
Move semantic-related bindings to SemanticsBinding
2023-02-24 19:30:57 +00:00
Lioness100
26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
chunhtai
660992a161
Fix text.rich to merge widget span (#113461)
* Fix text.rich to merge widget span

* migrate to new API

* update

* addressing comment

* addressing comments

* update

* addressing comment

* Update
2023-02-23 17:38:52 +00:00
Greg Price
cd125e1f71
Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664)
* Add test for RenderProxyBoxMixin; clarify doc, resolve TODO

The TODO comment suggested this mixin would no longer be needed once
a Dart issue on inherited constructors was fixed:
  https://github.com/dart-lang/sdk/issues/31543
That issue is now long since fixed, so I went to go carry out the TODO.

But in doing so, I realized that the mixin's documentation was more
right than the TODO comment: even with that issue fixed, there is a
legitimate use case for this mixin, namely to reuse the implementation
of RenderProxyBox in a class that also inherits from some other base
class.  Moreover, searching GitHub I found an example of a library
that makes real use of that capability.

So I think the right resolution is to accept that this separation
is useful and delete the TODO.

Then, add a test with an extremely simplified sketch of that
real-world example.  In case someone in the future attempts to
simplify this mixin away, the test will point us at the use case
that would be broken by such a change.

Also remove the only in-tree use of the mixin, which was redundant;
and expand the mixin's documentation to advise about that case.

* Tweak formatting

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

* Cut comments

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-08 01:17:23 +00:00
LongCatIsLooong
1148a2a8ba
Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (#119359)
* PostFrameCallbacks -> compositionCallbacks

* review

* review
2023-01-31 01:39:09 +00:00
Ahmed Ashour
1fd71de0c5
Remove superfluous words from comments (#119055)
* Remove superfluous words from comments.

* Revert `win32_window.h`

Which seems to come from `gallery`
2023-01-25 20:23:24 +00:00
Michael Goderbauer
50ed8a34b0
Enable unnecessary_null_comparison check (#118849)
* Enable unnecessary_null_comparison outside of packages

* fix snippet

* enable for all
2023-01-24 21:24:11 +00:00
Michael Goderbauer
9837eb6fc5
Remove unnecessary null checks in flutter/rendering (#118923) 2023-01-21 01:34:50 +00:00
Chris Yang
c83a698556
update uikit view documentation (#118715)
* update uikit view documentation

* fix
2023-01-18 22:09:10 +00:00
LongCatIsLooong
0a2e0a4730
Avoid using TextAffinity in TextBoundary (#117446)
* Avoid affinity like the plague

* ignore lint

* clean up

* fix test

* review

* Move wordboundary to text painter

* docs

* fix tests
2023-01-05 17:04:15 +00:00
Callum Moffat
c53501d835
Send text direction in selection rects (#117436) 2023-01-04 04:00:08 +00:00
LongCatIsLooong
3d0607b543
Defer systemFontsDidChange to the transientCallbacks phase (#117123)
* Always defer systemFontsDidChange to transientCallbacks phase

* unnecessary import
2022-12-16 19:27:03 +00:00
chunhtai
23a2fa31d2
Reland "Adds API in semanticsconfiguration to decide how to merge chi… (#116895)
* Reland "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)"

This reverts commit 7549925c8c44dea92c7bc75be676c17b7613f87f.

* makes markNeedsSemanticsUpdate more robust

* address comment
2022-12-16 17:20:20 +00:00
Lucas.Xu
80e1008cbc
fix: #110342 unable to update rich text widget gesture recognizer (#116849) 2022-12-16 09:32:09 +01:00
Jonah Williams
169b49fba7
Revert "[framework] make transform with filterQuality a rpb (#116792)" (#117095)
This reverts commit e331dcda1785982a9efbc762e08e9c617cd3f6ae.
2022-12-15 17:11:42 +00:00
LongCatIsLooong
04ee5926a2
Remove RenderEditable textPainter height hack (#113301)
* remove RenderEditable textPainter height hack

* Still applies the hack on web

* unskip web
2022-12-13 03:42:23 +00:00
Jonah Williams
e331dcda17
[framework] make transform with filterQuality a rpb (#116792)
* [framework] make transform with filterQuality a rpb

* fix tests

* ++
2022-12-12 23:30:17 +00:00
Jonah Williams
d19047d8a1
[framework] make opacity widget create a repaint boundary (#116788) 2022-12-12 18:40:13 +00:00
Ian Hickson
9fdb64b7e7
Taboo the word "simply" from our API documentation. (#116061) 2022-12-11 22:43:22 +00:00
Casey Hillers
7549925c8c
Revert "Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)" (#116839)
This reverts commit 352ad3a9efccc8c54deb72eb0d7164bfb42b2a49.
2022-12-11 02:23:40 +00:00
Callum Moffat
c4b8046d96
Floating cursor cleanup (#116746)
* Floating cursor cleanup

* Use TextSelection.fromPosition
2022-12-10 00:24:23 +00:00
chunhtai
352ad3a9ef
Adds API in semanticsconfiguration to decide how to merge child semanticsConfigurations (#110730)
* Adds semantics merger API and fix input decorator

* addressing comments

* abstractnode to object

* feature complete

* addressing comments

* fix comments

* conditionally add sort order

* fix bool

* fix test

* more fix

* fix tests
2022-12-07 16:59:16 +00:00
Loïc Sharma
05c6df6d1f
Improve Flex layout comment (#116004) 2022-12-05 20:50:06 +00:00
chunhtai
224fae5063
Fix iOS selectWordEdge doesn't account for affinity (#115849)
* Fix iOS selectWordEdge doesn't account for affinity

* fix test

* update
2022-11-28 17:32:17 +00:00
Jim Graham
0eb2d51ec9
Use the new pushImageFilter offset parameter to fix the transform of the children (#113673) (#115884) 2022-11-23 07:42:34 +00:00
Jonah Williams
9bb07b5f70
Revert "Use the new pushImageFilter offset parameter to fix the transform of the children (#113673)" (#115861)
This reverts commit 91aeda7bf6f977207d7ac07ca46c26560007a244.
2022-11-22 13:29:56 -08:00
Jim Graham
91aeda7bf6
Use the new pushImageFilter offset parameter to fix the transform of the children (#113673) 2022-11-22 17:24:44 +00:00
chunhtai
c2b29501f4
Add selection feedback for both selection area and text field (#115373)
* Add selection feedback for both selection area and text field

* Addressing comment

* Fixes more test
2022-11-17 18:27:56 +00:00
fzyzcjy
7d2b01132d
Fix logic error in markNeedsPaint (#112735)
* Update object.dart

* Update object.dart

* Update object.dart

* Update object.dart

* Update object.dart
2022-11-16 00:06:51 +00:00
Maurice Parrish
95ace11afa
Include initial offset when using PlatformViewSurface (#114103)
* add position to layout creation

* make position nullable

* fix tests

* test

* clear test size

* clear device pixel ratio

* add more documentaiton

* add comment about localToGlobal
2022-11-15 18:21:37 +00:00