DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,180 Commits 882 Branches 1,069 Tags
Commit Graph

25918 Commits

Author SHA1 Message Date
gaaclarke
8515af7ee9 Pulled out dir contents golden tool (flutter/engine#50703) 
fixes https://github.com/flutter/flutter/issues/143459

This also starts using it as part of scenario_app.

Testing: Is part of the testing infrastructure.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-16 22:18:05 +00:00
skia-flutter-autoroll
85129f0e30 Roll Dart SDK from 21b9ee6f0a52 to fa66195a3814 (3 revisions) (flutter/engine#50732) 
https://dart.googlesource.com/sdk.git/+log/21b9ee6f0a52..fa66195a3814

2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-153.0.dev
2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-152.0.dev
2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-151.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 22:04:14 +00:00
skia-flutter-autoroll
a0aba8e2ce Roll Skia from 2919d86cad12 to 6ae5032133d0 (8 revisions) (flutter/engine#50729) 
https://skia.googlesource.com/skia.git/+log/2919d86cad12..6ae5032133d0

2024-02-16 lovisolo@google.com [bazel] Rewrite Android benchmark tests to depend on the modular build.
2024-02-16 kjlubick@google.com Add #ifdef guards to headers to avoid double-declarations
2024-02-16 lovisolo@google.com [bazel] Rewrite benchmark tests to depend on the modular build.
2024-02-16 kjlubick@google.com Remove SkWuffsCodec.h
2024-02-16 bungeman@google.com Enable skia_use_libgrapheme on jobs
2024-02-16 lovisolo@google.com [bazel] BazelBenchmarkTestRunner.cpp: Various cleanups.
2024-02-16 lovisolo@google.com [bazel] GaneshBenchmarkTarget.cpp: Fix outdated enum.
2024-02-16 johnstiles@google.com Reduce single-component swizzles to an unmasked copy.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 21:27:59 +00:00
Jackson Gardner
b8d198edc2 Temporarily disable goldens for Safari. (flutter/engine#50724) 
Safari is producing too many golden diffs. See https://github.com/flutter/flutter/issues/143591. This disables them for now to stop the noise, but we should look into a longer term solution.
 2024-02-16 21:14:10 +00:00
Martin Kustermann
0e6ffa7346 [web] Remove unused allowInterop usage in flutter web code (flutter/engine#50718) 
The CLs that migrated to static interop forgot to update the
corresponding comments regarding the need to use `allowInterop`.

The re-exported `allowInterop` function happened in an internal library
(not exposed via `dart:ui*`) and was unused.

Issue https://github.com/dart-lang/sdk/issues/54908
 2024-02-16 21:46:42 +01:00
Jonah Williams
0b9a9d6d1d [Impeller] use fewer threads for shader bootstrap workers on low core machines. (flutter/engine#50726) 
Part of https://github.com/flutter/flutter/issues/143540

We were using 4 threads for shader bootstrap on a device with only 4 cores. Using fewer threads seems to improve performance on fewer core machines.
 2024-02-16 20:34:21 +00:00
Michael Goderbauer
da30adfc6f Fix implementation imports outside of lib (flutter/engine#50727) 
Work towards https://github.com/dart-lang/linter/issues/4859

There are libraries outside a `lib/` directory, which violate `implementation_imports`.
 2024-02-16 20:19:33 +00:00
skia-flutter-autoroll
9176419d68 Roll Skia from 87e8e9c8f42b to 2919d86cad12 (8 revisions) (flutter/engine#50723) 
https://skia.googlesource.com/skia.git/+log/87e8e9c8f42b..2919d86cad12

2024-02-16 bungeman@google.com [skunicode] libgrapheme accumulate line break pos
2024-02-16 johnstiles@google.com Allow sk_Caps in private runtime effects.
2024-02-16 brianosman@google.com Remove AVX2 slice of BitmapProcState_opts
2024-02-16 johnstiles@google.com Use immediate-mode binary ops for two-slot arithmetic.
2024-02-16 kjlubick@google.com Remove extraneous SK_API from SkFontMgr_custom_empty.cpp
2024-02-16 michaelludwig@google.com Revert "[skif] Track padding around FilterResult images"
2024-02-16 kjlubick@google.com Address a few clang-tidy suggestions
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c2c1bfb03bd7 to 59c02c8da968 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 18:50:23 +00:00
skia-flutter-autoroll
f5d36627c4 Roll Dart SDK from 947c8c487e28 to 21b9ee6f0a52 (2 revisions) (flutter/engine#50717) 
https://dart.googlesource.com/sdk.git/+log/947c8c487e28..21b9ee6f0a52

2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-150.0.dev
2024-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-149.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 18:01:07 +00:00
skia-flutter-autoroll
6da068b6bd Roll Skia from c89a4cd72308 to 87e8e9c8f42b (3 revisions) (flutter/engine#50716) 
https://skia.googlesource.com/skia.git/+log/c89a4cd72308..87e8e9c8f42b

2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e53270c9ca1a to 3ca8befb2412 (20 revisions)
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6ca8603c26c8 to cfeca87ea13f (3 revisions)
2024-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2def6c361471 to d8439c0f5bfa (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 17:53:38 +00:00
skia-flutter-autoroll
19f9409aa6 Roll Fuchsia Linux SDK from fXqP_YC4zTp9G2hA5... to YN5KCfom7Ax0Z69s_... (flutter/engine#50719) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 17:47:29 +00:00
Jason Simmons
84ce5f16aa Use the Pixel 7/API 33 device in the Firebase test lab script (flutter/engine#50721) 
This test is currently failing consistently when running with Pixel 8/API 34
 2024-02-16 17:27:13 +00:00
Bruno Leroux
4b5c993fe4 [Web] Ignore invalid keyboard events related to autofill (flutter/engine#50590) 
## Description

This PR fixes an 'Unexpected null value' error related to autoFill.
When using Autofill feature, Chrome emits keyboard events whose `event.code` and `event.key` are null.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/114620.

## Tests

Adds 1 test.
 2024-02-16 07:04:48 +00:00
Jason Simmons
ea6b80144d Add the web package to the set of Dart third_party packages in DEPS (flutter/engine#50714) 
Dart is rolling the http package to a version that depends on the web package. (see https://dart.googlesource.com/http/+/d8b237d273f49bada2aa7feaa0e7795e2541fe83)
 2024-02-16 06:54:49 +00:00
skia-flutter-autoroll
1c47705918 Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709) 
https://dart.googlesource.com/sdk.git/+log/9bbac4d40725..947c8c487e28

2024-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-148.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-16 01:47:19 +00:00
Loïc Sharma
89b44f4fff [Windows] Improve FlutterWindow unit tests (flutter/engine#50676) 
_This was split from https://github.com/flutter/engine/pull/50673 to reduce noise in that PR._

Previously `MockFlutterWindow` called a `FlutterWindow` constructor which created a window & resized it. This change introduces a minimal base constructor for testing purposes. This allows us to skip some noisy mocks in a subsequent change: https://github.com/flutter/engine/pull/50673

This also introduces a fixture for the window unit tests.

Part of https://github.com/flutter/flutter/issues/137267
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-16 00:38:18 +00:00
Zachary Anderson
80076b93fb [et] Adds a logger (flutter/engine#50693) 2024-02-16 00:22:54 +00:00
Matan Lurey
d99aee7142 Update README.md (flutter/engine#50702) 
Oopsie.
 2024-02-15 15:38:20 -08:00
skia-flutter-autoroll
58f6902888 Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704) 
https://skia.googlesource.com/skia.git/+log/078b316e0563..3cbb5d6a71fe

2024-02-15 jvanverth@google.com [graphite] Fill out SmallPathAtlas.
2024-02-15 weiyuhuang@google.com Strut Half Leading Attempt 2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 22:54:33 +00:00
Juanjo Tugores
ec948a8b48 Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608) 
Move the accesibility placeholder to the platform dispatcher.

This change makes the platform dispatcher append a single accesibility placeholder, per app, to the `<body />`. Previous behavior was to insert a placeholder inside each `<flutter-view />`

Relevant Issues are:

* Design doc: https://flutter.dev/go/focus-management 
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443
* Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 22:07:58 +00:00
skia-flutter-autoroll
403c2a297c Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700) 
https://skia.googlesource.com/skia.git/+log/a8e4db1afac5..078b316e0563

2024-02-15 lovisolo@google.com [bazel] GaneshGLSurfaceManager: Fix sample counts in configs.
2024-02-15 michaelludwig@google.com [skif] Track padding around FilterResult images
2024-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 16c7058465af to c2c1bfb03bd7 (2 revisions)
2024-02-15 lovisolo@google.com [bazel] BazelGMTestRunner.cpp: Add --knownDigestsFile flag.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 21:58:36 +00:00
skia-flutter-autoroll
fd7318004a Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699) 
https://dart.googlesource.com/sdk.git/+log/5e442dc80903..9bbac4d40725

2024-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-147.0.dev
2024-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-146.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 21:55:40 +00:00
Rulong Chen（陈汝龙）
8d744a5fbe [Android] Remove the unnecessary parent interface. (flutter/engine#50677) 
`ImageConsumer` and `GLTextureConsumer` should not inherit from `TextureEntry`.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 21:49:54 +00:00
Brandon DeRosier
5b42e9e87e [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698) 
So that it's easy to determine whether the playground test itself caused the failure or not.
 2024-02-15 21:32:13 +00:00
skia-flutter-autoroll
18a6a57cff Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696) 
https://skia.googlesource.com/skia.git/+log/6ee2b5f61ae5..a8e4db1afac5

2024-02-15 kjlubick@google.com Move GrBackendDrawableInfo to Vulkan subfolder
2024-02-15 brianosman@google.com Add --runtimeCPUDetection to nanobench
2024-02-15 dtapuska@chromium.org Fix iOS 17.4 SDK build failure
2024-02-15 kjlubick@google.com Skip Name.json in SkottieWasm perf test
2024-02-15 jvanverth@google.com Remove MtlIsAppInBackground.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 20:50:22 +00:00
zijiehe@
4c418e9452 [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 
This change replicas https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20arm64%20FEMU and runs tests on simulated arm64 on x64. E.g. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/1994921/overview
or more accurately, https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756061244290412945/+/u/test:_arm64_emulator_based_debug_tests/stdout

The vulkan tests are excluded, qemu does not support vulkan.
The display_list_render_tests is excluded as it's way too slow (over 400 seconds).

After this change, comparing to femu_test.py, the only missing case is the dart-aot-runner-integration-test which is executed in fuchsia_profile_x64 anyway. It needs `--no-lto` in fuchsia_profile_arm64. I may need to confirm if the fuchsia_profile_arm64 build is used in fuchsia or the fuchsia_release_arm64.

Bug: https://github.com/flutter/flutter/issues/140179

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 20:22:23 +00:00
gaaclarke
7d9ad5606f [Impeller] Updated benchmarks (flutter/engine#50694) 
Looks like we changed devices sometime in august.  This mostly switches comparisons from using Samsung galaxy 10 to pixel 7 pro.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 19:28:17 +00:00
godofredoc
b6753d492b Documentation for test timeouts. (flutter/engine#50687) 
Support for test timeouts was added on the engine v2 recipes and this is documenting the new properties in build tests and global tests configurations.

Bug: https://github.com/flutter/flutter/issues/143021

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 19:09:56 +00:00
Zachary Anderson
8ed833927f Shift some Linux builders from Goma to RBE (flutter/engine#50653) 
This PR shifts all Linux builders except for linux_fuchsia and
linux_clang_tidy from GOMA to RBE. It also shifts one build from another
builder to linux_unopt.
 2024-02-15 10:42:43 -08:00
skia-flutter-autoroll
33405beb29 Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691) 
https://skia.googlesource.com/skia.git/+log/12d0b7fac4c3..6ee2b5f61ae5

2024-02-15 kjlubick@google.com Moving GR_TEST_UTILS out of non-ganesh code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 18:09:05 +00:00
gaaclarke
fcbd40e8e4 Added tool to easily check golden diffs locally. (flutter/engine#50654) 
This addresses the problem where people feel like they have to upload a PR to get diffs from Skia Gold.  This should work for most workflows.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 17:50:06 +00:00
skia-flutter-autoroll
7acb0fb5ff Roll Skia from 4bbf2060b008 to 12d0b7fac4c3 (2 revisions) (flutter/engine#50689) 
https://skia.googlesource.com/skia.git/+log/4bbf2060b008..12d0b7fac4c3

2024-02-15 herb@google.com Unpremul for _opts
2024-02-15 robertphillips@google.com [graphite] Add first stage of unpacking the UniqueKeys

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 17:10:11 +00:00
John O'Neil
1bf4eb1a30 Provide a matrix inverse shim for GLES 2.0. (flutter/engine#50545) 
This PR addresses [ Issue #141829](https://github.com/flutter/flutter/issues/141829).

We saw a shader compilation error after updating `flutter/impeller` due to the lack of a matrix `inverse` implementation on GLSL 1.0 used on GLSL 2.0. This change provides one (for the current used case which is only for `mat3` support.

I think this change needs some discussion as gating the change on GLSL < 1.4 would be more effective. Also my knowledge of correctly managing these `.glsl` based shaders is still superficial.

- [x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [ x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [x ] I listed at least one issue that this PR fixes in the description above.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 16:32:03 +00:00
Jonah Williams
dac5a4b792 [iOS] Ensure FlutterMetalLayer has correct backpressure. (flutter/engine#50486) 
See also https://github.com/flutter/flutter/issues/140901 . We were not accounting for GPU backpressure in the FML, this applies the patch from @knopp to track this.
 2024-02-15 16:28:33 +00:00
skia-flutter-autoroll
e1136b1caf Roll Skia from 682f0e1e7e77 to 4bbf2060b008 (3 revisions) (flutter/engine#50686) 
https://skia.googlesource.com/skia.git/+log/682f0e1e7e77..4bbf2060b008

2024-02-15 drott@chromium.org Fix Bazel build of viewer with Fontations enabled
2024-02-15 nicolettep@google.com [graphite] Load MSAA from resolve
2024-02-15 brianosman@google.com On CPU, allow drawVertices with identical UVs across a triangle

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 16:12:59 +00:00
Jesse Seales
22167a091b Pin OSV-Scanner reusable workflow (flutter/engine#50649) 
Update the vulnerability scanning workflow to pin the reusable OSV-Scanner workflow for better control over updates in the future.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 16:07:01 +00:00
William Hesse
1e43ea059b Add support for dart_src GN variable to flutter_frontend_server build (flutter/engine#50685) 
Support for the dart_src GN variable was missing the import of the variable definition in the flutter_frontend_server BUILD.gn file.

Follow up to https://github.com/flutter/engine/pull/50624/

Part of issue https://github.com/flutter/flutter/issues/143335
 2024-02-15 16:02:56 +00:00
Renan
918d73b4aa fix: consider array size on canvaskit shader data (flutter/engine#49754) 
This PR changes the ShaderData construction on canvaskit to consider array uniforms. 

https://github.com/flutter/flutter/issues/141296

https://github.com/flutter/flutter/issues/141838

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 15:23:12 +00:00
skia-flutter-autoroll
1478f1e0dc Roll Skia from 85ab600a9519 to 1277910beec9 (2 revisions) (flutter/engine#50682) 
https://skia.googlesource.com/skia.git/+log/85ab600a9519..1277910beec9

2024-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1ed2fa79f8ce to 6ca8603c26c8 (3 revisions)
2024-02-15 armansito@google.com [viewer] Add a "compute-msaa16" pathstrategy option

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 06:35:34 +00:00
skia-flutter-autoroll
cb0d9d39d1 Roll Fuchsia Linux SDK from mZP8LxbhYHstUxmxd... to fXqP_YC4zTp9G2hA5... (flutter/engine#50680) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 06:25:23 +00:00
Chinmay Garde
6c17d7bf9d Use a GN variable (dart_src) to reference the location of the Dart checkout. (flutter/engine#50624) 
Towards https://github.com/flutter/flutter/issues/143335
 2024-02-14 21:12:23 -08:00
Matan Lurey
95e8704f1a Add a &right_filter=params to the Skia Gold links. (flutter/engine#50675) 
Otherwise they are compared against other API versions and backends by default, which is confusing.
 2024-02-15 02:31:13 +00:00
skia-flutter-autoroll
c9aa1cfcb7 Roll Skia from 2d5cf67614d0 to b6201d9c2f73 (2 revisions) (flutter/engine#50674) 
https://skia.googlesource.com/skia.git/+log/2d5cf67614d0..b6201d9c2f73

2024-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1ed2fa79f8ce to 6ca8603c26c8
2024-02-14 dtapuska@chromium.org Fix building skia inside iOS Application Extension

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 02:25:23 +00:00
Matan Lurey
6d14dc5b6a Disable Android API v28 tests on CI. (flutter/engine#50672) 
They are too unstable. See https://github.com/flutter/flutter/issues/143471.

![image](https://github.com/flutter/engine/assets/168174/311aa4ab-2c1d-40ec-bd43-b87e38d4b3d6)
 2024-02-15 01:58:09 +00:00
Matan Lurey
46d8d6660c Use modern concurrency constructs. (flutter/engine#50671) 
The old code made me cry.

Potentially related to https://github.com/flutter/flutter/issues/143471.
 2024-02-14 17:51:30 -08:00
skia-flutter-autoroll
a4cc66e9ae Roll Dart SDK from 322e34dc53f6 to f1b1fa85a1be (1 revision) (flutter/engine#50670) 
https://dart.googlesource.com/sdk.git/+log/322e34dc53f6..f1b1fa85a1be

2024-02-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-144.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-15 01:30:13 +00:00
Matan Lurey
53ab3dc4b4 Move boringssl to flutter/third_party. (flutter/engine#50601) 
As ready as it's ever going to be.
 2024-02-14 17:17:28 -08:00
Rulong Chen（陈汝龙）
07c39717a4 [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647) 
This is a minor refactoring with no semantic changes.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-14 17:11:54 -08:00
Jim Graham
9fdf2de647 [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635) 
Consolidates the 3 coordinate operations in the PositionUVWriter into a single transform for efficiency.
 2024-02-15 01:02:15 +00:00
David Iglesias
45adab9726 [web] Add dynamic view sizing (v2) (flutter/engine#50271) 
### Changes

* Introduces a new `viewConstraints` JS configuration parameter to configure max/min width/height constraints for a view. Those can have the following values:
  * An integer `>= 0`: max/min size in pixels
  * `Infinity` (or `Number.POSITIVE_INFINITY`): (only for max values) -> **unconstrained**.
  * When any value is not set, it defaults to "tight to the current size".
    * See [Understanding constraints](https://docs.flutter.dev/ui/layout/constraints).
* Computes the correct `physicalConstraints` of a view off of its `physicalSize` and its `viewConstraints` for the framework to use during layout.
  * When no constraints are passed, the current behavior is preserved: the default constraints are "tight" to the `physicalSize`.
* Resizes the current view DOM when requested by the framework and updates its internal physicalSize, then continues with the render procedure.

### Example

This is how we can configure a view to "take as much vertical space as needed":

```js
flutterApp.addView({
  viewConstraints: {
    minHeight: 0,
    maxHeight: Infinity,
  },
  hostElement: ...,
});
```

### TODO

* Needs actual unit tests

### Issues

* Fixes https://github.com/flutter/flutter/issues/137444
* Closes https://github.com/flutter/engine/pull/48541

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-15 00:56:57 +00:00