John McDole
83a97eeaf1
Update CONTRIBUTING.md links ( flutter/engine#53043 )
...
`engine_dev_setup` moved to markdown
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-29 22:36:43 +00:00
skia-flutter-autoroll
a7cacf5852
Roll Skia from 32746679f7be to aecf76e8eb9a (1 revision) ( flutter/engine#53100 )
...
https://skia.googlesource.com/skia.git/+log/32746679f7be..aecf76e8eb9a
2024-05-29 johnstiles@google.com Add uvecN type to the built-in types.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 22:11:22 +00:00
skia-flutter-autoroll
86521543e6
Roll Skia from b18b7d6af6e8 to 32746679f7be (2 revisions) ( flutter/engine#53097 )
...
https://skia.googlesource.com/skia.git/+log/b18b7d6af6e8..32746679f7be
2024-05-29 johnstiles@google.com Remove guard flag for mad() in raster pipeline.
2024-05-29 armansito@google.com Manually roll Dawn and abseil-cpp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 21:11:31 +00:00
Jonah Williams
0847b349a7
[Impeller] revert changes to IO thread upload scheduling. ( flutter/engine#53096 )
...
Fixes https://github.com/flutter/flutter/issues/147429
Turns out we need the I/O thread for all backends still to limit uploads otherwise we compete with the raster thread.
2024-05-29 20:59:16 +00:00
Jonah Williams
4512c9eb76
[Impeller] fix barriers prior to mip generation. ( flutter/engine#53082 )
...
This fixes the flickering and rendering errors when running on Android seen in https://github.com/flutter/flutter/issues/148412 .
The problem is the barriers proceding mip generation do not account for the input text having been the output of a render pass. Unfortunately no validation errors on this, and no Idea how to test it.
2024-05-29 20:46:05 +00:00
skia-flutter-autoroll
5f55364a1a
Roll Skia from e11a5c5b402e to b18b7d6af6e8 (2 revisions) ( flutter/engine#53095 )
...
https://skia.googlesource.com/skia.git/+log/e11a5c5b402e..b18b7d6af6e8
2024-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9fbe42f1f959 to 8f291de2f5be (6 revisions)
2024-05-29 jvanverth@google.com Fix text 565 to RGBA conversion on BGRA-based systems.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 20:14:05 +00:00
Michael Goderbauer
c7f659ac91
Switch to FilterQuality.medium for images ( flutter/engine#52984 )
...
https://github.com/flutter/flutter/issues/148253
2024-05-29 20:02:17 +00:00
skia-flutter-autoroll
b3b2f46853
Roll Skia from a4f58c9dabc3 to e11a5c5b402e (1 revision) ( flutter/engine#53092 )
...
https://skia.googlesource.com/skia.git/+log/a4f58c9dabc3..e11a5c5b402e
2024-05-29 jvanverth@google.com Reland "[ganesh] Support vertical LCD with SDF text"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 18:48:08 +00:00
skia-flutter-autoroll
b1f4a1e7a6
Roll Skia from ca77972f659e to a4f58c9dabc3 (2 revisions) ( flutter/engine#53091 )
...
https://skia.googlesource.com/skia.git/+log/ca77972f659e..a4f58c9dabc3
2024-05-29 drott@chromium.org [Fontations-backend] Homogenize test results for COLRv1 test
2024-05-29 robertphillips@google.com [graphite] Add lighting ImageFilters to Precompilation system
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 17:37:22 +00:00
Jonah Williams
25d9c64162
[Impeller] relax conditions for SkRRect.isSimple conversion to impeller::RRect. ( flutter/engine#53083 )
...
The flickering in https://github.com/flutter/flutter/issues/148412 is caused by us switching between the RRect fast path and a gaussian blur. The reason is that the SkRect.isSimple check doesn't handle fp precision very well. On one of the frames the difference was :
```
D/skia (18362): SkRect::MakeLTRB(74, 179.666672f, 374, 479.666656f);
D/skia (18362): const SkPoint corners[] = {
D/skia (18362): { 150, 149.999969f },
D/skia (18362): { 150, 150 },
D/skia (18362): { 150, 149.999969f },
D/skia (18362): { 150, 150 },
D/skia (18362): };
```
So lets used a relaxed check for RRect.isSimple instead.
Fixes https://github.com/flutter/flutter/issues/148412
2024-05-29 16:45:22 +00:00
skia-flutter-autoroll
66e443eb6b
Manual roll Dart SDK from 641d61332238 to ef405fbe3917 (12 revisions) ( flutter/engine#53089 )
...
Manual roll requested by jacksongardner@google.com
https://dart.googlesource.com/sdk.git/+log/641d61332238..ef405fbe3917
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-203.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-202.0.dev
2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-201.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-200.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-199.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-198.0.dev
2024-05-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-197.0.dev
2024-05-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-196.0.dev
2024-05-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-195.0.dev
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-194.0.dev
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-193.0.dev
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-192.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 16:29:03 +00:00
skia-flutter-autoroll
60b6efc9da
Roll Skia from 99966843c23f to 2fe794827c51 (1 revision) ( flutter/engine#53087 )
...
https://skia.googlesource.com/skia.git/+log/99966843c23f..2fe794827c51
2024-05-29 robertphillips@google.com Revert "[skif] Take advantage of PixelBoundary in rescale()"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 14:20:06 +00:00
skia-flutter-autoroll
669fac0182
Roll Skia from eedef8763102 to 9ea5a1dd5270 (1 revision) ( flutter/engine#53084 )
...
https://skia.googlesource.com/skia.git/+log/eedef8763102..9ea5a1dd5270
2024-05-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6cab40b89cc8 to 57354f93e99c (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-29 05:46:23 +00:00
Jim Graham
2933b2257a
DisplayList forward opacity incompatibility through deferred saves ( flutter/engine#53078 )
...
The previous reorg of the DisplayListBuilder save/restore code placed the code that forwards layer flags inside the code that processes a non-deferred save call, but it needs to be processed regardless of the deferred save.
2024-05-29 02:05:40 +00:00
skia-flutter-autoroll
cd00bec78c
Roll Skia from ac454b80130c to 0026a6047133 (1 revision) ( flutter/engine#53076 )
...
https://skia.googlesource.com/skia.git/+log/ac454b80130c..0026a6047133
2024-05-28 michaelludwig@google.com [graphite] Use Context's ResourceProvider for async readback recording
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 23:13:23 +00:00
Gray Mackall
dab310ecb8
Manual revert of #53001 ( flutter/engine#53075 )
...
Revert label failed due to conflicts
`FlutterFragmentTest.java` was the only file that had merge issues, everything else is the output of `git revert 802e5d2cd3c9e73f336e3fe43487b64a5fdf98d8`
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-28 23:00:20 +00:00
Chinmay Garde
829947077f
Remove --ios-cpu flag. Only the arm64 variant is supported. ( flutter/engine#53044 )
...
We don't support 32-bit arm iOS builds anymore. But adding the --ios-cpu=arm64 appends the "_arm" to the out subdirectory. This just causes confusion since the ios_debug_unopt is still arm64.
Just remove the flag that does nothing.
2024-05-28 22:26:16 +00:00
skia-flutter-autoroll
c80c71c800
Roll Skia from 229d94a8807e to ac454b80130c (1 revision) ( flutter/engine#53074 )
...
https://skia.googlesource.com/skia.git/+log/229d94a8807e..ac454b80130c
2024-05-28 michaelludwig@google.com [skif] Take advantage of PixelBoundary in rescale()
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 21:58:52 +00:00
Jonah Williams
eae27f210b
[Impeller] make strokes slightly lighter. ( flutter/engine#53067 )
...
We can set the minimum stroke width to 0.5 to guarantee at least one hit of 4x MSAA coverage. This doesn't fix stroke fidelity issues but it does make it a bit better.
https://github.com/flutter/flutter/issues/144313
2024-05-28 21:04:21 +00:00
skia-flutter-autoroll
ad5ba74b0d
Roll Skia from 23ddbb590e44 to 229d94a8807e (2 revisions) ( flutter/engine#53071 )
...
https://skia.googlesource.com/skia.git/+log/23ddbb590e44..229d94a8807e
2024-05-28 borenet@google.com Remove Pixel4XL SkpBench jobs
2024-05-28 nicolettep@google.com [graphite] VulkanSamplerYcbcrConversion -> VulkanYcbcrConversion
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 20:50:22 +00:00
Justin McCandless
6dfec16435
FlutterFragment predictive back ( flutter/engine#52302 )
...
Android add-to-app apps now support predictive back when going between Activities or back to the home screen. Predictive back route transitions within the Flutter part of the app are not yet supported.
2024-05-28 12:52:05 -07:00
skia-flutter-autoroll
be9ea34652
Roll Skia from 02c359cf8233 to 23ddbb590e44 (2 revisions) ( flutter/engine#53070 )
...
https://skia.googlesource.com/skia.git/+log/02c359cf8233..23ddbb590e44
2024-05-28 fmalita@google.com [skottie] Fix word animation with explicit line breaks
2024-05-28 kjlubick@google.com Fix GLWindowContext_unix
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 19:42:17 +00:00
skia-flutter-autoroll
0ee23e14e8
Roll Skia from 4f91b3865441 to 02c359cf8233 (1 revision) ( flutter/engine#53069 )
...
https://skia.googlesource.com/skia.git/+log/4f91b3865441..02c359cf8233
2024-05-28 michaelludwig@google.com Reland "[graphite] Use approx-fit textures in async readback"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 18:42:22 +00:00
gaaclarke
4795bc576d
[Impeller] shrunk the buffer for the rrect_blur ( flutter/engine#53068 )
...
issue https://github.com/flutter/flutter/issues/148496
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-28 18:29:09 +00:00
skia-flutter-autoroll
9f29233004
Roll Skia from 91cd2b48377a to 4f91b3865441 (4 revisions) ( flutter/engine#53066 )
...
https://skia.googlesource.com/skia.git/+log/91cd2b48377a..4f91b3865441
2024-05-28 johnstiles@google.com Reorder stroke tesselator checks to do a bit less work.
2024-05-28 johnstiles@google.com Use mad in dither, blend and modulo computations.
2024-05-28 johnstiles@google.com Implement swap() for Skia hash tables.
2024-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 8ecbf179f1e3 to df449d7e2ec1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 17:39:20 +00:00
Gray Mackall
802e5d2cd3
Upgrade all[most] androidx dependencies to latest ( flutter/engine#53001 )
...
Upgrades every `androidx` dependency in the `src/third_party/android_embedding_dependencies` bundle to the latest version, except the `lifecycle` group*. Tested running a couple of apps as well because when updating these dependencies in the past I've been able to build the engine but then flutter run fail when trying to run an app.
Fixes https://github.com/flutter/flutter/issues/129307 , also unblocks a feature that will eventually be needed for Scribe.
[*]`2.8.0` is the latest there, but I ran into an issue with dexing when I tried to upgrade, due to b/336164417, an AGP bug that had its fix backported to all >`8.0.0` versions, but we still support less than that so we will have to wait on that upgrade.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-05-28 16:58:59 +00:00
skia-flutter-autoroll
4cc2731490
Roll Skia from 0c2c490021b7 to 91cd2b48377a (3 revisions) ( flutter/engine#53065 )
...
https://skia.googlesource.com/skia.git/+log/0c2c490021b7..91cd2b48377a
2024-05-28 kjlubick@google.com Make frameworks available when linking executables too
2024-05-28 drott@chromium.org [Fontations-backend] Fix direction of cap-height and x-height
2024-05-28 johnstiles@google.com Add support for golden tests of private Runtime Shaders.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 16:29:23 +00:00
skia-flutter-autoroll
e0680c89dc
Roll Skia from 545203f95d4e to 0c2c490021b7 (2 revisions) ( flutter/engine#53063 )
...
https://skia.googlesource.com/skia.git/+log/545203f95d4e..0c2c490021b7
2024-05-28 johnstiles@google.com Restore some tests to the WGSL tests fileset.
2024-05-28 kjlubick@google.com Need to rewrite VulkanMemoryAllocatorWrapper header #include
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 15:12:08 +00:00
skia-flutter-autoroll
15b1f2186e
Roll Skia from 74b4d97be6ab to 545203f95d4e (1 revision) ( flutter/engine#53062 )
...
https://skia.googlesource.com/skia.git/+log/74b4d97be6ab..545203f95d4e
2024-05-28 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.19.2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 14:06:22 +00:00
johnniwinther
43149fdc24
Remove use of --nnbd-agnostic ( flutter/engine#53055 )
...
The Dart VM no longer supports unsound null safety, so we don't need to
generate the platform in agnostic mode.
2024-05-28 10:07:40 +02:00
Jonah Williams
c670f5191f
[Impeller] Use scaled font to determine bounds, match Skia position rounding behavior, add subpixel X/Y/All/None positioning. ( flutter/engine#53042 )
...
Multiple fixes to text rendering that match skia behavior on almost all bugs I've found, except for the glyphs are still _slightly_ too fine for some CJK text. The fixes are:
1. Compute the gylph size in the typographer context, using text size * scale factor text, instead of computing smaller bounds and scaling it up. This was not accurate and as a result we would positon glyphs incorrect by multiple pixels sometimes, causing uneven rows.
2. Match Skia's rounding behavior. previously we were rounding in multiple places, Skia rounds once. This is important to prevent jumping.
3. Use 4 subpixel X positions for rendering. This is the big one that ensures the visible layout matches exactly. Adds support for Y, both, and none positioning too. I couldn't find any examples of just Y or both. Some fonts may specify that have no subpixel positioning. So we don't bother to compute it for those.
Fixes https://github.com/flutter/flutter/issues/138386 / mostly, except slightly not bold enough.
Fixes https://github.com/flutter/flutter/issues/147577 / mostly, except slightly not bold enough.
Fixes https://github.com/flutter/flutter/issues/140475
Fixes https://github.com/flutter/flutter/issues/141467
Fixes https://github.com/flutter/flutter/issues/135523
Fixes https://github.com/flutter/flutter/issues/127815
2024-05-28 06:08:05 +00:00
skia-flutter-autoroll
373ded8e27
Roll Skia from 064f93590e63 to 312160c7c920 (1 revision) ( flutter/engine#53058 )
...
https://skia.googlesource.com/skia.git/+log/064f93590e63..312160c7c920
2024-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 75ae5ddd462e to 6cab40b89cc8 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 05:54:35 +00:00
Chinmay Garde
6c35a86b30
Add an unoptimized Android debug config to local_engine.json. ( flutter/engine#53057 )
2024-05-28 04:58:24 +00:00
Byoungchan Lee
d56c301037
Add Linux platform support for fetching refresh rate on startup. ( flutter/engine#52934 )
...
This patch addresses the missing implementation of
`platformDispatcher.views` on Linux. It checks the refresh rate of the
renderer's window and returns the value. Without this implementation,
`WidgetsBinding.instance.platformDispatcher.views.first.display.size`
would throw an exception on Linux, preventing safe usage.
Related: https://github.com/flutter/flutter/issues/144230
2024-05-28 12:38:07 +12:00
skia-flutter-autoroll
a470e63489
Roll Skia from 33234e7c2072 to a74086522b47 (3 revisions) ( flutter/engine#53052 )
...
https://skia.googlesource.com/skia.git/+log/33234e7c2072..a74086522b47
2024-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 75ae5ddd462e to 6cab40b89cc8
2024-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a4f76cda0587 to 75ae5ddd462e (2 revisions)
2024-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from deff872bef22 to ab1d358e50d2 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bwils@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 07:00:31 +00:00
Chinmay Garde
51a803510c
[Impeller] Suppress SPIRV validation errors in latest Vulkan SDK. ( flutter/engine#53049 )
...
Workaround for https://github.com/flutter/flutter/issues/149111
2024-05-27 05:15:27 +00:00
auto-submit[bot]
f0cb5fe589
Reverts "Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) ( #53032 )" ( flutter/engine#53041 )
...
Reverts: flutter/engine#53032
Initiated by: zanderso
Reason for reverting: https://github.com/flutter/flutter/issues/149093
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/641d61332238..b759e9f83ff9
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-192.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 19:21:49 +00:00
auto-submit[bot]
0b1584084b
Reverts "Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) ( #53036 )" ( flutter/engine#53040 )
...
Reverts: flutter/engine#53036
Initiated by: zanderso
Reason for reverting: https://github.com/flutter/flutter/issues/149093
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/b759e9f83ff9..aed02f471e34
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-193.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 19:17:47 +00:00
auto-submit[bot]
08bca93595
Reverts "Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) ( #53037 )" ( flutter/engine#53039 )
...
Reverts: flutter/engine#53037
Initiated by: zanderso
Reason for reverting: https://github.com/flutter/flutter/issues/149093
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/aed02f471e34..17c351dd16f4
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-194.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 19:11:47 +00:00
skia-flutter-autoroll
66843dd18c
Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) ( flutter/engine#53037 )
...
https://dart.googlesource.com/sdk.git/+log/aed02f471e34..17c351dd16f4
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-194.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 10:39:37 +00:00
skia-flutter-autoroll
bae66f7349
Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) ( flutter/engine#53036 )
...
https://dart.googlesource.com/sdk.git/+log/b759e9f83ff9..aed02f471e34
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-193.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 06:28:33 +00:00
skia-flutter-autoroll
bff4a24c63
Roll Fuchsia Linux SDK from 9PoD1BZXVglZ-EWu3... to j_hH7zx04OsJaL9p2... ( flutter/engine#53035 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 05:36:26 +00:00
skia-flutter-autoroll
8fe5a8c7f8
Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) ( flutter/engine#53032 )
...
https://dart.googlesource.com/sdk.git/+log/641d61332238..b759e9f83ff9
2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-192.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 02:30:06 +00:00
skia-flutter-autoroll
72736f5772
Roll Skia from 0b7d656b9c03 to 7eb8515603c1 (1 revision) ( flutter/engine#53031 )
...
https://skia.googlesource.com/skia.git/+log/0b7d656b9c03..7eb8515603c1
2024-05-25 jvanverth@google.com Revert "[ganesh] Support vertical LCD with SDF text"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 01:08:17 +00:00
skia-flutter-autoroll
4b1f1c5d3d
Roll Dart SDK from 4ef8ed68a8d4 to 641d61332238 (1 revision) ( flutter/engine#53029 )
...
https://dart.googlesource.com/sdk.git/+log/4ef8ed68a8d4..641d61332238
2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-191.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 22:02:04 +00:00
skia-flutter-autoroll
01dbe1d5ad
Roll Skia from 10459d97152a to 0b7d656b9c03 (3 revisions) ( flutter/engine#53028 )
...
https://skia.googlesource.com/skia.git/+log/10459d97152a..0b7d656b9c03
2024-05-24 jvanverth@google.com [graphite] Fix some more SDF GMs
2024-05-24 michaelludwig@google.com Revert "[graphite] Use approx-fit textures in async readback"
2024-05-24 robertphillips@google.com [graphite] Add morphology ImageFilter to Precompilation system
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 21:54:18 +00:00
Jim Graham
43b9282bec
Reland "DisplayListBuilder internal reorganization with better rendering op overlap detection" (52646) ( flutter/engine#53002 )
...
Reverts https://github.com/flutter/engine/pull/52725
This commit makes some long-needed internal improvements to the way that the DisplayListBuilder manages its per-save/saveLayer data. The information for layer bounds and matrix/clips is now maintained in the layer info structure itself rather than shared across a number of stack structures which required careful alignment of the 3 different stacks and made it more difficult to compare and update adjacent layers during save and restore operations.
The new code stores all information for a layer within a single structure and the save and restore operations can be more clear about which information they are getting or setting in the current and parent layers.
In addition, the layer bounds accumulations were updated to have a more flexible algorithm for detecting overlap of rendering operations for the opacity peephole optimization. Previously, more than one rendering op on a layer would prevent opacity peephole optimizations, but now the condition will be recognized until the first rendering op that overlaps the bounds of the previous rendering operations. This will help for some potentially common cases of 2 non-overlapping ops or even a list of rendering operations laid out in a row.
2024-05-24 21:20:50 +00:00
skia-flutter-autoroll
a7b2ed7bf8
Roll Skia from 137a4ea4e033 to 10459d97152a (3 revisions) ( flutter/engine#53027 )
...
https://skia.googlesource.com/skia.git/+log/137a4ea4e033..10459d97152a
2024-05-24 jvanverth@google.com [graphite] Fix surfaceprops_df.
2024-05-24 ccameron@chromium.org Replace SkDynamicMemoryEndianWStream with helper functions
2024-05-24 michaelludwig@google.com [graphite] Use approx-fit textures in async readback
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 20:52:22 +00:00
skia-flutter-autoroll
c1121245f8
Roll Skia from d252bca326a6 to 137a4ea4e033 (1 revision) ( flutter/engine#53026 )
...
https://skia.googlesource.com/skia.git/+log/d252bca326a6..137a4ea4e033
2024-05-24 robertphillips@google.com [graphite] Settle on BlurMaskFilter Precompilation API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 19:54:02 +00:00
skia-flutter-autoroll
c550a7d292
Roll Skia from 97783ac3000d to d252bca326a6 (2 revisions) ( flutter/engine#53025 )
...
https://skia.googlesource.com/skia.git/+log/97783ac3000d..d252bca326a6
2024-05-24 sky@google.com Don't draw paths that are too large to tesselate
2024-05-24 jvanverth@google.com [ganesh] Support vertical LCD with SDF text
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 18:52:17 +00:00
