DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,663 Commits 882 Branches 1,069 Tags
Commit Graph

22725 Commits

Author SHA1 Message Date
gmackall
805cd4816d Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109) 
Solely documentation change to explain the reasoning behind the change in https://github.com/flutter/engine/pull/42700.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-23 14:21:55 +00:00
skia-flutter-autoroll
cee6554538 Roll Fuchsia Linux SDK from tcVndpnH_jzGm5LsJ... to VSKvLPB4DCIDvXzOA... (flutter/engine#43134) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 07:38:20 +00:00
skia-flutter-autoroll
73ed54d95e Roll Skia from 450bc21cc836 to a94abf80dd2f (2 revisions) (flutter/engine#43132) 
https://skia.googlesource.com/skia.git/+log/450bc21cc836..a94abf80dd2f

2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7fe8d8d9b147 to 74755bf0105b (7 revisions)
2023-06-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6dfc38b8a59d to 8278361fbbef (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 06:39:05 +00:00
Dan Field
682e06b5fc Removed outdated comment from lib/ui/canvas.h (flutter/engine#43112) 
This no longer applies.
 2023-06-23 04:29:19 +00:00
skia-flutter-autoroll
3d40f7724e Roll Skia from 6595192c8352 to a989b6f1aec5 (1 revision) (flutter/engine#43120) 
https://skia.googlesource.com/skia.git/+log/6595192c8352..a989b6f1aec5

2023-06-23 nicolettep@google.com [graphite] Add binding field to descriptor struct and rename appropriately; utilize in Vulkan

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 02:13:11 +00:00
Brandon DeRosier
e88246ebb4 [Impeller] Include CPU blends + Flutter blend reference image in goldens (flutter/engine#43117) 
Part of https://github.com/flutter/flutter/issues/128606.

- Adds blend imagery that matches the Flutter BlendMode documentation:
https://api.flutter.dev/flutter/dart-ui/BlendMode.html
- Adds a clear side-by-side comparison of SaveLayer blending vs CPU
blending to make verifying correctness possible.
  - Top squares are SaveLayer-applied blends.
  - Bottom squares are CPU blends.
 2023-06-22 17:57:13 -07:00
gaaclarke
3604e9b519 [Impeller] Fix and reland drawPaint collapsing optimization. (flutter/engine#43097) 
Collapses DrawPaint calls into clear colors when possible.

issue https://github.com/flutter/flutter/issues/129292
relands https://github.com/flutter/engine/pull/41711

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-22 17:40:49 -07:00
skia-flutter-autoroll
e20c352bf0 Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114) 
https://skia.googlesource.com/skia.git/+log/cb44fca83da0..5265b5ee1afc

2023-06-22 kjlubick@google.com Preserve SkNWayCanvas::onFlush
2023-06-22 bsalomon@google.com Fold SkMatrixProvider into SkBaseDevice and remove it.
2023-06-22 weiyuhuang@google.com Add `applyRoundingHack` to `ParagraphStyle`
2023-06-22 brianosman@google.com Remove all usage of SkMatrixProvider outside of SkDevice.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 23:28:29 +00:00
godofredoc
51e1adf23c Add missing android lint to linux_unopt. (flutter/engine#43099) 
The test was not migrated to v2.

Bug: https://github.com/flutter/flutter/issues/127759

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 22:25:10 +00:00
skia-flutter-autoroll
784eaf4e31 Roll Skia from 273f4cf92b7e to cb44fca83da0 (2 revisions) (flutter/engine#43107) 
https://skia.googlesource.com/skia.git/+log/273f4cf92b7e..cb44fca83da0

2023-06-22 nicolettep@google.com [graphite] Batch of Vulkan fixes for running dm
2023-06-22 jvanverth@google.com [graphite] Add Vulkan Linux bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 22:20:47 +00:00
utzcoz
23d3ca2e2b [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965) 
Make Robolectric tests work with SDK 33. The Robolectric doesn't support create presentation window now, so this CL also adds a custom presentation shadow to hook showing state to make related tests work.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 20:33:57 +00:00
skia-flutter-autoroll
5a20ffdb0a Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106) 
https://skia.googlesource.com/skia.git/+log/09b36b8ce0db..273f4cf92b7e

2023-06-22 michaelludwig@google.com Revert "[skif] Update lighting image filters to use FilterResult"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 20:30:10 +00:00
Lau Ching Jun
574191ed36 Workaround a release blocker after libc++ change (flutter/engine#43091) 
The code breaks in C++20 mode after libc++ removes comparisons for `std::vector` and replaces them with 'operator <=>'.

See cl/542541552 for context.
 2023-06-22 19:33:44 +00:00
skia-flutter-autoroll
bb015ab8c5 Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102) 
https://skia.googlesource.com/skia.git/+log/8168c802c391..09b36b8ce0db

2023-06-22 brianosman@google.com Avoid division by zero in emboss mask filter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 19:21:06 +00:00
Brandon DeRosier
05d4a13865 [Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093) 
Resolves https://github.com/flutter/flutter/issues/128353.
Reverts https://github.com/flutter/engine/pull/43087.

Reland without the kDecal usage -- we don't need it after the last
iteration of fixes.
 2023-06-22 11:38:19 -07:00
Brandon DeRosier
034f5e4edf [Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094) 
Fixes uncontrolled crash when kDecal is used (as seen on
https://github.com/flutter/engine/pull/43087).
 2023-06-22 11:35:15 -07:00
Jesse Seales
baef7fd849 Use minor version, ignore patches for CodeQL (flutter/engine#43088) 
The patches of CodeQL updated by dependabot were causing too many engine PRs. This change updates to allow for dependabot to just use minor versions.

*List which issues are fixed by this PR. You must list at least one issue.*
Addresses https://github.com/flutter/flutter/issues/112911

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-22 18:22:49 +00:00
Dan Field
b6fa0a20a5 Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928) 
Fixes https://github.com/flutter/flutter/issues/128746

Prints a warning the first time a platform channel sends a message from the wrong thread with instructions/link to the site about how to fix this.
 2023-06-22 18:16:40 +00:00
skia-flutter-autoroll
97c396add6 Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096) 
https://skia.googlesource.com/skia.git/+log/3f3e1da4b7eb..8168c802c391

2023-06-22 michaelludwig@google.com [skif] Update lighting image filters to use FilterResult
2023-06-22 jacksongardner@google.com Fix assert logic.
2023-06-22 johnstiles@google.com Eliminate remaining vestiges of SkVM.
2023-06-22 johnstiles@google.com Remove SkVM codegen support from SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 18:08:03 +00:00
Jonah Williams
5c56768c14 [Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089) 
Also forces the creation of a stencil attachment always on Android to reduce the number of PSO variants.

https://github.com/flutter/flutter/issues/129050
 2023-06-22 17:51:49 +00:00
Mouad Debbar
907fcd3245 [web] Don't get break type from v8BreakIterator (flutter/engine#43053) 
In some languages, when the text contains a new line "\n", the `v8BreakIterator` starts returning different values from `breakType()`. This caused our code to think that those line breaks were hard line breaks when in fact they were soft line breaks. Still unclear if this is a `v8BreakIterator` bug or a wrong expectation on our side regarding how `breakType()` is supposed to work.

Instead of using `v8BreakIterator.breakType()`, let's do the `soft` vs `hard` detection ourselves (we already have all the necessary pieces).

Fixes https://github.com/flutter/flutter/issues/127379
 2023-06-22 17:35:44 +00:00
Jonah Williams
0b17d31261 Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061) 
Reverts flutter/engine#42944

This didn't improve any of the benchmarks, which I think at least disproves my theory on overloading. Lets go back to the prior strategy and look for improvements elsewhere.
 2023-06-22 17:19:42 +00:00
Jonah Williams
635a109a6d [Impeller] Add fence waiter trace event. (flutter/engine#43092) 
I suspect that some of the worst frame times are caused by submission blocking on adding a fence. Add a trace event that would make that obvious.

![unnamed](https://github.com/flutter/engine/assets/8975114/93650ac8-4451-49d7-b8fa-00fc9f7f4277)
 2023-06-22 17:17:48 +00:00
Jonah Williams
aa890e3d65 [Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085) 
At least from what I've found online, this API is already safe to call from multiple threads. From testing, at startup the presence of the mutex is adding ~100ms to shader creation time, as all compilations across N threads are fighting for the same lock.

https://github.com/flutter/flutter/issues/129050
 2023-06-22 16:23:44 +00:00
Zachary Anderson
85aa1a0f7c Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087) 
Reverts flutter/engine#43028

An engine roll containing only this commit turned the framework tree red with a crasher on Android. I'm a bit concerned because it looked like one of the benchmarks that crashed should not have been using Impeller see https://github.com/flutter/flutter/pull/129353 and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_blur_backdrop_filter_perf__timeline_summary/1120/overview
 2023-06-22 15:41:24 +00:00
skia-flutter-autoroll
f62f444425 Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:37:50 +00:00
skia-flutter-autoroll
db6192d93c Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080) 
https://skia.googlesource.com/skia.git/+log/117f57a53215..3f3e1da4b7eb

2023-06-22 johnstiles@google.com Remove `transformT` SkVM helpers from gradient code.
2023-06-22 kjlubick@google.com Completely remove graphite #ifdefs from subruncontainer
2023-06-22 kjlubick@google.com Move VertexFiller::boundsAndDeviceMatrix impl to src/graphite
2023-06-22 kjlubick@google.com Move VertexFiller::fillInstanceData to src/graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:21:57 +00:00
skia-flutter-autoroll
fdbdf29c04 Roll Skia from 5013b651f8ec to 117f57a53215 (1 revision) (flutter/engine#43078) 
https://skia.googlesource.com/skia.git/+log/5013b651f8ec..117f57a53215

2023-06-22 herb@google.com Cubic intersections for glyph underlines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 14:10:27 +00:00
skia-flutter-autoroll
84df708771 Roll Skia from 71047dca9f77 to 5013b651f8ec (4 revisions) (flutter/engine#43073) 
https://skia.googlesource.com/skia.git/+log/71047dca9f77..5013b651f8ec

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 15156b1da43d to ac263582dda4 (7 revisions)
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b8f1a3ad5f9e to afd97bf1e914 (1 revision)
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7fe8d8d9b147 to 44d5e772a1fb
2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3189ad2cb814 to 7fe8d8d9b147 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 09:20:53 +00:00
Brandon DeRosier
f2dfbd9193 [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028) 
Resolves https://github.com/flutter/flutter/issues/128353.

Depends on https://github.com/flutter/engine/pull/43026.

* Maps the texel coordinate space correctly relative to the geometry
pixel coordinates.
* Use decal sampling for subpass textures.
* Simplify the computation by using new rect utilities such as
`Rect::Project`.
 2023-06-22 01:13:37 -07:00
Dan Field
a535f5635f [Impeller] Fix up coverage hints for blending/vertices, fix TiledTextureContents::RenderToSnapshot (flutter/engine#43017) 
Fixes https://github.com/flutter/flutter/issues/128329
Fixes https://github.com/flutter/flutter/issues/128807

The panorama example app is still not quite visually on par with skia - the scaling or filtering or something isn't quite as nice as in the skia backend - but it does render now and no longer tries to create gigantical textures.
 2023-06-22 03:20:36 +00:00
Tamir Duberstein
fd56ab9e44 Remove process-local tempfs (flutter/engine#43056) 
This was incorrectly made read-only in 0984c52a8f; instead of implementing it locally, ask the component manager for the directory.
 2023-06-22 02:46:23 +00:00
skia-flutter-autoroll
78e9b58804 Roll Skia from 0185ce148be9 to 076e7c004d20 (2 revisions) (flutter/engine#43069) 
https://skia.googlesource.com/skia.git/+log/0185ce148be9..076e7c004d20

2023-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bcc1118ec796 to 23a32754e715 (6 revisions)
2023-06-22 armansito@google.com [graphite][compute] PathAtlas and ComputePathAtlas classes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 02:26:48 +00:00
skia-flutter-autoroll
caa0802bad Roll Skia from 96d6135e9ee8 to 0185ce148be9 (4 revisions) (flutter/engine#43068) 
https://skia.googlesource.com/skia.git/+log/96d6135e9ee8..0185ce148be9

2023-06-21 armansito@google.com [graphite] Support ClipStack evaluation without side effects
2023-06-21 johnstiles@google.com Remove SkUpdatableColorShader class.
2023-06-21 johnstiles@google.com Remove SkVMBlitter class.
2023-06-21 armansito@google.com [graphite] Fix local coords in Bitmap and SDF text renderers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 01:15:17 +00:00
Brandon DeRosier
0caad561d9 [Impeller] Uniquely label subpasses and root blit (flutter/engine#43015) 
Makes subpasses easier to identify in frame captures.
 2023-06-21 17:18:15 -07:00
Brandon DeRosier
cec295a528 [Impeller] Add Rect::Project (flutter/engine#43026) 
- Utility to project a rectangle onto another rectangle.
- Fix constness for Rect::Expand.
- Add named methods for scaling.
 2023-06-21 17:17:51 -07:00
skia-flutter-autoroll
e2c36cac36 Roll Skia from 32e953e71266 to 96d6135e9ee8 (1 revision) (flutter/engine#43067) 
https://skia.googlesource.com/skia.git/+log/32e953e71266..96d6135e9ee8

2023-06-21 brianosman@google.com SkDraw no longer uses SkMatrixProvider

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 23:39:57 +00:00
skia-flutter-autoroll
091c429506 Roll Fuchsia Linux SDK from 4mkuVtlGBaumKSe8x... to 7EZeNE4aGd29VfDly... (flutter/engine#43066) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 23:04:47 +00:00
skia-flutter-autoroll
82bafb3517 Roll Skia from 7eeb94b1e778 to 32e953e71266 (17 revisions) (flutter/engine#43064) 
https://skia.googlesource.com/skia.git/+log/7eeb94b1e778..32e953e71266

2023-06-21 johnstiles@google.com Remove class SkFilterColorProgram.
2023-06-21 brianosman@google.com Use MatrixRec in legacy shader context code
2023-06-21 johnstiles@google.com Delete SkVM program()/onProgram() callbacks.
2023-06-21 johnstiles@google.com Turn off mechanisms which can enable SkVM.
2023-06-21 kjlubick@google.com Remove SkCanvas::flush() from Skia-proper and remove other gpu-specific code
2023-06-21 brianosman@google.com SkShaderBase::ContextRec only needs paint alpha
2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from ba42f5db9450 to 0fde633f706b (6 revisions)
2023-06-21 nicolettep@google.com [graphite] Move SkSL and shader module logic from Vulkan resource provider to graphics pipeline
2023-06-21 kjlubick@google.com Break SkTestCanvas.cpp off into own file list to put only in GPU builds
2023-06-21 herb@google.com Change SubRunType to SubRunStreamTag
2023-06-21 jvanverth@google.com [graphite] Add Vulkan Windows Debug test job
2023-06-21 herb@google.com Reland "De-SkScalar SkRect"
2023-06-21 johnstiles@google.com Remove SkVM JIT.
2023-06-21 robertphillips@google.com Fix tasks.json
2023-06-21 sharaks@google.com Update Skia milestone to 117
2023-06-21 robertphillips@google.com [graphite] Move tiled rendering helper function to TiledTextureUtils
2023-06-21 sharaks@google.com Merge 15 release notes into RELEASE_NOTES.md

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 22:34:18 +00:00
Márk Tolmács
f41c1644d8 Enabling pre-push checks on Windows (flutter/engine#36123) 
Re-submit the changes to enable windows pre-push checks.

This patch changes how `ci/bin/format.dart` generate diffs from `diff` and `patch` commands to `git diff` and `git apply` in order to have a common method for these operations on all platforms. Windows installations don't have diff and patch commands available by default and many implementations which provide such commands work differently than the UN*X tools. Git however works consistently across all platforms.

Additionally, this patch also changes the python executable in some of the pre-push components affected by this to `vpython3` to continue the effort started at flutter/flutter#108474 and I also removed the `--no-sound-null-safety` parameter in the ci/format.sh, ci/format.bat files

NOTE: Since the original patch caused some issues, I suggest that this should be tested more carefully before it is merged.

### Issues fixed by this PR
* flutter/flutter#108122
* flutter/flutter#107920
* flutter/flutter#86506
* flutter/flutter#106615

### [flutter/tests] repo impact
None.

writing and running engine tests.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 17:20:06 +00:00
godofredoc
f039068b13 Document the use of contexts on engine_v2 tests. (flutter/engine#43013) 
Contexts are predefined python contexts that can be dynamically added to the test execution.

Bug: https://github.com/flutter/flutter/issues/129187

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 16:43:33 +00:00
godofredoc
853bdd7bd7 Generate treemap. (flutter/engine#43029) 
Engine V2 was not generating the size treemap. This change will start uploading the size treemap to the test logs.

Bug: https://github.com/flutter/flutter/issues/128482

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 16:28:09 +00:00
skia-flutter-autoroll
c1b1c6cdfe Roll Skia from c983b97d03a8 to 7eeb94b1e778 (4 revisions) (flutter/engine#43045) 
https://skia.googlesource.com/skia.git/+log/c983b97d03a8..7eeb94b1e778

2023-06-21 kjlubick@google.com Add filegroups to support G3 builds
2023-06-21 fmalita@chromium.org Manual Roll Dawn from 0d5e76a2427f to ba42f5db9450 (19 revisions)
2023-06-21 herb@google.com Only inline midpoint
2023-06-21 robertphillips@google.com [graphite] Update some GMs to use Graphite ContextOptions overrides

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 16:01:13 +00:00
godofredoc
1567bc1600 Move android emulator tests to v2. (flutter/engine#43008) 
These tests have been running on staging successfully for a few days.

Bug: https://github.com/flutter/flutter/issues/127680

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-21 15:26:00 +00:00
skia-flutter-autoroll
69577428b6 Roll Skia from 65f30e5804c7 to c983b97d03a8 (2 revisions) (flutter/engine#43044) 
https://skia.googlesource.com/skia.git/+log/65f30e5804c7..c983b97d03a8

2023-06-21 robertphillips@google.com [graphite] Add ContextOptions override for Graphite (in dm)
2023-06-21 robertphillips@google.com Move the Ganesh version of DrawTiledBitmap to its own file (and rename)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 14:50:22 +00:00
skia-flutter-autoroll
e6ce69365e Roll Skia from 7121db7c6dc2 to 65f30e5804c7 (3 revisions) (flutter/engine#43043) 
https://skia.googlesource.com/skia.git/+log/7121db7c6dc2..65f30e5804c7

2023-06-21 kjlubick@google.com Remove SkTestCanvas from public.bzl
2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f0fc1de57d41 to bcc1118ec796 (7 revisions)
2023-06-21 kjlubick@google.com Add decoder #includes to implementation files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 13:44:29 +00:00
skia-flutter-autoroll
d8a2471082 Roll Fuchsia Linux SDK from 41wcREjd9roHDS1jM... to 4mkuVtlGBaumKSe8x... (flutter/engine#43038) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 08:09:17 +00:00
skia-flutter-autoroll
c176702eff Roll Skia from a6412350122e to 7121db7c6dc2 (3 revisions) (flutter/engine#43037) 
https://skia.googlesource.com/skia.git/+log/a6412350122e..7121db7c6dc2

2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 84379a529407 to 15156b1da43d (14 revisions)
2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3189ad2cb814 to 7fe792ac4552
2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ab08126079d3 to 3189ad2cb814 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 07:16:03 +00:00
skia-flutter-autoroll
c87f7f691b Roll Skia from efc045c15fdd to a6412350122e (2 revisions) (flutter/engine#43036) 
https://skia.googlesource.com/skia.git/+log/efc045c15fdd..a6412350122e

2023-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ae667fe96db9 to b8f1a3ad5f9e (2 revisions)
2023-06-21 kjlubick@google.com Move SkTestCanvas impl to its own cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 05:58:59 +00:00
Bruno Leroux
8aff00a5d8 [Android] Return the keyboard pressed state (flutter/engine#42758) 
## Description

This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in https://github.com/flutter/flutter/pull/122885).

This is a rework of https://github.com/flutter/engine/pull/41695 which was reverted in https://github.com/flutter/engine/pull/42346.

This issue with https://github.com/flutter/engine/pull/41695 was that the framework side did not get an answer when the channel was setup in the engine without registering a handler (on the engine side) to handle framework requests. The issue was reproducible when the engine initialization was managed by the app (see https://github.com/flutter/flutter/issues/122441#issuecomment-1582052616 for a repro).

This PR fixes this issue by changing `flutter/keyboard` lifecycle: the engine now creates the channel and registers a handler just after the channel creation.
In order to avoid regression, this PR also updates the channel implemenation (see `KeyboardChannel`) to return an empty `HashMap` when there is no handler registered.

## Related Issue

Android engine implementation for https://github.com/flutter/flutter/issues/87391
(see https://github.com/flutter/engine/pull/42346 for Linux implementation)
Fixes https://github.com/flutter/flutter/issues/122441

## Tests

Adds 3 tests.
 2023-06-21 05:49:06 +00:00