1232 Commits

Author SHA1 Message Date
Phil Quitslund
802eca29d2
set literal conversions (#27811) 2019-03-06 11:05:16 -08:00
Amir Hardon
5099701f88
Make RenderUiKitView reject absorbed touch events (#28666)
When a touch event that is in the bounds of a RenderUiKitView is absorbed by another render object,
the RenderUiKitView's handleEvent is not called for that object. On the platform side, the touch event hits the FlutterTouchInterceptingView which is waiting for a framework decision that never arrived on whether to reject or accept the gesture.

This change fixes the issue by having RenderUiKitView register a global PointerRoute, that is used to reject absorbed touch events.
2019-03-04 14:26:50 -08:00
Mouad Debbar
b94bf87c70
Text selection via mouse (#28290) 2019-03-01 13:57:10 -08:00
Alexandre Ardhuin
387f885481
Add missing trailing commas (#28673)
* add trailing commas on list/map/parameters

* add trailing commas on Invocation with nb of arg>1

* add commas for widget containing widgets

* add trailing commas if instantiation contains trailing comma

* revert bad change
2019-03-01 08:17:55 +01:00
Greg Spencer
ccdd50578c
Fix spelling errors. (#28657)
Fix the spelling errors in the dartdocs for the framework.

There are no functionality changes here, just documentation fixes.
2019-02-28 15:37:19 -08:00
xster
ec00e974d0
Add long-press-move support for text fields 2 (#28242) 2019-02-25 14:34:54 -08:00
Gary Qian
7b5a769b31
Force line height in TextFields with strut (#27612) 2019-02-23 03:35:37 -08:00
Alexandre Ardhuin
5169ab5974
format parameter list (#27261) 2019-02-21 09:27:07 +01:00
Ali EP
307848953f Fixes crossAxisSpacing overflow in RTL (#27945) 2019-02-20 15:43:01 -08:00
Sander Kersten
d1136e3109 Fix issue where SliverPersistentHeader that is both floating and pinned would scroll down when scrolling past the beginning of the ScrollView (#27433) 2019-02-20 15:42:15 -08:00
Michael Goderbauer
655800260a
Add TextOverflow.visible (#28182) 2019-02-20 15:40:25 -08:00
xster
39b1ff1aa3
revert 26001 (#28032) 2019-02-20 15:34:44 -08:00
Hans Muller
19f79ac8da
Add extendBody parameter to Scaffold, body MediaQuery reflects BAB height (#27973) 2019-02-15 14:48:39 -08:00
Michael Goderbauer
a4de06ade0
Reapply "Fix overflow clipping/fading for text (#27892)" (#27980)
Fixes https://github.com/flutter/flutter/issues/25025
2019-02-15 09:37:33 -08:00
Greg Spencer
262f12b4a9
Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793)
This converts all remaining "## Sample code" segments into snippets, and fixes
the snippet generator to handle multiple snippets in the same dartdoc block
properly.

I also generated, compiled, and ran each of the existing application samples,
and fixed them up to be more useful and/or just run without errors.

This PR fixes these problems with examples:

1. Switching tabs in a snippet now works if there is more than one snippet in
   a single dartdoc block.
2. Generation of snippet code now works if there is more than one snippet.
3. Contrast of text and links in the code sample block has been improved to
   recommended levels.
4. Added five new snippet templates, including a "freeform" template to make
   it possible to show examples that need to change the app instantiation.
5. Fixed several examples to run properly, a couple by adding the "Scaffold"
   widget to the template, a couple by just fixing their code.
6. Fixed visual look of some of the samples when they run by placing many
   samples inside of a Scaffold.
7. In order to make it easier to run locally, changed the sample analyzer to
   remove the contents of the supplied temp directory before running, since
   having files that hang around is problematic (only a problem when running
   locally with the `--temp` argument).
8. Added a `SampleCheckerException` class, and handle sample checking
   exceptions more gracefully.
9. Deprecated the old "## Sample code" designation, and added enforcement for
   the deprecation.
10. Removed unnecessary `new` from templates (although they never appeared in
   the samples thanks to dartfmt, but still).

Fixes #26398
Fixes #27411
2019-02-15 07:48:49 -08:00
xster
22f8880909
Make sure the selection is still painted under the text (#27970) 2019-02-14 16:50:06 -08:00
Michael Goderbauer
d1707ab0ad
Revert "Fix overflow clipping/fading for text (#27892)" (#27966)
This reverts commit 46cabdab22ce59ba06949d666216ae4d10b76761.
2019-02-14 15:15:01 -08:00
Michael Goderbauer
46cabdab22
Fix overflow clipping/fading for text (#27892) 2019-02-13 13:49:00 -08:00
Raouf Rahiche
964fab0205 fix small typo (#27659)
just a small typo 
the word "the constraints" is duplicated
2019-02-12 15:54:50 -08:00
xster
892c8919c7
Add long-press-drag cursor move support on iOS (#26001) 2019-02-12 15:10:48 -08:00
Matt Carroll
a13fdbcf32
Implemented Dark Mode for Android (#25525) (#26605) 2019-02-06 16:52:47 -08:00
xster
ee30499a7e
Stop using SelectionChangedCause internally to show the text selection toolbar (#27534) 2019-02-06 14:39:14 -08:00
Greg Spencer
da27f62337
Make a kReleaseMode constant that is public. (#27502)
Before this, we had several places where an isReleaseMode was defined, all with the same definition. This just makes it more broadly visible to allow our users to use it, as well as creating debug and profile versions, and adding a device lab test for it.

Since this is a const value, this makes it possible for a developer to easily mark blocks that can be removed at AOT compile time.
2019-02-06 14:37:17 -08:00
xster
32b9c2f07e
Add more RenderEditable test coverage (#27003) 2019-02-05 00:54:54 -08:00
Matt Carroll
92125ed38f
Enable dependency injection of Window instead of using static property (#27389) 2019-02-04 16:46:04 -08:00
Gary Qian
c6cc3cdeda
Integrate Strut: Add StrutStyle, expose Strut API, wire up strut with dart:ui, Roll engine 31a7f4d..e7eb1c8 (7 commits) (#26332)
Includes a breaking change to dart:ui ParagraphStyle where lineHeight is renamed to height for consistency with TextStyle.
2019-02-04 10:17:25 -08:00
liyuqian
16d3847847
Fix typo "when when" (#27413) 2019-02-01 15:04:51 -08:00
Michael Goderbauer
6d20ff2446
Remove all obsolete "// ignore:" (#27271) 2019-01-30 08:56:12 -08:00
Alexandre Ardhuin
ef276ffea5
format initializer list of constructors (#27111) 2019-01-29 21:47:16 +01:00
Konstantin Scheglov
4fe41abfcc
Add default values for optional parameters. (#27197) 2019-01-29 11:49:57 -08:00
Greg Spencer
1811d57445
Implement hover support for mouse pointers. (#24830)
This implements support for hovering mouse pointers, so that mice connected to Android devices, and ChromeOS devices running Android apps will work properly.

It teaches flutter_test about hover events, which required changing how they are created and used.

Also modifies AnnotatedRegion to allow a region that can be located someplace other than just the origin.

Along with tests for all of the above.

Fixes #5504
2019-01-29 11:34:26 -08:00
Michael Goderbauer
c9d5b129e2
Remove obsolete ignore: (#27199) 2019-01-29 10:36:53 -08:00
jslavitz
d2a2a5cfe2
Adds a fade in and out, rounds corners, fixes offset and fixes height of cursor on iOS (#24876)
* Fixes cursor on iOS devices
2019-01-28 19:49:19 -08:00
Jonah Williams
04546cc69c
prevent _computeColumnWidths from getting stuck due to double precision (#27112) 2019-01-25 23:37:19 -08:00
Alexandre Ardhuin
66f424f0f8
fix some bad indentations (#26921)
* fix some bad indentations

* remove suspicious line
2019-01-23 15:43:27 +01:00
Michael Goderbauer
56039b4ba7
Make getOffsetToReveal work with nested Viewports (#26663)
Fixes #20893, the most-upvoted bug for framework.

A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
2019-01-17 11:03:07 -08:00
Kyrel Jerome
a0f58c5e7a Grammatical fix: "places" to "placed" (#26482) 2019-01-16 10:43:29 -08:00
Michael Goderbauer
e4c8f1b993
3D SemanticsTree (#25670) 2019-01-16 10:29:00 -08:00
Chris Bracken
584ef083c7
Replace Android-specific check with switch (#24754)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-15 19:42:55 -08:00
Michael Goderbauer
f3f2d5a1bd
Remove TODO, reduce tech debt (#26612)
I fixed this TODO a while ago during my a11y work.
2019-01-15 19:06:07 -08:00
Amir Hardon
cbff7ca43c
Cleanup temporary catchError. (#26454)
This was added to make sure we don't crash before the engine is rolled
with the system channel API addition and is no longer needed.
2019-01-15 10:13:48 -08:00
jslavitz
4377083810
Selects a word on force tap (#25683)
* adds force press select word functionality
2019-01-14 10:29:51 -08:00
matthew-carroll
517f8dc279
Add consumedScrollExtent to SliverConstraints as reported by Viewport (#24551) 2019-01-09 12:34:54 -08:00
Hans Muller
4ad3d99b20
Fix a floating snapping SliverAppBar crash (#26101) 2019-01-07 09:04:55 -08:00
Amir Hardon
50f9b88395
Actively reject UiKitView gestures. (#25792)
flutter/engine#7307 changes the engine side of embedded UIView to only
reject gestures when the framework sends a `rejectGesture` message, so
that gesture resolution can done after a touch sequence has ended (see
PR description for flutter/engine#7307 for more details).

This change makes the framework send a `rejectGesture` message to the
engine when a UiKitView rejects a gesture.

I'm planning to land this PR before the engine side change, so right now
it swallows the exception thrown if there is no engine implementation
for `rejectGesture` (which keeps us with the current behavior). After
this change lands I'll land the engine PR, and then clean up the part
that swallows the exception.
2018-12-26 19:34:53 -08:00
Justin McCandless
9161ec42cb
Include cursor in textfield intrinsic width measurement (#25055)
* Include cursor in textfield intrinsic width measurement

* Add cursorWidth assertion, add comment about assumed cursor width, and test null stepWidth
2018-12-26 08:56:02 -08:00
Ian Hickson
e239872561
ClipPath.shape and related fixes (#24816) 2018-12-23 15:21:11 -08:00
Alexandre Ardhuin
19ce65eec9
no period after an alone link in see also section (#25604) 2018-12-21 19:23:42 +01:00
xster
b8a035a3d4
Adds CupertinoTheme (#23759) 2018-12-18 20:36:35 -08:00
Alexandre Ardhuin
e41f1463cd
make see also sections uniform (#25513) 2018-12-18 21:45:20 +01:00