1006 Commits

Author SHA1 Message Date
Shi-Hao Hong
d3c864de06
Add endIndent property to Divider and VerticalDivider (#34057)
* Fixed indent to properly add to the top and not to the start

* Updated Divider documentation
2019-06-07 18:32:17 -07:00
Anthony
e1d0ded926
[Material] Create a themable Range Slider (continuous and discrete) (#31681)
Creates a Material Design range slider.

The range slider is based off the updated slider, with the main difference being that it has 2 thumbs.
By default, the thumbs cannot pass each other and both the thumb and the value indicator create a stroke when they are overlapping for better visibility.
2019-06-06 15:31:02 -04:00
Kate Lovett
005fa1c689
Updating names to correct versioning convention (#33865) 2019-06-06 12:15:44 -07:00
Jason Simmons
95818d2b7a
Reland "Framework support for font features in text styles" (#33876)
See https://github.com/flutter/flutter/issues/31691
2019-06-05 16:36:05 -07:00
MH Johnson
1b87f558d5
[Material] Add support for hovered, pressed, and focused text color on Buttons. (#33090)
* Support for stateful text colors in buttons

* Add color and a11y tests for buttons
2019-06-05 15:46:53 -04:00
Justin McCandless
a35d6615ee
Double double tap toggles instead of error (#33802)
Fix exception that was happening when double-double-tapping a TextField (or double long tapping).
2019-06-04 10:39:08 -07:00
Justin McCandless
fce54ae685
Handles hidden by keyboard (#32838)
Extra space when scrolling to selected input so that the selection caret is visible.
2019-06-04 08:37:29 -07:00
Kate Lovett
04015b987b
Fixing duplicate test names. (#33805) 2019-06-04 07:01:52 -07:00
Jonah Williams
7442eeafe5
Reland https://github.com/flutter/flutter/pull/33663 (#33828) 2019-06-04 00:41:21 -07:00
Todd Volkert
6d554827b6
Revert "Use conditional imports for flutter foundation libraries (#33663)" (#33825)
This reverts commit 90500a5dc4341dd41f3ae0d99fc92daa5ffd2a9c.
2019-06-03 22:00:45 -07:00
Todd Volkert
cb90617911
Revert "ModalRoute resumes previous focus on didPopNext (#33152)" (#33815)
This reverts commit 0f2254a5c334b2435167083b48e681f4fb18acd4.
2019-06-03 17:24:56 -07:00
Jonah Williams
90500a5dc4
Use conditional imports for flutter foundation libraries (#33663) 2019-06-03 14:56:15 -07:00
chunhtai
730025fa17
fix issue 14014 read only text field (#32059) 2019-06-03 14:00:43 -07:00
Jonah Williams
6619ab8fea
Add web safe indirection to Platform.isPlatform getters (2) (#33780) 2019-06-03 13:16:14 -07:00
Jonah Williams
cd1d40a7c9
Revert "Add web safe indirection to Platform.isPlatform getters (#33406)" (#33776)
This reverts commit d92b3b40d2113a216bdfd7c2c69d9d0f4d905a0d.
2019-06-03 11:08:30 -07:00
Jonah Williams
d92b3b40d2
Add web safe indirection to Platform.isPlatform getters (#33406) 2019-06-03 10:55:36 -07:00
Tong Mu
0f2254a5c3
ModalRoute resumes previous focus on didPopNext (#33152)
This PR changes ModalRoute so that, when the route on top of it is popped, it requests to focus on the last focus.
2019-05-31 14:15:20 -07:00
Justin McCandless
d963e4fe35
Text selection handles are sometimes not interactive (#31852)
The text selection handles now feel a lot more responsive, and their implementation was cleaned up a bit.
2019-05-30 12:31:18 -07:00
Tong Mu
fa3fbc89a3
Material allows "select all" when not collapsed (#32950)
This PR enables "Select all" on MaterialTextSelection when text is partially selected.
2019-05-30 10:03:31 -07:00
LongCatIsLooong
22ea031e28
Fix ScrollbarPainter thumbExtent calculation and add padding (#31763)
- Fixed extentInside calculation in ScrollMetrics
- Added asserts to extentInside getter, as well as ScrollPosition.applyContentDimensions to enforce minScrollExtent <= maxScrollExtent
- Added padding to ScrollbarPainter, updated implementation. Took care of some edge cases.
- Changed some scroll bar constants on Cupertino side.
2019-05-29 16:52:21 -07:00
Darren Austin
252a14ba2f
Fixed for DropdownButton crashing when a style was used that didn't include a fontSize (#33474)
Fixed an issue with a DropdownButton crashing when a style was used that didn't include a fontSize.
2019-05-29 13:18:34 -07:00
Jonah Williams
2d9b158faf
Revert "Framework support for font features in text styles (#33230)" (#33444)
This reverts commit 841286d652379a6e9f1e95d54c8c9e628f4f1d5c.
2019-05-28 11:35:03 -07:00
Harry Terkelsen
13e9bfcc94
Add binaryMessenger constructor argument to platform channels (#30406)
* Deprecates `BinaryMessages` in favor of a default instance of `BinaryMessenger`, called `defaultBinaryMessenger`
* Platform channels use the `defaultBinaryMessenger` for their binaryMessenger default argument.
2019-05-28 11:18:22 -07:00
Jason Simmons
841286d652
Framework support for font features in text styles (#33230)
See https://github.com/flutter/flutter/issues/31691
2019-05-28 11:06:54 -07:00
Jonah Williams
a656bcf54f
rename test file that misnamed (#33361) 2019-05-28 09:56:13 -07:00
Chris Bracken
4d9923201b
Correct typos (#33322)
Corects a bnuch of typeos throuhgout teh Fluter codebsae.

Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Shi-Hao Hong
9d52085344
ExpandIcon Custom Colors (#33148)
* Implement ExpandIcon custom color, expandedColor, and disabledColor

* Update to use pumpAndSettle instead of hard-coded duration

* Update colors to unfocused state, added dark mode test to active state

* Fix Colors.white30 doc opacity value

* Add links to Material Design specifications to color, expandedColor and disabledColor

* Update API docs to reference dark theme material page
2019-05-24 09:06:23 -07:00
Justin McCandless
6031c56d4c
Material Long Press Text Handle Flash (#32911)
Fix a bug where holding down on text selection caused the handles to flash. The fix was to only update selection when it actually changed.
2019-05-23 08:15:59 -07:00
Shi-Hao Hong
3265e15925
SliverAppBar shape property (#33073) 2019-05-21 08:30:58 -07:00
Greg Spencer
d31ce31a27
Update enabled color for outlined text fields. (#33083)
Resets the enabled color for outline text field default borders to "On Surface 38%" instead of "On Surface 12%" to match spec. Also fixes the hover overlay to be "On Surface 12%" to match spec.
2019-05-20 17:25:59 -07:00
Greg Spencer
d0c603d0bb
Turn off container focus highlight for filled text fields. (#33062)
This turns off focus highlight for filled text fields, since it turns out not to be to spec.
2019-05-20 13:39:53 -07:00
Greg Spencer
47a9ddc803
Make hover and focus not respond when buttons and fields are disabled. (#32914)
Disabled fields and buttons were responding to hover and focus changes, and they shouldn't.
2019-05-18 14:58:38 -07:00
Greg Spencer
76dccbe2fb
Use reverseDuration on Tooltip and InkWell. (#32904)
This puts the new AnimationController reverseDuration argument to use in two places: focus for InkWells and fade out for Tooltips.
2019-05-18 12:56:40 -07:00
Greg Spencer
9f21ae0de5
Text field focus and hover support. (#32776)
This adds support for an animated focusColor and hoverColor to InputDecorator. This color will blend with the background over a fade in period whenever the InputDecorator is focused or hovered, respectively.

It also adds a Listener to the TextField to listen for hover events.
2019-05-16 17:31:46 -07:00
chunhtai
3f92640521
Visual selection is not adjusted when changing text selection with TalkBack (#32832) 2019-05-16 14:41:39 -07:00
Greg Spencer
c8dbd00199
Skip flaky date picker tests on Windows (#32817)
Date picker tests have been flaky on Windows for a long time, and repeatedly require restarting of bots. In the interest of productivity, disabling them on Windows.

Related to #19696
2019-05-16 09:31:05 -07:00
Darren Austin
3d93f24c05
Tapping a modal bottom sheet should not dismiss it by default (#32528)
Removed the GestureDetector from the modal bottom sheet that dismissed it on tap and updated several tests to accommodate this change.
2019-05-15 15:50:39 -07:00
MH Johnson
da0a3a275a
[Material] Remove inherit: false on default TextStyle in bottom navigation bar (#32727) 2019-05-15 10:30:41 -04:00
Greg Spencer
bb3c660522
Implements focus handling and hover for Material buttons. (#31438)
This implements focus and hover handling for Material buttons. It inserts Focus widgets into the tree in order to allow buttons to be focusable via keyboard traversal (a.k.a. TAB traversal), and Listener widgets into the InkWell to allow the detection of hover states for widgets.

Addresses #11344, #1608, and #13264.
2019-05-14 20:48:29 -07:00
Darren Austin
752147e2b1
Added 'enabled' property to the PopupMenuButton (#32527)
Added 'enabled' property to the PopupMenuButton to allow the button to be disabled in the case where the menu would be empty.
2019-05-14 15:48:13 -07:00
Mouad Debbar
bcae3563d4
Redo: Show/hide toolbar and handles based on device kind (#32704) 2019-05-14 11:04:16 -07:00
Mouad Debbar
ef5abcc6bf
Revert "Show/hide toolbar and handles based on device kind (#29683)" (#32702)
This reverts commit 18ca37542d8e946724f1ccc41b6d7c98c28d7164.
2019-05-14 09:33:04 -07:00
Mouad Debbar
18ca37542d
Show/hide toolbar and handles based on device kind (#29683) 2019-05-14 08:50:23 -07:00
Greg Spencer
a5053bfb29
Fix transforms for things with RenderPointerListeners (#32535)
This fixes #32525, because it now marks the compositing bits as needing to be recalculated if the mouse tracker changes its idea of whether or not a mouse is attached.

This bug occurred because the test framework was leaking state from one test to the next (the state about whether a mouse pointer was active), and so even though there was a "passing" test when run in order with the other tests in the file, when the test was run individually (or first), it would have failed and caught the bug.

This adds an assert to make sure that after each test there are no simulated mouse pointers connected, and now calls removePointer in all of the tests where this was a problem.
2019-05-13 15:48:12 -07:00
Kate Lovett
829bdeb426
Fixing accidental merge from WIP branch. (#32520)
Revert "Merge branch 'master' into master"

This reverts commit e3a03c04c4530b06e77383fd73d2c43644dc832a, reversing
changes made to 64749826498123e795c77f9bec8cea804a40a051.
2019-05-10 15:53:41 -07:00
Kate Lovett
e3a03c04c4
Merge branch 'master' into master 2019-05-10 15:16:40 -07:00
Hans Muller
6d0e235cf8
Support for replacing the TabController, after disposing the old one (#32434) 2019-05-09 22:02:46 -07:00
Greg Spencer
d2fe08628d
Implements FocusTraversalPolicy and DefaultFocusTraversal features. (#30076)
This implements a DefaultFocusTraversal widget to describe the focus traversal policy for its children, defined by a FocusTraversalPolicy object from which custom policies may be created. Pre-defined policies include widget-order traversal, "reading order" traversal and directional traversal.
2019-05-09 20:24:23 -07:00
Michael Goderbauer
1621baafc7
Introduce separate HitTestResults for Box and Sliver (#31894) 2019-05-09 10:00:01 +02:00
chunhtai
21efdff8a5
fix issue 32212 Text field keyboard selection crashes (#32256) 2019-05-07 15:07:11 -07:00