2511 Commits

Author SHA1 Message Date
Jonah Williams
7f7c00a4e9
Enable web foundation tests (#34032) 2019-06-09 11:03:46 -07:00
Shi-Hao Hong
d3c864de06
Add endIndent property to Divider and VerticalDivider (#34057)
* Fixed indent to properly add to the top and not to the start

* Updated Divider documentation
2019-06-07 18:32:17 -07:00
Gary Qian
c2eaf8359d
Reland "Text inline widgets, TextSpan rework (#30069)" with improved backwards compatibility (#34051) 2019-06-07 15:47:23 -07:00
Amir Hardon
362b999b90
Revert "Prevent exception being thrown on hasScrolledBody (#31485)" (#34061)
This reverts commit ab707aca8f82688c6a3cb46801ce9b39d138ac60.
2019-06-07 12:43:27 -07:00
Jonah Williams
42a14b5891
Compatibility pass on flutter/foundation tests for JavaScript compilation. (1) (#33349) 2019-06-06 21:22:00 -07:00
Gary Qian
4e5cf5efb0
Revert "Reland "Text inline widgets, TextSpan rework" (#33946)" (#34002)
This reverts commit 14414f350ac040f9626f1aa0b3071f42cc9136a6.
2019-06-06 18:25:36 -07:00
Michael Goderbauer
926bc6231a
Remove print (#34004) 2019-06-06 16:26:12 -07:00
Amir Hardon
7d27550f6f
Respond to AndroidView focus events. (#33901)
When an AndroidView gains focus we invoke the(newly introduced)
'TextInput.setPlatformViewClient' text_input system channel method
which sets the platform view as the text input target.

When the AndroidView loses focus we send a clearFocus message to
platform views system channel(so the engine can clear the focus from
the platform view).

This PR is going to land before the engine implementation is rolled to
the framework, we swallow MissingPluginException for the newly
introduced method channel methods so this is a no-op before the engine
is ready(after the engine is rolled with the corresponding change I'll
remove the logic to swallow the exceptions).

The engine counterpart is in: flutter/engine#9203
2019-06-06 14:49:31 -07:00
Anthony
e1d0ded926
[Material] Create a themable Range Slider (continuous and discrete) (#31681)
Creates a Material Design range slider.

The range slider is based off the updated slider, with the main difference being that it has 2 thumbs.
By default, the thumbs cannot pass each other and both the thumb and the value indicator create a stroke when they are overlapping for better visibility.
2019-06-06 15:31:02 -04:00
Kate Lovett
005fa1c689
Updating names to correct versioning convention (#33865) 2019-06-06 12:15:44 -07:00
Michael Goderbauer
9114f4456c
Add localFocalPoint to ScaleDetector (#33955) 2019-06-06 11:09:39 -07:00
sjindel-google
f83df74b6b
Don't print warning message when running benchmarks test. (#33842)
# Description
Currently the benchmarks test prints a scary warning message, even when it passes, that a benchmark is being run with asserts enabled.

Normally we don't want developers to do this, because the performance of code with asserts is not characteristic of what end-users will experience. However, we need to unit-test benchmarkWidgets, so I've added a contraindicated option to suppress the warning for the test.

# Related Issues
25049 (comment)
2019-06-06 19:39:32 +02:00
Zachary Anderson
366dcb1588
Revert engine back to afb9d510c3bb0f1b97980434b41200a2d3491697 (#33982)
Revert "Add currentSystemFrameTimeStamp to SchedulerBinding (#33886)"

This reverts commit 61b83d320e9149828ffb5e39e1da6d14d281c0c2.
2019-06-06 09:50:45 -07:00
Gary Qian
14414f350a
Reland "Text inline widgets, TextSpan rework" (#33946) 2019-06-05 18:14:17 -07:00
Michael Goderbauer
61b83d320e
Add currentSystemFrameTimeStamp to SchedulerBinding (#33886) 2019-06-05 18:02:01 -07:00
Greg Spencer
947bd7524a
Fix a bug in Shortcuts with synonyms, and add tests. (#33949)
This fixes a rather embarrassing bug in ShortcutManager that happened because I forgot to add the tests I meant to add.

This fixes the bug, and adds the tests.
2019-06-05 17:13:25 -07:00
Jason Simmons
95818d2b7a
Reland "Framework support for font features in text styles" (#33876)
See https://github.com/flutter/flutter/issues/31691
2019-06-05 16:36:05 -07:00
Greg Spencer
f0978c225a
Game controller button support (#33868)
This adds support for game controller buttons. It adds some supplemental USB HID codes that aren't available from the Chromium source code, and maps those on Android to the game pad buttons that Android supports. Other platforms are not supported yet.
2019-06-05 16:23:17 -07:00
K. P. Sroka
ab707aca8f Prevent exception being thrown on hasScrolledBody (#31485)
Convert scheduling to use `scheduleMicrotask` instead of `Timer.run`
2019-06-05 13:30:59 -07:00
MH Johnson
1b87f558d5
[Material] Add support for hovered, pressed, and focused text color on Buttons. (#33090)
* Support for stateful text colors in buttons

* Add color and a11y tests for buttons
2019-06-05 15:46:53 -04:00
Gary Qian
2db7918eb5
Revert "Text inline widgets, TextSpan rework (#33794)" (#33928)
This reverts commit 86862c1e625b97966594b772c88527a5302dd6cc.
2019-06-05 11:35:46 -07:00
Gary Qian
86862c1e62
Text inline widgets, TextSpan rework (#33794)
* Merge in changes for inline widgets

* Make analyzer happy, fix tests

* Fix analyzer

* Add missing doc

* Docs on RichText

* Fix analyzer some more

* Remove whitespace at end of line

* Update goldens

* Text fixes

* Analyzer
2019-06-04 16:27:53 -07:00
Greg Spencer
387e2b0602
Add actions and keyboard shortcut map support (#33298)
This implements the keyboard shortcut handling and action invocation in order to provide a place in the infrastructure for keyboard events to trigger actions. This will allow binding of key events to actions like "move the focus to the next widget" and "activate button".
2019-06-04 11:30:24 -07:00
Justin McCandless
a35d6615ee
Double double tap toggles instead of error (#33802)
Fix exception that was happening when double-double-tapping a TextField (or double long tapping).
2019-06-04 10:39:08 -07:00
Tong Mu
c482edac4f
Revert "Move declaration of semantic handlers from detectors to recognizers (#33475)" (#33851)
This reverts commit 572f349f5c7db7a783870ea8d4ecc641a365563f.
2019-06-04 10:13:15 -07:00
Justin McCandless
fce54ae685
Handles hidden by keyboard (#32838)
Extra space when scrolling to selected input so that the selection caret is visible.
2019-06-04 08:37:29 -07:00
Kate Lovett
04015b987b
Fixing duplicate test names. (#33805) 2019-06-04 07:01:52 -07:00
Jonah Williams
7442eeafe5
Reland https://github.com/flutter/flutter/pull/33663 (#33828) 2019-06-04 00:41:21 -07:00
Todd Volkert
6d554827b6
Revert "Use conditional imports for flutter foundation libraries (#33663)" (#33825)
This reverts commit 90500a5dc4341dd41f3ae0d99fc92daa5ffd2a9c.
2019-06-03 22:00:45 -07:00
Greg Spencer
a70b020e18
Add pseudo-key synonyms for keys like shift, meta, alt, and control. (#33695)
This adds a list of key synonyms for non-printable keyboard keys that appear in more than one place So keys like LogicalKeyboardKey.shiftLeft and LogicalKeyboardKey.shiftRight now can be mapped to just LogicalKeyboardKey.shift.

I also fixed a bug in the gen_keycodes tool where GLFW entries would get removed if they weren't parsed from the source on the web.
2019-06-03 18:41:04 -07:00
Todd Volkert
cb90617911
Revert "ModalRoute resumes previous focus on didPopNext (#33152)" (#33815)
This reverts commit 0f2254a5c334b2435167083b48e681f4fb18acd4.
2019-06-03 17:24:56 -07:00
Tong Mu
572f349f5c
Move declaration of semantic handlers from detectors to recognizers (#33475)
- A refactor that moves the semantics declaration from detectors to recognizers to allow custom recognizers to respond to semantic gectures.
- Renames all handlers related to semantics from Gesture* to Semantics*.
2019-06-03 15:07:23 -07:00
Jonah Williams
90500a5dc4
Use conditional imports for flutter foundation libraries (#33663) 2019-06-03 14:56:15 -07:00
chunhtai
730025fa17
fix issue 14014 read only text field (#32059) 2019-06-03 14:00:43 -07:00
Todd Volkert
5441044132
Revert "Update consolidateHttpClientResponseBytes() to use compressionState (#33729)" (#33790)
This reverts commit 306a09a384e6ba0fe02ae3a44d28ceeb372b3a25.
2019-06-03 13:48:27 -07:00
Jonah Williams
6619ab8fea
Add web safe indirection to Platform.isPlatform getters (2) (#33780) 2019-06-03 13:16:14 -07:00
Jonah Williams
cd1d40a7c9
Revert "Add web safe indirection to Platform.isPlatform getters (#33406)" (#33776)
This reverts commit d92b3b40d2113a216bdfd7c2c69d9d0f4d905a0d.
2019-06-03 11:08:30 -07:00
Jonah Williams
d92b3b40d2
Add web safe indirection to Platform.isPlatform getters (#33406) 2019-06-03 10:55:36 -07:00
SimonIT
683238e82a Fix disabled CupertinoTextField style (#32974) 2019-06-03 10:34:47 -07:00
Todd Volkert
306a09a384
Update consolidateHttpClientResponseBytes() to use compressionState (#33729)
This updates to use the new HttpClientResponse.compressionState
API that was recently added in the SDK.

https://github.com/flutter/flutter/issues/32374
2019-06-03 09:50:21 -07:00
Michael Goderbauer
ae23d4a490
Transform PointerEvents to the local coordinate system of the event receiver (#32192) 2019-05-31 16:48:50 -07:00
Todd Volkert
56940b544f
Update FadeInImage to use new Image APIs (#33370)
This updates FadeInImage to use the new Image.frameBuilder
API (added in #33369), to greatly simplify the implementation
of FadeInImage.

This also removes the FadeInImage.placeholderSemanticLabel property.
This property was added in #28799 for the sake of completeness (the bug
it fixed was the lack of any semantic label support in FadeInImage), but a
placeholder is a transient visual artifact, not something that affects the
underlying semantic meaning of the image.
2019-05-31 14:42:48 -07:00
Tong Mu
0f2254a5c3
ModalRoute resumes previous focus on didPopNext (#33152)
This PR changes ModalRoute so that, when the route on top of it is popped, it requests to focus on the last focus.
2019-05-31 14:15:20 -07:00
Justin McCandless
d963e4fe35
Text selection handles are sometimes not interactive (#31852)
The text selection handles now feel a lot more responsive, and their implementation was cleaned up a bit.
2019-05-30 12:31:18 -07:00
Todd Volkert
cba41ca2ec
Remove assert from Image._handleImageFrame() (#33602)
Tickers being disabled and re-enabled can cause the
condition of a synchronous notification happening after
image frames have been delivered, which is valid in that
case. As such, this removes the assert.

https://github.com/flutter/flutter/issues/32374
2019-05-30 12:04:01 -07:00
Gary Qian
2cb5b24b02
Fix text scaling of strut style (#33462) 2019-05-30 10:13:17 -07:00
Tong Mu
fa3fbc89a3
Material allows "select all" when not collapsed (#32950)
This PR enables "Select all" on MaterialTextSelection when text is partially selected.
2019-05-30 10:03:31 -07:00
Greg Spencer
07aede4c31
Fix onExit calling when the mouse is removed. (#33477)
This PR solves two problems: currently, the onExit is called for a mouse pointer the moment the removal message is received, except that by the time it actually calls it, there is no _lastEvent for it in the mouse tracker (it's already been removed), resulting in an event being passed to the onExit that contains nulls for the position. Also, removePointer events don't actually get created with a position, although they easily could be, so that even the the _lastEvent in the mouse tracker were still populated, it would still give a null position and delta.

This PR adds support for the position and delta in a PointerRemovedEvent, and populates them. In addition, when a remove event is received, it doesn't actually remove the pointer until the mouse position check that gets scheduled actually happens.
2019-05-30 09:55:38 -07:00
chunhtai
bfc6df0e4f
fixed 33347 fill the gap during performLayout in SliverGrid and SliverFixedExtentList (#33467) 2019-05-30 09:24:02 -07:00
Jonah Williams
6feedcc6a4
use toFixedAsString and DoubleProperty in diagnosticProperties (#33488) 2019-05-30 08:57:10 -07:00