skia-flutter-autoroll
7f7beceb8e
Roll Skia from bef4d9b44369 to 2cead39756d8 (1 revision) ( flutter/engine#51899 )
...
https://skia.googlesource.com/skia.git/+log/bef4d9b44369..2cead39756d8
2024-04-04 kjlubick@google.com Reland "Fix defines for icu_subset"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 13:04:21 +00:00
skia-flutter-autoroll
bf0d686ce3
Roll Skia from 57bc01affec1 to 5fdc2b47dfa4 (1 revision) ( flutter/engine#51894 )
...
https://skia.googlesource.com/skia.git/+log/57bc01affec1..5fdc2b47dfa4
2024-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2fe35697982b to 596fa6121849 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 06:49:22 +00:00
Jonah Williams
e8b33af103
[Impeller] dont inc shared_ptr count for every command/pipeline in render_pass_vk ( flutter/engine#51874 )
...
We have to pay to inc/dec the shared_ptr, but all pipelines are persisted indefinitely so we shouldn't need to worry about dangling ptrs.
2024-04-04 02:45:35 +00:00
Jonah Williams
97b286ca62
[Impeller] cleanup auto usage in host_buffer ( flutter/engine#51875 )
...
Remove some autos, make some things const refs, move some shared_ptrs.
2024-04-03 23:30:21 +00:00
skia-flutter-autoroll
c44eed8805
Roll Skia from 82ae8ae5d3fb to fdbdb26b7029 (1 revision) ( flutter/engine#51886 )
...
https://skia.googlesource.com/skia.git/+log/82ae8ae5d3fb..fdbdb26b7029
2024-04-03 kjlubick@google.com Remove legacy Metal GrBackendTexture functions
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 23:12:18 +00:00
Matan Lurey
ff07b1f586
Remove the bringup 20x emulator config. ( flutter/engine#51885 )
...
I didn't end up learning much from this, other than I wish JSON had macros.
*Just kidding, sort of.
2024-04-03 22:47:23 +00:00
skia-flutter-autoroll
4070b03ae8
Roll Skia from 7d6dce620e46 to 82ae8ae5d3fb (2 revisions) ( flutter/engine#51883 )
...
https://skia.googlesource.com/skia.git/+log/7d6dce620e46..82ae8ae5d3fb
2024-04-03 bungeman@google.com [gn_to_cmake] Handle `group` better
2024-04-03 jvanverth@google.com [graphite] Add the ColorspaceXform for the YUV shader via Compose.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 22:13:04 +00:00
Jonah Williams
b951d15850
[scenarios] Use adb to take screenshot, block on screenshot operation. ( flutter/engine#51879 )
...
Use the screenshotUtil signal to have the runner take a screenshot with adb. Block the screenshotter until this has completed.
2024-04-03 22:11:22 +00:00
skia-flutter-autoroll
4059931118
Roll Dart SDK from 85adde7d4b5a to 5b812b9ec220 (2 revisions) ( flutter/engine#51884 )
...
https://dart.googlesource.com/sdk.git/+log/85adde7d4b5a..5b812b9ec220
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-18.0.dev
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-17.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 21:59:24 +00:00
skia-flutter-autoroll
f10717b549
Roll Skia from 8d7482b998d0 to 7d6dce620e46 (1 revision) ( flutter/engine#51878 )
...
https://skia.googlesource.com/skia.git/+log/8d7482b998d0..7d6dce620e46
2024-04-03 egdaniel@google.com [Graphite] Reduce resouce key size for vk desc sets.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 20:59:31 +00:00
Jackson Gardner
228c22e017
Be slightly more lenient about the assertion, as it differs on different backends. ( flutter/engine#51877 )
...
We shouldn't assume the exact format of the assertion string here, as the exact output is slightly different on dart2js vs ddc vs dart2wasm. They should all contain the message text, however.
2024-04-03 20:15:07 +00:00
skia-flutter-autoroll
0d4318275e
Roll Skia from afa233bb1979 to 8d7482b998d0 (2 revisions) ( flutter/engine#51876 )
...
https://skia.googlesource.com/skia.git/+log/afa233bb1979..8d7482b998d0
2024-04-03 jvanverth@google.com [graphite] Separate YUV sampling in shader from YUV-to-RGB conversion
2024-04-03 kjlubick@google.com Add GCC compile job to CQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 19:55:59 +00:00
Chinmay Garde
22be0b9fa4
[Impeller] Enable logging a warning when the user opts out of using Impeller. ( flutter/engine#51849 )
...
Part of https://github.com/flutter/flutter/issues/144439
This does two things:
* Logs a warning when the embedder requests a non-Impeller preference when creating a shell.
* Makes the iOS embedder request a warning be logged when Impeller is not used.
I decided to put the warning logs in the shell so that as we get more opinionated about Impeller on other platforms, those platforms can just flip a flag with common log origin.
2024-04-03 19:52:51 +00:00
Jonah Williams
fc55cde395
[Impeller] delete unused code. ( flutter/engine#51871 )
...
This might not be linted due to side effects of the method.
2024-04-03 19:40:36 +00:00
Jonah Williams
958a9aa859
[Impeller] eliminate sub-render pass for blended color + texture vertices. ( flutter/engine#51778 )
...
Fixes https://github.com/flutter/flutter/issues/145707
Part of https://github.com/flutter/flutter/issues/131345
If we're drawing vertices with per-color, a non-advanced blend, and a texture (with or without coordinates), use the porter duff shader to perform the blend without creating a sub render pass. IN addition to being more performant, this eliminates any potential rendering bugs caused by overlapping vertices.
This is not yet fixed for advanced blends.
2024-04-03 19:34:57 +00:00
skia-flutter-autoroll
3b6a0eb693
Roll Skia from 67f7b4d08d1f to afa233bb1979 (5 revisions) ( flutter/engine#51872 )
...
https://skia.googlesource.com/skia.git/+log/67f7b4d08d1f..afa233bb1979
2024-04-03 bungeman@google.com [dm] Fix TSAN reports about "done"
2024-04-03 kjlubick@google.com [bazel] Fix Android gms and benchmark POC
2024-04-03 kjlubick@google.com Revert "Zero-initialize Vec components to avoid MSan warnings"
2024-04-03 dcheng@chromium.org Zero-initialize Vec components to avoid MSan warnings
2024-04-03 dcheng@chromium.org Zero initialize context var used to smuggle swizzle control bytes.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 19:00:52 +00:00
skia-flutter-autoroll
ce130dad17
Roll Skia from 1d9340cf193e to 67f7b4d08d1f (1 revision) ( flutter/engine#51865 )
...
https://skia.googlesource.com/skia.git/+log/1d9340cf193e..67f7b4d08d1f
2024-04-03 egdaniel@google.com [Graphite] Reduce key generation of vulkan descriptor sets.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 17:26:00 +00:00
Jonah Williams
483338a49e
[scenarios] dont do a weird invalidate on TextView. ( flutter/engine#51866 )
...
I am now investigating why this is needed.
2024-04-03 17:18:10 +00:00
skia-flutter-autoroll
1bf17c308d
Roll Skia from ce3b5e8eb59b to 5f6223a01ba4 (1 revision) ( flutter/engine#51863 )
...
https://skia.googlesource.com/skia.git/+log/ce3b5e8eb59b..5f6223a01ba4
2024-04-03 robertphillips@google.com [graphite] Use X-macro to get better UniqueKey printouts (take 2)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 15:11:42 +00:00
skia-flutter-autoroll
16a2e393fd
Roll Skia from a247f8cc2a66 to ce3b5e8eb59b (24 revisions) ( flutter/engine#51861 )
...
https://skia.googlesource.com/skia.git/+log/a247f8cc2a66..ce3b5e8eb59b
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8f8193a59b53 to 98844beffb30 (17 revisions)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 432730a5288e to 43f849a0e433 (1 revision)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5d294e6e34ff to ff03a7b193da (11 revisions)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f3bc379a831a to 2fe35697982b (2 revisions)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ff61926fcedb to 62c59c41e194 (1 revision)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 66304f4f36ad to 2fe35697982b
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Skia Infra from 58b480b2288d to f3bc379a831a (6 revisions)
2024-04-02 robertphillips@google.com [graphite] Implement RuntimeEffect toLinearSrgb/fromLinearSrgb handling
2024-04-02 armansito@google.com Revert "[vello] Enable the bump allocation estimator"
2024-04-02 bungeman@google.com [paragraph] Clean up tests
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 48184ca84103 to 432730a5288e (3 revisions)
2024-04-02 hitawala@chromium.org Reland "Add FCC, YDZDX, GBR, SMPTE240 color space support"
2024-04-02 armansito@google.com [vello] Enable the bump allocation estimator
2024-04-02 michaelludwig@google.com [graphite] Cache read view on DrawContext
2024-04-02 armansito@google.com [graphite][vello] Use ScratchBuffers for all bindings
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from defc2fa459b6 to 934b734ed72a (1 revision)
2024-04-02 johnstiles@google.com Add SkBitmap::setColorSpace.
2024-04-02 nicolettep@google.com [graphite] Allow backends to append information to graphite sampler keys
2024-04-02 johnstiles@google.com Fix GraphiteStartGM initialization.
2024-04-02 michaelludwig@google.com [graphite] Check for null recorder before caps
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 319732cc90e4 to 48184ca84103 (1 revision)
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c6a6d3f9fa69 to 5d294e6e34ff (6 revisions)
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 58b480b2288d to 7d5d18ff3722
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from df0949e75440 to 58b480b2288d (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 13:52:23 +00:00
skia-flutter-autoroll
6575603e21
Roll Dart SDK from 892ec6169844 to 36b6628190e2 (1 revision) ( flutter/engine#51860 )
...
https://dart.googlesource.com/sdk.git/+log/892ec6169844..36b6628190e2
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-15.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 10:49:23 +00:00
skia-flutter-autoroll
91ce1f10bc
Roll Dart SDK from 091dd9120d35 to 892ec6169844 (3 revisions) ( flutter/engine#51859 )
...
https://dart.googlesource.com/sdk.git/+log/091dd9120d35..892ec6169844
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-14.0.dev
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-13.0.dev
2024-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-12.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 06:45:47 +00:00
Matan Lurey
0619d4193f
Use non-deprecated replacements for Android JUnit and test instrumentation ( flutter/engine#51854 )
...
Just removing some of the noise of walking through Java files in Android Studio, should be a NO-OP[^1].
- `androidx.test.runner.AndroidJUnit4` -> `androidx.test.ext.junit.runners.AndroidJUnit4`
- `androidx.test.InstrumentationRegistry` -> `androidx.test.platform.app.InstrumentationRegistry`
[^1]: Famous last words.
2024-04-03 04:26:14 +00:00
Jonah Williams
aa63d0d282
[Impeller] make color source a variant instead of a closure. ( flutter/engine#51853 )
...
This would also me to create a type safe visitor to pull out the data required for https://github.com/flutter/engine/pull/51778
2024-04-03 03:42:04 +00:00
Zachary Anderson
9404f5112e
Revert "Prevent solo: true from being committed" ( flutter/engine#51858 )
...
Reverts flutter/engine#51712
Reason for revert: As discussed in
https://github.com/flutter/flutter/issues/143312 , and in
https://discord.com/channels/608014603317936148/1224499330824802375 . I
apologize if this seems hasty and not fully justified, but it is
important that the engine repo follows policies like this to make it
easier for our various teams to work together.
2024-04-02 20:19:12 -07:00
Michael Goderbauer
b71942aadb
Remove outdated deprecated_member_use ignores ( flutter/engine#51836 )
...
These are obsolete with https://github.com/flutter/engine/pull/50575 .
2024-04-03 02:28:51 +00:00
Matan Lurey
86a137cf79
Use internal retries for SurfaceTexture and Impeller tests too. ( flutter/engine#51856 )
...
Similar to https://github.com/flutter/engine/pull/51838 .
2024-04-03 02:25:15 +00:00
Zachary Anderson
87162bdc8a
[et] Prepare local_engine.json for CI, teach et to understand local build names ( flutter/engine#51803 )
...
This is steps (2) and (3) of
https://github.com/flutter/flutter/issues/145263 .
The next steps after this are to:
1. Fix any issues that come up when running `local_engine.json` in CI.
1. Step (4) of https://github.com/flutter/flutter/issues/145263
1. Fill in some missing builds in `local_engine.json`.
2024-04-02 19:21:15 -07:00
gaaclarke
75d7c6fc7b
[Impeller] fixes PlusAdvanced alpha blending / adds alpha blending tests ( flutter/engine#51787 )
...
https://github.com/flutter/engine/pull/51756 had a bug in it when src
alpha was not 1. There was no test coverage for this. I've added the fix
and test coverage for all the blends.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-02 16:58:35 -07:00
Jason Simmons
296d677a7c
Add an engine switch that controls whether the platform isolate API is available. ( flutter/engine#51784 )
...
Platform isolates are currently supported only on Android and iOS.
See https://github.com/flutter/flutter/issues/136314
2024-04-02 22:47:04 +00:00
Matan Lurey
e4d88c98a4
Run DrawSolidBlueScreenTest 20x in a row in bringup (up from 5x) ( flutter/engine#51850 )
...
I'm hoping this increases the chance of a flake by ~4x, as that would help me debug https://github.com/flutter/flutter/issues/145988 .
Also removed `--verbose`, which wasn't valuable (just made the "filtered" logs harder to read).
2024-04-02 22:33:54 +00:00
Jason Simmons
e67380cbf1
Return an empty optional in HardwareBuffer::GetSystemUniqueID if the underlying NDK API is unavailable ( flutter/engine#51839 )
2024-04-02 22:33:51 +00:00
Matan Lurey
5084d0b432
Use fml::ScopedCleanupClosure instead of DeathRattle. ( flutter/engine#51834 )
...
Closes https://github.com/flutter/flutter/issues/146105 .
Originally when we authored these suites, `ScopedCleanupClosure` disallowed move-semantics, but that was fixed in https://github.com/flutter/engine/pull/45772 , so there is no reason to have a copy of these in different tests.
/cc @jonahwilliams
2024-04-02 22:33:48 +00:00
Tong Mu
bf68661eba
Remove the view ID check in macOS/FlutterCompositor ( flutter/engine#51852 )
...
This PR removes the view ID check added in https://github.com/flutter/engine/pull/51738 , which has been causing a test `FlutterEngineTest.CompositorIgnoresUnknownView`, added in https://github.com/flutter/engine/pull/51436 , to fail.
This problem was missed by the CI because the test and the view ID check were added in two PRs recently and they were not using the latest engine to check.
The view ID check is not needed anyway, and is only a temporary check until the multiview support is landed.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-02 22:17:36 +00:00
Matan Lurey
d3cc586a58
Do not use adb shell screenrecord during CI runs. ( flutter/engine#51848 )
...
This introduced quite a bit of flakiness because the system UI sometimes (???) reappears:
2024-04-02 21:08:31 +00:00
Loïc Sharma
b363028a18
[Embedder API] Add view ( flutter/engine#51523 )
...
Adds `FlutterEngineAddView` to the embedder API. This will be used to add a view.
Design doc: https://flutter.dev/go/multi-view-embedder-apis
Part of https://github.com/flutter/flutter/issues/144806
Part of https://github.com/flutter/flutter/issues/142845
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-02 21:04:54 +00:00
Jackson Gardner
fea11e834d
[skwasm] Fix Paragraph.getLineBoundary ( flutter/engine#51846 )
...
The Skia APIs I was previously using were returning `-1` for `paragraphGetLineNumberAt` when querying at the end of the string. I changed the implementation to be identical to what CanvasKit and the native Paragraph object are doing.
2024-04-02 20:31:56 +00:00
Chinmay Garde
2a07f9e53a
Allow creating slimpeller engine variants. ( flutter/engine#51824 )
...
Fixes https://github.com/flutter/flutter/issues/144432
2024-04-02 20:21:53 +00:00
Jonah Williams
444c075779
[Impeller] fix plus blend mode in porterduff shader. ( flutter/engine#51792 )
...
DrawAtlas already has the optimization in https://github.com/flutter/engine/pull/51778 and so it is still rendering incorrectly with wide gamut.
2024-04-02 20:21:52 +00:00
auto-submit[bot]
0434a4332f
Reverts "Replace WindowInsetsController... with adb shell commands ( #51843 )" ( flutter/engine#51847 )
...
Reverts: flutter/engine#51843
Initiated by: matanlurey
Reason for reverting: broke tree because the bottom bar now shows up.
Original PR Author: matanlurey
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
Previously our screenshots looked like this (when they ran correctly):
Now, sometimes (only on CI unfortunately) they look like this:
This started happening after https://github.com/flutter/engine/pull/51832 , but the change should be future-proof as well even if we disable the screen recording feature.
h/t @reidbaker
2024-04-02 19:32:48 +00:00
Matan Lurey
e124b252ae
Replace WindowInsetsController... with adb shell commands ( flutter/engine#51843 )
...
Previously our screenshots looked like this (when they ran correctly):
Now, sometimes (only on CI unfortunately) they look like this:
This started happening after
https://github.com/flutter/engine/pull/51832 , but the change should be
future-proof as well even if we disable the screen recording feature.
h/t @reidbaker
2024-04-02 10:01:59 -07:00
K Lubick
4ec8483024
Use moved GrBackendTexture factories for Skia's Metal backend ( flutter/engine#51828 )
...
In https://skia-review.googlesource.com/c/skia/+/833302 , Skia moved the
constructors for Metal versions of GrBackendTexture (and other
functions/methods). This updates uses in Flutter to use the new APIs.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-04-02 11:49:15 -04:00
dependabot[bot]
ff48787ccd
Bump actions/setup-python from 5.0.0 to 5.1.0 ( flutter/engine#51841 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.0.0 to 5.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases ">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Leveraging the raw API to retrieve the version-manifest, as it does not impose a rate limit and hence facilitates unrestricted consumption without the need for a token for Github Enterprise Servers by <a href="https://github.com/Shegox "><code>@âShegox</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/766 ">actions/setup-python#766</a>.</li>
<li>Dependency updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> and <a href="https://github.com/HarithaVattikuti "><code>@âHarithaVattikuti</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/817 ">actions/setup-python#817</a></li>
<li>Documentation changes for version in README by <a href="https://github.com/basnijholt "><code>@âbasnijholt</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/776 ">actions/setup-python#776</a></li>
<li>Documentation changes for link in README by <a href="https://github.com/ukd1 "><code>@âukd1</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/793 ">actions/setup-python#793</a></li>
<li>Documentation changes for link in Advanced Usage by <a href="https://github.com/Jamim "><code>@âJamim</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/782 ">actions/setup-python#782</a></li>
<li>Documentation changes for avoiding rate limit issues on GHES by <a href="https://github.com/priya-kinthali "><code>@âpriya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/835 ">actions/setup-python#835</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/basnijholt "><code>@âbasnijholt</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/776 ">actions/setup-python#776</a></li>
<li><a href="https://github.com/ukd1 "><code>@âukd1</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/793 ">actions/setup-python#793</a></li>
<li><a href="https://github.com/Jamim "><code>@âJamim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/782 ">actions/setup-python#782</a></li>
<li><a href="https://github.com/Shegox "><code>@âShegox</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/766 ">actions/setup-python#766</a></li>
<li><a href="https://github.com/priya-kinthali "><code>@âpriya-kinthali</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/835 ">actions/setup-python#835</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0 ">https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="82c7e631bbhttps://redirect.github.com/actions/setup-python/issues/835 ">#835</a>)</li>
<li><a href="10aa35afd7https://redirect.github.com/actions/setup-python/issues/766 ">#766</a>)</li>
<li><a href="9a7ac94420https://redirect.github.com/actions/setup-python/issues/817 ">#817</a>)</li>
<li><a href="871daa956chttps://redirect.github.com/actions/setup-python/issues/782 ">#782</a>)</li>
<li><a href="2f078955e4https://redirect.github.com/actions/setup-python/issues/793 ">#793</a>)</li>
<li><a href="e9d6f99097https://redirect.github.com/actions/setup-python/issues/776 ">#776</a>)</li>
<li>See full diff in <a href="0a5c615913...82c7e631bbhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=5.0.0&new-version=5.1.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-02 05:46:22 +00:00
skia-flutter-autoroll
6f2999789b
Roll Skia from fe64c32d7f2e to cd75e4672719 (1 revision) ( flutter/engine#51833 )
...
https://skia.googlesource.com/skia.git/+log/fe64c32d7f2e..cd75e4672719
2024-04-01 bungeman@google.com [paragraph] TypefaceFontProvider impl more FontMgr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-02 02:02:23 +00:00
Matan Lurey
1ff20bb3db
Move scenario_app integration tests back to max_attempts: 2. ( flutter/engine#51838 )
...
This seems to be the flakiest target, and is/was making our CI red all day.
Related: https://github.com/flutter/flutter/issues/145988 .
2024-04-02 00:56:14 +00:00
auto-submit[bot]
3bca0bb5c9
Reverts "[Impeller] Avoid loading redundant Vulkan extensions. ( #51818 )" ( flutter/engine#51835 )
...
Reverts: flutter/engine#51818
Initiated by: chinmaygarde
Reason for reverting: VK_EXT_queue_family_foreign needs to be explicitly enabled even though the documentation stays that 1.1 is a dependency (https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_queue_family_foreign.html#_extension_and_version_dependencies ). Broke validation enabled builds downstream. https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20hello_world_impeller/3118/ov
Original PR Author: chinmaygarde
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
All dependencies of VK_ANDROID_external_memory_android_hardware_buffer were enabled earlier. But I didn't realize that those extensions became core in Vulkan 1.1. There is no need to load them unnecessarily. It just makes the extensions requirements look more complicated than they are.
Just deletes code. No change in functionality.
2024-04-01 23:08:30 +00:00
Matan Lurey
a70095b10c
Run and record adb shell screenrecord during Android scenario app ( flutter/engine#51832 )
...
More grasping at straws to solve https://github.com/flutter/flutter/issues/145988 .
At some point this could be moved to `--verbose` if it isn't useful.
This will automatically be copied into `${FLUTTER_LOGS_DIR}`, yay!
Example:
https://github.com/flutter/engine/assets/168174/c8caca7a-88ec-4d09-88bd-ebfc531f6512
2024-04-01 22:49:47 +00:00
skia-flutter-autoroll
abe6506bda
Roll Skia from 0b0ed6ca101b to fe64c32d7f2e (4 revisions) ( flutter/engine#51831 )
...
https://skia.googlesource.com/skia.git/+log/0b0ed6ca101b..fe64c32d7f2e
2024-04-01 egdaniel@google.com Reland "Add compressed texture support to graphite."
2024-04-01 kjlubick@google.com Revert "Fix defines for icu_subset"
2024-04-01 kjlubick@google.com Fix some c++20 warnings
2024-04-01 armansito@google.com [graphite][compute] Buffer clear at DispatchGroup granularity
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 22:42:17 +00:00
Matan Lurey
f8b8fafd60
Run the DrawSolidBlueScreenTest 5x in a row in bringup builds. ( flutter/engine#51829 )
...
Trying to reproduce https://github.com/flutter/flutter/issues/145988
outside of texture tests.
/cc @ricardoamador
2024-04-01 14:47:52 -07:00
Matan Lurey
4ae59a2770
Remove tests related to StrictMode that were never running on CI. ( flutter/engine#51827 )
...
Closes https://github.com/flutter/flutter/issues/60635 as not planned.
2024-04-01 21:26:58 +00:00
