This just extracts arguments to the TextInputClient.setClient async
method call into an NSDictionary local to reduce the deep
indentation of the formatted code.
While the bulk of these calls are identical and could be extracted to a
utility function, or a class extension method like
`handleDefaultSetClientCall`, the point of these tests is to exercise
FlutterTextInputPlugin, and the message protocol over the channel are
precisely what's being tested, so it makes sense to keep these
explicit.
Followup patch to https://github.com/flutter/engine/pull/39632.
Issue: https://github.com/flutter/flutter/issues/120252
* working commit
* some clean up
* white space fixes
* whitespace
* remove unused import
* Addressing PR comment, fix tests, update touch packet on Andriod
* formatting n whitespace again
* add new field to web ui pointer.dart
* update test
* whitespace
* fix test
* PR comments
* fix test
* whitespace
* fix test by factoring out logic into helper function
* whitespace
* fix malformed string
* pr comments
* fix type issue
* sigh whitespace
* revert test changes :)
* pr comments + separate out tests
* extra space
* change test name
* Implemented wide gamut images for iOS
Moved the surface to an extended range color format.
* wrong gamma but default pixel format set to bgra10_xr
* BGR10_XR add
* format
* updated todos
* updated todo with information about pixel formats
* switched logic for determining if we have a wide gamut image
* cleaned up gamut math to match style and linked source
* made the color attachment pixel format match the surface
* updated vulkan format switch
* removed comment
* added enable disable switch
* moved default to bgr10 for now since there is a bug where someone is still reading this, msaa?
* fixed the decoder settings to make sure we don't lose wide gamut colors
* fixed stored srgb gamut variable
* fixed false lint
* updated test
* added ability to grab the surface data for tests
* made the screenshot utility return the format
* added width and height to the platform channel payload
* fixed a couple of broken targets
* moved back the default pixel buffer format
* cleanup and add docstrings
* made the surfacedata feature only available in debug builds
* added decoding unit test
* fixed objc tests
* turned off by default
* bdero feedback1
* bdero2
* bdero3
* fixed merge issue
* removed using std::shared_ptr
Adds marks to cleanly separate the sections of TextInputPlugin when
viewing in XCode and other IDEs that recognise #pragma mark. This file
is getting pretty long.
No tests since this is a cleanup with no functional changes.
By default, autocomplete is enabled during text input on macOS. On Macs
with the touchbar enabled, the current text input and any suggested
autocompletions are listed in the touchbar.
This adds support for disabling autocomplete when autofill is disabled,
when obscureText is set in the text input configuration, and when the
autofill hint type is "password" or "username". When an AutofillGroup is
in use, we disable autocomplete for all fields within the group when any
of the fields disables autocomplete.
While OS-level autocomplete support is far more robust on iOS, this
behaviour matches our enable/disable state management behaviour on that
platform.
Issue: https://github.com/flutter/flutter/issues/119824
* [Windows] Remove accessibility root assumptions
* Improve tests
* Improve comment
* Use helper
* Add TODO
* Fix
* Make test more thorough
* Add assertion
* More assertions
* Format
* Tweak comments based off feedback
When there are PlatformViews on the screen (threads merged), Flutter engine cannot consistently hit 120 fps, especially when the PlatformView is animating (scrolling etc), thus producing janks.
This PR locks the refresh rate to 80fps to avoid janks.
Fixesflutter/flutter#116640
fdio_service_connect no longer provides rights. Since we need the READABLE right when opening the debug/ctrl/diagnostics directories, this change uses fdio_open_at.
This change also fixes the Clone to remove specific rights and instead use CLONE_SAME_RIGHTS.
Verified locally that we no longer get ACCESS_DENIED on the diagnostics directory when opening in component manager.
See https://fxrev.dev/793422.
Missed in 92fca42e0667969b3a78815c77afca9c6acd1c83,
3bfa5c5b1db5391d49cc58f9a23f1b4cd802d3e3 and
d429b674f1dd60590fda077fd893a4493c2b5455.
