dependabot[bot]
7d62bd0a2a
Bump github/codeql-action from 3.25.8 to 3.25.10 ( flutter/engine#53446 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.8 to 3.25.10.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.25.10 - 13 Jun 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.5. <a href="https://redirect.github.com/github/codeql-action/pull/2327 ">#2327</a></li>
</ul>
<h2>3.25.9 - 12 Jun 2024</h2>
<ul>
<li>Avoid failing database creation if the database folder already exists and contains some unexpected files. Requires CodeQL 2.18.0 or higher. <a href="https://redirect.github.com/github/codeql-action/pull/2330 ">#2330</a></li>
<li>The init Action will attempt to clean up the database cluster directory before creating a new database and at the end of the job. This will help to avoid issues where the database cluster directory is left in an inconsistent state. <a href="https://redirect.github.com/github/codeql-action/pull/2332 ">#2332</a></li>
</ul>
<h2>3.25.8 - 04 Jun 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.4. <a href="https://redirect.github.com/github/codeql-action/pull/2321 ">#2321</a></li>
</ul>
<h2>3.25.7 - 31 May 2024</h2>
<ul>
<li>We are rolling out a feature in May/June 2024 that will reduce the Actions cache usage of the Action by keeping only the newest TRAP cache for each language. <a href="https://redirect.github.com/github/codeql-action/pull/2306 ">#2306</a></li>
</ul>
<h2>3.25.6 - 20 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.3. <a href="https://redirect.github.com/github/codeql-action/pull/2295 ">#2295</a></li>
</ul>
<h2>3.25.5 - 13 May 2024</h2>
<ul>
<li>Add a compatibility matrix of supported CodeQL Action, CodeQL CLI, and GitHub Enterprise Server versions to the <a href="https://github.com/github/codeql-action/blob/main/README.md ">https://github.com/github/codeql-action/blob/main/README.md </a>. <a href="https://redirect.github.com/github/codeql-action/pull/2273 ">#2273</a></li>
<li>Avoid printing out a warning for a missing <code>on.push</code> trigger when the CodeQL Action is triggered via a <code>workflow_call</code> event. <a href="https://redirect.github.com/github/codeql-action/pull/2274 ">#2274</a></li>
<li>The <code>tools: latest</code> input to the <code>init</code> Action has been renamed to <code>tools: linked</code>. This option specifies that the Action should use the tools shipped at the same time as the Action. The old name will continue to work for backwards compatibility, but we recommend that new workflows use the new name. <a href="https://redirect.github.com/github/codeql-action/pull/2281 ">#2281</a></li>
</ul>
<h2>3.25.4 - 08 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.2. <a href="https://redirect.github.com/github/codeql-action/pull/2270 ">#2270</a></li>
</ul>
<h2>3.25.3 - 25 Apr 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.1. <a href="https://redirect.github.com/github/codeql-action/pull/2247 ">#2247</a></li>
<li>Workflows running on <code>macos-latest</code> using CodeQL CLI versions before v2.15.1 will need to either upgrade their CLI version to v2.15.1 or newer, or change the platform to an Intel MacOS runner, such as <code>macos-12</code>. ARM machines with SIP disabled, including the newest <code>macos-latest</code> image, are unsupported for CLI versions before 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/2261 ">#2261</a></li>
</ul>
<h2>3.25.2 - 22 Apr 2024</h2>
<p>No user facing changes.</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="23acc5c183https://redirect.github.com/github/codeql-action/issues/2337 ">#2337</a> from github/update-v3.25.10-5bf6dad35</li>
<li><a href="9b72dbdc685bf6dad35bhttps://redirect.github.com/github/codeql-action/issues/2329 ">#2329</a> from github/henrymercer/csharp-buildless-rollback-me...</li>
<li><a href="feec81c66b789b5f86efhttps://redirect.github.com/github/codeql-action/issues/2328 ">#2328</a> from github/henrymercer/direct-tracing-fix</li>
<li><a href="c36b5fc54fhttps://redirect.github.com/github/codeql-action/issues/2327 ">#2327</a> from github/update-bundle/codeql-bundle-v2.17.5</li>
<li><a href="b3642aa04d1fc6e20182https://redirect.github.com/github/codeql-action/issues/2335 ">#2335</a> from github/mergeback/v3.25.9-to-main-530d4fea</li>
<li><a href="356bee4b4a385808c7152e230e8fe0...23acc5c183https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.25.8&new-version=3.25.10 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-06-18 05:59:31 +00:00
Chinmay Garde
59ff141856
[Impeller] Update iOS CPU profiling instructions. ( flutter/engine#53440 )
...
Adds more instructions on how to setup `FlameGraph`. Some other subjective improvements to readability.
2024-06-18 02:12:10 +00:00
skia-flutter-autoroll
9d838a3eef
Roll Skia from 2b9bc16df969 to 2db8813a349d (4 revisions) ( flutter/engine#53438 )
...
https://skia.googlesource.com/skia.git/+log/2b9bc16df969..2db8813a349d
2024-06-17 bungeman@google.com Test typeface palette serialization
2024-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b9f194451019 to 87ec89cd0d09
2024-06-17 jmbetancourt@google.com [skottie] compose image filter and shader driven effects
2024-06-17 enga@chromium.org [webgpu] Check wgpu::Status enum instead of bool
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-18 00:48:59 +00:00
skia-flutter-autoroll
bc63e1a5ca
Roll Dart SDK from 51bbba0da7d3 to 863f4d04575c (1 revision) ( flutter/engine#53436 )
...
https://dart.googlesource.com/sdk.git/+log/51bbba0da7d3..863f4d04575c
2024-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-272.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-18 00:47:25 +00:00
Jim Graham
c9b612ff9a
[DisplayList] Create DrawDashedLine for paragraph code ( flutter/engine#53411 )
...
With this minor addition to the DlCanvas/DisplayList API the code in the paragraph builder no longer needs to worry about PathEffect objects and their varying support on the backends.
At this point all PathEffect code in the engine is obsolete and can be deleted, but I'll leave that for a follow-on PR.
The only PathEffect related thing I did delete was support for rendering primitives with a PathEffect in the DL Rendering tests, both because it is a vestigial attribute and also because it would interfere with the new DrawDashedLine rendering test (a PathEffect on top of a PathEffect...).
2024-06-17 22:50:20 +00:00
Chinmay Garde
b16b8db64d
[Impeller] Update Android CPU profiling instructions. ( flutter/engine#53437 )
...
* Highlighting the section that says you can profile using a blank project. This saved me as I couldn't find the Profiler anywhere in the project for the Wondrous app.
* Added a section that shows how you can mark a release app as debuggable.
* Added tooltips for images.
* Cleanups for readability (subjective).
2024-06-17 22:46:03 +00:00
Jonah Williams
6da0384373
[Impeller] move draw vertices to dl unittests. ( flutter/engine#53400 )
...
Part of https://github.com/flutter/flutter/issues/142054
Moves all of the drawVertices tests for aiks and entities into DL. This might change some of the entity goldens but ... these are easy to eyeball so it should be fine IMO.
2024-06-17 22:27:04 +00:00
Chinmay Garde
9baa3320b4
[Impeller] Link CPU profiling docs from the main README. ( flutter/engine#53435 )
2024-06-17 22:04:16 +00:00
skia-flutter-autoroll
e9dcc56bf6
Roll Dart SDK from 1ce6b4d54247 to 51bbba0da7d3 (1 revision) ( flutter/engine#53432 )
...
https://dart.googlesource.com/sdk.git/+log/1ce6b4d54247..51bbba0da7d3
2024-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-271.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-17 18:35:57 +00:00
Jonah Williams
0daddbfe73
[Impeller] Move drawAtlas golden tests to display list. ( flutter/engine#53398 )
...
Part of https://github.com/flutter/flutter/issues/142054
Moves all of the drawAtlas tests for aiks and entities into DL. This might change some of the entity goldens but ... these are easy to eyeball so it should be fine IMO.
2024-06-17 18:24:56 +00:00
Filip Filmar
e2593bb7d9
[flatland] Handle fence overflow in flatland_connection.cc ( flutter/engine#53366 )
...
flatland_connection.cc used to allow an arbitrary number of acquire and release fences to be scheduled for each frame.
Sadly, Fuchsia has a limitation of (1) the number of total handles that can be sent per a FIDL call, but also (2) the Flatland protocol only supports sending up to 16 fences per each fence type.
Now, normally there should be very few scheduled fences per frame. But if frames get skipped, we could amass many fences which would then crash our attempts to send all of them to the Flatland `Present` endpoint.
This change introduces two fence multiplexer, which allow us to signal more than 16 fences per type, at a performance penalty. We expect to be able *not* to crash the FIDL subsystem using this approach, and may even be able to hobble along for a bit, until the fences issue is hopefully self-resolved.
That said, this issue seems to indicate there are frame scheduling problems elsewhere. But this is a fairly straightforward change to make without affecting the rest of the flatland code or integration, so we opt to do that first.
Issues: [#150136 ](https://github.com/flutter/engine/pull/53366 )
- [] I updated/added relevant documentation (doc comments with `///`).
2024-06-17 18:10:20 +00:00
skia-flutter-autoroll
8679dbb93f
Roll Skia from 0dda1054f543 to 2b9bc16df969 (1 revision) ( flutter/engine#53431 )
...
https://skia.googlesource.com/skia.git/+log/0dda1054f543..2b9bc16df969
2024-06-17 jvanverth@google.com [graphite] Add sk_hw_yuv_image_shader.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-17 17:44:57 +00:00
skia-flutter-autoroll
52fffb37aa
Roll Skia from 2121bbc603c7 to 0dda1054f543 (6 revisions) ( flutter/engine#53430 )
...
https://skia.googlesource.com/skia.git/+log/2121bbc603c7..0dda1054f543
2024-06-17 brianosman@google.com GrStyledShape::asRRect: Remove (unused) direction and start parameters
2024-06-17 fmalita@google.com [skottie-android] Minor style cleanup
2024-06-17 geofflang@chromium.org Revert flushBeforeWritePixels for PowerVR B-Series on ANGLE
2024-06-17 beaufort.francois@gmail.com WebGPU: Use GPUAdapter GetInfo() instead of GetProperties()
2024-06-17 blundell@chromium.org [Dawn] Add FormatBytesPerBlock() for format type External
2024-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 897d900fc1b1 to 7f05a36fb6d9 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-17 16:20:05 +00:00
skia-flutter-autoroll
84c1acba00
Roll Dart SDK from 4f8c8c476916 to 1ce6b4d54247 (1 revision) ( flutter/engine#53427 )
...
https://dart.googlesource.com/sdk.git/+log/4f8c8c476916..1ce6b4d54247
2024-06-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-270.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-17 14:24:33 +00:00
skia-flutter-autoroll
977964a09c
Roll Skia from 937ac9fecc6c to 8854918ff554 (2 revisions) ( flutter/engine#53423 )
...
https://skia.googlesource.com/skia.git/+log/937ac9fecc6c..8854918ff554
2024-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7318c69cffc7 to c50a89828545
2024-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1b41a295c513 to 7318c69cffc7 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-17 07:23:22 +00:00
skia-flutter-autoroll
42d239410c
Roll Dart SDK from f009db7ba764 to 4f8c8c476916 (1 revision) ( flutter/engine#53421 )
...
https://dart.googlesource.com/sdk.git/+log/f009db7ba764..4f8c8c476916
2024-06-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-269.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-16 22:11:34 +00:00
skia-flutter-autoroll
38f578c609
Roll Fuchsia Linux SDK from Rf8OkD3NooYAO4eRX... to 8lC7I8HnEItJU0qdI... ( flutter/engine#53420 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-16 08:29:40 +00:00
skia-flutter-autoroll
52fcf13b63
Roll Fuchsia Linux SDK from BkYg1UB1jdbAZv3gA... to Rf8OkD3NooYAO4eRX... ( flutter/engine#53416 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-15 07:18:32 +00:00
skia-flutter-autoroll
887b8bc68a
Roll Dart SDK from fd8f26dfc971 to f009db7ba764 (1 revision) ( flutter/engine#53415 )
...
https://dart.googlesource.com/sdk.git/+log/fd8f26dfc971..f009db7ba764
2024-06-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-268.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-15 06:25:23 +00:00
skia-flutter-autoroll
df51104555
Roll Dart SDK from dca20ab646c5 to fd8f26dfc971 (1 revision) ( flutter/engine#53413 )
...
https://dart.googlesource.com/sdk.git/+log/dca20ab646c5..fd8f26dfc971
2024-06-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-267.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-15 02:23:34 +00:00
Jason Simmons
50586aac61
Manual roll of Dart SDK from e90b0a53e058 to dca20ab646c5 ( flutter/engine#53410 )
...
Updates dart2wasm invocation to add the --enable-experimental-wasm-interop flag.
(see https://dart.googlesource.com/sdk/+/6f21d19b02eb82c0b44b01dbdb21ec7a17e17120 )
2024-06-15 00:52:56 +00:00
Chinmay Garde
e88cb577df
Update "Vulnerability scanning" to add the actions: read permission. ( flutter/engine#53409 )
2024-06-15 00:52:54 +00:00
gaaclarke
12ccf1ee1c
[Impeller] moved blur to unrotated local space, started respecting respect_ctm flag ( flutter/engine#53377 )
...
Resolves https://github.com/flutter/flutter/issues/142014
Resolves https://github.com/flutter/flutter/issues/150114
A previous patch made the blur operate in source space. This doesn't
work for text since it jumbles up the characters. We probably want the
text crisp when scaled anyways so it would make sense not to render
those is source space. Instead I moved the blur to "scaled source space"
or "unrotated local space", if you will.
This is more closely what we had previously but it handles rotation
correctly.
Also, brandon fixed a problem where we weren't minding a flag on how the
ctm should be used when rendering mask blurs. That was important to this
fix too.
## new golden results before patch
<img width="966" alt="Screenshot 2024-06-13 at 3 32 29 PM"
src="https://github.com/flutter/engine/assets/30870216/097ef2d3-26a6-45fc-b1a5-e0b699d31dfd ">
<img width="962" alt="Screenshot 2024-06-13 at 3 32 36 PM"
src="https://github.com/flutter/engine/assets/30870216/3b6c03fd-bf88-47eb-a0eb-c362dcaecd63 ">
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Brandon DeRosier <bdero@google.com>
2024-06-14 15:17:28 -07:00
skia-flutter-autoroll
8b481e855e
Roll Skia from 5560041fcfc0 to 136c7cc18d1e (4 revisions) ( flutter/engine#53406 )
...
https://skia.googlesource.com/skia.git/+log/5560041fcfc0..136c7cc18d1e
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 42ee85cf2154 to dd296c842e50 (2 revisions)
2024-06-14 bungeman@google.com [fontations] Define SkFontMgr_New_Fontations_Empty with SK_API
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 6cfa730ae00a to b9f194451019
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1b41a295c513 to c0388f6de1dc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-14 21:33:05 +00:00
Jason Simmons
285c718c82
Roll web_ui dependencies to enable the next roll of the Dart SDK ( flutter/engine#53399 )
...
Dart has removed the UnmodifiableXXXView classes, which were used by older versions of the archive package.
See https://dart.googlesource.com/sdk/+/18994e6e46ec9fb2fac8368c43d448119abd579f
2024-06-14 20:52:04 +00:00
Jackson Gardner
5dd33ba48e
Hack to prevent Safari from being backgrounded during unit tests. ( flutter/engine#53402 )
...
Safari actually pauses execution of our unit tests if the window becomes occluded or non-visible. As such, I am inserting this egregious hack which just makes the Safari window frontmost every 2 seconds so that the unit tests don't get stalled out.
This should fix https://github.com/flutter/flutter/issues/150023
2024-06-14 20:18:32 +00:00
skia-flutter-autoroll
6d88e21691
Manual roll Dart SDK from cabe65966815 to e90b0a53e058 (1 revision) ( flutter/engine#53404 )
...
Manual roll requested by jsimmons@google.com
https://dart.googlesource.com/sdk.git/+log/cabe65966815..e90b0a53e058
2024-06-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-261.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-14 20:10:23 +00:00
skia-flutter-autoroll
20cbde6609
Roll Skia from de1a50046289 to 5560041fcfc0 (1 revision) ( flutter/engine#53393 )
...
https://skia.googlesource.com/skia.git/+log/de1a50046289..5560041fcfc0
2024-06-14 blundell@chromium.org [Dawn] Add External to known Dawn formats
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-14 15:13:20 +00:00
skia-flutter-autoroll
7bc3d0649e
Manual roll Dart SDK from 115a9a2b26cd to cabe65966815 (1 revision) ( flutter/engine#53390 )
...
Manual roll requested by kustermann@google.com
https://dart.googlesource.com/sdk.git/+log/115a9a2b26cd..cabe65966815
2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-260.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com,kustermann@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-14 13:11:29 +00:00
skia-flutter-autoroll
daffb21107
Roll Skia from 3bebb0602780 to de1a50046289 (3 revisions) ( flutter/engine#53388 )
...
https://skia.googlesource.com/skia.git/+log/3bebb0602780..de1a50046289
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a7b72d6c8490 to 42ee85cf2154 (1 revision)
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 65f8dc8e3ad8 to 165b85b69226 (10 revisions)
2024-06-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ad5ea87faf24 to 1b41a295c513 (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-14 09:53:14 +00:00
skia-flutter-autoroll
fec3dbcd08
Roll Fuchsia Linux SDK from pGxbL7JoNb3yAYFw4... to BkYg1UB1jdbAZv3gA... ( flutter/engine#53386 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-14 02:35:22 +00:00
Jim Graham
d8b3b9a280
[Impeller] restore accidentally deleted Cap/Join benchmarks ( flutter/engine#53385 )
...
These benchmark invocations were accidentally deleted when the invocations of the "UV" versions were eliminated.
No unit tests because only benchmark code is changed.
2024-06-14 01:01:34 +00:00
Matan Lurey
5300aafdb5
Add a FlutterEngineRule (JUnit TestRule) and use it in FlutterRendererTest ( flutter/engine#53361 )
...
In https://github.com/flutter/engine/pull/53280 , I'm adding
lifecycle-aware methods to `SurfaceProducer`.
That means, in order to test that it WAI, we'll need to be running in a
simulated activity, and be able to switch scenario states (i.e. to
`RESUMED`). This was mentioned as well in
https://github.com/flutter/flutter/issues/133151 as being something we
want to do.
This PR adds a `FlutterEngineRule`, which allows the creation of a
"real" `FlutterEngine` and an `Intent` that can power
`AndroidScenarioRule<FlutterActivity>`. I felt bad doing all of this
work for a single `@Test`, so I also refactored the rest of the file and
cleaned things up a bit.
That said, I'm happy to revert or make changes if we liked how things
were setup before.
2024-06-13 16:22:54 -07:00
skia-flutter-autoroll
5778351976
Roll Skia from b21429b0ea78 to d248a9f99ff5 (2 revisions) ( flutter/engine#53383 )
...
https://skia.googlesource.com/skia.git/+log/b21429b0ea78..d248a9f99ff5
2024-06-13 brianosman@google.com Remove isUsingMask plumbing through AAA scan converter
2024-06-13 drott@chromium.org [Fontations-backend] Return default palette if index out of range
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 21:21:12 +00:00
skia-flutter-autoroll
c39ce6490e
Roll Skia from 40bdee9eedd6 to b21429b0ea78 (3 revisions) ( flutter/engine#53382 )
...
https://skia.googlesource.com/skia.git/+log/40bdee9eedd6..b21429b0ea78
2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f32e0658b219 to a7b72d6c8490 (8 revisions)
2024-06-13 bungeman@google.com Cache the default mask gamma
2024-06-13 michaelludwig@google.com [skif] Split blur filling into strict and fast regions
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 20:04:19 +00:00
Jim Graham
7ff652e5bf
[DisplayList] cull clip operations that can be trivially and safely ignored ( flutter/engine#53367 )
...
This mechanism pulls some clip-reduction logic from Impeller Entities up into DisplayListBuilder to simplify the work that Impeller has to do and also amortize the work if the DisplayList is reused from frame to frame. Since the DisplayList does not have access to information such as surface sizes, there will still be cases that Impeller can catch that must be conservatively included by the recording process in the Builder, so this mechanism does not replace the same code in Impeller, it merely catches some cases earlier, while recording widget output, to avoid the same work on every frame down in Impeller.
In this first pass only the most conservative and straightforward cases are handled - a clip on a layer which has a previous clip that the new clip fully contains (and which was not already restored).
This limited approach is already enough to eliminate a couple of clip operations in the layout of many of the pages in the `new_gallery` benchmarks.
2024-06-13 19:06:22 +00:00
skia-flutter-autoroll
edf06d07fd
Roll Skia from 0f47a9333edb to 40bdee9eedd6 (2 revisions) ( flutter/engine#53381 )
...
https://skia.googlesource.com/skia.git/+log/0f47a9333edb..40bdee9eedd6
2024-06-13 robertphillips@google.com [graphite] Rearrange code for newly public PrecompileShader API
2024-06-13 robertphillips@google.com [graphite] Expose PrecompileShader to public API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 18:43:11 +00:00
skia-flutter-autoroll
86c982b7f9
Roll Dart SDK from aa2265e5a192 to 115a9a2b26cd (5 revisions) ( flutter/engine#53380 )
...
https://dart.googlesource.com/sdk.git/+log/aa2265e5a192..115a9a2b26cd
2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-259.0.dev
2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-258.0.dev
2024-06-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-257.0.dev
2024-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-256.0.dev
2024-06-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-255.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 18:11:12 +00:00
skia-flutter-autoroll
88f016862a
Roll Skia from bf5a0e0dbf41 to 0f47a9333edb (2 revisions) ( flutter/engine#53378 )
...
https://skia.googlesource.com/skia.git/+log/bf5a0e0dbf41..0f47a9333edb
2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 22f8618f7005 to 5dbd83fd10db
2024-06-13 robertphillips@google.com [graphite] Rearrange code after PrecompileBlender had been made public
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 16:58:09 +00:00
skia-flutter-autoroll
d04ff169fe
Roll Skia from ecc64fb82374 to bf5a0e0dbf41 (2 revisions) ( flutter/engine#53376 )
...
https://skia.googlesource.com/skia.git/+log/ecc64fb82374..bf5a0e0dbf41
2024-06-13 enga@chromium.org Remove usage of wgpu::VertexFormat::Undefined
2024-06-13 robertphillips@google.com [graphite] Expose blenders in public Precompile API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 15:37:12 +00:00
Victoria Ashworth
ecad29a177
Change element to wait for in AppExtensionTests testAppExtensionLaunching ( flutter/engine#53358 )
...
Instead of waiting for the first cell in the share sheet to appear, wait for the first cell matching the predicate to appear. It seems that on macOS 14 it [occasionally doesn't find any matches](https://github.com/flutter/flutter/issues/150117#issuecomment-2163493564 ), presumably a race condition - so this will wait up to 10 seconds for the desired elements to appear.
Attempting to fix https://github.com/flutter/flutter/issues/150117 . I wasn't able to recreate locally and it only happens flakily in CI so hard to guarantee it will fix.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-13 14:39:18 +00:00
skia-flutter-autoroll
39eb74f203
Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) ( flutter/engine#53373 )
...
https://skia.googlesource.com/skia.git/+log/9ea9f37e8e1d..0fe7f7ac43c5
2024-06-13 drott@chromium.org [Fontations-backend] Fix get_font_style Rust tests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 10:21:32 +00:00
skia-flutter-autoroll
25ec2ce764
Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) ( flutter/engine#53370 )
...
https://skia.googlesource.com/skia.git/+log/69a53db434a6..704f70b7d756
2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6a805cf8a5fb to 9f4eff245f36 (23 revisions)
2024-06-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3e4b1b489466 to ad5ea87faf24 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 06:22:24 +00:00
skia-flutter-autoroll
305ae8ca47
Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) ( flutter/engine#53365 )
...
https://skia.googlesource.com/skia.git/+log/b2f163ae11bf..69a53db434a6
2024-06-12 michaelludwig@google.com [skif] Use FilterResult::rescale() for blur()
2024-06-12 brianosman@google.com Remove SKSL_STANDALONE from SkSLModuleLoader
2024-06-12 ccameron@chromium.org SkGainmapEncoder: Add Exif segment
2024-06-12 brianosman@google.com Remove guard for AAA scan converter intersection bugfix
2024-06-12 brianosman@google.com Fully remove deferred blitting from AAA scan converter
2024-06-12 ccameron@chromium.org SkTiff: Make constants public
2024-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ec3221eef698 to 8489c5749b4b
2024-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9a693759186a to c3c17897c123 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 02:31:52 +00:00
Jonah Williams
673ff9c03b
[Impeller] Move Gradient tests to display list. ( flutter/engine#53345 )
...
Migrate almost all of the gradient unittests to display list. Removes tests for disabled dithering and the dithering flag, as it has not been possible to disable dithering on gradients for months and months.
Part of https://github.com/flutter/flutter/issues/142054
2024-06-13 01:49:57 +00:00
skia-flutter-autoroll
72373a1c04
Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... ( flutter/engine#53363 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 01:10:52 +00:00
skia-flutter-autoroll
f16b85fc15
Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) ( flutter/engine#53357 )
...
https://skia.googlesource.com/skia.git/+log/be6a57569a92..b2f163ae11bf
2024-06-12 robertphillips@google.com [graphite] Rearrange code to match exposed Precompile API
2024-06-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from efa3591618f5 to 9a693759186a (6 revisions)
2024-06-12 robertphillips@google.com [graphite] Begin exposing Precompilation API
2024-06-12 bungeman@google.com Add needed include to SkPathRef.cpp
2024-06-12 bungeman@google.com Remove SkScalerContextRec::fPaintGamma
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-13 00:38:05 +00:00
Victoria Ashworth
b6f5261c79
Give mac_host_engine tests a longer timeout and allow to run on Mac-14 ( flutter/engine#53355 )
...
Allow Mac mac_host_engine tests to run for up to 90 minutes (previously assumed 60) and allow the tests to run on Mac-14. This should give the test more time when it needs to do additional tasks like install Xcode.
Timeout was recently added in https://flutter-review.googlesource.com/c/recipes/+/57980 .
Timeout tested in https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/941415/infra (timeout set to 4 minutes).
Fixes https://github.com/flutter/flutter/issues/150011 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-06-13 00:36:19 +00:00
John McDole
2a344eafcf
'Starter Project': port planet fragment shader to impeller tests ( flutter/engine#53362 )
...
This is a modified planet shader from the SimonDev's "GLSL Shaders from Scratch" course on teachables. With permission from Simon:
> 100% use however you want, with or without credit
I choose "with credit".
https://github.com/flutter/engine/assets/1924313/47da62b5-6b6d-47c2-ac9f-f3a33f177a86
2024-06-13 00:32:42 +00:00
skia-flutter-autoroll
44b391bfa9
Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) ( flutter/engine#53353 )
...
https://skia.googlesource.com/skia.git/+log/1ba0c3ebc7a5..be6a57569a92
2024-06-12 nathanasanchez@google.com Add storage buffer implementation for many stop gradients
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-12 14:37:10 +00:00
