17969 Commits

Author SHA1 Message Date
Emmanuel Garcia
7ae2fa67bd Move Skia gold client to shared location (flutter/engine#33672) 2022-05-31 16:33:04 -07:00
skia-flutter-autoroll
d2e7366d32 Roll Skia from 8d69d045793c to 817dd601f85f (3 revisions) (flutter/engine#33726) 2022-05-31 15:43:03 -07:00
Chinmay Garde
3296758fa9 [Impeller] Document the Impeller Coordinate System. (flutter/engine#33725)
Fixes https://github.com/flutter/flutter/issues/105052.
2022-05-31 15:28:25 -07:00
Chinmay Garde
40eb99ee5a [Impeller] Account for differences in coordinate spaces between OpenGL & Metal. (flutter/engine#33723) 2022-05-31 15:18:05 -07:00
Chris Yang
d303a310a6 PlatformView to set the correct overlay view frame, merge thread at the endFrame (flutter/engine#33262) 2022-05-31 14:42:34 -07:00
skia-flutter-autoroll
6e9d8cb208 Roll Skia from 9c9ef3845d04 to 8d69d045793c (3 revisions) (flutter/engine#33724) 2022-05-31 14:23:02 -07:00
Brandon DeRosier
533e395f82 [Impeller] Add high DPI support to the ImGui Impeller backend; make high DPI work in the Metal playground; make playground tests respect content scale (flutter/engine#33708) 2022-05-31 13:04:50 -07:00
skia-flutter-autoroll
ca9cccdea4 Roll Skia from 9676ef73025b to 9c9ef3845d04 (2 revisions) (flutter/engine#33721) 2022-05-31 13:03:02 -07:00
Tong Mu
78adf103bf Reland No.2 "Hardware Keyboard: Android" (flutter/engine#33686)
* Original code

* Changes

* Fix and test

Better formatted tests
2022-05-31 13:00:39 -07:00
skia-flutter-autoroll
16bea375cd Roll Skia from e78db5d6329c to 9676ef73025b (2 revisions) (flutter/engine#33720) 2022-05-31 11:38:04 -07:00
skia-flutter-autoroll
8f6cfad2f9 Roll Fuchsia Linux SDK from GA424pgEx... to sqbzSMhtc... (flutter/engine#33719) 2022-05-31 11:33:05 -07:00
Brandon DeRosier
914624970a Fix framebuffer mapping for viewport and scissor (flutter/engine#33706) 2022-05-31 11:27:49 -07:00
joshualitt
4617fb4bb2 [web] Migrate Flutter Web DOM usage to JS static interop - 21. (flutter/engine#33349) 2022-05-31 11:15:55 -07:00
Chris Bracken
8d7d82192e Pass std::string_view by value not by ref (flutter/engine#33699)
String views are small, cheap objects that fit in a couple registers, so
passing by value avoids pointer indirection and thus a memory load.

Fun related reading for future archaeologists:
https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/

And a Windows-specific footnote:
https://quuxplusone.github.io/blog/2021/11/19/string-view-by-value-ps/

No test change since there is no semantic change.
2022-05-31 11:13:29 -07:00
skia-flutter-autoroll
62e713598f Roll Skia from c6218799a6c7 to e78db5d6329c (3 revisions) (flutter/engine#33717) 2022-05-31 10:13:04 -07:00
Shivesh Ganju
3cfb7658cc [fuchsia] Fix precision errors occuring in layer tree frame size. (flutter/engine#33669)
This PR fixes the precision error which occurs when casting a double to int32, causing an incorrect physical display size to be propagated in
the layer tree ultimately causing input events on the left edge of the
display to be dropped.
2022-05-31 09:42:25 -07:00
skia-flutter-autoroll
15f20cb270 Roll Skia from 0582a9e6191a to c6218799a6c7 (8 revisions) (flutter/engine#33715) 2022-05-31 08:53:04 -07:00
Viren Khatri
fd3b605c70 Deprecates hashValues and hashList (flutter/engine#30674)
* deprecate hashValues and hashList

* rm unused imports

* missing periods and const lists

* improves hashing of lists

* ignore: avoid_classes_with_only_static_members

* migrate new classes

* refactor: update version of deprecation
2022-05-31 21:19:57 +05:30
Zachary Anderson
67d4e8ff38 Fixes for the Windows arm64 build (flutter/engine#33681)
* Fixes for the Windows arm64 build

* Update buildroot to 53abad0fa9c9e0285e80f9b0682316d5d39705be

* Update buildroot to f582982073b6f04b7a70bc284bac8fafa6c0a846
2022-05-31 08:06:47 -07:00
skia-flutter-autoroll
7ba60ce763 Roll Skia from 44444cccb802 to a3d2d6250937 (1 revision) (flutter/engine#33709) 2022-05-31 03:58:04 -07:00
Brandon DeRosier
32b77309c7 Fixes to get impeller_unittests building on Windows (flutter/engine#33705) 2022-05-31 01:13:47 -07:00
skia-flutter-autoroll
a0bd74cb70 Roll Skia from fb2d7d7a5975 to 44444cccb802 (1 revision) (flutter/engine#33703) 2022-05-30 23:08:04 -07:00
skia-flutter-autoroll
45bd9fe7fe Roll Fuchsia Linux SDK from FS8i5XBY8... to GA424pgEx... (flutter/engine#33702) 2022-05-30 22:08:04 -07:00
skia-flutter-autoroll
91cc38603c Roll Fuchsia Linux SDK from I9BFsXHCV... to FS8i5XBY8... (flutter/engine#33697) 2022-05-30 08:48:04 -07:00
skia-flutter-autoroll
0f81ba682a Roll Skia from ddbc340987c7 to fb2d7d7a5975 (1 revision) (flutter/engine#33694) 2022-05-30 00:33:05 -07:00
skia-flutter-autoroll
514efcdecf Roll Skia from 1f150eb68c67 to ddbc340987c7 (1 revision) (flutter/engine#33693) 2022-05-29 23:13:02 -07:00
skia-flutter-autoroll
3cc92c1994 Roll Fuchsia Linux SDK from VloDDuqdt... to I9BFsXHCV... (flutter/engine#33691) 2022-05-29 19:28:04 -07:00
skia-flutter-autoroll
71756f1fb1 Roll Skia from d05aff78a0ed to 1f150eb68c67 (1 revision) (flutter/engine#33690) 2022-05-29 18:13:04 -07:00
skia-flutter-autoroll
0f64909f5b Roll Fuchsia Linux SDK from pXxh0G0Cl... to VloDDuqdt... (flutter/engine#33687) 2022-05-29 06:08:03 -07:00
skia-flutter-autoroll
7d2229c47f Roll Skia from 20a2f7b4d443 to d05aff78a0ed (1 revision) (flutter/engine#33683) 2022-05-29 02:43:05 -07:00
Naud Ghebre
a84b408f8d Dart test runner: Pass name of the test dart component to test_manager via tast_case (flutter/engine#33665) 2022-05-29 01:20:23 -04:00
Chris Bracken
41a7ac3505 [impeller] Revert ShaderLibraryGLES validity check (flutter/engine#33679)
In https://github.com/flutter/engine/pull/33666, I landed a bulk lint
cleanup that applied fixes to global constant naming using the `--fix`
option to the linter script, but also caught a few straggling linter
violations that hadn't been previously fixed.

As part of this patch, the linter applied a change that moved
ShaderLibraryGLES's is_valid_ initialisation from the ctor body to the
initialiser list, always initialised to true. This is unsafe because
prior to is_valid_ initialisation in the ctor body, there was a bailout
if any of the shader_libraries wasn't valid.

This eliminates the use of the
`cppcoreguidelines-prefer-member-initializer` lint, which incorrectly
flagged this code due to the following issue:
https://github.com/llvm/llvm-project/issues/52837

This is a partial revert of https://github.com/flutter/engine/pull/33666.
Reintroduction of this issue is prevented by the removal of the 
`cppcoreguidelines-prefer-member-initializer` lint in this patch.
2022-05-28 17:23:03 -07:00
skia-flutter-autoroll
415df244af Roll Fuchsia Linux SDK from ybiCMWgUO... to pXxh0G0Cl... (flutter/engine#33682) 2022-05-28 16:48:04 -07:00
Brandon DeRosier
1c82aff4ed [Impeller] Implement DlColorFilterType::kBlend (flutter/engine#33656) 2022-05-28 14:01:43 -07:00
skia-flutter-autoroll
c69b848636 Roll Skia from ee6f41262b2e to 20a2f7b4d443 (1 revision) (flutter/engine#33678) 2022-05-28 06:53:03 -07:00
skia-flutter-autoroll
2fde143938 Roll Fuchsia Linux SDK from v57clWK63... to ybiCMWgUO... (flutter/engine#33677) 2022-05-28 03:28:04 -07:00
hellohuanlin
5bbb2437e2 Add focus support for platform view (flutter/engine#33093) 2022-05-27 23:33:02 -07:00
Chinmay Garde
13731ca4e3 [impeller] Document UBO workarounds in GL ES 2.0. (flutter/engine#33674) 2022-05-27 23:13:04 -07:00
skia-flutter-autoroll
96fbde253e Roll Skia from 9753199415ac to ee6f41262b2e (1 revision) (flutter/engine#33673) 2022-05-27 19:38:02 -07:00
Chris Bracken
56fbdd0232 [lint] Enforce k prefix for global constants (flutter/engine#33666)
Enforces that all global constants are prefixed with a 'k' as per the
style guide and updates the codebase into conformance where necessary.

This does not change any public API.

Additional testing provided by the addition of the lint rule.

Ref: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#begin-global-constant-names-with-prefix-k
2022-05-27 18:33:38 -07:00
skia-flutter-autoroll
1e275928fc Roll Skia from 162dfca3403b to 9753199415ac (1 revision) (flutter/engine#33671) 2022-05-27 18:13:04 -07:00
Chinmay Garde
cc83eb1091 [Impeller] Compile simulator specific Metal shader variants. (flutter/engine#33670) 2022-05-27 17:53:05 -07:00
Chinmay Garde
c928cd3e6a [Impeller] Import docs from wiki. (flutter/engine#33668)
It took me a while to figure out how best to put image heavy docs into a Wiki on
GitHub. Finally, gave up and moved these to a docs folder in Markdown syntax.
The images have been `pngcrush`ed with the `-brute` so they are about as small
as can be expected.

Added links to the articles from the README and also added Brandon's showcase to
zhoosh it up a bit :)

Fixes https://github.com/flutter/flutter/issues/104740
2022-05-27 14:52:49 -07:00
skia-flutter-autoroll
c23c4d1b32 Roll Fuchsia Linux SDK from QmhwWAbzL... to v57clWK63... (flutter/engine#33667) 2022-05-27 14:08:04 -07:00
J-P Nurmi
f35001f852 [Linux] fix typos in FlAccessibleNode docs (flutter/engine#32651) 2022-05-27 13:28:31 -07:00
Chris Bracken
2b84fdf8cb [macOS] Document onKeyboardLayoutChanged (flutter/engine#33663)
Replaces a TODO with documentation. No tests changed, since this change
simply adds a missing doc comment.
2022-05-27 12:48:10 -07:00
Shivesh Ganju
61a5c8873c [fuchsia] remove Fuchsia-specific kVsyncTraceName from VsyncWaiter. (flutter/engine#33519)
This CL changes the vsync trace name to "VsyncProcessCallback". The
benchmarks in fuchsia currently support "VsyncProcessCallback" and "vsync callback". After this change, support for "vsync callback" can be safely removed from fuchsia benchmarks.

Test: fx test host_x64/knowledge_card_test

Bug: 73367
2022-05-27 12:04:12 -07:00
Brandon DeRosier
41a5bd513e [Impeller] Interpret odd path winding in the dispatcher (flutter/engine#33657) 2022-05-27 11:49:24 -07:00
Michael Goderbauer
782679ce66 Move platform-specific stuff from macOS FVC to FlutterEngine (flutter/engine#33234) 2022-05-27 09:56:28 -07:00
skia-flutter-autoroll
292a7c9d11 Roll Skia from 6e1e6f3825d0 to 162dfca3403b (1 revision) (flutter/engine#33658) 2022-05-27 05:33:04 -07:00