1537 Commits

Author SHA1 Message Date
Michael Goderbauer
f2f84ca95f
Fix empty composing range on iOS (#10381) 2019-08-07 09:22:40 -07:00
Chinmay Garde
b769353cfd
Allow embedders to control Dart VM lifecycle on engine shutdown. (#10652)
This exposes the `Settings::leak_vm` flag to custom embedders. All embedder
unit-tests now shut down the VM on the shutdown of the last engine in the
process. The mechanics of VM shutdown are already tested in the Shell unit-tests
harness in the DartLifecycleUnittests set of of assertions. This just exposes
that functionality to custom embedders. Since it is part of the public stable
API, I also switched the name of the field to be something less snarky than the
field in private shell settings.
2019-08-06 16:15:37 -07:00
Matt Carroll
735255f36a
Android embedding refactor pr40 add static engine cache (#10481) 2019-08-06 16:15:21 -07:00
Chris Bracken
37a283765c
Migrate Fuchsia runners to SDK tracing API (#10478)
Migrates the Fuchsia Flutter and Dart runners off the internal tracing
APIs and onto the public SDK.
2019-08-06 11:26:34 -07:00
Qxyat
bad862e13d reset platformViewsController in engine.destroyContext when allowHeadlessExecution = false (#10629) 2019-08-05 17:36:58 -07:00
Kaushik Iska
ad3846effa
[flutter_runner] Port: Add connectToService, wrapping fdio_ns_connect. (#10644)
Use fdio_ns_connect to connect to services in a namespace. For pure
persistant fidl services the old path of creating a file descriptor and
then opening a channel to that file descriptor doesn't work.

We should provide a way to directly connect to a service without first
treating it as a file.

Test:
* workstation.frank, reboot button on main menu works.
* astro, device_settings "erase user data" reboot works.

Change-Id: I725ba9350547309bebb5530aa44236f841d88f99
2019-08-05 16:36:59 -07:00
sjindel-google
d6a02a3f67
Ensure debug-mode apps are always attached on iOS. (#10186) 2019-08-06 01:07:33 +02:00
Nathan Rogers
e81aa5869c
Use Fuchsia trace macros when targeting Fuchsia SDK (#10634)
When |OS_FUCHSIA| is defined (even when |FUCHSIA_SDK| is defined as
well), use the Fuchsia SDK trace macros rather than the Dart timeline.

Reasons for doing this include:

Fuchsia's trace macros support categories.  This allows one to
distinguish between (e.g.) "flutter" and "skia" trace events for trace
recording and trace visualization.

Fuchsia has existing in tree benchmarks that depend on finding certain
events under category "flutter".

See the Fuchsia performance mailing list discussion for more context.
2019-08-05 12:52:36 -07:00
Chinmay Garde
9c9f73e183
Fix threading and re-enable resource cache shell unit-tests. (#10636)
The rasterizer may only be accessed safely on the GPU task runner. The test was accessing the same on a non-engine known task runner instead (i.e the tests main task runner).

Crashes previously reproducible on all platforms with the following filters: `--gtest_filter="*ShellTest.SetResourceCacheSize*" --gtest_repeat=-1 --gtest_shuffle --gtest_random_seed=1988` at run ~400.

Fixes https://github.com/flutter/flutter/issues/37629
2019-08-05 12:47:30 -07:00
Kaushik Iska
8fd871799f
[fuchsia] CloneChannelFromFD fix for system.cc (#10635)
This is a utils method currently not exposed from fuchsia.
Ported over from [garnet
fd.cc](https://fuchsia.googlesource.com/fuchsia/+/master/garnet/public/lib/fsl/io/fd.cc).
2019-08-05 12:05:20 -07:00
Dan Field
2ccfd9e562
skip flaky tests (#10633) 2019-08-05 10:22:43 -07:00
Dan Field
960501721b
Reland Skia Caching improvements (#10434) 2019-08-02 19:31:57 -07:00
Chris Bracken
da0b7716c6
Add #else, #endif condition comments (#10477)
Adds a few missing condition hints on some preprocessor conditionals.
2019-08-02 15:45:07 -07:00
Jason Simmons
26368225b5
Fix deprecation warnings in the Android embedding (#10424) 2019-08-01 18:13:27 -07:00
Kaushik Iska
310bc030b4
Make kernel compiler use host toolchain (#10419) 2019-08-01 12:57:03 -07:00
Kaushik Iska
b41c172bcd
[fuchsia] Kernel compiler is now ready (#10309)
Also fixes the architecture of the bundled SO files.
2019-07-31 20:41:11 -07:00
Francisco Magdaleno
6aad13910c
[glfw] Enables replies on binary messenger in glfw embedder (#9948) 2019-07-31 14:27:46 -07:00
Francisco Magdaleno
cfa6c7c72b
[macos] Reland function refactor (#10189)
* [macos] Reland function refactor

* Fix bug
2019-07-31 10:57:02 -07:00
Dan Field
ed8e35c4cf
Remove get engine (#9747) 2019-07-30 17:11:04 -07:00
Matt Carroll
4c6948a88a
Android Embedding Refactor 38: Removed AssetManager from DartEntrypoint. (#10250) 2019-07-30 12:57:01 -07:00
Kaushik Iska
0d66b32516
[fuchsia] Start building dart_patched_sdk (#10246)
* [fuchsia] Start building dart_patched_sdk

* fix path
2019-07-30 09:57:58 -07:00
Matt Carroll
f336e05a69
Android Embedding PR37: Separated FlutterActivity and FlutterFragment via FlutterActivityAndFragmentDelegate (#9895) 2019-07-29 17:40:25 -07:00
Michael Klimushyn
839f9a2707
Deprecate FlutterView#enableTransparentBackground (#10235)
The API breaks accessibility highlighting because of
SurfaceView#setZOrderOnTop. Deprecate it since the underlying issue is
an Android SDK one that can't be worked around from within a
SurfaceView.
2019-07-29 12:46:26 -07:00
Michael Klimushyn
67524615be
Add better CIPD docs. (#10185)
Also commits cipd.yaml to source.
2019-07-26 15:39:48 -07:00
Kaushik Iska
3e3efe4c6c
[dart_runner] dart jit runner and dart jit product runner (#10179)
We now build dart runner as well
2019-07-26 13:29:46 -07:00
Jonah Williams
be9b245690
add suggested changes from flutter roll (#10176) 2019-07-26 12:56:08 -07:00
Kaushik Iska
3e0cff2a61
[fuchsia] Add support for aot mode in flutter runner (#10171)
* [fuchsia] Add support for aot mode in flutter runner

* [fuchsia] Bundle observatory with not product runners
2019-07-26 10:19:13 -07:00
Kaushik Iska
5f6f278520
[dart_runner] Rename dart to dart runner (#10172) 2019-07-26 10:15:08 -07:00
Kaushik Iska
5edd787cf2
[fuchsia] Push CMX to fars and add product mode support (#10144)
* Capture stderr for ninja command

* br

* [fuchsia] Push CMX to fars and add product mode support.

* fix shit

* fix GN format
2019-07-25 15:09:04 -07:00
Francisco Magdaleno
330b0f023c
Revert "[macos] Revert check on FlutterCodecs and refactor message function] (#10009)" (#10141)
This reverts commit bd3870219a1a7f6e18c94430ead9e0f8375b03b1.
2019-07-25 13:47:29 -07:00
gaaclarke
0ecb793e1d
ios: Fixed the callback for the first frame so that it isn't predicated on having a splash screen. (#9952) 2019-07-25 12:37:38 -07:00
gaaclarke
876eff6c6d
Revert "[fuchsia] Use the patched sdk to generate the flutter jit runner far (#10122)" (#10140)
This reverts commit fcd67323b2cd454fd9134850d4e0c9270fd43db5.
2019-07-25 10:52:27 -07:00
Kaushik Iska
fcd67323b2
[fuchsia] Use the patched sdk to generate the flutter jit runner far (#10122) 2019-07-24 17:10:48 -07:00
gaaclarke
aaf6bad4be
Fixed memory leak with engine registrars. (#10068) 2019-07-24 15:43:39 -07:00
Kaushik Iska
4bf81b8cf8
[fuchsia] Use manifest file to better replicate the existing build (#10102)
* Use manifest file to better replicate the existing build

Also fix app/bin error

* Add remaining shit

* patch in the remaining stuff

* Update BUILD.gn
2019-07-24 13:57:46 -07:00
Kaushik Iska
bdc7136953
[fuchsia] Add sysroot and clang libs to package (#10082)
* [fuchsia] Add sysroot deps

* bundle in clang stuff too

* fix host_os
2019-07-23 21:08:25 -07:00
Kaushik Iska
cf5d76c172
[fuchsia] Add support for libs in packages (#10081) 2019-07-23 19:22:42 -07:00
Kaushik Iska
eb74f2ce70
One more luci fix (#10078)
* Missing icu data from the far

* One more place to change the artifact name

* real name
2019-07-23 17:56:49 -07:00
Kaushik Iska
abf93699fd
Basic structure for flutter_jit_runner far (#10073)
* Basic structure for flutter_jit_runner far

- Added a package_dir gni that copies the dir structure.
- Doesn't support a lot of the existing functionality.
- Added a script to copy paths.

* pick libdart based on flutter mode

* fix licenses
2019-07-23 16:51:50 -07:00
Francisco Magdaleno
bd3870219a
[macos] Revert check on FlutterCodecs and refactor message function] (#10009)
* [macos] Revert check on FlutterCodecs and refactor message function]

* Remove duplicated code

* Move FlutterPlatformMessage initialization
2019-07-23 15:22:38 -07:00
adazh
ef99738baf
Added a DartExecutor API for querying # of pending channel callbacks (#10021) 2019-07-23 13:11:03 -07:00
Michael Klimushyn
8ed5da8b65
Add working Robolectric tests (#9954)
`gclient sync` now grabs Robolectric, JUnit, and their transitive
runtime dependencies. They're being stored in a new CIPD package,
`flutter/android/robolectric_bundle`.

`shell/platform/android/BUILD.gn` has a new target for building the
tests, `robolectric_tests`. `testing/run_tests.py` has been extended to
build and run the new target. Runs the android tests under
"build_and_test_android" on CI.

This also adds some very simple sample tests to start with and a README
to the java tests directory.
2019-07-23 09:06:19 -07:00
Justin McCandless
4decc174ee
Add support for Android's visible password input type (#9999)
For framework PR https://github.com/flutter/flutter/issues/31738
2019-07-23 07:57:39 -07:00
stuartmorgan
7d320c45ab
Add a macro for prefixing embedder.h symbols (#9851)
embedder.h is a C API, so has no namespace, and only uses 'Flutter' as a
prefix for most symbol names. This creates potential collisions with
other code; for instance, FlutterEngine is the name of a type in
embedder.h, but also an ObjC class in the iOS Flutter API.

This adds a macro that can be set to prefix symbol names, allowing
clients (notably, the macOS embedding) to adjust the names used by the
embedding API internally without breaking ABI or API compatibility for
the standard engine build.

Currently the macro is only applied to FlutterEngine, since that's the
symbol that is currently at issue, but it can be expanded to other
symbols in the future.
2019-07-23 05:48:48 -07:00
Matt Carroll
3aaeca3a57
Android Embedding Refactor PR36: Add splash screen support. (#9525) 2019-07-22 14:01:34 -07:00
Jason Simmons
1961417172
Exit flutter_tester with an error code on an unhandled exception (#9932) 2019-07-22 12:06:34 -07:00
Jason Simmons
be8819e2dc
Declare a copy of the enable_bitcode flag within the Flutter build scripts for use in Fuchsia builds (#10003)
enable_bitcode is defined in build/toolchain/clang.gni, which exists in the
Flutter buildroot but not in the Fuchsia source tree.
2019-07-22 12:06:16 -07:00
Francisco Magdaleno
6f3a2eb131
[macos] Add reply to binary messenger (#9953)
* Add reply to binary messenger

* Address comments

* Formatting

* Address comments
2019-07-22 11:08:08 -07:00
Matt Carroll
9cf13568e2
Added hasRenderedFirstFrame() to old FlutterView for Espresso (#36211). (#9939) 2019-07-19 16:46:02 -07:00
Matt Carroll
649e025f70
Removed PlatformViewsController if-statements from TextInputPlugin (#34286). (#9938) 2019-07-19 13:52:45 -07:00