21693 Commits

Author SHA1 Message Date
godofredoc
793e8e5ebb Remove ios-release-nobitcode from engine v2 builders. (flutter/engine#40830)
Remove ios-release-nobitcode from engine v2 builders.
2023-03-31 22:41:11 +00:00
Jackson Gardner
109dba62a1 Add ui_web to embedder.yaml so that the analyzer knows about it. (flutter/engine#40827)
Add ui_web to embedder.yaml so that the analyzer knows about it.
2023-03-31 21:30:17 +00:00
skia-flutter-autoroll
96f8457914 Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision) (flutter/engine#40826)
Roll Skia from 2b86c6d364d0 to 33f80c07a09c (1 revision)
2023-03-31 21:16:32 +00:00
Jonah Williams
f67fd036d6 [Impeller] Increase precision of texture coordinate input (flutter/engine#40803)
[Impeller] Increase precision of texture coordinate input
2023-03-31 20:56:01 +00:00
Zachary Anderson
284b13faae Revert "[macOS] Change view ID to signed" (flutter/engine#40829)
Reverts flutter/engine#39958

Failing the roll to the framework starting with
https://github.com/flutter/flutter/pull/123893

One example:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20dart_plugin_registry_test/21819/overview
2023-03-31 13:52:57 -07:00
Zachary Anderson
342f3ce824 Fix pretty list printer to handle nulls (flutter/engine#40825)
Fix pretty list printer to handle nulls
2023-03-31 20:20:04 +00:00
Jason Simmons
5735652166 [Impeller] Declare gradient shader inputs as high precision to avoid overflows. (flutter/engine#40806)
[Impeller] Declare gradient shader inputs as high precision to avoid overflows.
2023-03-31 20:08:54 +00:00
Harry Terkelsen
89f12f767f Revert "Re-enable LTO and roll buildroot to enable sINLINING_LIMIT" (flutter/engine#40822)
Reverts flutter/engine#40808

Regresses benchmarks:
https://flutter-flutter-perf.skia.org/e/?numCommits=100&queries=test%3Dweb_benchmarks_canvaskit
2023-03-31 12:35:59 -07:00
Tong Mu
d3bbe5cb8a [macOS] Change view ID to signed (flutter/engine#39958)
This PR makes view ID signed from unsigned int64.

Initially, I made view IDs unsigned because they were opaque anyway. As
I'm working deeper into multiview, I found some issues that made me
think signed is better:

* Unsigned integers are worse
  * Sometimes you want negative values to represent special values.
* Unsigned integers are dangerous (if compared with signed ones by
mistake.)
* Unsigned integers are not needed
  * We're very unlikely to reach that big anyway.
  * Almost all other languages support only signed integers.
  * Also JavaScript only supports up to 51 bits of integer.

Therefore I think it's better to change them to signed int64, especially
before these APIs are widely used by developers.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-03-31 12:11:49 -07:00
skia-flutter-autoroll
bd145d476a Roll Skia from 5f965db93be3 to 2b86c6d364d0 (4 revisions) (flutter/engine#40823)
Roll Skia from 5f965db93be3 to 2b86c6d364d0 (4 revisions)
2023-03-31 18:46:09 +00:00
Loïc Sharma
f4f8988c2a Complete the update semantics embedder API migration (flutter/engine#40773)
Complete the update semantics embedder API migration
2023-03-31 18:40:42 +00:00
skia-flutter-autoroll
5c20d020db Roll Skia from 38cbca906011 to 5f965db93be3 (7 revisions) (flutter/engine#40821)
Roll Skia from 38cbca906011 to 5f965db93be3 (7 revisions)
2023-03-31 16:01:38 +00:00
Zachary Anderson
afe2be4024 Clean up gn script goma logic a bit (flutter/engine#40817) 2023-03-31 08:23:33 -07:00
Zachary Anderson
db6bf07686 Revert "[Impeller] Use Vulkan by default (#40809)" (flutter/engine#40820)
This reverts commit 35efb76a0606844593208ce0c6722aeb9c6b89cf.

Reverting for https://github.com/flutter/flutter/issues/123859
2023-03-31 08:05:36 -07:00
skia-flutter-autoroll
799576572a Roll Skia from f6c1eefd4600 to 38cbca906011 (2 revisions) (flutter/engine#40816)
Roll Skia from f6c1eefd4600 to 38cbca906011 (2 revisions)
2023-03-31 14:08:22 +00:00
Dan Field
5e18c462d3 [Impeller] Reland move more files to core. (flutter/engine#40812)
[Impeller] Reland move more files to core.
2023-03-31 06:53:22 +00:00
Dan Field
6c649e4ba9 [Impeller] Skip TextRotated golden test. (flutter/engine#40818)
[Impeller] Skip TextRotated golden test.
2023-03-31 06:50:05 +00:00
Dan Field
35efb76a06 [Impeller] Use Vulkan by default (flutter/engine#40809)
[Impeller] Use Vulkan by default
2023-03-31 05:05:56 +00:00
Jackson Gardner
63dac880c4 Re-enable LTO and roll buildroot to enable sINLINING_LIMIT (flutter/engine#40808)
Re-enable LTO and roll buildroot to enable `sINLINING_LIMIT`
2023-03-31 04:09:55 +00:00
Brandon DeRosier
2b0d541321 [Impeller] iOS/macOS: Only wait for command scheduling prior to present (flutter/engine#40781) 2023-03-30 17:41:14 -07:00
skia-flutter-autoroll
f06d79cea2 Roll Skia from 9b2e538f1367 to f6c1eefd4600 (4 revisions) (flutter/engine#40807)
Roll Skia from 9b2e538f1367 to f6c1eefd4600 (4 revisions)
2023-03-31 00:38:24 +00:00
Dan Field
a77325dab9 Revert "[Impeller] move everything needed by the code gen template to core (#40801)" (flutter/engine#40811)
This reverts commit e31cf0690fe3fbb8f97bcaddeb3a953897869ce0.
2023-03-30 16:55:18 -07:00
Dan Field
81c86a261c [Impeller] Delete dead code from reflector.cc (flutter/engine#40805) 2023-03-30 16:35:17 -07:00
Dan Field
e31cf0690f [Impeller] move everything needed by the code gen template to core (flutter/engine#40801) 2023-03-30 16:35:02 -07:00
Jackson Gardner
1a59a35e3c ui_web library (flutter/engine#40608)
`ui_web` library
2023-03-30 23:14:18 +00:00
Jonah Williams
c44b7c1192 [Impeller] use native decal on metal and Vulkan backend (flutter/engine#40723)
[Impeller] use native decal on metal and Vulkan backend
2023-03-30 22:37:55 +00:00
gaaclarke
0407296be4 [Impeller] backfilled golden tests from playground tests in aiks_unittests. (flutter/engine#40770)
[Impeller] backfilled golden tests from playground tests in aiks_unittests.
2023-03-30 21:38:22 +00:00
dependabot[bot]
8c5378eb5e Bump github/codeql-action from 2.2.7 to 2.2.8 (flutter/engine#40661)
Bump github/codeql-action from 2.2.7 to 2.2.8
2023-03-30 21:15:57 +00:00
Zachary Anderson
a1119ed629 Un-ifdef vulkan code in impellerc (flutter/engine#40797)
[Impeller] Un-ifdef vulkan code in impellerc
2023-03-30 20:56:02 +00:00
Kevin Lubick
f944e918a1 Use new SkImages namespace instead of legacy SkImage static functions (flutter/engine#40761)
Use new SkImages namespace instead of legacy SkImage static functions
2023-03-30 20:22:09 +00:00
godofredoc
46af818918 Add initial docs for the engine build definition. (flutter/engine#40621)
Add initial docs for the engine build definition.
2023-03-30 20:18:48 +00:00
Thomas Gales
7f5afc5533 [fuchsia] Feedback filing migration (flutter/engine#40736)
[fuchsia] Feedback filing migration
2023-03-30 20:09:50 +00:00
Brandon DeRosier
8fe44e180e [Impeller] Always create at least one RenderPass if the clear color has been overridden (flutter/engine#40793)
[Impeller] Always create at least one RenderPass if the clear color has been overridden
2023-03-30 20:09:48 +00:00
Chinmay Garde
8116ea14c7 [Impeller] Enable vulkan validations via a flag on Android. (flutter/engine#40792)
[Impeller] Enable vulkan validations via a flag on Android.
2023-03-30 20:07:51 +00:00
skia-flutter-autoroll
daddd18785 Roll Skia from 1d687fb03a4a to 9b2e538f1367 (31 revisions) (flutter/engine#40790)
Roll Skia from 1d687fb03a4a to 9b2e538f1367 (31 revisions)
2023-03-30 19:41:47 +00:00
Bernardo Ferrari
60663bccf0 SemanticsFlag/SemanticsAction enum migration (part 1) (flutter/engine#40571)
`SemanticsFlag`/`SemanticsAction` enum migration (part 1)
2023-03-30 18:32:38 +00:00
Dan Field
3c6508d73e [Impeller] Go back to using MSL compiler backend for Vulkan (flutter/engine#40786)
[Impeller] Go back to using MSL compiler backend for Vulkan
2023-03-30 18:04:54 +00:00
Mouad Debbar
89becd1e69 [web] LRU cache for text segmentation (flutter/engine#40782)
[web] LRU cache for text segmentation
2023-03-30 18:01:08 +00:00
Jonah Williams
2e9cdc9bd8 Revert "[Impeller] migrate Gaussian shaders to half precision. (#40752)" (flutter/engine#40784)
Revert "[Impeller] migrate Gaussian shaders to half precision."
2023-03-30 17:49:11 +00:00
Dan Field
33e5c46f72 [Impeller] Remove duplicate include in scene_context.h (flutter/engine#40785)
[Impeller] Remove duplicate include in scene_context.h
2023-03-30 17:42:48 +00:00
Dan Field
21c804db76 [Impeller] Fallback to graphics queue is transfer queue is not available. (flutter/engine#40787)
[Impeller] Fallback to graphics queue is transfer queue is not available
2023-03-30 17:35:58 +00:00
skia-flutter-autoroll
043461bd75 Roll Skia from 001ba6e28f99 to 1d687fb03a4a (1 revision) (flutter/engine#40756)
Roll Skia from 001ba6e28f99 to 1d687fb03a4a (1 revision)
2023-03-30 17:30:51 +00:00
Dan Field
102e68ae36 [Impeller] Guard against empty grid sizes (flutter/engine#40769)
[Impeller] Guard against empty grid sizes
2023-03-30 17:18:05 +00:00
skia-flutter-autoroll
8c6e873849 Roll Fuchsia Linux SDK from hiuBNrBiGQLcPYrmg... to wylduTqeHd3pLUo0V... (flutter/engine#40780)
Roll Fuchsia Linux SDK from hiuBNrBiGQLcPYrmg... to wylduTqeHd3pLUo0V...
2023-03-30 13:25:05 +00:00
luckysmg
de2ccc20e3 Revert "[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. (#40703)" (flutter/engine#40777)
Revert "[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct."
2023-03-30 08:11:57 +00:00
Chinmay Garde
d48b1b596f [Impeller] Handle cases where the max swapchain image count can be zero. (flutter/engine#40776)
[Impeller] Handle cases where the max swapchain image count can be zero.
2023-03-30 07:13:10 +00:00
luckysmg
9b3ea55c61 [iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. (flutter/engine#40703)
[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct.
2023-03-30 05:30:17 +00:00
Brandon DeRosier
3cb18e4d28 [Impeller] Don't use waitUntilScheduled on iOS (flutter/engine#40768)
[Impeller] Don't use waitUntilScheduled on iOS
2023-03-30 04:06:18 +00:00
Brandon DeRosier
2ac9efa6a5 Fail GN when impeller backends are enabled which are impossible to build (flutter/engine#40772) 2023-03-29 20:11:41 -07:00
hangyu
f53c064783 [macOS]Support SemanticsService.announce (flutter/engine#40585)
[macOS]Support SemanticsService.announce
2023-03-30 01:37:05 +00:00