This patch is in preparation for incremental package serving from the engine repo.
fxbug.dev/76633
Previous attempt to land this patch was failing because I was generating
the package manifest in the package's directory.
Currently, the licenses are copied into the bucket just before
uploading it. Copying the licenses is definitely more about "building"
the bucket than it is about "processing the CIPD package", but
concretely, some tools complain if the license files arent there, and
I'd like to be able to use the cipd tool to upload the bucket
directly.
Co-authored-by: Hunter Freyer <hjfreyer@google.com>
Example before:
$ ./tools/fuchsia/build_fuchsia_artifacts.py \
--engine-version HEAD \
--no-lto \
--archs x64 \
--runtime-mode debug
Running gn for variant "fuchsia_debug_x64" with flags: --fuchsia,--fuchsia-cpu,x64,--runtime-mode,debug,--no-lto
Generating GN files in: out/fuchsia_debug_x64
Done. Made 1085 targets from 221 files in 532ms
ninja: Entering directory `/usr/local/google/home/hjfreyer/flutter/engine/src/flutter/tools/fuchsia/../../../out/fuchsia_debug_x64'
ninja: error: empty path
Traceback (most recent call last):
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 391, in <module>
sys.exit(main())
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 380, in main
args.targets.split(","))
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 283, in BuildTarget
BuildNinjaTargets(out_dir, [ 'flutter' ] + additional_targets)
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 72, in BuildNinjaTargets
os.path.join(_out_dir, variant_dir)] + targets)
File "./tools/fuchsia/build_fuchsia_artifacts.py", line 55, in RunExecutable
subprocess.check_call(command, cwd=_src_root_dir)
File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', '/usr/local/google/home/hjfreyer/flutter/engine/src/flutter/tools/fuchsia/../../../out/fuchsia_debug_x64', 'flutter', '']' returned non-zero exit status 1
Co-authored-by: Hunter Freyer <hjfreyer@google.com>
Used the the `misspell` tool available at
https://github.com/client9/misspell, then applied hand-corrections. It's
possible we could adopt this as a presubmit, but there are still enough
false positives that it may not be worth the effort.
* Roll Dart SDK from b7e02a713eab to 91d7c69ed7ea
Update const_finder_test expectations to accommodate daae24b4880.
Changes since last roll:
```
91d7c69ed7e Version 2.13.0-143.0.dev
88c24ef66ac Roll benchmarks-internal 354c978979c5..076df10d9b77
b250a58d8e8 Implement `int.>>>` for DDC.
7e2cc73da8b Revert "[infra] Make worktrees work (again?)"
a531b78369e [infra] Make worktrees work (again?)
945ac84c16e Version 2.13.0-142.0.dev
e8f57b66058 [vm/aot] Handle FieldInitializer pointing to a Field's Reference which is reused for a getter
1cb203d8c9b Remove unused code and files from analysis_server:
3162957a786 (origin/base) [gardening] Add explicit type to ensure templated function applies.
7b35c1ecc2f (tag: 2.13.0-141.0.dev) Version 2.13.0-141.0.dev
829ef927789 [vm] Expand compressed heap to 4GB.
2472db00311 [vm] Inform the OS that it can reclaim free'd portions of the compressed heap.
e2baf16ebda Support ddc module format in expression compilation in ddc.
8e7c8c9d8b2 Roll icu dependency to 81d656878ec611cb0b42d52c82e9dae93920d9ba.
52fccfb392b Version 2.13.0-140.0.dev
6b575c72ec8 Prepare to publish analyzer 1.2.0 and _fe_analyzer_shared 18.0.0.
c0b800ceb51 Issue 45318. Check for dynamic bounded and Function bounded.
daae24b4880 [vm/aot] Retain fields used in constants
369c36e67c2 Issue 45299. Fix yield type check for function expressions.
c9e10c931cb [vm, compiler] Predicate boolean loads.
87bfe9ea276 (tag: 2.13.0-139.0.dev) Version 2.13.0-139.0.dev
cf3dcc4256c [analyzer] Prevent MOVE_FILE using absolute URIs when moving files out of lib
c9061339678 [cfe] Multi-call const function tests to existing behavior.
16beb348133 [vm/aot] Remove special cases of dynamic function lookups from precompiler
55522f9e90b Fix a bug in completion when a setter does not have a corresponding getter
d42de4ed062 [vm] Crash on impossible GDT null errors
69ec09825a3 [vm] On Android set abort message before aborting
b72e7b81ebd (tag: 2.13.0-138.0.dev) Version 2.13.0-138.0.dev
d6b79dab6c6 [cfe] Correct argument count in extension member errors
b5da327ed9a [parser] Parse and skip metadata according to spec
```
* Update const_finder_test expectations
* Update license
* Update expectations
This fixes an issue in CppWinRT related to std::terminate(); the tool
now uses abort() instead.
CppWinRT patch: https://github.com/microsoft/cppwinrt/pull/868
This also fixes a couple bugs in the README.md:
* Uses tmp as the temp dir into which we unpack the nupkg archive rather
than cppwinrt to avoid confusion with the containing directory, which is
named cppwinrt.
* Fixes a typo around the directory from which the cipd command should
be executed.
This moves tooling related to the creation of the Android embedding
bundle CIPD package under tools/cipd. Having a single location for CIPD
package creation tooling avoids spreading these around the tree and aids
in discovery.
This does not change the path within the CIPD package repo, nor does it
change the path to which we download it via gclient as specified in the
DEPS file.
This will be followed by a patch to add a new Windows CIPD package
necessary for UWP builds.
