820 Commits

Author SHA1 Message Date
Michael Goderbauer
58a1894a1c
Update to latest clang (#6174)
* Roll buildroot to be483cb1cd3a9c4313b2e534034d23a05c3d849e
* Rolls buildtools to c1408453246f0475547b6fe634c2f3dad71c6457
2018-09-06 15:29:04 -07:00
liyuqian
e70d0e1b7c
Always serialize fonts during skp capturing (#6160)
This fixes flutter/flutter#20788
2018-09-06 13:44:47 -07:00
Zachary Anderson
30c8da8abf
Pull $flutter_root:config into shell/engine/version:version (#6186)
To fix the Fuchsia build.
2018-09-06 12:26:20 -07:00
Chinmay Garde
ade0f22303
Remove unused file picture_serializer. (#6179) 2018-09-05 19:45:55 -07:00
Michael Klimushyn
108e0a64ef
Add transparency helpers to FlutterView.java (#6172)
Fixes #9627
2018-09-05 16:47:02 -07:00
Jason Simmons
e6d9b34a8c
Remove the old location of the ICU data asset (#6170)
The tools are now placing icudtl.dat in the flutter_shared directory.
It is no longer necessary to check for this asset at its previous path.
2018-09-05 12:22:27 -07:00
Simon Lightfoot
9f0ad8b794 Fixes negative end selection offset. (#6171) 2018-09-05 12:12:21 -07:00
Michael Klimushyn
0981731fd7
Enable transparent FlutterViews (#6163)
- Changes rasterizer to clear the canvas with `SkColor_TRANSPARENT`
- Removes the unused `backgroundColor` param from `FlutterView.java`
2018-09-05 10:44:02 -07:00
Jason Simmons
6af60d716a
Remove obsolete discovery mechanism from FlutterView (#6157) 2018-09-05 10:01:33 -07:00
Chinmay Garde
6ad3183b18
Fix windows build. (#6162) 2018-09-04 18:23:29 -07:00
Jason Simmons
b32ceafb1f
Add some more logs for diagnosing screenshot failures (#6156)
Fixes https://github.com/flutter/flutter/issues/21228
2018-09-04 14:38:10 -07:00
Kirill Nikolaev
b0b8daa7b2 Unregister onFrameAvailable callbacks when a TextureEntry is released. (#6079)
Otherwise the callbacks may be called after FlutterNativeView is destroyed and is null.

Also defensively check for whether the texture is already released in the callback because the callback may be called from another thread by a stale reference (see the comment).

This closes https://github.com/flutter/flutter/issues/20951.
2018-09-04 06:31:01 -07:00
Chinmay Garde
f25d89a2de
Fix windows embedder builds. (#6137) 2018-08-31 20:23:53 -07:00
Chinmay Garde
b3c778fe9c
Allow embedders to specify software renderer configs. (#6133) 2018-08-31 20:03:06 -07:00
James D. Lin
fbf6726436
Mark deprecated Flutter iOS APIs as unavailable (#6124)
The following were previously marked as deprecated over a month ago:
* `FlutterStandardBigInteger`
* `-[FlutterDartProject initFromDefaultSourceForConfiguration]`

Remove their implementations and mark them as unavailable.
2018-08-31 12:33:57 -07:00
James D. Lin
51d4be7745
Add a -[FlutterViewController splashScreenView] property (#6112)
Add a `-[FlutterViewController splashScreenView]` property

Add a `-[FlutterViewController splashScreenView]` property that
clients can use to customize the launch view (issue #17140).
2018-08-30 15:13:28 -07:00
jslavitz
1c76824186
entering a character with a selection deletes the selection (#6113) 2018-08-30 10:29:04 -07:00
Chinmay Garde
47a1ce0e62
Allow embedders to set the root surface transformation. (#6085) 2018-08-28 14:13:49 -07:00
Jonah Williams
56bad48ab2
expose bold text flag in accessibility features for iOS (#6072) 2018-08-28 12:38:54 -07:00
Amir Hardon
ad4e87d07d
Convert synthesized Android motion events to long and not to int. (#6103) 2018-08-28 12:12:47 -07:00
Jonah Williams
c867305c30
Unconditionally set resource id to empty string (#6096) 2018-08-27 10:54:07 -07:00
Chinmay Garde
3087090149
Allow embedders to invalidate FBO bindings after present. (#6084) 2018-08-24 16:53:13 -07:00
amirh
0914926014
Allow passing extra creation parameters for embedded Android views. (#6081)
This allows plugins to pass extra parameters from the Dart side to the
platform view constructor.
2018-08-24 11:15:14 -07:00
Chinmay Garde
c822ab26cf
Allow building the embedder API for the target toolchains. (#6069) 2018-08-22 16:42:47 -07:00
Chinmay Garde
140a5b7575
Alllow access to Flutter engine, Dart & Skia versions in the Shell API. (#6060) 2018-08-21 08:52:24 -07:00
amirh
2ff1626335
Support LTR/RTL layout directions for embedded Android views. (#6057) 2018-08-20 16:22:38 -07:00
amirh
c06432da47
Delay the removal of the onDrawListener. (#6052)
In Android O removing the ViewTreeObserver.onDrawListener from the
listener call crashes. Instead we post a runnable to remove it.
2018-08-20 12:13:26 -07:00
Jonah Williams
c23690f0d7
use setContentDescription for controls on Android (#6050) 2018-08-20 09:30:13 -07:00
amirh
be0c3143c5
Add views added to the WindowManager into the presentation view tree. (#6043)
The default WindowManager implementation in Android's Presentation is
delegating addView/removeView/updateViewLayout calls to the global
WindowManager.
This can result in a crash when an embedded view is trying to e.g show a
PopupWindow.

This change adds a custom WindowManager that overrides
addView (and removeView/updateViewLayout) and adds the view to the
presentation's view tree.

Note that views might keep a reference to the window manager which
might be an issue when we move a view from one virtual display to
another (due to a resize). For this reason when re-sizing we are not
creating a new window manager for the new presentation, but updating the
window manager's references to be relevant for the new presentation and
re-use it.
2018-08-17 17:01:42 -07:00
James D. Lin
4ff4a5cc99
Fix potential null pointer dereference in FlutterDartProject (#6035)
If `FlutterDartProject` found an `FLTLibraryPath` entry in an iOS
application's `Info.plist`, it assumed that values that were valid
filesystem paths were paths to bundles.  If the attempt to retrieve
the `NSBundle` fails, `FlutterDartProject` ignored the failure and
then would assign `nil` to a C++ `std::string`, resulting in a null
pointer dereference.

Add some failure checks to prevent this.
2018-08-16 17:40:33 -07:00
Chinmay Garde
9c0c62016d
Re-apply "Log Tonic errors with FML_LOG" (#6026)
This reverts commit d03897011aa6a88d2c95c0b7f3f47291db8eb2da and updates the tonic SHA.
2018-08-15 14:28:24 -07:00
Martin Kustermann
81baff97c2
Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (#6024) 2018-08-15 17:45:11 +02:00
Chinmay Garde
d03897011a
Revert "Log Tonic errors with FML_LOG" (#6021)
Reverts flutter/engine#6015

This is causing the Windows bots to fail.
2018-08-14 22:22:28 -07:00
Chinmay Garde
82c79f85e1
Fix Android Vulkan builds to account for resource context management API updates. (#6020) 2018-08-14 22:20:05 -07:00
Jason Simmons
f22dfa2d21
Log Tonic errors with FML_LOG (#6015) 2018-08-14 17:04:38 -07:00
Jason Simmons
ea07f27997
Detach the resource context before shutting down the IO thread (#6009) 2018-08-14 13:15:42 -07:00
Niko Yuwono
6e780fdc67 Add NSNull check in setSystemChromeSystemUIOverlayStyle (#6011) 2018-08-14 11:45:45 -07:00
James D. Lin
7ec5f8ada4
Don't require FLTLibraryPath and FLTAssetsPath from the main NSBundle (#5986)
We'd like the ability to add Flutter to existing iOS applications
without requiring that they set `FLTLibraryPath` and `FLTAssetsPath`
in the main bundle's `Info.plist`.

1. Modify `-[FlutterDartProject initWithPrecompiledDartBundle:]` to
   support setting the library and assets path from the specified
   `NSBundle` instead.

2. If no `NSBundle` is explicitly specified, look for one with a
   default bundle identifier ("io.flutter.flutter.app") before
   falling back to the main NSBundle.

Also remove `+[FlutterDartProject pathForFlutterAssetsFromBundle:]`
because we don't use it internally, and it isn't exposed in the
header file.
2018-08-14 10:45:05 -07:00
Chinmay Garde
89176ee006
Remove unused argument on Animator, Engine and PlatformView delegates. (#6007)
When these delegate methods were initially added, it was expected that a single
shell would be able to own mutliple platform views, engines and animators. This
plan was abandoned in favor of creating multiple shells with their own platform
views, engines, etc.. The arguments were meant to ease the disambiguate the
instances of the variaous objects managed by the shell. This is no longer
necessary.
2018-08-13 16:16:10 -07:00
Chinmay Garde
1eefcabe36
Check the kernel header magic to determine if a mapping may be a valid kernel blob. (#5997) 2018-08-10 15:12:48 -07:00
nathanrogersgoogle
149ea7b74c
Add a delay to Animator::BeginFrame's NotifyIdle call (#5972)
This change adds a delay before Animator::BeginFrame calls its
delegate's OnAnimatorNotifyIdle.  This is because under certain
workloads, such as our parent view resizing us, which is communicated
via viewport change events, we won't have a frame scheduled yet in the
animator, despite the fact that we will go on to schedule a frame once
the viewport event arrives.

In Fuchsia's resizing performance test, on our reference high end x86-64
hardware, the previous logic was resulting in a ~45ms garbage collection
right after the first frame of an animation.
2018-08-10 13:28:09 -07:00
Stanislav Baranov
74373462e4
Fix codepush breakage caused by #5954. (#5996) 2018-08-10 13:23:51 -07:00
amirh
a389dc595f
Cast MotionEvent timestamps to Number. (#5994)
Dart might choose to marshall the timestamps to a Java Long or Integer.
Casting directly to int was crashing when the timestamp wass a Long.
2018-08-10 12:46:49 -07:00
Todd Volkert
a84b210b3d
Reference platform_strong.dill, not platform.dill (#5992) 2018-08-10 11:55:36 -07:00
Ben Konyi
e54bc4ea18
Fixed invalid call site of runWithEntrypointAndCallback (#5984) 2018-08-09 12:42:59 -07:00
Ben Konyi
764884b91e
Removed callback for HeadlessDartRunner (#5983) 2018-08-09 11:21:51 -07:00
Alexander Aprelev
8a7af11f72
Fix IsolateStart event kind. (#5978) 2018-08-08 15:45:26 -07:00
Keerti Parthasarathy
78f8bcace7
Annotate deprecated methods with @Deprecated (#5976) 2018-08-08 13:02:41 -07:00
Jonah Williams
4208f84043
make ios text affinity behavior match android (#5971) 2018-08-08 10:54:29 -07:00
amirh
14af0348bc
Complete the AndroidView resize call only after a new frame is ready. (#5968)
This allows the framework to know that a frame with the resized view is
ready and to behave deterministically to workaround the jank issue
described in flutter/flutter/19572
2018-08-07 18:56:34 -07:00