1197 Commits

Author SHA1 Message Date
Ferhat
705fcac4eb
[web] Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls. (#17980)
* Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls.

* Remove font set test
2020-05-03 18:06:08 -07:00
Alexander Aprelev
1c8ee9856b
Introduce runtime check that it is root isolate that makes UI native calls. (#18050)
* Revert "Do not register UI-related native functions in secondary isolates (#6401)"

This reverts commit 69ae5694de54d2a163743dcec727fcea1c7bc8e1 as it doesn't work when root and secondary isolates run in the same isolate group.

* Confirm it is root isolate that makes UI native calls.

* Fix format, UIDartState reference from Fuchsia source

* No UI isolate check for fuchsia calls

* Fix typo. Remove redundant runtime calls
2020-05-01 09:05:41 -07:00
Mouad Debbar
3e975147fd
[web] First batch of unit tests for line breaker (#18034) 2020-04-30 10:50:51 -07:00
Yegor
590381a00a
soften shadows even more; fix shadow alpha (#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
7c084c57bd
[web] Use correct shell operator to compare file limits (#18032) 2020-04-29 18:12:48 -07:00
Siva
aa695d4d7b
Revert all build changes made to test the Dart NNBD unfork CL. (#18033) 2020-04-29 12:32:30 -07:00
Jason Simmons
01cf8c36ce
Disable the import_internal_library analyzer check for dart:ui (#18009)
The latest version of dartanalyzer does not support disabling this for a
specific line of code.
2020-04-28 13:45:47 -07:00
Siva
494a63c411
Trial PR to enable null safety unfork in the Dart SDK. (#17818)
* Trial PR to enable null safety unfork in the Dart SDK.

* Fix web-sdk builds.

* Manua; Roll of Dart cab69e77066b0db305187fd6e618a4f524ae9efd...03429b20cd67f85d65cc589b529ab8c1a4780912

dart-lang/sdk@ cab69e7706 [BUILD] - Initial CL to unfork the NNBD Dart SDK NOTE: This is a trial submit and will be reverted immediately.
2020-04-27 19:51:23 -07:00
Mouad Debbar
aa00d50396
[web] Don't allow empty initial route (#17936) 2020-04-27 13:54:07 -07:00
Mouad Debbar
d132ac576b
[web] Fix exception when getting boxes for rich text range (#17933) 2020-04-24 14:30:32 -07:00
Ferhat
cade0e90ca
[web] Batch systemFontChange messages (#17885)
* Batch systemFontChange messages
* Update test for async
2020-04-24 14:10:22 -07:00
Ferhat
371a8a05b0
[web] When a canvas element is reused and is first element in child list, preserve zIndex. (#17906)
* Fix zIndex removal on reuse
* Move check after append call to simplify
2020-04-23 15:09:59 -07:00
Nurhan Turgut
8fff8da38d
[web] autofill hints (#17887)
* adding autofill hints map from flutter values to the browser values, which will  be used by the web engine:

* removing unused reverse map

* addressing reviewer comments

* changing licences
2020-04-23 10:00:56 -07:00
Ferhat
ace381d76c
[web] Speedup color to css string 25% (#17866)
* Speedup color to css string 25%
2020-04-22 12:28:29 -07:00
Yegor
deaf14ec7d
Use Float32List as Matrix storage inside the Web engine (#17856)
This change converts all Float64List matrices to Float32List at the dart:ui interface boundary. Internally, it only uses Float32List. Float32List requires less memory and is orders of magnitude faster to allocate, and it has sufficient precision as Flutter mobile engine and Skia use 32-bit floats anyway.

This change speeds up frame preroll by 50% on the bench_card_infinite_scroll benchmark.

For more details on Float64Array allocation in JS (which backs Float64List in Dart) see the following:

https://bugs.chromium.org/p/v8/issues/detail?id=9199
https://bugs.chromium.org/p/v8/issues/detail?id=2022
2020-04-22 11:08:23 -07:00
Yegor
1beb220852
Report SceneBuilder submetrics through profiling API (#17852)
* add scenebuilder submetrics
* Disable Profiler by default
2020-04-22 09:15:18 -07:00
Ferhat
8d7071ea46
Prevent unnecessary DOM append call when canvas is reused (#17864) 2020-04-21 23:00:02 -07:00
Dan Field
f043e73d43
Roll CanvasKit to 0.14.0, fix Canvas.saveLayer(null, paint) (#17849) 2020-04-21 19:22:21 -07:00
Gary Qian
8dc91229b4
PlatformResolvedLocale localization message channel (#17755) 2020-04-21 15:34:44 -07:00
Ferhat
753514cefb
Canvas regression (#17738)
* Change backdrop filter element location based on ancestor clip. Add test.
* update test
* Addressed review comments. updated goldens
* Check ancestor on retain
* addressed review comments
2020-04-20 18:59:17 -07:00
Mouad Debbar
b0c4be9bd8
[web] Synthesize keyup event when the browser doesn't trigger a keyup (#17742) 2020-04-20 15:23:39 -07:00
Yegor
219c51f8d7
remove allocation from growLTRB; remove dynamism in vector_math (#17735) 2020-04-18 13:53:53 -07:00
Nurhan Turgut
ca3b36357f
[web] fix ulimit issues on Mac (#17767)
* check the max user limit before changing the limits

* more detailed changes in the file/user limit increase

* addressing pr reviews
2020-04-17 17:55:52 -07:00
Ferhat
5c0da71518
[web] Cleanup. Split path and surface stats code into separate files (#17796)
* Split path and surface stats code into separate files

* Update licenses
2020-04-17 17:47:22 -07:00
Nurhan Turgut
58cdc93242
web engine should not give an error for the new text editing method. (#17771) 2020-04-17 10:27:33 -07:00
Brian Osman
fb208b486e
Convert semantics_node from SkMatrix44 to SkM44 (#17763)
* Convert semantics_node from SkMatrix44 to SkM44
2020-04-17 07:24:40 -04:00
Yegor
dd87e3f944
Optimize static content scrolling (#17621)
* store paint command bounds
* do not apply commands outside the clip region
* better cull rect prediction
* enforce RecordingCanvas.endRecording
2020-04-14 20:08:10 -07:00
Ferhat
1192667a7a
[web] Fix extra canvas generation due to context access (#17710)
* Fix extra canvas generation due to context access
* add comment
* address review comment
2020-04-14 15:40:16 -07:00
Ferhat
4a1085a6f2
[web] Fix compositing order when adding paragraph tags (#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
Nurhan Turgut
deef2663ac
Run integration tests on ci (#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
Mehmet Fidanboylu
47a88e8ea3
Add support for setting allow http flag in Dart VM (#17653) 2020-04-11 11:55:05 -07:00
Mouad Debbar
c69f21a349
[web] Combine duplicate platform message spy implementations (#17615) 2020-04-10 13:30:41 -07:00
Ferhat
6b065297cf
Fix Path hit test code for high dpi devices (#17608) 2020-04-09 22:18:42 -07:00
Nurhan Turgut
6245149b41
[web] using pkill to quit safari (#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Ferhat
db644677fa
[web] Fix multi-reply on message channel. Add test (#17591)
* Fix multi-reply on message channel. Add test
* Add check for viewInstanceCount
* skip no-headless test
2020-04-08 17:18:06 -07:00
Mouad Debbar
7a591cf475
[web] Fix regression of pointer events on mobile browsers (#17595) 2020-04-08 14:48:56 -07:00
Mouad Debbar
b0b67ef9e2
[web] Fix window.defaultRouteName (#17580) 2020-04-08 13:51:38 -07:00
Harry Terkelsen
38cba0757d
Do not enable antialiasing by default in CanvasKit mode (#17534)
* Do not enable antialiasing by default in CanvasKit mode

* Add comment
2020-04-08 11:55:23 -07:00
Nurhan Turgut
394ac6b484
[web] fix clipboard.getData (#17544)
* remove the fake reply for paste message. the clipboard.dart will reply with the content of the clipboard

* also remove the fake answer for copy
2020-04-07 11:34:33 -07:00
chunhtai
e2fcc66fc6
always forward move event (#17541)
flutter/flutter#54022

The original issue is the _MotionEventsDispatcher depends on all down pointers to send out their own move events. If the third pointer has the movement of zero, it will get filter out by the PointerDataPacketConverter. This result with only two pointer move events been sent to RenderAndroidView, and they both get ignored because it is waiting for the third one.

This pr fixes it by always forward the move event
2020-04-07 11:24:11 -07:00
Mouad Debbar
bd760768c8
[web] Detect when the mouseup occurs outside of window (#17495) 2020-04-06 15:06:03 -07:00
cjng96
46277fd2ca
Remove code which skips keyEvent from input control on web (#17242) 2020-04-01 09:32:18 -07:00
liyuqian
f003d9b41a
GPU to raster rename, patch 2 (#17428) 2020-03-31 15:16:11 -07:00
liyuqian
807ca8543c
More rename from GPU thread to raster thread (#17408)
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor https://github.com/flutter/engine/pull/17329

Due to file name changes, this PR is expected to change the license files.

We haven't rename `shell/gpu` to `shell/raster` yet. It should be optional but I think it's better to have `raster_surface_software.cc` than `gpu_surface_software.cc`.
2020-03-31 14:05:28 -07:00
Ferhat
40931c8fe5
[web] Fix HtmlImage state pollution due to image.clone optimization (#17370)
* fix drawImage style when destination width==source
* Add regression test
* dartfmt
* update golden lock
* Addressed review comment
* remove transform reset since _drawImage is called
2020-03-30 16:42:36 -07:00
gaaclarke
113ebf963f
Roll src/third_party/dart 1402e8e1a42d.e21c4353006d (95 commits) (#17386)
git log 1402e8e1a42d..e21c4353006d665e7c4378413ad4d237f18437e0 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 jsimmons@google.com [dart:io] Fuchsia version of SocketBase::AvailableDatagram
2020-03-30 jwren@google.com Fix the dart help test output by implementing printUsage() in the test command
2020-03-30 sstrickl@google.com [vm/aot] Drop some Function objects not needed at runtime.
2020-03-30 mit@google.com Roll pub to latest version
2020-03-30 scheglov@google.com Document differences in inheritance tests between CFE and analyzer.
2020-03-30 scheglov@google.com Revert "Fix the result type of binary expression with the left TypeParameter extends num type."
2020-03-30 johnniwinther@google.com [cfe] Handle member signatures from dill in class hierarchy builder
2020-03-30 eernst@google.com [cfe] Add missing .next in endImplicitCreationExpression
2020-03-30 jensj@google.com [CFE] Add api to get language version for uri
2020-03-30 johnniwinther@google.com [cfe] Don't include member signature in id testing by default.
2020-03-30 johnniwinther@google.com [kernel] Make verbose qualified names conditional in toStringInternal
2020-03-30 devoncarew@google.com [dartdev] test the dartdev analyze --fatal-warnings option
2020-03-30 brianwilkerson@google.com Enable omit_local_variable_types in analyzer_plugin
2020-03-30 brianwilkerson@google.com Enable omit_loval_variable_types in analysis_server_client
2020-03-30 brianwilkerson@google.com Enable omit_local_variable_types in analysis_server
2020-03-30 keertip@google.com Add guard code for exceptions from ResourceProvider when reading contents.
2020-03-29 scheglov@google.com Fix the result type of binary expression with the left TypeParameter extends num type.
2020-03-28 scheglov@google.com Fix for creating a setter when the target is in a part without a library.
2020-03-28 brianwilkerson@google.com Remove the need for a --corpus flag from completion_metrics
2020-03-28 brianwilkerson@google.com Remove the need for a --corpus flag from relevance_metrics
2020-03-28 brianwilkerson@google.com Remove an unused variable in AstBuilder
2020-03-28 brianwilkerson@google.com Sort non-generated files in analyis_server and add a test to ensure they stay that way
2020-03-28 scheglov@google.com Add LibraryElement.languageVersionMajor/Minor
2020-03-28 scheglov@google.com Report exceptions with the file content for getResult().
2020-03-28 scheglov@google.com Fix crash in index when the invoked element is multiply defined.
2020-03-28 eernst@google.com Add implementation of several parts of non-function type aliases
2020-03-28 johnniwinther@google.com [cfe] Groups standard tests in update_expectations.dart
2020-03-28 sra@google.com [dart2js] Specialize is- and as- tests for nullable types
2020-03-28 rmacnak@google.com [vm] Do not allocate when evaluating arguments to StorePointer.
2020-03-28 rmacnak@google.com [vm] Fix some data races with profiler samples.
2020-03-28 alexmarkov@google.com Revert "[analyzer] Remove deprecated language version API"
2020-03-27 nshahan@google.com [ddc] Cleanup cast in dart:_runtime lib
2020-03-27 brianwilkerson@google.com New relevance values for UriContributor
2020-03-27 brianwilkerson@google.com New relevance values for KeywordContributor
2020-03-27 brianwilkerson@google.com New relevance values for VariableNameContributor
2020-03-27 paulberry@google.com Migration: don't use union edges for field formal parameters
2020-03-27 rmacnak@google.com [vm] Fix memory leak in profiler when some samples are in native functions without a dynamic symbol.
2020-03-27 bkonyi@google.com [ package:dds ] Fixed smoke_test.dart which was unable to launch smoke.dart due to use of a relative path.
2020-03-27 zichangguo@google.com [dart:io] Fix parsing the response of the HTTP connect method
2020-03-27 mfairhurst@google.com [nnbd_migration] Add confirm dialog to "apply migration" button
2020-03-27 rmacnak@google.com [test] Update use of Null as a bottom type to Never.
2020-03-27 eernst@google.com Added new tests.
2020-03-27 alexmarkov@google.com [vm/nnbd/aot/tfa] Support NNBD strong mode in type flow analysis
2020-03-27 mfairhurst@google.com [analyzer] Remove deprecated language version API
2020-03-27 brianwilkerson@google.com Update relevance computations in LocalReferenceContributor
2020-03-27 brianwilkerson@google.com Update relevance values for LocalLibraryContributor and ImportedReferenceContributor
2020-03-27 sigurdm@google.com Bump pub version
2020-03-27 sigmund@google.com [dart2js] Update test-matrix to specify the libraries.json to dart2js batch runner
2020-03-27 jcollins@google.com Update dartdoc to 0.30.3.
2020-03-27 alexmarkov@google.com [vm/nnbd] Fix marking static fields as late
2020-03-27 scheglov@google.com Fix for completion in formal parameters of GenericFunctionType.
2020-03-27 mfairhurst@google.com [nnbd_migration] Add a "rerun from sources" button.
2020-03-27 mfairhurst@google.com Revert "[analyzer] Copy result of allSupertypes for now."
2020-03-27 scheglov@google.com Merge types during instance member inference.
2020-03-27 scheglov@google.com Catch linking exceptions and include the cycle file contents.
2020-03-27 johnniwinther@google.com [cfe] Handle throw in return type inference
2020-03-27 alexmarkov@google.com [vm/aot/tfa] Fix tracking of parameters in async_op closures
2020-03-27 zichangguo@google.com Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 athom@google.com [infra] Update checked-in SDKs to 2.8.0-dev.18.0
2020-03-27 johnniwinther@google.com [cfe] Add tool for updating all id-tests and expectation tests
2020-03-27 athom@google.com [homebrew] Add support for the beta channel formula
2020-03-27 brianwilkerson@google.com Sort files in analysis_server_client and analyzer_plugin and add tests to keep them that way
2020-03-27 askesc@google.com [benchmark] Benchmark for UTF-8 decoding with typical data.
2020-03-27 jensj@google.com [parser] Change recovery for constructor; report errors in bad constructors
2020-03-27 johnniwinther@google.com [cfe] Use legacy erasure before argument inference
2020-03-27 jensj@google.com [kernel] Polish toString implementation on AST nodes
2020-03-27 sra@google.com [dart2js] Print non-minified init object as multiline
2020-03-27 karlklose@google.com [infra] Handle test steps with no tested configuration
2020-03-27 zichangguo@google.com [dart:io] remove available at _NativeSocket::Read
2020-03-27 nbosch@google.com Remove a stale TODO comment
2020-03-27 rnystrom@google.com Add other breaking changes to CHANGELOG.
2020-03-27 liama@google.com [nnbd/test] Fix tests that are failing in strong mode
2020-03-26 rnystrom@google.com Fix Markdown link in CHANGELOG and remove duplicate entry.
2020-03-26 brianwilkerson@google.com Compute new relevance in LocalConstructorContributor
2020-03-26 kevmoo@google.com DEPS: remove references to pkg:package_resolver
2020-03-26 jcollins@google.com Add a way for analysis_server to open communication via a IsolateChannel.
2020-03-26 scheglov@google.com Use NNBD_TOP_MERGE to combine signatures of the inherited members.
2020-03-26 nshahan@google.com [ddc] Update types in JSArray operations
2020-03-26 srawlins@google.com Migrator: Add an auth token for the preview site
2020-03-26 dacoharkes@google.com [vm] Add Reachability Fence Instruction
2020-03-26 sra@google.com [benchmark] Make BigIntPrintParse be NNBD-agnostic
2020-03-26 rnystrom@google.com Bump the SDK constraint on dart_internal to permit Dart 2.8.0.
2020-03-26 kevmoo@google.com Update changelog with dart2js --package-root removal
2020-03-26 alexmarkov@google.com [vm/corelib] Specify types explicitly in convert_patch.dart
2020-03-26 scheglov@google.com Update checkForWrongTypeParameterVarianceInMethod(), fix NPE.
2020-03-26 mfairhurst@google.com [analyzer] Copy result of allSupertypes for now.
2020-03-26 scheglov@google.com Add  more data to debug crash in buildExportNamespace().
2020-03-26 scheglov@google.com Fix for crash when FieldFormalParameter in a local function has annotations.
2020-03-26 bkonyi@google.com [ VM / DartDev ] Disable DartDev for the 2.8 release
2020-03-26 kevmoo@google.com Remove unused package-root option and configuration from dart2js
2020-03-26 srujzs@google.com [dart:html] Add nullability to EventTarget conversion
2020-03-26 kevmoo@google.com DEPS: Bring in latest pub
2020-03-26 dacoharkes@google.com [vm/ffi] Mark Struct as entrypoint
2020-03-26 jensj@google.com [analyzer] Sort entries in error.dart and syntactic_errors.dart
2020-03-26 karlklose@google.com [infra] pkg/smith: custom test runner steps are test steps
2020-03-30 15:22:47 -07:00
Ferhat
c779894d08
[web] Fix canvas z-index leaking across repaints when element is reused. (#17378)
* Fix z-index leak. Add test for canvas reuse
* add regression test
* update golden locks
* fix analysis errors
2020-03-30 12:54:06 -07:00
Yegor
7bd8dee5be
fix implicit dynamic and two lints everywhere; implicit cast in dev/ (#17372) 2020-03-29 19:23:37 -07:00
Nurhan Turgut
a973ade331
change chrome version (#17382)
* change chrome version

* change chrome version
2020-03-27 16:52:02 -07:00
Dan Field
4affba4fec
Add keep annotation to Locale.toString (#17376) 2020-03-27 15:24:54 -07:00