14811 Commits

Author SHA1 Message Date
Dan Field
9951638f3b
retry getting the main isolate (#68894) 2020-10-23 15:55:32 -07:00
Jonah Williams
0f28edac65
[flutter_tools] null safety mode is used for dill naming (#68898)
* [flutter_tools] null safety mode is used for dill naming

* add bad test case
2020-10-23 15:39:58 -07:00
Roc Boronat
8d6ba3ebe9
Fix a typo: "Its weight" instead of "It's weight" (#68883) 2020-10-23 14:17:04 -07:00
Jenn Magder
832d776b15
Stop debugger when iOS app crashes (#68844) 2020-10-23 14:12:04 -07:00
Yash Johri
f3562c6f1d
[SwitchListTile and CheckboxListTile] Adds selectedTileColor property (#68358) 2020-10-23 14:07:05 -07:00
Justin McCandless
0c63d63b1f
InteractiveViewer constrained docs (#68327) 2020-10-23 14:02:03 -07:00
Jenn Magder
59544e377d
Apple silicon arch -arm64 -> -arm64e (#68855) 2020-10-23 13:48:38 -07:00
Jonah Williams
424ea0958b
[flutter_tools] make android deps no longer required for flutter doctor (#68533) 2020-10-23 12:37:04 -07:00
Jonah Williams
cb67513f29
[flutter_tools] Reland: simplify pub cache logic (#67589)
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.

Also takes an opportunity to fix the kernel snapshot depending on the .packages or package_config. Due to the generated: date field this causes extra rebuilds. Instead when pub get is run, write out an additional file with just the package contents and version.

Fixes #66777
Fixes #65723
2020-10-23 10:00:56 -07:00
Michael Goderbauer
6cb6eef615
Make Material/CupertinoLocalizations non-nullable (#68807) 2020-10-23 09:12:42 -07:00
Jenn Magder
351ccf7eaf
Better error message when export options plist does not a fix (#68826) 2020-10-22 23:28:51 -07:00
Jenn Magder
aea070790f
Turn off CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER in CocoaPod targets (#68817) 2020-10-22 22:02:04 -07:00
Cyp
45e02daf22
Correctly handle centerSlice with resoultion-aware assets. (#68325) 2020-10-22 21:57:03 -07:00
Jonah Williams
1edec6fc20
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)" (#68845)
This reverts commit 2e75f52ae4fe22128a2d4274a01bc19bdc13507f.
2020-10-22 19:39:33 -07:00
Jonah Williams
b25ce5b16c
Revert "Fix a multiple pointers bug (#68587)" (#68841)
This reverts commit bde85ea3bb3e80c1294c6d084eb5f9804867be8f.
2020-10-22 19:16:08 -07:00
xubaolin
bde85ea3bb
Fix a multiple pointers bug (#68587)
* Fix mutiple pointers bug

* Add unit test case

* Remove unnecessary map clone
2020-10-22 16:09:47 -07:00
xubaolin
95909c2a04
change TextEditingController.clear() behavior (#68775)
Fixes a bug where keyboard capitalization mode was exited when pressing clear.
2020-10-22 15:56:26 -07:00
Kate Lovett
8e8f61856a
Fix overscroll edge case that puts NestedScrollViews out of sync (#68644) 2020-10-22 15:37:06 -07:00
YeungKC
c5c2b24a07
Fix floating behavior of long label and outline input border (#68727)
Corrects the space available to the label in an outlined text field
2020-10-22 15:36:06 -07:00
Alexander Brusher
099ae9b417
Re-enables tests previously failing due to new semantics flag. (#66916) 2020-10-22 15:32:03 -07:00
Jonah Williams
2e75f52ae4
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web (#68451)
Overhaul of flutter drive in order to deliver a better experience, namely:

flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
Removes web-initialize-platform as this is no longer used
flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)
Web changes

Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible

Additional NNBD related bug fixes:

No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-22 15:07:02 -07:00
xubaolin
1bd661f4d4
fix a widgetspan hittest bug (#68694) 2020-10-22 14:27:04 -07:00
Ian Hickson
6a434ab9ec
Fix grammar and writing style for some of the Router documentation (#68513) 2020-10-22 14:22:09 -07:00
stuartmorgan
3da995adec
Handle backspace in text fields (#68812)
Currently the framework handles delete, but not backspace, so embeddings
all have to implement backspace handling themselves. This eliminates
that inconsistency and allows simplified code in embeddings by adding
backspace handling.

It also fixes a bug uncovered in the delete handling where deleting a
selection would also delete the next character after the selection.
2020-10-22 13:51:07 -07:00
Jenn Magder
f63d56e455
App.framework must support iOS 8 for older Flutter projects (#68729)
* App.framework must support iOS 8 for older Flutter projects

* Fix test
2020-10-22 13:50:54 -07:00
stuartmorgan
3ff334d68d
Add a missing include to the Linux plugin template (#68737)
The template uses strcmp (to check the received method), so should
include <cstring>
2020-10-22 13:50:39 -07:00
Jonah Williams
37470dfc0b
[devicelab] de-flake iOS launch (#68790)
* [devicelab] de-flake iOS launch
2020-10-22 13:37:57 -07:00
Jonah Williams
21ca1f9ba5
[flutter_tools] use --no-print-incremental-dependencies for non-resident and test compiles (#68678) 2020-10-22 13:34:59 -07:00
Dan Field
4af674285b
Move service extension to correct binding so images are repainted after enabling/disabling, update test (#68793)
* Move service extension to correct binding so images are repainted after enabling/disabling, update test

* Update binding.dart
2020-10-22 13:34:21 -07:00
Jonah Williams
37042fdb08
[flutter_tools] remove iOS screenshot on failure functionality (#68650)
* [flutter_tools] remove iOS screenshot on failure functionality

* remove all screenshot code
2020-10-22 13:34:07 -07:00
puelo
24d3999783
Generate RawKeyEvents for iOS 13.4+ (#65193)
* Added RawKeyEvent support for iOS

* Removed unused remnant

* added some missing keys

* Removed trailing whitespaces

* commit for build

* Added mapping names

* Made iOS keycodes generatable and collectable

* Fixed naming and formatting issues

* fixed raw_keyboard_test
2020-10-22 13:33:51 -07:00
Jenn Magder
f877266139
Add CocoaPods sudo installation note (#68542)
* Add CocoaPods sudo installation note

* Refer to instructions
2020-10-22 13:33:35 -07:00
chunhtai
6cab3f6008
fix simple dialog introducing additional node for semantics label (#68804)
* fix simple dialog introducing additional node for semantics label

* add test
2020-10-22 13:33:17 -07:00
Jenn Magder
04657354f5
Build IPA command (#67781)
* Build IPA command

* xcarchive -> ipa
2020-10-22 13:32:51 -07:00
Michael Goderbauer
91478d96a8
Do not instantiate intermediate tabs during transition (#68124) 2020-10-22 13:32:47 -07:00
Jaime Blasco
52c715fe43
Add textSelectionControls to TextField etc. (#66785)
Enables custom text selection menus by allowing selectionControls to be passed to TextField et. al.
2020-10-22 13:31:51 -07:00
Robert Ancell
16b9933d85
Disable header bar when not using GNOME Shell. (#68452)
Fixes https://github.com/flutter/flutter/issues/68253
2020-10-22 10:24:19 +13:00
Robert Ancell
b200baebd7
Try the Wayland GDK backend, the engine now supports it (#66519)
* Try the Wayland GDK backend, the engine now supports it

* Update comment from review

* Just do default GTK behaviour
2020-10-22 09:38:11 +13:00
Jacob Richman
0884236504
Fix assert due to VSCode passing in an isolateId as well as the expected args to setPubRootDirectories. (#68721) 2020-10-21 12:13:10 -07:00
Michael Goderbauer
42f3709a5a
Sound null safety for framework and flutter_test (#68642) 2020-10-21 10:09:11 -07:00
Justin McCandless
955e07461b
Revert "Fix text field label width on outline input border (#67736)" (#68672) 2020-10-21 08:52:03 -07:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings (#68302)" (#68714)
This reverts commit ae06c19a371cbf8eb9de84d0c3d880c7cd101683.
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings (#68302) 2020-10-21 16:34:24 +02:00
Jacob Richman
e5d7bab115
Fix null safety error in inspector service extensions taking a variable number of args. (#68661)
* Fix null safety error in inspector service extensions taking variable numbers of args.

Fixes https://github.com/flutter/flutter/issues/68627.
Also fix all inspector tests that do not rely on golden image functionality
so that they run with --enable-experiment=non-nullable. This verifies there
is test coverage to ensure there isn't a regression.

* Remove uses of dynamic.
2020-10-20 18:27:55 -07:00
Jenn Magder
d29cd9beb6
Clean up device logger and port forwarding on drive completion (#68655) 2020-10-20 16:01:51 -07:00
Jonah Williams
cb5865d86c
[flutter_tools] add some versions to tool sources, cleanup build.yaml (#68624) 2020-10-20 09:50:31 -07:00
Jenn Magder
d81691d0f4
Revert "Build iOS apps using Swift Packages (#68361)" (#68546)
This reverts commit dd9323bdfba0bd829c6f23d3a9d8d953d1a00af2.
2020-10-19 17:57:32 -07:00
Yegor
ea3b08f333
Respond to HTTP POST requests with 404 in WebAssetServer (#68492)
* Respond to POST with 404 in WebAssetServer
2020-10-19 16:21:39 -07:00
Jenn Magder
dd9323bdfb
Build iOS apps using Swift Packages (#68361) 2020-10-19 15:47:04 -07:00
Jenn Magder
5e17a240bd
Generate only requested platform directories on create (#68376) 2020-10-19 14:17:43 -07:00