1133 Commits

Author SHA1 Message Date
Yegor
2f769be663
Soften shadows (#17231)
* Soften shadows

* update goldens
2020-03-20 19:50:00 -07:00
Nurhan Turgut
48902d146a
Felt add integration (#17190)
* adding arguments to felt for running different type of tests

* adding test type enums to felt

* more changes to felt for testing branches

* more additions to code

* more changes to felt

* adding code for cloning web_drivers

* validating test directories. running the integration tests. update the readme file partially

* Removing todo lists used for development

* addressing reviewers comments

* remove unused imports

* addressing more reviewer comments

* addressing more reviewer comments

* addressing reviewer comments.

* addressing reviewer comments.

* fixing typos

* using chromedriverinstaller as a library. Fixing the commit number used from web_installers repo

* clean drivers directory after tests finish

* addressing more reviewer comments

* throwing all critical exceptions instead of logging and returning boolean flags

* adding todos for items we can do for making felt easier to use for local development

* do not run integration tests on CIs. Added an issue to the TODO.

* changing todo's with issues.
2020-03-20 19:24:13 -07:00
Ferhat
6d30043313
Fix blend test diffrate on mac (#17198)
* Fix error message for golden failure. Fix blend test diffrate when running on MacOS

* Revert MacOS adjustment
2020-03-18 16:47:58 -07:00
Dan Field
034f913b98
Teach frontend compiler to replace toString with super.toString for selected packages (#17068)
Adds annotation `keepToString` to opt out.
2020-03-17 15:40:09 -07:00
Dan Field
d03f620143
Two point conical gradient for web CanvasKit (#17146) 2020-03-16 12:11:02 -07:00
Ferhat
5a07488251
[web] Add HtmlCodec progress callback (#17139)
* Wire up htmlcodec chunkcallback for progress events

* Add test for HtmlCodec
2020-03-16 11:41:44 -07:00
MennaFadali
57e69fe176
Implementing Locale.toLanguageTag in flutter web. (#17131) 2020-03-13 08:57:53 -07:00
Nurhan Turgut
9a3016fbed
increasing user limits for macos (#17097) 2020-03-11 12:15:47 -07:00
Chinmay Garde
17e07c537e
Implement asynchronous texture uploads when using the Metal backend on iOS. (#17046)
This moves the Metal `GrContext` creation utilities from `GPUSurfaceMetal` into
a separate `IOSContext` object subclass. An analogue of this object was used in
the GL regime for the management of onscreen and offscreen contexts that were
not tied to the lifecycle of the `GPUSurface`. This pattern has now been
generalized for use with all backends that need a resource context
(`IOSContextGL` and `IOContextMetal`).

The platform views controller management in the `ExternalViewEmbedder` interface
implementation was repeated three times for [Metal][metal], [OpenGL](opengl) and
[Software](software) rendering. This repetition has been removed and a single
implementation present in the base `IOSSurface` and used on all platforms.
Addition of new client rendering APIs should not affect how the engine renders
into the platform view interleaving levels.

All rendering API selection logic has been moved into a single set of utilities
in `rendering_api_selection.h`. This enables the removal of a lot of code blocks
guarded by `FLUTTER_SHELL_ENABLE_METAL`. The remaining uses of this will be
removed when unified builds are enabled.

The Metal backend now also adds traces similar to the GL backend.

The `IOGLContext` has been renamed to `IOContextGL` to be more in line with the
convention used in this library.

Fixes https://github.com/flutter/flutter/issues/41827
Adds https://github.com/flutter/flutter/issues/52150

[metal]: 1194ba2b21/shell/platform/darwin/ios/ios_surface_metal.mm (L55)
[opengl]: 1194ba2b21/shell/platform/darwin/ios/ios_surface_gl.mm (L95)
[software]: 1194ba2b21/shell/platform/darwin/ios/ios_surface_software.mm (L146)
2020-03-10 16:01:53 -07:00
Chinmay Garde
bcefcdb880
Use the ELF loader to setup AOT symbols in benchmark runner. (#17051)
We no longer package AOT artifacts as discrete blobs. The portable ELF loader
from the testing library may be used instead.

Fixes https://github.com/flutter/flutter/issues/52263
2020-03-10 12:28:24 -07:00
Ferhat
a3e883b149
[web] Fixes for Firefox & Safari double underline decoration bugs. (#16994)
* Work around line measurement rounding bug in Firefox. Add -webkit prefix for Safari text decoration
* Add check for measurement tests for firefox
2020-03-09 22:36:46 -07:00
Dan Field
a18066bfb3
Avoid capturing this unsafely in MultiFrameCodec (#16824) 2020-03-09 21:18:50 -07:00
Yegor
d41e25b549
Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (#17040)
This reverts 619acd58ca55b2a85cf70d0f7861e3c98058972d and re-lands 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1. The 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1 was good. The screenshot changes were expected.

Fixes https://github.com/flutter/flutter/issues/32215
2020-03-09 20:32:59 -07:00
Ferhat
7f942f273b
Add support for firefox mac installer. Update web_ui pubspec for http.wq (#17044)
* Add support for firefox mac installer. Update web_ui pubspec for http.wq
* Addressed review comment 'final'
2020-03-09 18:13:37 -07:00
Yegor
4f4fdbf21f
fix "TREE INCONSISTENT" noise in compositing_test.dart (#16995) 2020-03-09 16:26:18 -07:00
Yegor
cb3237e255
Add more child lifecycle tests (#16689) 2020-03-09 16:26:06 -07:00
Chris Bracken
619acd58ca
Revert "fix shadows and mask filter blurs (#16963)" (#17008)
Broke golden file tests in the framework. Reverting to unblock the
engine roll to the framework.

This reverts commit 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1.
2020-03-07 10:18:10 -08:00
Yegor
e2c04549a0
remove 10s timeouts from tests (#16988) 2020-03-06 12:37:52 -08:00
Ferhat
0ad54c2106
[web] Fixes IE11 crash due to missing canvas ellipse support and font polyfill failure (#16965)
* Add context ellipse polyfill
* Change call sites for ellipse
* Switch fontloader polyfill font for ie11
2020-03-06 09:50:02 -08:00
Yegor
6cfa7fcad6
fix shadows and mask filter blurs (#16963)
* fix shadows and mask filter blurs

* update goldens

* clarify the choice to min the shadows
2020-03-05 22:07:57 -08:00
Chris Bracken
78a1c7ebf9
Revert "Drop last usages of Dart_New from engine (#16838)" (#16915)
We believe this may be implicated in a Windows-specific crash during the
Flutter Gallery integration test.

See:
https://github.com/flutter/flutter/issues/51896

This reverts commit f9b78c5db2bc3087e1793947b11ca643c2d747cf.
2020-03-03 14:52:56 -08:00
Dan Field
f9b78c5db2
Drop last usages of Dart_New from engine (#16838)
Image
Codec
FrameInfo
Scene/Picture toImage
2020-03-02 21:30:28 -08:00
Dan Field
96061d6228
shake out Paint.toString (#16850) 2020-02-28 10:41:55 -08:00
Dan Field
e47fa0bee9
Avoid using Dart_New for semantics (#16849) 2020-02-28 10:31:03 -08:00
Dan Field
c2fc31d19d
remove usage of Dart_New for paragraph/libtxt (#16837) 2020-02-28 00:15:40 -08:00
Ben Konyi
1e01b775e3
Enable HTTP and socket profiling dart:io service extensions for Flutter (#16800) 2020-02-27 08:29:58 -08:00
Ferhat
c0e29b6000
Fix stale physicalSize on resize event (#16822) 2020-02-26 15:54:10 -08:00
Mouad Debbar
7685e080bb
[web] Guard the remaining calls to window.onPlatformMessage (#16791) 2020-02-25 15:06:07 -08:00
Nurhan Turgut
9ac76ad5ad
[web] changing user limits for macos (#16797)
* changing user limits for macos

* check kernel name instead
2020-02-25 15:04:07 -08:00
Ferhat
d590e9841d
Evict BitmapCanvas(s) from cache when canvas allocation fails (#16793) 2020-02-25 13:38:25 -08:00
Mouad Debbar
d670059451
[web] Respect maxLines when calculating boxes for a range (#16749) 2020-02-24 14:26:03 -08:00
Mouad Debbar
971122b314
[web] Reduce the usage of unnecessary lists in pointer binding (#16745) 2020-02-24 14:21:04 -08:00
Ferhat
b87bb0a161
[web] Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under… (#16721)
* Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under memory pressure.

* optimized _reduceCanvasMemoryUsage

* Addressed review comments
2020-02-24 11:19:47 -08:00
Miguel Beltran
d0c2418dfe
Add support for Increase Contrast on iOS (#15343) 2020-02-22 14:04:04 -08:00
Dan Field
c3f4c1a085
Migrate Path to AssociateWithDartWrapper (#16753) 2020-02-22 12:59:35 -08:00
Mouad Debbar
afe7968e6b
[web] Paragraph.longestLine doesn't need to check for isSingleLine anymore (#16736) 2020-02-21 13:18:09 -08:00
Mouad Debbar
136a057f28
[web] Rename LineMetrics.text to LineMetrics.displayText (#16734) 2020-02-21 13:17:59 -08:00
Nurhan Turgut
941aee35bd
[web] add comment to skipped safari test (#16737)
* add comment to skipped safari test

* test not running semantics on Mac

* disable semantics test which is unreliable
2020-02-21 13:03:29 -08:00
Ryan Macnak
930a80ac86
Fix some compiler warnings in newer versions of Clang. (#16733) 2020-02-21 12:57:06 -08:00
Nurhan Turgut
ab0dd12975
[web] Running safari tests on LUCI (#16715)
* Safari font collection tests skip failing methods

* add a clear to the semantics test to make sure no DOM elements are leaking to the other tests

* fix semantics_helper_test. skip for semantics_test. teardown didn't work

* skip test, the skipped method run for 8 minutes according to the logs

* history tests methods runs multiple times. only run them on linux for now. they were also already failing in edge/windows
2020-02-21 09:03:13 -08:00
Dan Field
e18aba3321
Refactor of ClaimDartHandle -> AssociateWithDartWrapper (#16720) 2020-02-20 17:31:03 -08:00
Dan Field
60b27fd545
Reland "Remove usage of Dart_AllocateWithNativeFields" (#16713) 2020-02-20 16:06:02 -08:00
vsmenon
0ef67b5e74
opt out dart:ui from nnbd (#16473)
* opt out dart:ui from nnbd

* Annotate tests as well
2020-02-20 11:04:00 -08:00
Dan Field
f2f8c342be
Revert "Remove usage of Dart_AllocateWithNativeFields from tonic (#16588)" (#16684)
This reverts commit 4941ff7bf608e0bca764e1edad769a3f8cca797f.
2020-02-19 10:00:05 -08:00
Mouad Debbar
8dba815a73
[web] Paragraph.getBoxesForRange uses LineMetrics (#16625) 2020-02-19 09:56:57 -08:00
Harry Terkelsen
d03582d183
URL-encode asset URLs so assets are properly loaded (#16630)
* URL-encode asset URLs so assets are properly loaded

* Add comment
2020-02-18 16:19:36 -08:00
Yegor
48d64c13e4
update hash code logic on the web (#16624) 2020-02-18 12:29:17 -08:00
Nurhan Turgut
77c5812d48
[web] Skipping failing edge tests (#16626)
* making edge default test browser on windows. adding some skips (not all) for methods failing on edge

* skip failing tests. make egde default for testing

* skip one more test

* addressing reviewer comments. removing extra bat file
2020-02-18 09:36:04 -08:00
Ben Konyi
4941ff7bf6
Remove usage of Dart_AllocateWithNativeFields from tonic (#16588)
This API is being removed from the Dart SDK.
2020-02-14 13:55:38 -08:00
Ferhat
15e7f51b32
Implement Path extractPath, tangent APIs (#16599)
* Add pathMeasure
* Implement tangetAt
* add extractPath segment iterator
* Implement extractPath/chopCubicAt/chopQuadAt
* Wire up extractPath and add tests for cubic/quadratic
* Switch to interpolate on chopCubic
* addressed review comments
2020-02-14 13:29:27 -08:00