skia-flutter-autoroll
6f54fe438c
Roll Skia from b311e4d0d21e to f320a125e031 (1 revision) ( flutter/engine#48208 )
...
https://skia.googlesource.com/skia.git/+log/b311e4d0d21e..f320a125e031
2023-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 2b3cf74d484d to 02a8c0638601 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-19 05:27:23 +00:00
skia-flutter-autoroll
ac0b88e368
Roll Fuchsia Linux SDK from Bcq9TZdt-vtTSL5YH... to LnToEykA8o68jv58K... ( flutter/engine#48202 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-18 10:32:19 +00:00
skia-flutter-autoroll
435bc8a370
Roll Dart SDK from 3d4886a2e218 to 564cfb2cfe79 (1 revision) ( flutter/engine#48195 )
...
https://dart.googlesource.com/sdk.git/+log/3d4886a2e218..564cfb2cfe79
2023-11-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-149.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-18 01:57:16 +00:00
skia-flutter-autoroll
64e53d3adf
Roll Skia from 04b0ac194443 to 11b5847aea97 (3 revisions) ( flutter/engine#48188 )
...
https://skia.googlesource.com/skia.git/+log/04b0ac194443..11b5847aea97
2023-11-17 johnstiles@google.com Disable TransformHsw and TransformSkx on Android.
2023-11-17 jvanverth@google.com Remove legacy gradient stop calculation.
2023-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from fb11678cf25f to 2b3cf74d484d (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 22:29:03 +00:00
skia-flutter-autoroll
ff14804a28
Roll Dart SDK from 03cddb5d740d to 3d4886a2e218 (1 revision) ( flutter/engine#48187 )
...
https://dart.googlesource.com/sdk.git/+log/03cddb5d740d..3d4886a2e218
2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-148.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 21:46:05 +00:00
skia-flutter-autoroll
38660931e5
Roll Skia from dd7a26ead897 to 04b0ac194443 (8 revisions) ( flutter/engine#48186 )
...
https://skia.googlesource.com/skia.git/+log/dd7a26ead897..04b0ac194443
2023-11-17 lovisolo@google.com [bazel] Generate device-specific configurations with Gold/Perf trace keys.
2023-11-17 maskray@google.com SkScan_AAAPath: for potential -fsanitize=alignment failure
2023-11-17 kjlubick@google.com Revert "Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY"
2023-11-17 maskray@google.com [docs] Fix /dev/contrib/ links
2023-11-17 kjlubick@google.com Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY
2023-11-17 brianosman@google.com Revert "Emoji font resolution fix"
2023-11-17 kjlubick@google.com Touch the skcms files to avoid 409 error on roll
2023-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bc5a26ce9f2b to ff8a5b05fd8b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 21:42:05 +00:00
Chris Yang
e7f47ca25d
[Ios] move flutter_test_ios_mrc unittests to arc ( flutter/engine#48162 )
...
Move all tests in flutter_test_ios_mrc to arc
Part of https://github.com/flutter/flutter/issues/137801
Changes mostly involves trivial mrc to arc changes. non-trivial changes are commented inline.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-17 20:26:16 +00:00
skia-flutter-autoroll
4d2b97c7eb
Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) ( flutter/engine#48182 )
...
https://dart.googlesource.com/sdk.git/+log/a9c212f2f54b..03cddb5d740d
2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-147.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 17:40:11 +00:00
skia-flutter-autoroll
3c9ecd0323
Roll Fuchsia Linux SDK from M0zM3CJLIrd5lb0u0... to Bcq9TZdt-vtTSL5YH... ( flutter/engine#48172 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 09:34:23 +00:00
Brandon DeRosier
f553fe0023
[Flutter GPU] Add Textures. ( flutter/engine#48118 )
2023-11-16 22:28:54 -08:00
skia-flutter-autoroll
f87be71799
Roll Dart SDK from 12c5efc94edf to 46e8b18047eb (1 revision) ( flutter/engine#48168 )
...
https://dart.googlesource.com/sdk.git/+log/12c5efc94edf..46e8b18047eb
2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-145.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 04:38:20 +00:00
Dan Field
89ff1d0d8b
Only run systrace test on API 29+, avoid building scenario app for 28 ( flutter/engine#48163 )
...
The emulator tests I added yesterday are failing because the systrace python test script uses features introduced in API 29, which causes the `perfetto` invocation to fail.
It's not essential that we run this test on lower API levels, so instead I'm making the script bail out in this case.
Other than that, the shard seems to be consistently passing, so I'm removing bringup.
2023-11-17 02:20:51 +00:00
Brandon DeRosier
f9b113e43c
[Impeller] Add support for external GL textures to TiledTextureContents. ( flutter/engine#47586 )
2023-11-16 16:56:49 -08:00
skia-flutter-autoroll
b429c3008b
Roll Dart SDK from 906f23c1cb20 to 12c5efc94edf (1 revision) ( flutter/engine#48157 )
...
https://dart.googlesource.com/sdk.git/+log/906f23c1cb20..12c5efc94edf
2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-144.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 00:40:13 +00:00
skia-flutter-autoroll
90d8214c24
Roll Skia from 762d95ed65e0 to c7d2a4933dfa (1 revision) ( flutter/engine#48159 )
...
https://skia.googlesource.com/skia.git/+log/762d95ed65e0..c7d2a4933dfa
2023-11-16 jlavrova@google.com Emoji font resolution fix
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 00:36:15 +00:00
gaaclarke
6f471e9027
[Impeller] Implements gaussian blur that scales down before applying the blur ( flutter/engine#47576 )
...
A partial implementation of the new gaussian blur effect. This should perform enough of the code to start getting some performance numbers.
Known outstanding problems:
1) The edges of the blur are clipped. I have notes on how I plan on expanding render space in the PR.
1) Animating the sigma causes some "jumping around artifacts" resulting from the downsampling (maybe the discrete nature of texture pixel size?)
1) Coverage hints are ignored. I think depth tests will make that not much of an issue.
1) We aren't ping ponging textures yet
1) The snapshot's transform is ignored.
issue: https://github.com/flutter/flutter/issues/131580
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-16 22:34:22 +00:00
skia-flutter-autoroll
a189220384
Roll Skia from 297049bbfc0d to 4c099aaa259f (5 revisions) ( flutter/engine#48138 )
...
https://skia.googlesource.com/skia.git/+log/297049bbfc0d..4c099aaa259f
2023-11-16 lovisolo@google.com Reland "Reland: [bazel] Housekeeper-PerCommit-CheckGeneratedFiles: Add "go generate", Gazelle and Buildifier steps."
2023-11-16 SCHMIDT Expose default SK_GAMMA_CONTRAST values in SkTypes
2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 14160bee80f4 to bc5a26ce9f2b
2023-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from ba1e7f5c1e82 to f23b91844a05
2023-11-16 kjlubick@google.com Fix up fuzzers implicit dependency on default SkFontMgr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 20:27:17 +00:00
skia-flutter-autoroll
18fe89baba
Roll Dart SDK from b512191e9612 to 906f23c1cb20 (1 revision) ( flutter/engine#48136 )
...
https://dart.googlesource.com/sdk.git/+log/b512191e9612..906f23c1cb20
2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-143.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 20:11:06 +00:00
Jonah Williams
50edc5f397
[Impeller] store all path point data in single buffer. ( flutter/engine#47896 )
...
Path objects are expensive to allocate, create, move, et cetera because of the large number of internal heap allocations performed. This change combines the linear, quad, and cubic buffers into a single point buffer that stores all points/control points inline.
The existing component buffer stores the index to the first point in the buffer, and the type field determines how many points are read.
Benchmarked in https://flutter-engine-perf.skia.org/e/?queries=test%3DBM_Polyline_cubic_polyline%26test%3DBM_Polyline_quad_polyline&selected=commit%3D38035%26name%3D%252Cconfig%253Ddefault%252Ccpu_scaling_enabled%253Dfalse%252Cexecutable%253D_b_s_w_ir_cache_builder_src_out_host_release_geometry_benchmarks%252Clibrary_build_type%253Drelease%252Cmhz_per_cpu%253D2200%252Cnum_cpus%253D8%252Csub_result%253DTotalPointCount%252Ctest%253DBM_Polyline_quad_polyline%252Cunit%253Dns%252C
https://github.com/flutter/flutter/issues/138004
2023-11-16 18:54:12 +00:00
skia-flutter-autoroll
8325f708f0
Roll Skia from b9ead4140f84 to 297049bbfc0d (2 revisions) ( flutter/engine#48133 )
...
https://skia.googlesource.com/skia.git/+log/b9ead4140f84..297049bbfc0d
2023-11-16 kjlubick@google.com Add option to skip emsdk sync
2023-11-16 jvanverth@google.com [graphite] Improvement to image sampling performance.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 18:36:26 +00:00
Jonah Williams
a4b4cae1a8
[Impeller] Create a drawable backed TextureMTL. ( flutter/engine#48049 )
...
Allow creating a TextureMTL instance that is backend by a CAMetalLayer, which only acquires the drawable (and texture) lazily.
I split TextureMTL into two subclasses, one that has the standard wrapping behavior of a MTLTexture, and the other that holds a drawable. This is part of the foundational work for "removing drawable acquisition latency", as we need to delay aquisition of the drawable texture to a worker thread.
The drawable backed texture is only used in tests for now.
Part of https://github.com/flutter/flutter/issues/138490
2023-11-16 17:50:18 +00:00
Matan Lurey
4638f4fc85
Re-land "Make lib/ui/{text|window}/... compatible with .ci.yaml" ( flutter/engine#48097 )
...
Reverts https://github.com/flutter/engine/pull/48083 .
2023-11-16 08:40:19 -08:00
skia-flutter-autoroll
a7cb9573ca
Roll Skia from bf1d6d84db73 to b9ead4140f84 (1 revision) ( flutter/engine#48124 )
...
https://skia.googlesource.com/skia.git/+log/bf1d6d84db73..b9ead4140f84
2023-11-16 robertphillips@google.com [graphite] Allow creation of Protected Devices
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 16:37:06 +00:00
skia-flutter-autoroll
79e0a2f56a
Roll Skia from 2fe70dd9cbf8 to bf1d6d84db73 (1 revision) ( flutter/engine#48122 )
...
https://skia.googlesource.com/skia.git/+log/2fe70dd9cbf8..bf1d6d84db73
2023-11-16 lehoangquyen@chromium.org GraphiteDawn: cache uniform buffers' bind groups.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 15:39:59 +00:00
skia-flutter-autoroll
696b837f74
Roll Dart SDK from 5cccc24d127f to b512191e9612 (1 revision) ( flutter/engine#48120 )
...
https://dart.googlesource.com/sdk.git/+log/5cccc24d127f..b512191e9612
2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-142.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 13:38:33 +00:00
skia-flutter-autoroll
86e7d7731d
Roll Fuchsia Linux SDK from AuDKY8ob6GrGwDlmk... to M0zM3CJLIrd5lb0u0... ( flutter/engine#48115 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 08:49:15 +00:00
skia-flutter-autoroll
eca85da3ce
Roll Dart SDK from 65819963fb17 to cc6acfd7d57c (5 revisions) ( flutter/engine#48100 )
...
https://dart.googlesource.com/sdk.git/+log/65819963fb17..cc6acfd7d57c
2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-140.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-139.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-138.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-137.0.dev
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-136.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 02:16:32 +00:00
Dan Field
d38b0967a0
[Impeller] Gate Vulkan selection on API 29 ( flutter/engine#48089 )
...
Platform Views on Android require API 29 when using Vulkan.
~~I'm not sure if I did the CI changes right, want to run it here and see. The added test needs to run on a device or emulator with API 29 or above and API 28 or below to be valid.~~
Makes the following changes to CI:
- Runs the emulator tests on presubmit, but only if `shell/platform/android/**` or `lib/ui/**` or `.ci.yaml` changes.
- Changes the emulator tests to be a regular engine_v2 test that spawns an x86 build. Unfortunately, the older API level emulators are only available for x86, not x86_64, and you cannot run the binary we create unless it matches the ABI.
- Runs the new test on both API 28 and API 34.
Fixes https://github.com/flutter/flutter/issues/132984
/cc @johnmccutchan fyi
2023-11-16 02:04:41 +00:00
Chris Yang
c07e3193e7
[ios] introduce weak_nsobject ( flutter/engine#47947 )
...
Introduce weak_nsobject from chromium.
There are some usages of weak_ptr wrapping Objective-C ids, weak_ptr is not really designed for ids and such usages are blocking the arc migration.
This PR mostly copies the weak_nsobject from chromium, at the same hash that we copied the ARC/MRC compatible scoped_nsobject: fd625125b8
To match how we used weak_ptr for those ids, I made some changes to the weak_nsobject:
- WeakNSObjects needs to be generated by a WeakNSObjectFactory. The WeakNSObjectFactory is owned by the objc class and acts as the generator of the WeakNSObjects. All the WeakNSObjects' derefing thread should be the same of the WeakNSObjectFactory's creation thread.
- chromuim's WeakNSObjects can be detached from the thread and re-attached to a new thread. To match our weak_ptr behavior, I changed WeakNSObjects to be only accessed from a single thread, the same as weak_ptr
This PR also moves the FlutterEngine to use WeakNSObject and updated related classes.
part of https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-15 23:43:24 +00:00
skia-flutter-autoroll
81e50af073
Roll Skia from e954d1a1972c to 5d6bdbf69dea (2 revisions) ( flutter/engine#48094 )
...
https://skia.googlesource.com/skia.git/+log/e954d1a1972c..5d6bdbf69dea
2023-11-15 hitawala@chromium.org Graphite: Relax wgpu::TextureAspect validation
2023-11-15 bungeman@google.com Make SkFontMetrics::operator== const
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 23:33:08 +00:00
skia-flutter-autoroll
701b799055
Roll Skia from b23074a79bda to e954d1a1972c (7 revisions) ( flutter/engine#48092 )
...
https://skia.googlesource.com/skia.git/+log/b23074a79bda..e954d1a1972c
2023-11-15 michaelludwig@google.com Set fill style and remove path effects on saveLayer restore paint
2023-11-15 johnstiles@google.com Fix minor errors in gn_to_bp.
2023-11-15 bungeman@google.com Check for empty glyphs in last resort fallback
2023-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 1f5289c9db82 to ba1e7f5c1e82
2023-11-15 johnstiles@google.com Fix typo in YUV cubic filter.
2023-11-15 johnstiles@google.com Add Haswell and Skylake support to skcms gn/bazel build files.
2023-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4aadd727887d to 13dd63c18adf (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 22:49:20 +00:00
auto-submit[bot]
ff90f25a41
Reverts "Make lib/ui/{text|window}/... compatible with .clang_tidy." ( flutter/engine#48083 )
...
Reverts flutter/engine#48000
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
I just ... deleted `text_box.h` as it appears unused and unreferenced?
---
Work towards https://github.com/flutter/flutter/issues/134969 .
All changes were made automatically (i.e. with `--fix`).
2023-11-15 19:55:17 +00:00
skia-flutter-autoroll
10c992d881
Roll Skia from c42226314a4f to b23074a79bda (3 revisions) ( flutter/engine#48081 )
...
https://skia.googlesource.com/skia.git/+log/c42226314a4f..b23074a79bda
2023-11-15 johnstiles@google.com Remove switch from bitmap_text_coverage_fn.
2023-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d3983fb3caec to 14160bee80f4
2023-11-15 robertphillips@google.com Avoid memoryless attachments w/ protected rendering
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 19:25:58 +00:00
Matan Lurey
2c058e08ff
Make lib/ui/{text|window}/... compatible with .clang_tidy. ( flutter/engine#48000 )
...
I just ... deleted `text_box.h` as it appears unused and unreferenced?
---
Work towards https://github.com/flutter/flutter/issues/134969 .
All changes were made automatically (i.e. with `--fix`).
2023-11-15 11:21:55 -08:00
skia-flutter-autoroll
65050f8ffc
Roll Skia from 1f23a0b74619 to c42226314a4f (2 revisions) ( flutter/engine#48075 )
...
https://skia.googlesource.com/skia.git/+log/1f23a0b74619..c42226314a4f
2023-11-15 robertphillips@google.com [graphite] Add ManagedGraphiteTexture::ReleaseProc
2023-11-15 robertphillips@google.com [graphite] Attach internal protected elements together
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 17:35:08 +00:00
Greg Spencer
28d807f326
Update keycode output ( flutter/engine#47988 )
...
## Description
This updates the keycode definitions to match what the keycode generator produces, to keep them in sync.
2023-11-15 17:29:34 +00:00
skia-flutter-autoroll
3ada26f096
Roll Skia from 1abce6b0a763 to 3b7a62e2ac3f (2 revisions) ( flutter/engine#48071 )
...
https://skia.googlesource.com/skia.git/+log/1abce6b0a763..3b7a62e2ac3f
2023-11-15 kjlubick@google.com Revert^3 "Reland: [bazel] Housekeeper-PerCommit-CheckGeneratedFiles: Add "go generate", Gazelle and Buildifier steps."
2023-11-15 kjlubick@google.com Export DirectWrite typeface via SK_SPI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 16:03:55 +00:00
Zachary Anderson
2ce96843c0
Reverts Dart to 3.3.0-135.0.dev ( flutter/engine#48070 )
...
Reverts Dart for analysis_server crash in customer_testing:
https://github.com/flutter/flutter/issues/138485
2023-11-15 07:42:22 -08:00
skia-flutter-autoroll
49b4c626b9
Roll Dart SDK from 849fd6ccc339 to 002e66832465 (1 revision) ( flutter/engine#48065 )
...
https://dart.googlesource.com/sdk.git/+log/849fd6ccc339..002e66832465
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-137.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 13:41:34 +00:00
skia-flutter-autoroll
999227e8cf
Roll Dart SDK from 65819963fb17 to 849fd6ccc339 (1 revision) ( flutter/engine#48060 )
...
https://dart.googlesource.com/sdk.git/+log/65819963fb17..849fd6ccc339
2023-11-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-136.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 09:43:40 +00:00
skia-flutter-autoroll
42501a6f44
Roll Skia from 0f6a4e6a3b51 to 0d9175bb5cfa (1 revision) ( flutter/engine#48045 )
...
https://skia.googlesource.com/skia.git/+log/0f6a4e6a3b51..0d9175bb5cfa
2023-11-14 kjlubick@google.com Remove dependency from TestFontCollection to default SkFontMgr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 00:24:05 +00:00
skia-flutter-autoroll
ab301ace16
Roll Dart SDK from 6219f11bf0fb to 6f1322227bdf (6 revisions) ( flutter/engine#48039 )
...
https://dart.googlesource.com/sdk.git/+log/6219f11bf0fb..6f1322227bdf
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-133.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-132.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-131.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-130.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-129.0.dev
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-128.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 22:54:29 +00:00
skia-flutter-autoroll
6627c40f29
Roll Skia from 6feae2c274ce to 650913eacd01 (1 revision) ( flutter/engine#48034 )
...
https://skia.googlesource.com/skia.git/+log/6feae2c274ce..650913eacd01
2023-11-14 johnstiles@google.com Add shader text and errors to the failure message.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 20:38:22 +00:00
skia-flutter-autoroll
3ca59e39a5
Roll Skia from a811132be321 to ce88be2adf67 (1 revision) ( flutter/engine#48022 )
...
https://skia.googlesource.com/skia.git/+log/a811132be321..ce88be2adf67
2023-11-14 johnstiles@google.com Remove skcms_Set|RestoreTarget.h.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 17:29:43 +00:00
skia-flutter-autoroll
3dfa827fe1
Roll Skia from f22c71596039 to b7d581997f2b (1 revision) ( flutter/engine#48018 )
...
https://skia.googlesource.com/skia.git/+log/f22c71596039..b7d581997f2b
2023-11-14 kjlubick@google.com Partially revert fuzz SkFontMgr changes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 14:47:35 +00:00
skia-flutter-autoroll
02d89e50b3
Roll Fuchsia Linux SDK from UaodAPcg8HCGdDb-C... to AuDKY8ob6GrGwDlmk... ( flutter/engine#48016 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 12:09:16 +00:00
auto-submit[bot]
7da37d5aef
Reverts "Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision)" ( flutter/engine#48011 )
...
Reverts flutter/engine#48006
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
https://dart.googlesource.com/sdk.git/+log/6219f11bf0fb..b3d3b381fd7b
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-128.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 07:19:26 +00:00
Zachary Anderson
ef11fee4ed
Move Skia to //flutter/third_party/skia ( flutter/engine#47913 )
...
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373 ), we are moving all
third-party dependencies from //third_party to //flutter/third_party.
Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.
To land this PR, we'll need to:
1. Stop the Skia -> Engine autoroller
1. Update the license goldens in this PR.
1. Update
https://skia.googlesource.com/skia-autoroll-internal-config/+/refs/heads/main/skia-infra-public/skia-flutter.cfg#55
1. Land this PR.
1. Re-start the Skia -> Engine autoroller
2023-11-13 20:04:35 -08:00
skia-flutter-autoroll
f7af706204
Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision) ( flutter/engine#48006 )
...
https://dart.googlesource.com/sdk.git/+log/6219f11bf0fb..b3d3b381fd7b
2023-11-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-128.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 04:00:27 +00:00
skia-flutter-autoroll
b7027c4fb2
Manual roll Dart SDK from 370145bbbd4f to 6219f11bf0fb (7 revisions) ( flutter/engine#47998 )
...
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/370145bbbd4f..6219f11bf0fb
2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-127.0.dev
2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-126.0.dev
2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-125.0.dev
2023-11-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-124.0.dev
2023-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-123.0.dev
2023-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-122.0.dev
2023-11-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-121.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-14 00:50:06 +00:00