20512 Commits

Author SHA1 Message Date
skia-flutter-autoroll
6ecfc2a1ae Roll Skia from dd3285a80b23 to f84dc9303045 (4 revisions) (flutter/engine#38123)
https://skia.googlesource.com/skia.git/+log/dd3285a80b23..f84dc9303045

2022-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 06203d02db10 to 5e031f59c8f1
2022-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a9464755b535 to dad69cc70e02 (5 revisions)
2022-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0c4f620f2412 to 255b9d293af6 (4 revisions)
2022-12-07 jcgregorio@google.com Fix Linux RTX 3060 GPU dimension.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-09 11:40:23 +00:00
Brandon DeRosier
f9aba7d6b1 [Impeller] Use DrawPath instead of Rect geometry when the paint style is stroke (flutter/engine#38146)
* [Impeller] Use DrawPath instead of Rect geometry when the paint state is set to stroke

* Add playground
2022-12-08 23:33:05 +00:00
Chris Bracken
dd92718f62 [tools] Eliminate version on Obj-C docs (flutter/engine#38145)
Eliminates the --module-version flag to jazzy when generating Obj-C
docs. This was hardcoded to 1.0.0. Since we have no knowledge of which
Flutter version a given engine build will be part of, eliminate it
altogether.
2022-12-08 13:24:42 -08:00
joshualitt
1d4bb09ac3 [web] Trivial fix for non-static interop JS interop class. (flutter/engine#38126) 2022-12-08 12:49:59 -08:00
Chris Bracken
bd43e9cc99 [embedder] Consistent naming for GL/Metal tests (flutter/engine#38141)
While I've sent a patch to mark the shell/platform/embedder/tests and
fixtures directories as test exempt (since they are tests), by
convention, tests should end in _unittests.* for C++ tests, and _test.*
for Dart tests. This renames for consistency with other tests such as
embedder_a11y_unittests.cc.

Uncovered by https://github.com/flutter/engine/pull/38133

Related: https://github.com/flutter/cocoon/pull/2340
Issue: https://github.com/flutter/flutter/issues/116381
2022-12-08 11:28:52 -08:00
Jim Graham
84a4d1eb85 Revert "Remove dlCanvasRecorder from flutter::PictureRecorder (#38127)" (flutter/engine#38137)
This reverts commit 79d6b0168967845dd928a97913c0a0ab4e8b97ab.
2022-12-08 18:49:56 +00:00
Chris Bracken
354ce9ffe0 [embedder] Expose metal surface from test context (flutter/engine#38133)
This is a minor cleanup that exposes the test metal surface to tests via
EmbedderTestContextMeta::GetTestMetalSurface for parity with the
GetTestMetalContext method which exposes the test metal context. This
eliminates the need for the more specific GetTextureInfo method since
the texture info is accessible via the test context.

This is a test refactoring with no semantic differences to the engine.

Issue: https://github.com/flutter/flutter/issues/116381
2022-12-08 10:23:29 -08:00
godofredoc
493eaa6275 Remove autoninja. (flutter/engine#38136)
Autoninja is being deprecated and this is removing engine v2
configurations.
2022-12-08 17:39:44 +00:00
Jonah Williams
83206b1c23 [Impeller] order metal samplers according to declared order and not usage order (flutter/engine#38115)
* [Impeller] order metal samplers according to declared order and not use order

* ++

* always enabl remapping

* Revert "always enabl remapping"

This reverts commit 2fffb05aeea9cfcbd0df051540054ca0d6c337c0.

* ++

* add test

* ++

* ++

* only run on mac
2022-12-08 17:23:12 +00:00
Loïc Sharma
8c119e59da [Windows] Add more cursor plugin tests (flutter/engine#38112)
* [Windows] Add more cursor plugin tests

* Tweak

* Add dependency
2022-12-08 00:42:23 +00:00
Jim Graham
79d6b01689 Remove dlCanvasRecorder from flutter::PictureRecorder (flutter/engine#38127)
* remove use of DLCanvasRecorder from PictureRecorder

* clang-tidy
2022-12-07 23:15:28 +00:00
Brandon DeRosier
5ad4bcdd38 [Impeller Scene] Depth attachment; baked lighting example (flutter/engine#38118)
* [Impeller Scene] Depth buffer; baked lighting example

* vk formats

* Remove kD24UNormS8UInt

* Address comments
2022-12-07 22:11:30 +00:00
Chris Bracken
0fab2ea52d [embedder] Ensure destruction called on present (flutter/engine#38078)
This is a followup to flutter/engine#38038.

In that patch, a destruction callback for textures created via the
FlutterRendererConfig callbacks (as opposed to by the FlutterCompositor
callbacks) was added and passed through to the texture info attached to
the SurfaceFrame generated in
GPUSurfaceMetalSkia::AcquireFrameFromMTLTexture (called via
GPUSurfaceMetalSkia::GetMTLTexture, which invokes the
get_next_drawable_callback), however, in order for the destruction
callback to make it to the presented Skia texture, it needs to be passed
through to the present callback here:
960af0a350/shell/gpu/gpu_surface_metal_skia.mm (LL233)

which is invoked by the submit callback passed to Skia:
960af0a350/shell/gpu/gpu_surface_metal_skia.mm (LL239)

The present callback is implemented in EmbedderSurface::PresentTexture,
which invokes the present callback registered in
FlutterMetalRendererConfig.present_drawable_callback. This patch ensures
that the destruction callback is passed through to Skia's present
callback so destruction occurs in the right place.

Issue: https://github.com/flutter/flutter/issues/116381
2022-12-07 20:40:22 +00:00
Camille Simon
374a9b507f [iOS] Change locale format for spell check (flutter/engine#38080)
* Change format

* Add pointer

* Check length

* Add check
2022-12-07 20:09:16 +00:00
fzyzcjy
52668a7252 Reland fix wrong VSYNC event (flutter/engine#37865) 2022-12-07 13:46:06 -05:00
Erik
b7bf0a3155 Full implementation of text-input-test (flutter/engine#37986)
Implements text-input-test, validates that we're able to receive the correct platform messages through the flutter/keyevent channel
2022-12-07 12:17:51 -05:00
Nayuta403
c2290f0a8f Create FlutterActivity/FlutterFragment using light weight engine with FlutterEngineGroup (flutter/engine#36963) 2022-12-07 09:17:03 -08:00
skia-flutter-autoroll
960af0a350 Roll Fuchsia Linux SDK from NlJGkMbtZqQ6_BCpu... to xn8ztWtp-zww-jObz... (flutter/engine#38122)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-07 16:16:04 +00:00
yaakovschectman
a204b24bf5 Preliminary implementation of UIA for A11y on Windows (flutter/engine#37754)
* Initial

* Comment TODOs

* Shim windowsx

* Comment testing

* UIA works at most basic

* Get Native target in win delegate

* Rework events

* FlutterWindowsView unit tests for UIA

* Enable UIA unit tests

* Conditional UIA implementation

* Text selection MSAA event

* License

* PR

* Before change to AccessibilityBridgeWindows

* AccessibilityBridgeWindows in FlutterWindowsEngine

* Use AccessibilityBridgeWindows for AXFragmentRootDelegateWin

* Format

* Remove unneeded windowsx_shim imports

* PR Comment
2022-12-07 11:12:13 -05:00
Siva
aac2690ea4 Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (flutter/engine#38105)
* Remove uses of --no-sound-null-safety in preparation for the Dart 3.0
roll.

* Update quiver package to latest.

* Run Fuchsia engine in null safe mode.

* Run Fuchsia engine in non null safe mode.

* Update Dart version to 3.0

* Address review comments.
2022-12-06 20:38:02 -08:00
nbayati
0687bec1e9 Use announce function in live region (flutter/engine#38084)
* use announce function in live region

* unit tests

* createtouch

* throw an error for unimplemented functions in the mock class
2022-12-07 02:27:34 +00:00
Brandon DeRosier
577e00ee34 [Impeller Scene] Render imported meshes (flutter/engine#38097)
* [Impeller Scene] Render imported meshes

* Address comments
2022-12-07 02:21:25 +00:00
Jason Simmons
ed23ba912f Pin the analyzer package version in lib/web_ui (flutter/engine#38114)
Other web_ui package dependences are incompatible with analyzer-5.3.0
2022-12-06 18:01:16 -08:00
Chinmay Garde
6ebc41ded5 [Impeller] Remove unused flag enable-impeller-vulkan. (flutter/engine#38109)
* [Impeller] Remove unused flag.

* Incorporate review feedback.
2022-12-07 00:13:04 +00:00
skia-flutter-autoroll
7b20bf6c62 Roll Skia from aea62b0970c3 to dd3285a80b23 (1 revision) (flutter/engine#38111)
https://skia.googlesource.com/skia.git/+log/aea62b0970c3..dd3285a80b23

2022-12-06 johnstiles@google.com Reland "Implement program dumps in the RP builder."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-06 23:37:29 +00:00
skia-flutter-autoroll
01390c1842 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter/engine#38107)
https://skia.googlesource.com/skia.git/+log/13e5241ce8b7..aea62b0970c3

2022-12-06 jcgregorio@google.com Fix typo in Win RTX 3060.
2022-12-06 johnstiles@google.com Revert "Implement program dumps in the RP builder."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-06 21:49:24 +00:00
Yegor
46df95a467 [web:canvaskit] test zero font size (flutter/engine#37916)
* [web:canvaskit] test zero font size

* Noop change to trigger golden uploads

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
2022-12-06 20:40:05 +00:00
skia-flutter-autoroll
76525fe805 Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter/engine#38106)
https://skia.googlesource.com/skia.git/+log/b63a254727f3..13e5241ce8b7

2022-12-06 jcgregorio@google.com December Patch Tuesday.
2022-12-06 jvanverth@google.com [metal] Fix issues with non-AA clip.
2022-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 80770ea57aff to 0c4f620f2412 (3 revisions)
2022-12-06 johnstiles@google.com Implement program dumps in the RP builder.
2022-12-06 penghuang@chromium.org [graphite] Implement DawnBuffer
2022-12-06 jcgregorio@google.com Add reboot back into abd recovery flow.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-06 20:12:17 +00:00
Reid Baker
e192a12f91 Add gradle option to allow/show System.out.print logs (flutter/engine#38104)
This is useful for java test debugging.
Audit of all java tests shows only 4 logged lines so this should
not add log spam but will aid in contributor test debugging.
2022-12-06 19:46:06 +00:00
Jason Simmons
426d21f97e Disable an extension in Xvfb to work around errors seen when running Impeller/Vulkan unit tests (flutter/engine#38092)
See https://github.com/flutter/flutter/issues/116130
2022-12-06 17:18:12 +00:00
Jackson Gardner
3b68ad4bfe Check for renderer-specific versions of the tests first. (flutter/engine#38088)
* Check for renderer-specific versions of the tests first.

* Fix indentation.
2022-12-06 16:49:50 +00:00
alanwutang11
a8e4b872ef implement targetWidth and targetHeight (flutter/engine#38028)
* implement targetWidth and targetHeight

* blank lines and typo

* addressed comments

* add warning to tests
2022-12-06 15:21:33 +00:00
skia-flutter-autoroll
f05c51df09 Roll Skia from e2244ea470c0 to b63a254727f3 (1 revision) (flutter/engine#38098)
https://skia.googlesource.com/skia.git/+log/e2244ea470c0..b63a254727f3

2022-12-06 johnstiles@google.com Add IWYU mapping: reverse exists in <algorithm>.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-06 14:27:29 +00:00
skia-flutter-autoroll
da94096a90 Roll Skia from ad85f404b97d to e2244ea470c0 (5 revisions) (flutter/engine#38096)
https://skia.googlesource.com/skia.git/+log/ad85f404b97d..e2244ea470c0

2022-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b55f242675c0 to 6a062f5dd011
2022-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b36e337e8d94 to a9464755b535 (11 revisions)
2022-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 35859e727fc0 to b55f242675c0 (11 revisions)
2022-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 1e1834a4ce8b to 3c4fddf3e3a2 (9 revisions)
2022-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ef116f5551fb to 80770ea57aff (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-06 10:43:24 +00:00
Brandon DeRosier
59e6e268a8 Update glfw to head and imgui to the docking branch (flutter/engine#38085) 2022-12-05 22:16:27 -08:00
skia-flutter-autoroll
890571c3ef Roll Skia from e9c0d4b83ca4 to ad85f404b97d (3 revisions) (flutter/engine#38089)
https://skia.googlesource.com/skia.git/+log/e9c0d4b83ca4..ad85f404b97d

2022-12-05 johnstiles@google.com Fix assertion when calling to_string(nan).
2022-12-05 bungeman@google.com Rename SkFunctionWrapper and add SkFunctionObject
2022-12-05 johnstiles@google.com Add SkRasterPipeline::getStageList.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-06 03:31:25 +00:00
Brandon DeRosier
bbf4579f77 [Impeller Scene] Parse GLTF primitives (flutter/engine#38064) 2022-12-05 14:09:53 -08:00
Brandon DeRosier
8f398c03bd [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
* Resolve language before working directory, print the working directory that was tried

* Quotes
2022-12-05 21:27:49 +00:00
htoor3
0485c8e365 [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011)
* Add pseudoelement css to remove password reveal

* Add comments

* Add changes to inject style tag to shadow root on Edge browsers

* Remove print statement

* Dart lint

* Whitespace

* Fix comments

* Change to getter
2022-12-05 21:26:09 +00:00
Loïc Sharma
b209893339 [Windows] Make the engine own PlatformHandler (flutter/engine#37855) 2022-12-05 20:29:33 +00:00
skia-flutter-autoroll
d12f1bebd3 Roll Skia from 1a8a0e1113da to e9c0d4b83ca4 (2 revisions) (flutter/engine#38077)
https://skia.googlesource.com/skia.git/+log/1a8a0e1113da..e9c0d4b83ca4

2022-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 80f030c1d4c7 to b36e337e8d94 (15 revisions)
2022-12-05 herb@google.com SkTArray: extract common code for the constructors

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-05 20:27:57 +00:00
skia-flutter-autoroll
269e36aea1 Roll Skia from f75f98074f60 to 1a8a0e1113da (5 revisions) (flutter/engine#38073)
https://skia.googlesource.com/skia.git/+log/f75f98074f60..1a8a0e1113da

2022-12-05 penghuang@chromium.org [graphite] Use staging buffers for vertex, index, uniform and storage buffers
2022-12-05 robertphillips@google.com [graphite] Add skeleton of the combination system
2022-12-05 johnstiles@google.com Centralize stack-pointer adjustment into one function.
2022-12-05 bsalomon@google.com Mesh GMs build with SK_LEGACY_MESH_MAKE defined
2022-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 63dc6101459e to ef116f5551fb (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-05 18:22:25 +00:00
skia-flutter-autoroll
14b071d6b6 Roll Skia from 5dd1b7d6a303 to f75f98074f60 (3 revisions) (flutter/engine#38070)
https://skia.googlesource.com/skia.git/+log/5dd1b7d6a303..f75f98074f60

2022-12-05 johnstiles@google.com Add SkRasterPipeline::GetStageName.
2022-12-05 kjlubick@google.com [includes] Enforce IWYU on core .cpp files
2022-12-05 jvanverth@google.com [graphite] Don't go through Recording for Context's asyncReadPixels

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-05 17:12:37 +00:00
dependabot[bot]
a85a25a18d Bump github/codeql-action from 2.1.31 to 2.1.35 (flutter/engine#38066)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.31 to 2.1.35.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2.1.31...b2a92eb56d8cb930006a1c6ed86b0782dd8a4297)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-05 08:51:24 +00:00
skia-flutter-autoroll
6941621dce Roll Skia from 32827b415412 to 5dd1b7d6a303 (3 revisions) (flutter/engine#38065)
https://skia.googlesource.com/skia.git/+log/32827b415412..5dd1b7d6a303

2022-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 35859e727fc0 to 33a786fadaaf
2022-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 51ef7225b668 to 35859e727fc0 (9 revisions)
2022-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 15e7f94b762e to 1e1834a4ce8b (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-05 07:08:20 +00:00
skia-flutter-autoroll
40aeab592c Roll Skia from d0e3902c97b3 to 32827b415412 (1 revision) (flutter/engine#38059)
https://skia.googlesource.com/skia.git/+log/d0e3902c97b3..32827b415412

2022-12-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC djsollen@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-12-04 15:36:32 +00:00
Brandon DeRosier
39362b24b5 [Impeller] Add Quaternion to Matrix conversion (flutter/engine#38056) 2022-12-03 19:17:51 -08:00
Brandon DeRosier
cfccb9ed0b [Impeller Scene] Wire up camera (flutter/engine#38053)
* [Impeller Scene] Wire up camera

* Resolve view transform once
2022-12-03 23:11:21 +00:00
Brandon DeRosier
ab78871b66 [Impeller] Make perspective transform resolve to left handed clip space (flutter/engine#38052) 2022-12-03 14:07:55 -08:00
Chris Bracken
d260fc82cd [embedder] Ensure FlutterMetalTexture cleanup call (flutter/engine#38038)
This ensures FlutterMetalTexture.destruction_callback gets called.

FlutterRendererConfig.get_next_drawable_callback holds a callback used by the embedder API to request a drawable; in the case of Metal, this drawable is a FlutterMetalTexture.

FlutterMetalTexture.destruction_callback should be called when it's safe to release resources associated with the FlutterMetalTexture. This callback is not currently invoked for textures returned via FlutterRendererConfig.get_next_drawable_callback; instead we unpack the returned struct and pass it on.

In the compositor codepath, we do create an SkSurface that triggers the destruction callback, here:
bbdb5d6a3e/shell/platform/embedder/embedder.cc (L868-L881)

Issue: https://github.com/flutter/flutter/issues/116381
2022-12-03 01:30:23 -08:00