785 Commits

Author SHA1 Message Date
Greg Price
6a92b93fea
Fix state leak in rendering/editable_test; remove no-shuffle (#123806)
Fix state leak in rendering/editable_test (framework shuffle-all 2/n)
2023-03-31 00:09:01 +00:00
LongCatIsLooong
482b5f63e9
Unskip #62819 Fixes #12357 (#122945)
Unskip #62819 Fixes #12357
2023-03-24 22:07:47 +00:00
Michael Goderbauer
fda9ecfef7
Remove 1745 decorative breaks (#123259)
Remove 1745 decorative breaks
2023-03-22 21:12:22 +00:00
Kate Lovett
484c22682b
Fix error message for unbounded viewports (#123035)
Fix error message for unbounded viewports
2023-03-20 21:34:00 +00:00
Michael Goderbauer
a599c08c32
Remvoe last few references to window singleton (#122644)
Remove last few references to window singleton
2023-03-15 00:34:34 +00:00
pdblasi-google
714389b5a3
Reland: Updates flutter/test/rendering to no longer use TestWindow (#122621)
Reland: Updates `flutter/test/rendering` to no longer use `TestWindow`
2023-03-14 20:51:06 +00:00
Michael Goderbauer
473fa38f77
Reland "Remove references to BindingBase.window (#122119 & #122341)" (#122412)
Reland "Remove references to BindingBase.window (#122119 & #122341)"
2023-03-14 16:48:07 +00:00
Michael Goderbauer
12ef7535a8
Reland "Introduce the PipelineOwner tree (#122231)" (#122452)
Reland "Introduce the PipelineOwner tree (#122231)"
2023-03-13 17:58:56 +00:00
Jim Graham
670f9d2037
Revert "Introduce the PipelineOwner tree (#122231)" (#122425)
This reverts commit f73c358e43df7c123e6d0141b3bc822877a1855d.
2023-03-10 13:15:46 -08:00
Michael Goderbauer
f73c358e43
Introduce the PipelineOwner tree (#122231)
Introduce the PipelineOwner tree
2023-03-10 19:57:17 +00:00
Casey Hillers
1f42612323
Revert PRs relating to single window assumption (#122369)
* Revert "Remove references to BindingBase.window (#122119)"

This reverts commit c7681f00cf1fb1c63bebb27d715f29feb77b78b7.

* Revert "Remove another reference to BindingBase.window (#122341)"

This reverts commit 6ec444506375cfa94535a45c2320e01094c295e0.

* Revert "Reland (2): Removes single window assumptions from `flutter_test` (#122233)"

This reverts commit eb3d317ea06e59fadc379210f5c6e685505d8e0f.

* Revert "Remove single view assumption from TestViewConfiguration (#122352)"

This reverts commit 927289fb4e5b25a71f794bc808a8c31554859a50.

* Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (#122325)"

This reverts commit 67e17e45f05271c6c409183c1d33806683cb9e4d.

* Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (#122327)"

This reverts commit c2a5111cc0f9bcb104982b38a1a0a9c4210b601f.

* Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (#122347)"

This reverts commit 28b65e089b3f8e8c21572cd8a73184858b6360c3.

* Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (#122321)"

This reverts commit 01367d52d7886f51a8921c9dc4a8e4c541686e98.
2023-03-09 22:53:38 -08:00
pdblasi-google
28b65e089b
Updates flutter/test/rendering to no longer use TestWindow (#122347)
Updates `flutter/test/rendering` to no longer use `TestWindow`
2023-03-10 01:49:20 +00:00
Michael Goderbauer
c7681f00cf
Remove references to BindingBase.window (#122119)
Remove references to BindingBase.window
2023-03-09 19:14:34 +00:00
LongCatIsLooong
f4551e6450
Reland "Update test font (#121306)" (#122068)
Reland "Update test font (#121306)"
2023-03-09 19:05:32 +00:00
Tomasz Gucio
43190156db
Use tearoffs (#122091)
Use tearoffs in TestRenderingFlutterBinding
2023-03-07 23:11:39 +00:00
LongCatIsLooong
33ffdd704f
Revert "Update test font (#121306)" (#122053)
This reverts commit 9f69a3679bc441d3ff985362e47b80ee2a51c60f.
2023-03-06 14:15:58 -08:00
LongCatIsLooong
9f69a3679b
Update test font (#121306)
Update test font
2023-03-06 21:46:51 +00:00
Hans Muller
1bfba7564b
Added identical(a,b) short circuit to rendering library lerp methods (#121566)
Added identical(a,b) short circuit to rendering library lerp methods
2023-02-28 00:55:56 +00:00
Lioness100
26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Michael Goderbauer
5ccb4d4b95
Rename WindowPadding to ViewPadding (#121152)
* Rename WindowPadding to ViewPadding

* dart fix

* typos
2023-02-22 21:32:40 +00:00
Mouad Debbar
902d86e09c
[web] Unify line boundary expectations on web and non-web (#121006)
* [web] Temporarily disable a line boundary test

* [web] Unify line boundary expectations on web and non-web
2023-02-21 17:28:13 +00:00
Mouad Debbar
f785136852
[web] Temporarily disable a line boundary test (#121005) 2023-02-17 21:50:11 +00:00
Greg Price
cd125e1f71
Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664)
* Add test for RenderProxyBoxMixin; clarify doc, resolve TODO

The TODO comment suggested this mixin would no longer be needed once
a Dart issue on inherited constructors was fixed:
  https://github.com/dart-lang/sdk/issues/31543
That issue is now long since fixed, so I went to go carry out the TODO.

But in doing so, I realized that the mixin's documentation was more
right than the TODO comment: even with that issue fixed, there is a
legitimate use case for this mixin, namely to reuse the implementation
of RenderProxyBox in a class that also inherits from some other base
class.  Moreover, searching GitHub I found an example of a library
that makes real use of that capability.

So I think the right resolution is to accept that this separation
is useful and delete the TODO.

Then, add a test with an extremely simplified sketch of that
real-world example.  In case someone in the future attempts to
simplify this mixin away, the test will point us at the use case
that would be broken by such a change.

Also remove the only in-tree use of the mixin, which was redundant;
and expand the mixin's documentation to advise about that case.

* Tweak formatting

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

* Cut comments

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-08 01:17:23 +00:00
Jonah Williams
69421c1682
[framework] use shader tiling instead of repeated calls to drawImage (#119495)
* [framework] use shader tiling instead of repeated calls to drawImage

* ++

* ++

* review and test updates

* ++

* Update decoration_image.dart

* Update decoration_image.dart

* ++

* ++

* ++

* ++

* ++

* Update painting.dart

* Update decoration_test.dart
2023-02-03 07:28:57 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real (#119673)
* Make Flex,Row,Column const for real

* dart fix --apply

* fix snippets

* fix integration test

* add comment
2023-02-02 19:33:57 +00:00
LongCatIsLooong
1148a2a8ba
Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (#119359)
* PostFrameCallbacks -> compositionCallbacks

* review

* review
2023-01-31 01:39:09 +00:00
Michael Goderbauer
e9ca9cc146
Remove references to dart:ui's window singelton (#119296) 2023-01-27 21:36:54 +00:00
Michael Goderbauer
bb73121cb4
Remove unnecessary null checks in flutter/test (#118905) 2023-01-20 22:09:06 +00:00
LongCatIsLooong
0a2e0a4730
Avoid using TextAffinity in TextBoundary (#117446)
* Avoid affinity like the plague

* ignore lint

* clean up

* fix test

* review

* Move wordboundary to text painter

* docs

* fix tests
2023-01-05 17:04:15 +00:00
Sam Rawlins
63653e8272
== override parameters are non-nullable (#117839) 2023-01-04 01:13:21 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
Michael Goderbauer
81bc54be75
Enable use_colored_box lint (#117370) 2022-12-20 14:09:55 -08:00
Michael Goderbauer
fa3777bd3e
Enable sized_box_shrink_expand lint (#117371)
* Enable  lint

* note about discarded_futures

* note about use_decorated_box

* update note on require_trailing_commas
2022-12-20 19:07:15 +00:00
Lucas.Xu
b20a9e0a37
imporve gesture recognizer semantics test cases (#117257) 2022-12-17 21:00:46 +01:00
Lucas.Xu
80e1008cbc
fix: #110342 unable to update rich text widget gesture recognizer (#116849) 2022-12-16 09:32:09 +01:00
Callum Moffat
c4b8046d96
Floating cursor cleanup (#116746)
* Floating cursor cleanup

* Use TextSelection.fromPosition
2022-12-10 00:24:23 +00:00
chunhtai
c2b29501f4
Add selection feedback for both selection area and text field (#115373)
* Add selection feedback for both selection area and text field

* Addressing comment

* Fixes more test
2022-11-17 18:27:56 +00:00
Bruno Leroux
f1cdfa289d
Use AppBar.systemOverlayStyle to style system navigation bar (#104827)
* Use upper AnnotatedRegion properties when no bottom one found (and vice versa)

* Update comments

Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2022-11-07 20:42:56 +00:00
chunhtai
80bf355192
Support keyboard selection in SelectabledRegion (#112584)
* Support keyboard selection in selectable region

* fix some comments

* addressing comments
2022-11-04 10:55:28 -07:00
Alex Wallen
23d258df57
Remove deprecated updateSemantics API usage. (#113382) 2022-10-26 20:20:41 +00:00
Tomasz Gucio
e76f88316a
Cache TextPainter plain text value to improve performance (#109841) 2022-10-25 22:51:35 +02:00
LongCatIsLooong
78e94155a0
[RenderEditable] report real height when maxLines == 1. (#112029) 2022-09-28 21:40:47 +00:00
Polina Cherkasova
0a35cf95eb
Instrument State, Layer, RenderObject and Element. (#111328) 2022-09-20 16:39:46 -07:00
Kate Lovett
30c2d77d16
Remove Deprecated RenderUnconstrainedBox (#111711) 2022-09-20 00:54:36 +00:00
fzyzcjy
4ead92cf9b
Fix UiKitView which wrongly unconditionally repaints (#111790) 2022-09-19 17:16:18 +00:00
Jonah Williams
7e1e840999
[framework] revert removal of opacity (#111202) 2022-09-08 18:33:23 +00:00
Jason Simmons
f57fcac717
Clear the static _debugDoingBaseline flag if baseline calculation throws (#110387) 2022-08-30 19:49:17 +00:00
Greg Spencer
ee8488e871
Remove warnings when UnconstrainedBox and ConstraintsTransformBox are clipped (#110393) 2022-08-29 17:21:04 +00:00
Kate Lovett
7e12b37111
Deprecate 2018 text theme parameters (#109817) 2022-08-22 20:00:34 +00:00
Jonah Williams
44d3181deb
[framework] remove restriction on texture layer rasterization (#109900) 2022-08-20 03:06:23 +00:00