1323 Commits

Author SHA1 Message Date
Ayush Bherwani
60b9d15495
[RaisedButton] Added padding property to RaisedButton.icon (#52393) 2020-03-13 17:21:02 -07:00
Tong Mu
c82c399eb7
[DataTable] Hide arrow padding when not sorting (#51667)
* Change onSort and add tests

* Add doc

* Regression test

* Remove if (true)

* Make test clearer

* Clearer comment
2020-03-12 18:20:15 -07:00
Justin McCandless
4841a7ed6f
Text Selection Overflow (Android) (#49391)
Adds an overflow menu to the text selection menu on Android when the items overflow.
2020-03-11 13:36:10 -07:00
Per Classon
1546f41ec1
Add width constraints for FlexibleSpaceBar.title in its expanded state, so that overflow of long titles can be handled (#51335) 2020-03-09 12:06:01 -07:00
Per Classon
88852731a5
Validate text selection before updating it inside of EditableText (#51410) 2020-03-06 01:26:01 -08:00
Flutter GitHub Bot
cccbf1f200
Custom onPressed behavior for CloseButton widget (#51925) 2020-03-04 20:36:02 -08:00
Flutter GitHub Bot
b0381df11f
Unlooping Golden File Tests (#51883) 2020-03-04 15:21:01 -08:00
Shi-Hao Hong
ad44b05ca4
Revert "AlertDialog widget scrollable by default (#49848)" (#51886)
This reverts commit 28f2c96a8a63ca75700b307692b3bc691d6d010c.
2020-03-03 14:03:05 -08:00
Shi-Hao Hong
28f2c96a8a
AlertDialog widget scrollable by default (#49848) 2020-03-03 13:39:01 -08:00
Shi-Hao Hong
d2c734a36f
Simple repeating word fixes (#51871) 2020-03-03 11:13:07 -08:00
Greg Spencer
1ba4f1f509
Add Linux and Windows target platforms (#51519)
This PR adds the linux and windows target platform enum values, along with automatically setting the defaultTargetPlatform to the appropriate value on those platforms.

Fixes #31366
2020-03-03 04:38:04 -08:00
Pierre-Louis
ec64f93fdd
Material Bottom Sheet Reveal/Dismiss animation uses a curved animation (#51122) 2020-03-02 09:49:03 -08:00
Justin McCandless
7011d30876
AppBar Height Fix (#48761) 2020-02-28 09:51:02 -08:00
Jason Simmons
ae027c194f
Use strut box heights to calculate selection rectangles in order to ensure that they remain within visible bounds (#50354) 2020-02-28 09:36:03 -08:00
Darren Austin
fef2d6ccd6
Pass RouteSettings into all callers of showGeneralDialog. (#51525) 2020-02-27 15:11:01 -08:00
Dan Field
444b13b895
Colored box and container optimization (#50979) 2020-02-26 16:04:35 -08:00
Greg Spencer
9e744c5710
Implement VisualDensity for text fields. (#51438)
This implements VisualDensity changes for text fields*. By default, the layout of the text field does not change.

If the ThemeData.visualDensity is set to a value other than zero, then the density of the UI will increase or decrease. See the VisualDensity docs for more information.

(*In reality, the changes are on the InputDecorator class, not on the text field.)

I also fixed a problem that I think I found with _Decoration where it doesn't compare isDense or isCollapsed as part of its operator==.
2020-02-26 13:38:28 -08:00
Dmitry Ratushnyy
a70e4aec93
Material DataTable: added support of setting table row border thickness (#49692) 2020-02-24 09:46:03 -08:00
Shi-Hao Hong
6d4121c075
Fix tests that rely on FadeTransition incorrectly and depend on implementation details of FadeUpwardsTransitionBuilder (#51150) 2020-02-22 16:54:02 -08:00
Per Classon
74e564da2d
Add parameter to Scaffold so its possible to disable open Drawer drag gesture (#50925) 2020-02-19 18:51:04 -08:00
Darren Austin
7a83c6fcd4
Expose insetPadding and clipBehavior in Dialog and AlertDialog. (#50775) 2020-02-19 18:26:04 -08:00
Shi-Hao Hong
89ff794ac8
InputDecorator prefixIconConstraints and suffixIconConstraints (#50058) 2020-02-18 11:31:04 -08:00
creativecreatorormaybenot
08c835913e
Expose showButtonMenu of PopupMenuButtonState (#50670) 2020-02-14 14:51:19 -08:00
Shi-Hao Hong
1f3d423f92
Step 1: SnackBarBehavior.floating offset fix - Soft breaking change (#50597)
* Adds an opt-in flag to fix floating snackbar's offset when no floating action button is present. This flag will be removed once the migration for the fix is complete.

Co-authored-by: filaps <filip1997.28@mail.ru>
2020-02-13 10:04:31 -08:00
Shi-Hao Hong
a833effbc7
Reland Alert dialog overflow spacing (#50675)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-13 10:00:15 -08:00
Greg Spencer
232063e5c3
Changed ThemeData DiagnosticProperties to DiagnosticLevel.debug (#50589) 2020-02-13 09:53:02 -08:00
Greg Spencer
d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Jenn Magder
24017e761e
Revert "AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)" (#50674) 2020-02-12 15:20:13 -08:00
Shi-Hao Hong
23d61a81dc
AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-12 14:53:59 -08:00
Jacob Richman
7820641a05
Fix Diagnostics subclasses that had the wrong default value for the named parameter. (#50645) 2020-02-12 14:52:50 -08:00
Greg Spencer
c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046ed18ca32827e1a715ca5e405c646ac because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
Josh Burton
2b16202ea2
Adds shadowColor property to the Card widget (#47273) 2020-02-12 13:23:02 -08:00
Arthur Denner
d3e1e29375
SimpleDialogOption: support custom padding (#50035) 2020-02-12 08:58:03 -08:00
Anthony Mansour
4c1045c0f8
Fixed preferredSize getter in TabBar (#41299) 2020-02-12 08:53:02 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Lamonte
fd1062debd
Exposed optional scrollController property in ReorderableListView (#49148) 2020-02-11 10:58:02 -08:00
Greg Spencer
8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Shi-Hao Hong
67826bdce5
Revert "Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616)" (#50516)
This reverts commit 801a6a7e5e2c16525d3c2856a43ed34b5ff536a3.
2020-02-10 14:59:32 -08:00
Shi-Hao Hong
6dc3bfaa98
Fix Dropdown 'itemHeights' was called on null crash (#50366) 2020-02-07 18:28:02 -08:00
Michael Goderbauer
95d6ef741c
Nested TickerMode cannot turn tickers back on (#50355) 2020-02-07 18:23:02 -08:00
filaps
801a6a7e5e
Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616) 2020-02-07 16:08:02 -08:00
jimshepherd
92a335e465
Use state value in DropdownButtonFieldForm (#37145)
The current implementation of DropdownButtonFormField does not pass the initial value to _DropdownButtonFormFieldState. As a result changes made through the child DropdownButton are not made to the FormFieldState and the widget is not updated unless a onChanged function is provided to the DropdownButtomFormField constructor.

This change modifies DropdownButtonFormField to behave more consistently with other FormField widgets in how the Form state is handled.
2020-02-07 15:50:37 -08:00
Gary Qian
3e1a124e0e
Expose selectionHeightStyle and selectionWidthStyle on TextFields (#48917) 2020-02-05 17:38:03 -08:00
Shi-Hao Hong
e10df3c1a6
Step 1.5 of 3: AboutDialog uses scrollable AlertDialog (#49913) 2020-01-31 19:23:01 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations (#49622) 2020-01-31 18:30:21 +01:00
Bogdan Lukin
275ec45ec4
fix material selection handle paint with transparent textSelectionHandleColor (#49830) 2020-01-31 09:28:17 -08:00
Gary Qian
52df599419
Expose TextHeightBehavior in Text, RichText, and DefaultTextStyle. (#48346) 2020-01-29 17:02:57 -08:00
chunhtai
de7da494a1
Navigator 2.0: Refactor the imperative api to continue working in the new navigation system (#44930) 2020-01-29 13:43:02 -08:00
Dan Field
fabeb2a16f
Revert string interp (#49602) 2020-01-28 07:56:51 -08:00
Michael Goderbauer
bc5ea0a05a
Reland "Do not rebuild Routes when a new opaque Route is pushed on top" (#49376) 2020-01-27 23:56:41 -08:00