8672 Commits

Author SHA1 Message Date
skia-flutter-autoroll
69aaef3d03 Roll src/third_party/dart 49850e6919f7..16782e6c171f (16 commits) (flutter/engine#16485) 2020-02-06 20:18:03 -08:00
skia-flutter-autoroll
291207c072 Roll fuchsia/sdk/core/linux-amd64 from A9STP... to g2s3c... (flutter/engine#16484) 2020-02-06 17:33:03 -08:00
Francisco Magdaleno
40c7f488e9 Code cleanup on destructors (flutter/engine#16481) 2020-02-06 16:53:02 -08:00
skia-flutter-autoroll
0fae445981 Roll src/third_party/skia 121750c2efff..046f9893b953 (4 commits) (flutter/engine#16482) 2020-02-06 16:33:02 -08:00
Mouad Debbar
bdeb972d43 Run Flutter framework tests against the web engine in Cirrus (flutter/engine#16343) 2020-02-06 16:17:25 -08:00
skia-flutter-autoroll
0e6648c7b4 Roll src/third_party/dart b3396cbdcae1..49850e6919f7 (45 commits) (flutter/engine#16480) 2020-02-06 15:08:04 -08:00
George Wright
69e635c0fc Enable shell_unittests on Fuchsia with Vulkan dependencies. (flutter/engine#16376)
This also adds a dependency on SwiftShader's Vulkan frontend.
2020-02-06 15:07:01 -08:00
skia-flutter-autoroll
8e358801f6 Roll src/third_party/skia c0360582d211..121750c2efff (7 commits) (flutter/engine#16479) 2020-02-06 14:58:03 -08:00
Harry Terkelsen
f2839e3a3f Various fixes in CanvasKit (flutter/engine#16433)
- Enable dynamically loaded fonts
- Fix addOval
- Fix getBoxesForRange for negative ranges
2020-02-06 14:51:12 -08:00
stuartmorgan
f9ebc8e2dc Add noexcept annotations to EnableValue moves (flutter/engine#16478)
Fixes a warning when compiling in Visual Studio on Windows.
2020-02-06 14:28:31 -08:00
George Wright
36f5f76944 Enable runtime_unittests on Fuchsia 2020-02-06 13:52:33 -08:00
George Wright
10e7d17444 Fix elf_loader.cc on Fuchsia, add a TODO for proper fix 2020-02-06 13:52:33 -08:00
Anna Gringauze
1382e25796 Fix analyzer warnings for frontend_server change (flutter/engine#16470)
- added temporary ignore for annotate_overrides analyzer warning,
  will remove the ignore in a follow-up PR after the SDK change
  https://dart-review.googlesource.com/c/sdk/+/134561 lands.
- run dartfmt
2020-02-06 13:37:20 -08:00
skia-flutter-autoroll
a8adde9be6 Roll src/third_party/skia 7f36405ea3ec..c0360582d211 (6 commits) (flutter/engine#16476) 2020-02-06 13:23:03 -08:00
Sebastian Jeltsch
e7e1637bd9 Fix RasterCache LRU logic, opportunistic simplifications. (flutter/engine#16434)
RasterCache::Get() methods were not updating the RasterCache::Entry
access_count and used_this_frame fields, as is done in
RasterCache::Prepare(). This can result in onscreen images being evicted
from the cache as new entries are created (e.g. as new elements scroll
onscreen).
2020-02-06 13:15:51 -08:00
George Wright
bc12e7c8ab Disable unit tests using --gtest-filter instead of at compile time (flutter/engine#16472) 2020-02-06 13:01:14 -08:00
Chinmay Garde
f0ded2e849 Relax timing restrictions on WakeUpTimersAreSingletons. (flutter/engine#16446)
We don’t run this test on bots because we don’t want timeouts on any tests. This
only runs locally as a sanity check for timers.
2020-02-06 12:35:36 -08:00
Ferhat
0b3f68c172 Reset width/height before deallocation for Safari allocation bug. (flutter/engine#16469) 2020-02-06 12:30:27 -08:00
skia-flutter-autoroll
95393f6543 Roll src/third_party/skia 116b33e8ab21..7f36405ea3ec (3 commits) (flutter/engine#16471) 2020-02-06 11:43:04 -08:00
skia-flutter-autoroll
5fdf36f4cc Roll src/third_party/skia cc21d0c1f2ce..116b33e8ab21 (3 commits) (flutter/engine#16466) 2020-02-06 09:58:01 -08:00
skia-flutter-autoroll
ecedef91dd Roll src/third_party/skia f6e3eaf05150..cc21d0c1f2ce (1 commits) (flutter/engine#16463) 2020-02-06 08:13:03 -08:00
skia-flutter-autoroll
591ecae6f5 Roll src/third_party/skia cbf79b95c2d4..4721e067812f (1 commits) (flutter/engine#16459) 2020-02-06 04:38:02 -08:00
skia-flutter-autoroll
24103e4599 Roll fuchsia/sdk/core/linux-amd64 from VJv0H... to A9STP... (flutter/engine#16457) 2020-02-06 03:53:03 -08:00
Lau Ching Jun
2b914aa0dc Include <memory> in hb_wrapper.h because unique_ptr is used. (flutter/engine#16442) 2020-02-06 00:54:56 -08:00
stuartmorgan
86e0af1222 Roll rapidjson (flutter/engine#16347)
Rolls rapidjson forward to the next mirrored version. This is needed to
pick up fixes to building with clang on Windows, to support
https://github.com/flutter/flutter/issues/16256.
2020-02-05 22:35:02 -08:00
stuartmorgan
9c3b20b923 Wrap strdup to use compliant name on Windows (flutter/engine#16372)
A number of POSIX methods were renamed on Windows to match standards
requirements, giving deprecation warnings when calling strdup on Windows.
This adds a wrapper, to allow calling _strdup on Windows instead.

Part of #16256
2020-02-05 22:32:56 -08:00
stuartmorgan
91424efae5 Add explicit casts to printing of function pointers (flutter/engine#16370)
Compiling with clang on Windows fails here with a warning about implicit
cast from function pointer to object pointer. Rather than disable that
warning, this makes it an explicit cast. Since this is just test output,
it's not critical that this be a completely safe operation.

Part of #16256
2020-02-05 22:31:22 -08:00
skia-flutter-autoroll
1a72bb4b43 Roll src/third_party/skia ebc00f97fab1..cbf79b95c2d4 (4 commits) (flutter/engine#16456) 2020-02-05 22:23:04 -08:00
stuartmorgan
69e4ea885f Suppress some deprecation warnings on Windows (flutter/engine#16416)
Targeted suppression of some deprecation warnings that are build errors under
clang:
- Ignore the deprecation of codecvt's unicode conversion until we decide on
  a replacement strategy.
- Allow the deprecated posix names of functions in third_party/txt.

Part of https://github.com/flutter/flutter/issues/16256
2020-02-05 21:10:25 -08:00
Felipe Archondo
4884bd75f9 [fuchsia] change kMaxFramesInFlight to 3 (flutter/engine#16425)
To give more flexibility in scheduling, we change the number of frames
in flight we can have at one time to 3. We also introduce an offset from
VSync that Flutter can use to begin its work at. It is currently set at
0ms, matching previous behavior.
2020-02-05 23:58:05 -05:00
Mouad Debbar
efca62703f Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (flutter/engine#16365) 2020-02-05 19:53:03 -08:00
Yegor
617582e744 fix bad reference to maxDiffRatePercent (flutter/engine#16440)
* fix bad reference to maxDiffRatePercent

* back to 10%
2020-02-05 18:49:10 -08:00
gaaclarke
829529ba4c Added a plugin method that gets called when the engine is about to be deleted (flutter/engine#16336) 2020-02-05 16:12:16 -08:00
skia-flutter-autoroll
57fefafc72 Roll src/third_party/skia bc3307c395e2..ebc00f97fab1 (21 commits) (flutter/engine#16429) 2020-02-05 16:03:04 -08:00
Yegor
e101a7c901 use percent for golden diff rates; tighten the values (flutter/engine#16430) 2020-02-05 15:53:45 -08:00
Ferhat
a00b502efa [web] Fixes incorrect transform when context save and transforms are deferred. (flutter/engine#16412)
* Fix transform order in clipStack replay
2020-02-05 15:02:34 -08:00
stuartmorgan
1749454a9f Fix Windows embedding issues caught by clang (flutter/engine#16369)
Clang has different warning settings, so catches different issues than
the VS compile. This fixes various minor issues caught by clang.

Part of https://github.com/flutter/flutter/issues/16256
2020-02-05 14:27:09 -08:00
stuartmorgan
4e9824a89a Update license output (flutter/engine#16379)
The license output has a latent change that shows up for any change that
forces a re-run, due to the tonic move. This updates the output to
account for that.
2020-02-05 13:59:30 -08:00
Felipe Archondo
456e65b23f [fuchsia] Migrate flutter runner to use Present2 (flutter/engine#14162)
No change in behavior expected. We have 2 frames in flight as before. By switching to Present2 and specifying a kMaxFramesInFlight however, we allow us greater flexibility to change how Flutter schedules its frames.

This change also adds tests for SessionConnection and VsyncRecorder.
2020-02-05 13:51:04 -08:00
Dan Field
c829f34f55 fix build_id logic for fuchsia symbols (flutter/engine#16397) 2020-02-05 12:59:53 -08:00
gaaclarke
d185bc8360 Copied Apple's semantics for switches, made checkboxes the same. (flutter/engine#16211) 2020-02-05 10:13:31 -08:00
skia-flutter-autoroll
241f3da4dd Roll src/third_party/skia 6c9b1fd6663e..bc3307c395e2 (1 commits) (flutter/engine#16383) 2020-02-05 03:28:02 -08:00
skia-flutter-autoroll
8be28a529b Roll src/third_party/dart 48808f7dce81..34893faa6079 (7 commits) (flutter/engine#16381)
https://dart.googlesource.com/sdk.git/+log/48808f7dce81..34893faa6079

git log 48808f7dce81..34893faa6079 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 scheglov@google.com Use DartType.getDisplayString() instead of toString().
2020-02-05 scheglov@google.com Use DartType.getDisplayString() instead of toString().
2020-02-05 scheglov@google.com Use DartType.getDisplayString() instead of toString().
2020-02-05 johnniwinther@google.com [cfe] Implement weak mode constants semantics
2020-02-05 bkonyi@google.com Revert "[ VM / Service ] Added `getClientName`, `setClientName` and `requireResumeApproval` RPCs"
2020-02-05 fishythefish@google.com [dart2js] Remove typedefs from backend.
2020-02-05 nshahan@google.com Revert "[tests] Add tests for generic function type bounds with null safety"

Created with:
  gclient setdep -r src/third_party/dart@34893faa6079

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2020-02-05 04:34:16 -05:00
skia-flutter-autoroll
2848cb5177 Roll src/third_party/skia 14d64afaa8a3..6c9b1fd6663e (7 commits) (flutter/engine#16380) 2020-02-04 23:53:02 -08:00
skia-flutter-autoroll
77ae607cb0 Roll src/third_party/dart 68e904e444dc..48808f7dce81 (17 commits) (flutter/engine#16377)
https://dart.googlesource.com/sdk.git/+log/68e904e444dc..48808f7dce81

git log 68e904e444dc..48808f7dce81 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 bkonyi@google.com [ VM / Service ] Added `getClientName`, `setClientName` and `requireResumeApproval` RPCs
2020-02-04 vsm@google.com [dartdevc,nnbd] fix type errors in dart:_interceptors
2020-02-04 asiva@google.com [VM/libraries] - Fix issues in ported patch files that cause dart2js to fail (https://github.com/dart-lang/sdk/issues/40463)
2020-02-04 sigmund@google.com [ddc,dart2js] remove web patches for dart:cli
2020-02-04 rmacnak@google.com [vm] Remove FLAG_support_service and FLAG_support_reload, superseded by PRODUCT define.
2020-02-04 nshahan@google.com [dartdevc] Enforce more pedantic v1.9.0 lints and cleanup violations
2020-02-04 nshahan@google.com [tests] Add tests for generic function type bounds with null safety
2020-02-04 paulberry@google.com Migration: rework how ElementTypeProvider overrides element types.
2020-02-04 paulberry@google.com Sort declarations in assignment_expression_resolver.dart
2020-02-04 bkonyi@google.com [ DartFuzz ] Quality of life improvements in log output
2020-02-04 eernst@google.com Adjusted language/assign/to_type_test.dart to avoid irrelevant nnbd type error.
2020-02-04 devoncarew@google.com [migration tool] convert the javascript code in the migration tool to dart
2020-02-04 jcollins@google.com Do not require --enable-asserts for test_assertOnPathOutsidePackage.
2020-02-04 scheglov@google.com Remove 'withNullability' from TypeImpl.toString()
2020-02-04 kustermann@google.com [vm/concurrency] Speed up isolate communication via normal snapshotting
2020-02-04 regis@google.com [VM/nnbd] Fix canonicalization of type 'Never' (fixes #40249).
2020-02-04 jwren@google.com Refactor the CompletionMetricsComputer class into three classes: a subclass and two concrete classes, AbstractCompletionMetricsComputer, CompletionCoverageMetrics and RelevanceAnalyzerMetrics.

Created with:
  gclient setdep -r src/third_party/dart@48808f7dce81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
2020-02-04 23:15:46 -05:00
skia-flutter-autoroll
b6c80b1724 Roll src/third_party/skia 2aee7d24da8f..14d64afaa8a3 (10 commits) (flutter/engine#16374) 2020-02-04 19:53:02 -08:00
Dan Field
8e419f3347 Fuchsia a11y actions (flutter/engine#16321) 2020-02-04 19:01:19 -08:00
Gary Qian
1069df1834 Add docs (flutter/engine#16368) 2020-02-04 13:53:02 -08:00
stuartmorgan
7fb266e910 Fix and consolidate wstring conversion utils (flutter/engine#16342)
There were two variants of string/wstring conversion utils, one using
codecvt_utf8 and the other using codecvt_utf8_utf16. We want the latter,
since we want to be using UTF-16, not UCS2.
2020-02-04 13:33:07 -08:00
George Wright
252134fac8 Expose the dart kernel snapshot target and copied assets as a public dependency (flutter/engine#16266)
This allows for targets to depend on the assets generated by the test_fixtures target.
2020-02-04 12:30:48 -08:00