DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,092 Commits 882 Branches 1,069 Tags
Commit Graph

24348 Commits

Author SHA1 Message Date
Dan Field
670b5bd8e7 Fix Platform.script for flutter_tester (flutter/engine#46911) 
This addresses the problem in https://github.com/flutter/flutter/issues/12847 which changed slightly over time.

Today, `Platform.script` does not give an empty `file` URI, it gives something like `file://path/to/package/main.dart` _regardless of how the file is actually named_.

After this change, it will give the absolute path to the file being run under test.

So before this change, the new test would have a URI like

```
file:///Users/dnfield/src/flutter/engine/src/main.dart
```

And now it has

```
file:///Users/dnfield/src/flutter/engine/src/out/host_debug_unopt_arm64/gen/platform_test.dart.dill
```

This is going to be helpful in generating relative paths from the test file.
 2023-10-16 21:55:06 +00:00
skia-flutter-autoroll
2bd3e9b6e6 Roll Skia from 85c8dca08cbe to 8919fecf15c1 (1 revision) (flutter/engine#46966) 
https://skia.googlesource.com/skia.git/+log/85c8dca08cbe..8919fecf15c1

2023-10-16 kjlubick@google.com Reland "Remove GL dependency from GrBackendSemaphore"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 21:53:06 +00:00
Matej Knopp
64af1329c2 [macOS] FlutterMutatorView should clip to bounds (flutter/engine#46463) 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-16 21:14:57 +00:00
skia-flutter-autoroll
97eae1ceed Roll Skia from 0e5207fb4971 to 85c8dca08cbe (1 revision) (flutter/engine#46964) 
https://skia.googlesource.com/skia.git/+log/0e5207fb4971..85c8dca08cbe

2023-10-16 michaelludwig@google.com [graphite] Fix SkMatrix row-major uniform upload bug

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 20:46:57 +00:00
John McCutchan
9f4cf7153a Allow Image backed platform view rendering target on Android >= 29 again (flutter/engine#46958) 
- Refactor the fence waiting code to only wait on Android >= 33.
- Log a warning message once per image rendering target on Android >= 29 && < 33.
- Add a simple unit test of ImageReaderPlatformViewRenderTargets.
 2023-10-16 20:08:13 +00:00
skia-flutter-autoroll
0174442f71 Roll Skia from 68de6e352585 to 0e5207fb4971 (1 revision) (flutter/engine#46960) 
https://skia.googlesource.com/skia.git/+log/68de6e352585..0e5207fb4971

2023-10-16 sunnyps@chromium.org graphite: Fix SkMipmap memory leak

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 19:58:44 +00:00
skia-flutter-autoroll
11b3a931e8 Roll Skia from 675f088b9ac4 to 68de6e352585 (1 revision) (flutter/engine#46956) 
https://skia.googlesource.com/skia.git/+log/675f088b9ac4..68de6e352585

2023-10-16 kjlubick@google.com Move SkMultiPictureDocument functions into namespace in include/docs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 18:31:16 +00:00
gaaclarke
c8aa0844f2 [Impeller] implements a retry mechanism for dart:ui/Image.toByteData. (flutter/engine#46840) 
Design doc: [link](https://docs.google.com/document/d/1Uuiw3pdQxNFTA8OQuZ-kuvYg1NB42XgccQCZeqr4oII/edit#heading=h.hn6wreyrz6fm)
fixes: https://github.com/flutter/flutter/issues/135245

One slight deviation from the design doc is that I decided to make ContextMTL respond to changes to the SyncSwitch instead of having it observe the app state directly.  The benefits are:
1) This keeps that functionality in one location
1) It makes writing tests much easier
1) There's no need of conditional compilation between macos and ios
1) There is no need to add an objc class

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-16 18:31:13 +00:00
Jason Simmons
d54994a59e [Impeller] Adjust clip coverage operations to handle per-pass clip stacks (flutter/engine#46912) 
https://github.com/flutter/engine/pull/46597 creates a new clip coverage stack for each subpass.  This PR updates some clip coverage operations and assertions in EntityPass::OnRender to reflect that the current clip coverage stack only contains the range of depths within the current subpass.
 2023-10-16 18:06:10 +00:00
skia-flutter-autoroll
2e7e063f0b Roll Skia from 2db9c220ba00 to 675f088b9ac4 (2 revisions) (flutter/engine#46954) 
https://skia.googlesource.com/skia.git/+log/2db9c220ba00..675f088b9ac4

2023-10-16 johnstiles@google.com Make TArray::bytes a static function.
2023-10-16 johnstiles@google.com Factor out growAndPushBack into a helper function.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 17:43:28 +00:00
skia-flutter-autoroll
c22ec97536 Roll Dart SDK from 64a485bb79bd to 12f6559bd6ed (1 revision) (flutter/engine#46953) 
https://dart.googlesource.com/sdk.git/+log/64a485bb79bd..12f6559bd6ed

2023-10-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-28.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 17:31:07 +00:00
skia-flutter-autoroll
5f0c3370b8 Roll Skia from 44a0f98aa71a to 2db9c220ba00 (1 revision) (flutter/engine#46949) 
https://skia.googlesource.com/skia.git/+log/44a0f98aa71a..2db9c220ba00

2023-10-16 johnstiles@google.com Fix TArray::push_back when pushing references inside the container.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 16:56:21 +00:00
skia-flutter-autoroll
04ffd7c02a Roll Skia from 238ab1631282 to c03c9a02f6ef (1 revision) (flutter/engine#46946) 
https://skia.googlesource.com/skia.git/+log/238ab1631282..c03c9a02f6ef

2023-10-16 egdaniel@google.com Revert "When waiting on client provided semaphores, only block fragment stage work."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 14:41:22 +00:00
Jason Simmons
9019beb02b Avoid a deadlock in the flutter_tester process when deleting the Impeller Vulkan context during shutdown (flutter/engine#46860) 
The Impeller ContextVK contains a ConcurrentMessageLoop whose threads may invoke Dart timeline APIs.  The Dart APIs will create a thread-local object that will be deleted during thread shutdown.  Therefore, these threads should not outlive the engine/Shell and Dart VM.

Previously, RunTester held the ImpellerVulkanContextHolder on the stack, and its reference to the ContextVK would be dropped while exiting the function after the Shell is destructed.

This PR moves the contents of the tester's ImpellerVulkanContextHolder out of the instance on the stack and into a lambda owned by the Shell.

It also reenables the flutter_tester Impeller tests in the run_tests script.
 2023-10-16 14:37:18 +00:00
skia-flutter-autoroll
da92f0dbfd Roll Skia from 798ef5becc8d to a83914bb86c9 (1 revision) (flutter/engine#46938) 
https://skia.googlesource.com/skia.git/+log/798ef5becc8d..a83914bb86c9

2023-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 77ae6a2042d8 to b7f47ce3bc13 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-16 06:14:04 +00:00
Bruno Leroux
d003a7f2fb Reland - [Android] Add support for text processing actions (flutter/engine#46817) 
## Description

This is a reland of https://github.com/flutter/engine/pull/44579 which was reverted in https://github.com/flutter/engine/pull/46788.

This reland adds a check into `onActivityResult` in order to return early if the result is related to an unknown request code (aka the result is related to a request sent by another plugin).
It also adds one test that simulates receiving such an unknown request code.

## Related Issue

Android engine side for https://github.com/flutter/flutter/issues/107603

## Tests

Adds 4 tests.
 2023-10-16 05:43:15 +00:00
Tong Mu
f263e6a49f Revert "Reland: Enforce the rule of calling FlutterView.Render (#45300)" (flutter/engine#46919) 
Reverts flutter/engine#45555 due to possible performance regression, b/304898239
 2023-10-16 05:37:20 +00:00
Jonah Williams
959b288e4b [Impeller] Vulkan GPU tracer cleanups (flutter/engine#46915) 
Cleanups that seem to reduce occurance of SIGBUS crash, which It turns out I did not in fact fix.
 2023-10-14 18:40:25 +00:00
skia-flutter-autoroll
e39317a11d Roll Fuchsia Linux SDK from wBb32R567S1alWbfn... to ATLkmtMOIbHDqp6a_... (flutter/engine#46921) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-14 07:56:39 +00:00
skia-flutter-autoroll
2ef9d9127d Roll Skia from 9affbebb459a to 1c6e0141be7b (2 revisions) (flutter/engine#46918) 
https://skia.googlesource.com/skia.git/+log/9affbebb459a..1c6e0141be7b

2023-10-14 michaelludwig@google.com [graphite] Add Transform::Translate factory
2023-10-14 michaelludwig@google.com Add SkModifyPaintAndDstForDrawImageRect helper function

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-14 03:46:05 +00:00
skia-flutter-autoroll
f148740138 Roll Dart SDK from 5844b34768ce to 02e6d943f1a7 (1 revision) (flutter/engine#46917) 
https://dart.googlesource.com/sdk.git/+log/5844b34768ce..02e6d943f1a7

2023-10-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-26.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-14 01:33:00 +00:00
skia-flutter-autoroll
066f56a087 Roll Skia from 4bc4b4d22866 to 9affbebb459a (2 revisions) (flutter/engine#46913) 
https://skia.googlesource.com/skia.git/+log/4bc4b4d22866..9affbebb459a

2023-10-13 johnstiles@google.com Fix outdated calls inside SkPathOpsDebug code.
2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e96a768f1028 to e9f80c535365 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 22:17:48 +00:00
Jonah Williams
ff1fc77532 [Impeller] Add GPU frame time to Vulkan backend using timestamp queries. (flutter/engine#46796) 
For https://github.com/flutter/flutter/pull/136408 ,

Approximate the GPU frame time by measuring the difference between a timestamp query recorded at the beginning of the frame and a timestamp query recorded at the end of the frame.
 2023-10-13 22:05:00 +00:00
skia-flutter-autoroll
b5701a2d66 Manual roll Dart SDK from c8143a7c026f to 5844b34768ce (1 revision) (flutter/engine#46909) 
Manual roll requested by jacksongardner@google.com

https://dart.googlesource.com/sdk.git/+log/c8143a7c026f..5844b34768ce

2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-25.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 21:36:36 +00:00
skia-flutter-autoroll
4a414de39c Roll Skia from c9601553b0f3 to 4bc4b4d22866 (1 revision) (flutter/engine#46908) 
https://skia.googlesource.com/skia.git/+log/c9601553b0f3..4bc4b4d22866

2023-10-13 kjlubick@google.com Revert "Remove GL dependency from GrBackendSemaphore"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 21:32:07 +00:00
skia-flutter-autoroll
369ffac405 Roll Skia from 8dc8e21a4dec to c9601553b0f3 (3 revisions) (flutter/engine#46907) 
https://skia.googlesource.com/skia.git/+log/8dc8e21a4dec..c9601553b0f3

2023-10-13 armansito@google.com Add Graphite_Dawn_Vello jobs
2023-10-13 kjlubick@google.com [ClangTidy] Avoid copy by using a reference in GrModulateAtlasCoverageEffect
2023-10-13 kjlubick@google.com Remove GL dependency from GrBackendSemaphore

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 20:45:06 +00:00
skia-flutter-autoroll
374aaa2660 Roll Skia from b50d7f9aa743 to 8dc8e21a4dec (4 revisions) (flutter/engine#46902) 
https://skia.googlesource.com/skia.git/+log/b50d7f9aa743..8dc8e21a4dec

2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from bbf6a30f67f4 to 444eb9b78e14
2023-10-13 johnstiles@google.com Prefer precision over performance in Raster Pipeline.
2023-10-13 jvanverth@google.com [graphite] Enable RasterPathAtlas for single-sampled draws.
2023-10-13 johnstiles@google.com Enable Graphite in Canvaskit when WebGPU is enabled.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 19:59:46 +00:00
Jonah Williams
90709e4e33 [Impeller] fix clear color optimization for large subpasses. (flutter/engine#46887) 
Fixes https://github.com/flutter/flutter/issues/136507 .

The cause of this bug is that we use different sizes to compute the clear color value when constructing the render target and when skipping entities:

https://github.com/flutter/engine/blob/main/impeller/entity/entity_pass.cc#L632
https://github.com/flutter/engine/blob/main/impeller/entity/entity_pass.cc#L731 and
https://github.com/flutter/engine/blob/main/impeller/entity/entity_pass.cc#L900C3-L900C3

Either the former should use the root pass size or the later should use the subpass size. This usually isn't an issue because if something covers the root pass size it generally always covers the subpass size. But during the page transition, the scaled subpass ends up slightly bigger than the root pass size and so these conditions are mismatched:

Subpass size: (1550, 3188) root pass size (1440, 3036)

I think subpass size is correct. If the subpass is larger than the parent, then checking the parent size will give incorrect result.
 2023-10-13 19:34:55 +00:00
Matan Lurey
8708b3e411 Oops, allow files in opted-in third_party directories. (flutter/engine#46897) 
Closes https://github.com/flutter/flutter/issues/136551.
 2023-10-13 12:22:07 -07:00
skia-flutter-autoroll
82320bf21d Roll Skia from e10e6765480a to b50d7f9aa743 (1 revision) (flutter/engine#46899) 
https://skia.googlesource.com/skia.git/+log/e10e6765480a..b50d7f9aa743

2023-10-13 jvanverth@google.com [graphite] Restructure how we handle AtlasProvider uploads.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 19:12:21 +00:00
Dan Field
96b51058d2 [Impeller] Only allow Impeller in flutter_tester if vulkan is enabled. (flutter/engine#46895) 
Follows up on #46389 

That patch was too permissive in cases where a build system enables impeller but not vulkan. This change makes the build succeed in such systems.
 2023-10-13 18:57:10 +00:00
Ann Marie Mossman
f885190369 Replace deprecated [UIScreen mainScreen] in FlutterView.mm (flutter/engine#46802) 
Addresses: https://github.com/flutter/flutter/issues/130828
 2023-10-13 18:23:09 +00:00
skia-flutter-autoroll
fc38cde7bc Roll Skia from 643d74cf4e0b to 4783e1146146 (2 revisions) (flutter/engine#46890) 
https://skia.googlesource.com/skia.git/+log/643d74cf4e0b..4783e1146146

2023-10-13 johnstiles@google.com Improve Tegra3 and Mali400 quad-edge AA output.
2023-10-13 kjlubick@google.com [bazel] Update version of rules_pkg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 17:48:19 +00:00
skia-flutter-autoroll
b566cef531 Roll Dart SDK from 95e2ecee106a to c8143a7c026f (1 revision) (flutter/engine#46889) 
https://dart.googlesource.com/sdk.git/+log/95e2ecee106a..c8143a7c026f

2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-24.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 17:36:24 +00:00
skia-flutter-autoroll
79e05b780e Roll Skia from 77e73bb2744b to 643d74cf4e0b (2 revisions) (flutter/engine#46888) 
https://skia.googlesource.com/skia.git/+log/77e73bb2744b..643d74cf4e0b

2023-10-13 michaelludwig@google.com Add un-implemented API for SkDevice::drawCoverageMask
2023-10-13 fmalita@chromium.org [skottie] Adjustable WYSIWYG cursor weight

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 17:06:06 +00:00
Derek Xu
9b06776b0e Use --timeline_recorder=systrace instead of --systrace_timeline (flutter/engine#46884) 
`--systrace_timeline` is redundant and makes the `getFlagList` VM
Service RPC not return `timeline_recorder=systrace`
(https://github.com/flutter/devtools/issues/6524#issuecomment-1760090526),
so we would like to deprecate and remove it.
 2023-10-13 12:47:51 -04:00
Erik German
cc53445e19 fixed AutofillHints.middleName tanslation for web. (flutter/engine#46429) 
This PR fixes the AutofillHints.middleName has no effect on TextField in Web bug.

<img width="1440" alt="Screenshot 2023-09-30 at 1 18 03 p m" src="https://github.com/flutter/engine/assets/36830415/f6643b71-3944-42da-a9b4-47e1cebb290e">

Closes [#135542](https://github.com/flutter/flutter/issues/135542)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-13 16:34:57 +00:00
skia-flutter-autoroll
b388c001e4 Roll Skia from 3acf82dcc479 to 77e73bb2744b (2 revisions) (flutter/engine#46886) 
https://skia.googlesource.com/skia.git/+log/3acf82dcc479..77e73bb2744b

2023-10-13 kjlubick@google.com Remove legacy GrDirectContext::MakeGL
2023-10-13 kjlubick@google.com Remove empty filegroups

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 16:22:13 +00:00
gaaclarke
c053bc814b [Impeller] Started throwing errors if dart:ui/Image.toByteData fails (flutter/engine#46738) 
issue: https://github.com/flutter/flutter/issues/135245

This is a first step.  Next we'll implement a retry.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-13 09:04:47 -07:00
skia-flutter-autoroll
6ee1975481 Roll Skia from e566db061ce8 to 3acf82dcc479 (2 revisions) (flutter/engine#46883) 
https://skia.googlesource.com/skia.git/+log/e566db061ce8..3acf82dcc479

2023-10-13 michaelludwig@google.com Manual Dawn roll with flag removal
2023-10-13 robertphillips@google.com [graphite] Add some missing color filters to the precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 15:37:07 +00:00
Kevin Lubick
efc265b5e9 Fix forward declare and some deprecated enums (flutter/engine#46882) 
There was a compile error when trying to roll in
http://review.skia.org/764970, and this addresses that.

While I was here, I noticed some uses of the old-named `GrBackend` enum
and updated it to the non-deprecated enum class.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-13 10:56:27 -04:00
skia-flutter-autoroll
339526485c Roll Skia from c640eeed2695 to e566db061ce8 (1 revision) (flutter/engine#46881) 
https://skia.googlesource.com/skia.git/+log/c640eeed2695..e566db061ce8

2023-10-13 michaelludwig@google.com [skif] Skip auto saveLayer for most drawImageRect() calls

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 14:51:06 +00:00
Kevin Lubick
a6761a95ea Update to use GrDirectContexts::MakeVulkan (flutter/engine#46878) 
In http://review.skia.org/764516, Skia moved the way to make a Vulkan
context. This updates Flutter to use that new way.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-13 10:41:25 -04:00
Zachary Anderson
7922a335e8 Don't use objcopy to embed Android icudtl (flutter/engine#46862) 
When objcopy is used to embed data into a linkable object file, that
object file will only have default bits set in its header for ABI etc..
If the linker doesn't cooperate by ignoring ABI mismatches on object
files without code, then linking will fail. This PR stops using objcopy
to create an object file that embeds icudtl.dat into the Android
embedder, and instead uses the `bin_to_assembly.py` script that we're
already using for Dart VM snapshot data.

Context in https://github.com/llvm/llvm-project/issues/68915
 2023-10-13 07:33:24 -07:00
skia-flutter-autoroll
a6abdb4565 Roll Dart SDK from 54ef02480719 to 95e2ecee106a (1 revision) (flutter/engine#46877) 
https://dart.googlesource.com/sdk.git/+log/54ef02480719..95e2ecee106a

2023-10-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-23.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 13:33:06 +00:00
skia-flutter-autoroll
6d31e5591a Roll Fuchsia Linux SDK from QLiomHC9D-GWh_gyK... to pI1BVH08V0eG0M7sw... (flutter/engine#46867) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 06:29:52 +00:00
skia-flutter-autoroll
8cbb338d74 Roll Skia from bf557aeaaef8 to aee708412bec (1 revision) (flutter/engine#46865) 
https://skia.googlesource.com/skia.git/+log/bf557aeaaef8..aee708412bec

2023-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7ab058e00df4 to 77ae6a2042d8 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 05:35:05 +00:00
Zachary Anderson
35f53fe500 Revert "Remove the frontend server wrapper" (flutter/engine#46863) 
Reverts flutter/engine#46440

For b/305121780
 2023-10-12 20:42:35 -07:00
skia-flutter-autoroll
2f8358efe4 Roll Dart SDK from 34c06f0bcb29 to b0d65ad14354 (3 revisions) (flutter/engine#46859) 
https://dart.googlesource.com/sdk.git/+log/34c06f0bcb29..b0d65ad14354

2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-19.0.dev
2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-18.0.dev
2023-10-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-17.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-13 00:48:21 +00:00
Jason Simmons
e7da0b1c5a Temporarily remove the runs of the engine Dart tests with Impeller enabled (flutter/engine#46854) 
These tests are sometimes hanging when the flutter_tester deletes the ContextVK and ConcurrentMessageLoop during shutdown.
 2023-10-12 23:47:08 +00:00