DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,182 Commits 882 Branches 1,069 Tags
Commit Graph

25132 Commits

Author SHA1 Message Date
Matan Lurey
6192857eb8 Move third_party/yapf to flutter/third_party/yapf. (flutter/engine#48847) 
As part of eliminating the Flutter buildroot
(https://github.com/flutter/flutter/issues/67373), we are moving all
third-party dependencies from `//third_party` to
`//flutter/third_party`.
 2023-12-11 15:18:19 -08:00
Bartek Pacia
d3b6e4044d SemanticsUpdateBuilder migration: introduce identifier (flutter/engine#48882) 
This PR adds `String? identifier` to `SemanticsUpdateBuilder` (currently it's only available in the temproary `SemanticsUpdateBuilderNew` API.

This is mainly targeted at https://github.com/flutter/flutter/issues/17988

Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
part 2: [flutter] use `SemanticsUpdateBuilderNew`  https://github.com/flutter/flutter/pull/138331
**part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`** <-- we are here
part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again.
part 5: [engine] remove `SemanticsBuilderNew`
 2023-12-11 22:35:07 +00:00
Bartek Pacia
de91195bb1 Add support for exposing accessibility identifier as accessibilityIdentifier on iOS (flutter/engine#48858) 
This PR is a sibling of #47961 but for iOS
 2023-12-11 22:35:06 +00:00
auto-submit[bot]
3900ec6e47 Reverts "[Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" (flutter/engine#48895) 
Reverts flutter/engine#48811
Initiated by: camsim99
This change reverts the following previous change:
Original Description:
Adds target (`Linux linux_android_emulator_tests_api_33`)  to have Android emulator testst run on AVDs with Android 33 so that the differences between those tests runs and those running on AVDs with Android 34 (`Linux linux_android_emulator_tests`) may be observed.

Related to https://github.com/flutter/flutter/issues/137947.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-11 22:09:26 +00:00
skia-flutter-autoroll
d1d42aa3f1 Roll Skia from e55567fceb5f to 17bd70326a49 (22 revisions) (flutter/engine#48890) 
https://skia.googlesource.com/skia.git/+log/e55567fceb5f..17bd70326a49

2023-12-11 robertphillips@google.com Revert "[graphite] Allow GetSkColorTypeFromBufferFormat to be used in Graphite"
2023-12-11 jvanverth@google.com [graphite] Split cubic sampling of YUV images from non-cubic sampling.
2023-12-11 kjlubick@google.com Reland "Remove SkFontPriv functions related to "default" Typeface"
2023-12-11 michaelludwig@google.com [skif] Mark AutoSurface's device as immutable when snapping
2023-12-11 michaelludwig@google.com [skif] Add SkSpecialImages::AsBitmap, remove getROPixels()
2023-12-11 kjlubick@google.com Revert "Remove SkFontPriv functions related to "default" Typeface"
2023-12-11 robertphillips@google.com [graphite] Allow GetSkColorTypeFromBufferFormat to be used in Graphite
2023-12-11 kjlubick@google.com Remove SkFontPriv functions related to "default" Typeface
2023-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f4a64ca5f094 to d895a1c308f3 (1 revision)
2023-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1dd726c2f6be to 9196dd470724
2023-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2291a55e72cd to 29ab089da265 (26 revisions)
2023-12-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2023-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f3719bdaf8cc to f4a64ca5f094 (3 revisions)
2023-12-09 mkember@google.com [Fuchsia] Add FIDL HLCPP tables.c file to the build
2023-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from ffaff60d9659 to fa4c93a17fe6 (1 revision)
2023-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d4258544ceac to f3719bdaf8cc (6 revisions)
2023-12-08 kjlubick@google.com Update many uses of SkFont that had nullptr SkTypeface
2023-12-08 kjlubick@google.com Add Bazel buffet builds for paragraph and accessories
2023-12-08 petermcneeley@chromium.org [ganesh] Add BGRA8 / kRGB_888x combo
2023-12-08 jvanverth@google.com Add a new wacky_yuv GM that exercises cubic sampling.
2023-12-08 brianosman@google.com Fix text in viewer stats
2023-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from ae93b7885b44 to f90eb691f29a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,michaelludwig@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-11 21:29:04 +00:00
Camille Simon
744d36f9e0 [Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34 (flutter/engine#48811) 
Adds target (`Linux linux_android_emulator_tests_api_33`)  to have Android emulator testst run on AVDs with Android 33 so that the differences between those tests runs and those running on AVDs with Android 34 (`Linux linux_android_emulator_tests`) may be observed.

Related to https://github.com/flutter/flutter/issues/137947.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-11 21:25:07 +00:00
Matan Lurey
d64cd75e9f Move third_party/stb to flutter/third_party. (flutter/engine#48845) 
As part of eliminating the Flutter buildroot (https://github.com/flutter/flutter/issues/67373), we are moving all third-party dependencies from `//third_party` to `//flutter/third_party`.
 2023-12-11 21:19:35 +00:00
Casey Hillers
b5d6b5274c [ci.yaml] Add DEPS to emulator tests runIf (flutter/engine#48885) 
https://github.com/flutter/cocoon/pull/3333
 2023-12-11 21:10:17 +00:00
Mouad Debbar
ee266e5318 [web] PointerBinding per view (flutter/engine#48248) 
- Move initialization of `PointerBinding`/`KeyboardBinding` out of `FlutterViewEmbedder`.
- `computeEventOffsetToTarget` properly handles events within a given view.
- `PointerBinding` operates on the given Flutter view (it still listens to some `domWindow` events for the implicit view).
    - Stop using globals e.g. `ui.window`, `KeyboardBinding.instance`, `SafariPointerEventWorkaround.instance`, etc.
- `pointer_binding_test.dart` doesn't use globals either.
- `clickDebouncer` is now a static property on `PointerBinding`.

Fixes https://github.com/flutter/flutter/issues/137289
 2023-12-11 20:44:58 +00:00
Zachary Anderson
63e00ce106 Fix _availability_version_check for iOS 11 and 12 (flutter/engine#48624) 
This PR ports more of the implementation of availability checking from
clang-rt into the Engine. In particular, when the call to look up the
symbol `_availability_version_check` fails, this PR falls back on
reading the platform version information out of a plist file at a
well-known location, as is done
[here](2fd66e6eb6/compiler-rt/lib/builtins/os_version_check.c (L163)).

This change fixes a mistake in
https://github.com/flutter/engine/pull/44711, which didn't account for
`_availability_version_check` not being available on iOS 11 and 12.

Fixes https://github.com/flutter/flutter/issues/138711
 2023-12-11 11:51:55 -08:00
Jonah Williams
9c4d689d4c [Impeller] remove trace events that have outlived their usefulness. (flutter/engine#48856) 
Dart timeline tracing events are surprisingly expensive. Lets remove events we're not using to track anything, in favor of CPU profiles.
 2023-12-11 19:43:14 +00:00
Victoria Ashworth
9622acd973 Fix css changes with macOS 13 and Safari (flutter/engine#48807) 
Safari on macOS 13 outputs different styling than before. Adjust tests to accept new changes. 

Fixes https://github.com/flutter/flutter/issues/136274. Fixes https://github.com/flutter/flutter/issues/136279.

Example passing on macOS 12: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_web_engine/16401/overview
Example passing on macOS 13: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_web_engine/16396/overview

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-11 19:31:25 +00:00
gaaclarke
d84b450b1e [Impeller] made the blur entity test able to use the new blur (flutter/engine#48881) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-11 18:10:10 +00:00
skia-flutter-autoroll
e66cb4d55f Roll Dart SDK from cc0067095755 to 611fca7f0c20 (1 revision) (flutter/engine#48880) 
https://dart.googlesource.com/sdk.git/+log/cc0067095755..611fca7f0c20

2023-12-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-216.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-11 17:35:51 +00:00
skia-flutter-autoroll
961ab9f070 Roll Dart SDK from 9acc6e29b779 to e349db99706d (2 revisions) (flutter/engine#48864) 
https://dart.googlesource.com/sdk.git/+log/9acc6e29b779..e349db99706d

2023-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-212.0.dev
2023-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-211.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-09 05:33:21 +00:00
gaaclarke
e315f81ba0 [Impeller] Clamp new blur sigma (flutter/engine#48813) 
fixes `AiksTests.CanRenderBackdropBlurHugeSigma/Metal`

I also tweaked the existing quadratic equation to make sure the minima
is at 500 and `f(0) = 1`.

## before

<img width="1024" alt="Screenshot 2023-12-07 at 4 36 40 PM"
src="https://github.com/flutter/engine/assets/30870216/2f32388d-6960-47b2-a690-5e5be2cd4a9a">


## after
<img width="1022" alt="Screenshot 2023-12-07 at 4 32 11 PM"
src="https://github.com/flutter/engine/assets/30870216/b1855400-656d-41eb-858c-56fb7a1ab4cf">

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
 2023-12-08 16:57:40 -08:00
Matan Lurey
f4f06d00fb Move //third_party/tinygltf to //flutter/third_party/tinygltf (flutter/engine#48852) 
Work towards https://github.com/flutter/flutter/issues/67373.
 2023-12-09 00:47:24 +00:00
Matan Lurey
edbe663168 Roll buildroot, deleting colorama. (flutter/engine#48854) 
Work towards https://github.com/flutter/flutter/issues/67373.

Colorama was removed in https://github.com/flutter/buildroot/pull/800,
 2023-12-08 15:36:16 -08:00
skia-flutter-autoroll
9bae5b5988 Roll Dart SDK from feb35ba49cd7 to 9acc6e29b779 (1 revision) (flutter/engine#48853) 
https://dart.googlesource.com/sdk.git/+log/feb35ba49cd7..9acc6e29b779

2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-210.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 23:18:11 +00:00
Jim Graham
e677fa488e [Impeller] Directly tessellate filled ellipses (flutter/engine#48770) 
Add support for filling ellipses/ovals and greatly simplify the primitive tessellation mechanisms.
 2023-12-08 22:23:03 +00:00
Jonah Williams
3bef2b4693 [Impeller] dont allocate capture strings in release mode. (flutter/engine#48760) 
I'm not exactly sure why, but this seems to stop the allocation of capture labels in release mode.

Fixes https://github.com/flutter/flutter/issues/138908
 2023-12-08 21:55:58 +00:00
John McCutchan
c9528be3c6 Add a new external texture type to Android embedder (flutter/engine#48803) 
The `SurfaceProducer` interface exposes only exposes a Surface to render
on, abstracting away the consumer side of the external texture.

The `ImageReaderSurfaceProducer` implementation of this interface is
included as well as a basic test of that code.

Also, a small refactor so that `ImageTexture` and
`ImageReaderSurfaceProducer` can use the same native C++ code in the
engine.

Subsequent CLs will need to address the following:

- A SurfaceTextureSurfaceProducer (your eyes are probably bleeding from
that name) implementation is needed so we can support GL based systems.
- Update Platform Views to use this new SurfaceProducer type instead of
the legacy types.
- Deprecate SurfaceTexture and ImageTexture external texture types.

Related issue
[#139702](https://github.com/flutter/flutter/issues/139702)
 2023-12-08 13:20:51 -08:00
skia-flutter-autoroll
261ebc4fdb Roll Dart SDK from 422e0bcdcf96 to feb35ba49cd7 (2 revisions) (flutter/engine#48839) 
https://dart.googlesource.com/sdk.git/+log/422e0bcdcf96..feb35ba49cd7

2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-209.0.dev
2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-208.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 19:29:12 +00:00
Zachary Anderson
ff0ecf88c5 Run full clang_tidy in presubmit (flutter/engine#48831) 
I'm seeing post-submit runs of full clang_tidy taking about ~20-ish
minutes excluding queue time, so the premise of
https://github.com/flutter/flutter/issues/139769 may be incorrect. In
that case, we should re-enable full clang_tidy in presubmit and observe
any impacts to queue time.

Context is that the clang autoroll became unblocked and landed a roll
that passed clang_tidy checks in presubmit, but then failed in post
submit: https://github.com/flutter/engine/pull/48817
 2023-12-08 10:00:14 -08:00
skia-flutter-autoroll
6ad3d04825 Roll Skia from 13c286972ea3 to e55567fceb5f (4 revisions) (flutter/engine#48834) 
https://skia.googlesource.com/skia.git/+log/13c286972ea3..e55567fceb5f

2023-12-08 kjlubick@google.com Rename legacy Bazel targets in //modules
2023-12-08 johnstiles@google.com Ensure dm reports its progress at least every 4 seconds.
2023-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9da917953470 to d4258544ceac (6 revisions)
2023-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from dc4b1acd4859 to b8ca8de43841 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 16:27:23 +00:00
skia-flutter-autoroll
00b054b86a Roll Dart SDK from 2c928cc12f94 to 422e0bcdcf96 (1 revision) (flutter/engine#48822) 
https://dart.googlesource.com/sdk.git/+log/2c928cc12f94..422e0bcdcf96

2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-207.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 15:32:51 +00:00
Jackson Gardner
3133e1fbca Add the flutter_js target as a dep to web_sdk. (flutter/engine#48814) 
Currently, the `flutter_js` target is built as part of the flutter_web_sdk_archive target. However, it should also be built when doing the normal web_sdk, as that is what the monorepo builds (and does its own archiving).
 2023-12-08 15:28:12 +00:00
skia-flutter-autoroll
404b3cdb1b Roll Dart SDK from be8a95b6717d to 2c928cc12f94 (6 revisions) (flutter/engine#48818) 
https://dart.googlesource.com/sdk.git/+log/be8a95b6717d..2c928cc12f94

2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-206.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-205.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-204.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-203.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-202.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-201.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 02:24:22 +00:00
gaaclarke
4124911784 [Impeller] implements new blur tile mode (flutter/engine#48805) 
fixes https://github.com/flutter/flutter/issues/139165

## before

<img width="1027" alt="Screenshot 2023-12-07 at 2 18 42 PM"
src="https://github.com/flutter/engine/assets/30870216/606d7203-20d6-4efd-a788-2f539508a280">


## after

<img width="1026" alt="Screenshot 2023-12-07 at 2 14 39 PM"
src="https://github.com/flutter/engine/assets/30870216/8209b372-e477-4552-b4d1-2296b1e6d2d8">


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-12-07 16:06:04 -08:00
skia-flutter-autoroll
c97bdcde90 Roll Skia from dd7e37c0e2bd to 9e89d96899f4 (2 revisions) (flutter/engine#48809) 
https://skia.googlesource.com/skia.git/+log/dd7e37c0e2bd..9e89d96899f4

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d5f6f7c34c83 to 9da917953470 (7 revisions)
2023-12-07 johnstiles@google.com Improve diagnostic text from NoDestructor.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 23:12:15 +00:00
skia-flutter-autoroll
91da8ecf7d Roll Skia from b541f668f531 to dd7e37c0e2bd (3 revisions) (flutter/engine#48804) 
https://skia.googlesource.com/skia.git/+log/b541f668f531..dd7e37c0e2bd

2023-12-07 bungeman@google.com Fix spelling of MININUM
2023-12-07 nscobie@google.com Allow any exception to pass SkQP's SkSL error tests
2023-12-07 briansalomon@gmail.com Remove empty source list from shared_sources.gni

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 22:21:41 +00:00
Jason Simmons
e1ddb5e7f6 Revert Dart SDK back to be8a95b6717d (flutter/engine#48799) 
See https://github.com/flutter/flutter/issues/139755
 2023-12-07 21:59:06 +00:00
Victoria Ashworth
31210e4a38 Retry when safaridriver fails (flutter/engine#48791) 
Starting `safaridriver` is flakey sometimes on macOS 13. It will occasionally error with "Operation not permitted". As a workaround, if it fails with that message, retry starting `safaridriver`.

Fixes https://github.com/flutter/flutter/issues/136972.

Example of fix on macOS 13 bot: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/564967/overview
Note: The test is still failing due to https://github.com/flutter/flutter/issues/136279, but you can see it first has error "Operation not permitted" and retries and connects on second attempt.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-07 21:55:06 +00:00
skia-flutter-autoroll
301283a2dd Roll Skia from f49ec3e6c1b1 to b541f668f531 (2 revisions) (flutter/engine#48796) 
https://skia.googlesource.com/skia.git/+log/f49ec3e6c1b1..b541f668f531

2023-12-07 jvanverth@google.com [Vulkan] Allow push constants on Qualcomm devices.
2023-12-07 robertphillips@google.com [graphite] Allow 'tall_stretched_bitmaps' to run on the Dawn bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 21:34:26 +00:00
Jason Simmons
09e12e0f51 Reland "Replace use of Fontmgr::RefDefault with explicit creation calls" (flutter/engine#48764) 
Relands https://github.com/flutter/engine/pull/48571 with a patch that uses the directory-based SkFontMgr as a default font manager on Linux
 2023-12-07 15:45:08 +00:00
skia-flutter-autoroll
76b315be4d Roll Skia from 308f3d9bef2c to af998f66ae73 (1 revision) (flutter/engine#48784) 
https://skia.googlesource.com/skia.git/+log/308f3d9bef2c..af998f66ae73

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 945923e21457 to ffaff60d9659 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 15:12:49 +00:00
skia-flutter-autoroll
29c963f361 Roll Dart SDK from be8a95b6717d to 4b22e6430c20 (1 revision) (flutter/engine#48768) 
https://dart.googlesource.com/sdk.git/+log/be8a95b6717d..4b22e6430c20

2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-201.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 05:48:20 +00:00
skia-flutter-autoroll
7227929e66 Roll Skia from 8ebf43ba1c09 to dbcf508d1dce (1 revision) (flutter/engine#48766) 
https://skia.googlesource.com/skia.git/+log/8ebf43ba1c09..dbcf508d1dce

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll skcms from 529510fe003a to 945923e21457 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 05:00:22 +00:00
Jason Simmons
6f48ab3443 Revert "Replace use of Fontmgr::RefDefault with explicit creation calls" (flutter/engine#48755) 
This reverts commit d5d8b5de90f40644f23d309c0f68d03e299334eb.

The flutter/tests/skp_generator test (running in flutter_tester on
Linux) was failing, along with some customer tests.
 2023-12-06 17:50:14 -08:00
skia-flutter-autoroll
e0f9af8da2 Roll Skia from 2abb01e18ab3 to 8ebf43ba1c09 (1 revision) (flutter/engine#48761) 
https://skia.googlesource.com/skia.git/+log/2abb01e18ab3..8ebf43ba1c09

2023-12-07 contact@omeid.me Implement onMatchFamilyStyle for SkParagraph.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 01:50:04 +00:00
godofredoc
3551cb7ac6 Remove obsolete properties. (flutter/engine#48753) 
These properties were used within recipes to generate the gn and ninja commands for the different platforms. With V2 gn commands and its properties are set explicitly and the properties are not required anymore.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-06 22:55:04 +00:00
skia-flutter-autoroll
d9e59a5f9f Roll Skia from 326bdc97ac40 to 570103e08087 (1 revision) (flutter/engine#48746) 
https://skia.googlesource.com/skia.git/+log/326bdc97ac40..570103e08087

2023-12-06 ccameron@chromium.org SkCGUtils: Fix color space usage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 20:17:53 +00:00
Jonah Williams
8b54eb6bf5 [Impeller] Store Buffer/Texture bindings in vector instead of map. (flutter/engine#48719) 
Places the binding data in a vector, since they key was only meaningful on metal but not used anywhere. I don't think that we need to specificially handle the case where our own contents bind the same contents multiple times, but interested to discuss if folks disagree.
 2023-12-06 19:32:41 +00:00
skia-flutter-autoroll
a75c76e6ec Roll Skia from 33cba437bf70 to 326bdc97ac40 (2 revisions) (flutter/engine#48743) 
https://skia.googlesource.com/skia.git/+log/33cba437bf70..326bdc97ac40

2023-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bebb07797be7 to c890c27e81bc
2023-12-06 jvanverth@google.com [GL] Add Apple Silicon support and fix transfer alignment issue.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 19:28:22 +00:00
Jason Simmons
2de054c92a [Impeller] Provide the clear color to an advanced blend if it was optimized out (flutter/engine#48646) 
If all previous elements were skipped due to clear color optimization,
then the clear color must be rendered as an input to the advanced blend
if framebuffer fetch is not available.
 2023-12-06 10:46:22 -08:00
Loïc Sharma
ea34df3c56 [Windows] Set swap interval on raster thread after startup (flutter/engine#47787) 
The EGL context can only be used by a single thread at a time. Currently:

1. The platform thread uses the EGL context to configure the render surface when a `FlutterViewController` is created
2. The raster thread uses the EGL context to render

In a multi-view world, a `FlutterViewController` can be created in parallel to a rendering operation. This results in multiple threads attempting to use the EGL context in parallel, which can crash (see https://github.com/flutter/flutter/issues/137973).

This change configures the render surface on the raster thread if the raster thread exists (aka the engine is running).

Addresses https://github.com/flutter/flutter/issues/137973

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-06 18:44:17 +00:00
Loïc Sharma
6c6f23360c [Windows] Refactor the GLES proc table (flutter/engine#48688) 
GLES functions are resolved at runtime. This refactors how these functions are stored by introducing the `GlProcTable` abstraction.

This is a step towards switching the Windows embedder to `FlutterCompositor` rendering as the present callback will use the `GlProcTable` to render OpenGL backing stores.
 
Part of https://github.com/flutter/flutter/issues/128904

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-06 18:19:36 +00:00
Kevin Lubick
d5d8b5de90 Replace use of Fontmgr::RefDefault with explicit creation calls (flutter/engine#48571) 
In https://g-issues.skia.org/issues/305780908 Skia is removing the
default SkFontMgr. Previous work consolidated all references to
txt/platform.h and this replaces those last references. I attempted to
mirror the existing functionality, which still responds to GN flags and
the target platform.

After this PR, Flutter should not be depending on the default fontmgr
(and the defines in flutter_defines.gni) will maintain that behavior
until the legacy functions/methods are deleted from Skia. There were a
few tests that I missed on an earlier PR which relied on the default
font (helper added in #47493). These tests were failing because they
were making some assertions related to TextBlobs, which didn't work if
the (now-empty) Typeface they loaded had no glyphs. Thus, I added a few
extra asserts to make sure these textblobs *had* glyphs which make the
failing tests less mysterious, should this issue crop up again.

I cleaned up Flutter's BUILD.gn file for Skia a bit, deleting unused
targets related to the font managers. This involved fixing an implicit
dependency from //third_party/glfw/ to `Gdi32.lib` on Windows.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-12-06 13:02:34 -05:00
Jonah Williams
9eb8dc90f3 [Impeller] disable entity culling by default. (flutter/engine#48717) 
From local testing across both flutter galleries, wonderous, some other test apps, the only time this code successfully culls is during the stretch overscroll (and we cull 1 or so entries). The cost of this culling is approximately 20% of entity rendering time, and about 5% of overall raster time.

![image](https://github.com/flutter/engine/assets/8975114/ef85629c-48a8-457f-8385-0c8136404571)
 2023-12-06 18:00:07 +00:00
skia-flutter-autoroll
a84b6362ed Roll Skia from 12dffa893c2a to 23e1cb20a6b5 (1 revision) (flutter/engine#48737) 
https://skia.googlesource.com/skia.git/+log/12dffa893c2a..23e1cb20a6b5

2023-12-06 briansalomon@gmail.com [graphite] Externalize the use of Asyncify to yield in WASM builds.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 17:02:59 +00:00