6633 Commits

Author SHA1 Message Date
Helin Shiah
e62c1f6954
Send text error in JSON and print in tools (#59018) 2020-06-09 11:18:03 -07:00
chunhtai
39e00d2ea4
fix overscroll position if there is sliver before center sliver in custom scroll view (#59015) 2020-06-09 11:13:03 -07:00
Jason Simmons
5736def36c
Handle selection ranges where getBoxesForSelection returns an empty list (#59014) 2020-06-09 11:08:04 -07:00
Pierre-Louis
22ea668f82
Scale input decorator label width (#59010) 2020-06-09 11:03:02 -07:00
chunhtai
17ed4e0b3a
Introduce inherited navigator observer and refactor hero controller (#58808) 2020-06-08 16:18:02 -07:00
chunhtai
333eb9d76a
enable Navigator.of to accept a navigator element and return its stat… (#58259) 2020-06-08 16:13:02 -07:00
Greg Spencer
d7321d92b8
Make _RenderSlider not be a semantics container (#58535)
This PR makes _RenderSlider not be a semantics container. This is so that the FocusableActionDetector in the Slider widget will get to aggregate the semantics information, since otherwise Talkback won't focus the slider because it thinks that the focus node doesn't have anything to say (which it doesn't but the _RenderSlider child does). If the _RenderSlider is a semantics container, then it keeps its speakable information to itself, but it isn't the Focus widget, so when the keyboard focus goes to the focus node, the accessibility focus doesn't move.

Since the _RenderSlider is always wrapped by the Slider widget, there's nothing lost in making it not be a container.
2020-06-08 14:04:45 -07:00
Per Classon
452e6b17c7
Add collapsed height param to SliverAppBar (#58593) 2020-06-08 13:18:02 -07:00
dev-aentgs
2802095104
Update animation.dart (#58971) 2020-06-08 12:42:58 -07:00
Jonah Williams
0620cfa770
Revert "Send text error in JSON and print in tools (#58994)" (#59002)
This reverts commit f0174b176a87ca12a8128ca1cd5edadcfede46b5.
2020-06-08 11:56:23 -07:00
Helin Shiah
f0174b176a
Send text error in JSON and print in tools (#58994)
* Revert "Revert "Send text error in JSON and print in tools (#58284)" (#58872)"

This reverts commit c2d5e18cb2df9400ab3b34f12fb1eba957084e2f.

* Put streamListen in try/catch if extension events already listened for
2020-06-08 11:24:23 -07:00
LongCatIsLooong
b64d652fd1
Add 2 new keyboard types and infer keyboardType from autofill hints (#56641) 2020-06-08 11:23:03 -07:00
Jonah Williams
c2d5e18cb2
Revert "Send text error in JSON and print in tools (#58284)" (#58872)
This reverts commit cce6b3c5aeb12488d7dbec854a0b3adb4b720cd0.
2020-06-06 10:35:58 -07:00
Helin Shiah
cce6b3c5ae
Send text error in JSON and print in tools (#58284)
* Send text error in JSON and print in tools

* Add test for error text

* Fix analysis issues

* Move streamListen to try/catch and use global.printStatus

* Extract print error fn and listen for events in web runner

* Add extension listen request to test

* Update packages/flutter_tools/lib/src/resident_runner.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* Rename error parsing method

* Allow crash if listen for extension stream fails

* Add test for error and non-error extension events

* Fix formatting for TextTreeRenderer

* Use shorter message for second exceptions

* Specify types for map

* Add empty JSON for resident_web_runner test

* Move stream listen to vmservice and add vmservice test

* Fix stream type

* Move structured error log definition to vmservice

* Use correct test matcher isNot

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-06-05 19:07:37 -07:00
Kabo
8b201b988b
Update build doc (#58754) 2020-06-05 15:43:03 -07:00
chunhtai
5eaaad41fb
fix cupertino page route dismisses hero transition when swipe to the … (#58024)
* fix cupertino page route dismisses hero transition when swipe to the edge

* add more comment

* addressing comments
2020-06-05 15:40:28 -07:00
chunhtai
afbb80b260
fix navigator observer announcement order (#57605)
* fix navigator observer announcement order

* addressing review comments

* update

* fix analyzer
2020-06-05 15:18:50 -07:00
Nils Reichardt
3e273b14e2
[web & desktop] Hide all characters in a TextField, when obscureText is true on web & desktop (#56794) 2020-06-05 15:18:01 -07:00
Michel Feinstein
71a5c61907
Adds physics to the TabBar (#57416) (#57644) 2020-06-05 06:38:03 -07:00
Kate Lovett
3ec6978c9c
Fix custom physics application in TabBarView (#58715) 2020-06-04 16:43:03 -07:00
Michael Rienstra
78c2defae4
Minor correction to documentation for buttonColor (#58117) 2020-06-04 16:38:03 -07:00
jBrennen
e9a4759947
#57730 - Support custom shapes for ListTiles (#57733) 2020-06-04 16:33:02 -07:00
Hans Muller
10ae8698b4
Added MaterialStateProperty overlayColor to InkWell (#58650) 2020-06-04 14:04:11 -07:00
Tomohiro Hattori
03524a426f
Add sample code of GestureDetector with no children (#57838) 2020-06-04 10:43:01 -07:00
Kate Lovett
b915808f63
Step 2 (#57751) 2020-06-04 10:38:02 -07:00
Kate Lovett
8ae64ef1fd
Changing default opt-in (#57511) 2020-06-04 10:33:03 -07:00
chunhtai
8a19145f3e
update build doc string to advocate avoiding doing tasks other than b… (#58213) 2020-06-04 10:18:02 -07:00
William Oprandi
91e7678f79
Allow null value for CheckboxListTile (#58154) 2020-06-03 16:13:01 -07:00
Pedro Massango
997a6ffc00
Pass MaterialButton.disabledElevation into RawMaterialButton (#58209)
* Pass disabledElevation from MaterialButton into RawMaterialButton
2020-06-03 15:12:32 -07:00
Robert Ancell
0b7a08c4f6
Update StandardCodec documentation with double alignment (#58456) 2020-06-03 15:08:01 -07:00
Greg Spencer
82acf02d2c
Make it possible to remove nodes from traversal sort. (#58621) 2020-06-03 14:53:01 -07:00
Ian Hickson
a82a51b052
More information about our error message APIs. (#58350) 2020-06-03 14:49:39 -07:00
Dan Field
c5318f7f07
Make debugSemantics available to profile mode (#58620) 2020-06-03 12:32:35 -07:00
MH Johnson
4bae771509
[Line Heights] Add textHeightBehavior to SelectableText. (#58530) 2020-06-03 11:53:02 -07:00
Ian Hickson
67881172fd
Error message improvements (#58204) 2020-06-02 18:03:03 -07:00
MariaMelnik
7f65c6a8c6
Stopped all animation controllers after toggleable has been detached. (#57809) 2020-06-02 17:58:03 -07:00
Justin McCandless
c940282bf3
InteractiveViewer Widget (#56409) 2020-06-02 17:53:05 -07:00
Ian Hickson
74a2e6a5e0
Various bits of trivial cleanup (#58203) 2020-06-02 13:53:01 -07:00
Tong Mu
729ba11bc4
Add doc and test for Container's hitTest behavior (#57522) 2020-06-02 13:18:01 -07:00
Tong Mu
0bda633509
InkWell uses MaterialStateMouseCursor and defaults to clickable (#58448)
* Adds support for material state mouse cursor to InkWell and InkResponse
* Set their default cursors to be MaterialStateMouseCursor.clickable.
2020-06-02 12:27:11 -07:00
Dan Field
a7f998f0ac
Do not assume imageCache is created when handleMemoryPressure is called (#58503)
* Do not assume imageCache is created when handleMemoryPressure is called

* comment for test
2020-06-02 10:27:50 -07:00
VisheshAtWork
df45748de6
Added Documentation for AnimationController.repeat() (#58098) 2020-06-02 09:16:28 -07:00
LongCatIsLooong
bbb95e5787
EditableText.bringIntoView calls showOnScreen (#58346) 2020-06-01 12:08:01 -07:00
Mehmet Fidanboylu
1d395c5e18
Revert "Add clipBehavior to widgets with clipRect (#55977)" (#58344)
This reverts commit cd593dae1961ca2bc5c045a310f16e6cdffc8294.
2020-05-31 07:41:50 -07:00
Ian Hickson
ffc5602656
Dedupe (and update) the --track-widget-creation documentation (#58206) 2020-05-30 17:48:02 -07:00
Greg Spencer
37f562fa36
Remove callback asserts on FocusableActionDetector (#58272)
This makes the callback arguments to FocusableActionDetector optional, if you (for instance) only want to define shortcuts and actions and a focus node for something.
2020-05-29 15:57:05 -07:00
Justin McCandless
7d17c53992
Helpful assertion for isAlwaysShown error (#58258) 2020-05-29 15:48:01 -07:00
liyuqian
cd593dae19
Add clipBehavior to widgets with clipRect (#55977)
* Add clipBehavior to RenderFlex

* Add clipBehavior to FittedBox

* Add clipBehavior to Flex and FittedBox

* Add clipBehavior to UnconstrainedBox

* Add clipBehavior to Stack and Wrap

* Add clipBehavior to TextEditable

* Add clipBehavior to ListWheelScrollView

* Add clipBehavior to SingleChildScrollView

* Add clipBehavior to RenderViewportBase's widgets

Those widgets are NestedScrollView and ShrinkWrappingViewport.

* Fix tests

* Remove enum Overflow and fix typo

* Remove clipToSize

* Analyze fix

* Remove Mixin and other small fixes

* Fix tests and respect Stack's default clipBehavior

* Add Overflow back to make it non-breaking

* Restore clipBehavior to make it non-breaking

* Small fixes

* Fix rebase
2020-05-29 15:38:50 -07:00
Pedro Massango
af9a409eda
Prevent WhitelistingTextInputFormatter to return a empty string if the current value does not satisfy the formatter (#57264) 2020-05-29 09:48:02 -07:00
Helin Shiah
479f370379
Add function to set structured error early (#58118)
* Add function to set structured error early

* Remove unused imports

* Save test handler in setUp

* Add utils file for shared test service

* Rename structured error functions

* Use setUpAll to save error handler and call initStructuredError from other init

* Rename widget inspector test service

* Remove debugging print statement

* Move error handling setting back to initServiceExtensions

* Rename structured error handler in test

* Namespace environment variable

* Rename test
2020-05-28 16:38:10 -07:00