1002 Commits

Author SHA1 Message Date
Chris Yang
9553f8daa7
Extract common PlatformView functionality: Painting and Semantics (#36955)
* painting and semantics

* more comments

* fixing ci

* review fixes

* add assert for id

* rename custom layer factory to layer builder

* review updates

* partial review fixes

* some doc updates

* more doc updates

* only expose getter for id in PlatformViewController

* doc updates/removing all the  references

* remove extra

* more doc updates

* some doc updates

* more doc fixes

* review fixes
2019-08-02 10:07:59 -07:00
chunhtai
eddcc6bb25
reland Enable selection by default for password text field and expose api to turn on and off context menu options (#37324) 2019-08-01 14:19:04 -07:00
Tong Mu
5bb8d8fcde
Split Mouse from Listener (#36217)
- Splits on{Enter,Hover,Exit} from Listener to MouseRegion. Deprecated API is kept for compatibility.
- Splits on{Enter,Hover,Exit} from RenderPointerListener to RenderMouseRegion.
2019-08-01 11:06:50 -07:00
Yegor
ea32385162
Fix some tests now that the isMultiline flag is added to values (#37328) 2019-08-01 07:33:20 -07:00
Chris Yang
21d6d7efb2
Add comments to an Android Platform view gesture test case to explain the test (#37322) 2019-07-31 17:52:05 -07:00
Michael Goderbauer
6ab2445ef5
Fix Textfields in Semantics Debugger (#37158) 2019-07-31 17:33:38 +02:00
Justin McCandless
d82bca2a31
Fix selection menu not showing after clear (#37042)
This allows the text selection menu to be shown after deleting all text in a text field.
2019-07-31 08:01:15 -07:00
Michael Goderbauer
9a01ed2a55
Revert "reland Enable selection by default for password text field and expose api to turn on and off context menu options (#34676) (#37183)" (#37295)
This reverts commit 7eb09a842e406f15dccb5ac1fac2ec7f511708fb.
2019-07-31 15:34:22 +02:00
chunhtai
7eb09a842e
reland Enable selection by default for password text field and expose api to turn on and off context menu options (#34676) (#37183)
This reverts commit 48c7090f3c2faa20499d2ae8ccca563138d0c215.
2019-07-30 14:19:10 -07:00
LongCatIsLooong
9357e70dfd
use FlutterError in MultiChildRenderObjectWidget (#37187) 2019-07-29 22:11:51 -07:00
Justin McCandless
b2497822e8
Android visible password input type support (#36695)
Android devices can now use the VisibleText input keyboard type.
2019-07-29 15:15:57 -07:00
Justin McCandless
c8be195e95
Fix thumb size calculation (#36887)
Cupertino's thumb would jump up/down in size at the overscroll boundary, and this fixes it.
2019-07-29 10:33:53 -07:00
Tong Mu
24f483cf25
Redo: Modal dismissed by any button (#36956)
This PR makes ModalBarrier dismiss modal with any button press instead of primary button up, by making it use a private recognizer _AnyTapGestureRecognizer that is similar to TapGestureRecognizer but accepts gestures by any single button.
2019-07-28 21:44:21 -07:00
Kate Lovett
616794fca7
Re-land "Part 1: Skia Gold Testing" (#36103) 2019-07-28 12:26:06 -07:00
LongCatIsLooong
e4ebcdf6f4 use SizedBox instead of Container for building collapsed selection (#37048) 2019-07-27 11:48:24 -07:00
chunhtai
48c7090f3c
Revert "Enable selection by default for password text field and expose api to turn on and off context menu options (#34676)" (#37055)
This reverts commit 0d0af31598f5ee0552529bfd3fdc35be1d8fe176.
2019-07-26 18:25:52 -07:00
LongCatIsLooong
9c8badd1b5
Add SliverLayoutBuilder (#35941) 2019-07-26 10:39:44 -07:00
chunhtai
0d0af31598
Enable selection by default for password text field and expose api to turn on and off context menu options (#34676) 2019-07-26 10:03:30 -07:00
Tong Mu
9cbac2a4ce
Revert "Dismiss modal with any button press (#32770)" (#36877)
This reverts commit 1aa4628fa27034deb68743d636be5aba04b4ad6f.
2019-07-24 14:26:46 -07:00
K. P. Sroka
1b57006c82 Prevents infinite loop in Table._computeColumnWidths (#36262) 2019-07-23 19:51:57 -07:00
Devon Carew
d708d9deb2
add an error count field to the Flutter.Error event (#36768)
* add an error count field to the Flutter.Error event

* review comments; more tests

* normalize comments
2019-07-23 17:01:14 -07:00
chunhtai
1cb6b8bb0d
fixes iphone force press keybaord select crashes (#36698) 2019-07-22 13:20:21 -07:00
Todd Volkert
fbd4bb91f6
Revert "AsyncSnapshot.data to throw if error or no data (#34626)" (#36618)
This reverts commit b61fcfd25d0b32ec3791d09493d0235bb9a2b43f.
2019-07-20 22:10:59 -07:00
chunhtai
a52f0f773c
Fixes sliver list does not layout firstchild when child reordered (#36493) 2019-07-19 12:19:05 -07:00
chunhtai
2338576aa6
implement selectable text (#34019) 2019-07-19 12:17:41 -07:00
Kate Lovett
38e41f5aee
SliverFillRemaining accounts for child size when hasScrollBody is false (#35810)
Fixes the hasScrollBody flag not accounting for child size. Adds the ability to specify over-scroll behavior.
2019-07-19 11:35:31 -07:00
Todd Volkert
b61fcfd25d
AsyncSnapshot.data to throw if error or no data (#34626)
This updates `AsyncSnapshot.data` to act as `AsyncSnapshot.requireData`
used to -- and it removes `AsyncSnapshot.requireData`. Correspondingly,
this adds a `StreamBuilder.withoutInitialData()` constructor, makes the
`initialData` argument to the default `StreamBuilder()` constructor required,
and deprecates the `initialData` argument to the `FutureBuilder()` constructor.

See the  breaking change announcement for more info.

https://github.com/flutter/flutter/issues/34545
https://groups.google.com/forum/#!topic/flutter-announce/H6Od0QdsdrI
2019-07-18 16:26:13 -07:00
Tong Mu
1aa4628fa2
Dismiss modal with any button press (#32770)
This PR makes ModalBarrier dismiss modal with any button press instead of primary button up, by making it use a private recognizer _AnyTapGestureRecognizer that claims victor and calls onAnyTapDown immediately after it receives any PointerDownEvent.
2019-07-18 15:33:49 -07:00
Dan Field
b7a49c4afe
fix sliver fixed pinned appbar (#36333) 2019-07-18 10:37:08 -07:00
Mouad Debbar
9c9b71a0fb
Add multi-line flag to semantics (#36297) 2019-07-18 10:36:22 -07:00
chunhtai
4eb11c9f52
Fixes RenderSliverFixedExtentBoxAdaptor correctly calculates leadingGarbage and trailingGarbage. (#36302) 2019-07-17 10:40:07 -07:00
伯言
b2cc97013d Fix FocusTraversalPolicy makes focus lost (#34153) (#34712)
FocusTraversalPolicy keep the previously visited node to avoid hysteresis. But even if the visited focus has been disposed, FocusTraversalPolicy will still use it to requestFocus, which will cause FocusManger to get an abandoned node to get the focus.
2019-07-17 10:00:06 -07:00
chunhtai
7992e3242d
Fix nested scroll view can rebuild if mark dirty during scheduleWarmUpFrame (#36097) 2019-07-17 09:29:08 -07:00
Dan Field
5923f34ce4
Revert "Fix semantics for floating pinned sliver app bar (#35574)" (#36319)
This reverts commit 39baa0995c53cd1378c7a9ede791543ad1e2e711.
2019-07-17 09:24:51 -07:00
Dan Field
c96806ec88
Allow semantics labels to be shorter or longer than raw text (#36243) 2019-07-16 20:40:36 -07:00
Kate Lovett
8809f698cb
Revert "Part 1: Skia Gold Testing (#33688)" (#36094)
This reverts commit eb0b17902876f1a75eb7180c0b9f3571efb312b8.
Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
2019-07-12 13:35:36 -07:00
Kate Lovett
eb0b179028
Part 1: Skia Gold Testing (#33688)
* Fresh PR for Gold integration.

* Nits

* WIP

* Artifacts from merge

* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.

* Updating for CI implementation

* Write out service account

* Writing to skip out

* WIP

* ++

* Fixing depot tools deps

* Windows depot_tools

* Fixing setup scripts

* ++

* depot tools

* ++

* WIP

* Tracing depot_tools clone

* WIP

* ++

* analyzer

* WIP

* chrome typo

* copy artifact

* Working on tests

* Code cleanup

* ++

* Code cleanup, updated tests

* ++ review feedback

* Review

* Analyzer

* Review feedback

* Nits from review

* PRogress

* ++

* Fixing tests

* ++

* Testing repo route

* Just needing documention around new structures.

* cleanup

* Analyzer

* Documentation updates

* Documentation updates

* Cirrus updates

* cirrus nit

* Review feedback

* Review feedback

* Fixing skip comparator

* Fix base directory for Skia Gold case

* ++

* Feedback

* ++

* Fixed uri assertion

* Made GoldensClient abstract, altered SkiaGoldClient constructor

* Analyzer
2019-07-12 12:23:04 -07:00
chunhtai
fc7bd6ad24
refactor out selection handlers (#35207) 2019-07-12 12:13:50 -07:00
Dan Field
7a20148548
Add colorFilterLayer/Widget (#35468) 2019-07-11 15:49:51 -07:00
LongCatIsLooong
539f09f801
Remove _debugWillReattachChildren assertions from _TableElement (#34202) 2019-07-11 13:54:51 -07:00
Justin McCandless
ff53fbe194
Text selection menu show/hide cases (#35219)
Show and hide the text selection menu at the correct time with various gestures in the text field.
2019-07-10 14:08:14 -07:00
chunhtai
a76e39f984
Rendering errors with root causes in the widget layer should have a reference to the widget (#32511) 2019-07-09 10:18:30 -07:00
Kate Lovett
97b2c98642
Navigator pushAndRemoveUntil Fix (#35223)
* Initial work

* ++

* Updated tests

* Moved TestObserver out for access across tests.

* ++

* Added hero tests

* Review feedback

* simplified preceding route overlay

* Review feedback

* trailing doc slash
2019-07-09 10:17:30 -07:00
Dan Field
39baa0995c
Fix semantics for floating pinned sliver app bar (#35574) 2019-07-08 14:02:42 -07:00
Dan Field
f85630b18a
Fix RenderFittedBox when child.size.isEmpty (#35487) 2019-07-03 12:40:06 -07:00
chunhtai
f143fd6a4f
fix Selection handles position is off (#34665) 2019-07-03 10:50:10 -07:00
Siva
3a67442129
Manual roll of engine 45b66b7...ffba2f6 (#35464)
* Manual roll of engine 45b66b7...ffba2f6

git log 45b66b7...ffba2f6 --oneline

ffba2f68d Roll src/third_party/dart b37aa3b036...0abff7b2bb (#9588)
62514cb77 Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (#9587)
9f2721284 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (#9586)
03a31e0ad Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (#9583)

* Fix analyzer warning.
2019-07-02 13:16:00 -07:00
Tong Mu
1a374d820d
New parameter for RawGestureDetector to customize semantics mapping (#33936)
This PR adds a new parameter to RawGestureDetector, `semantics`, which configures how detectors handle semantics gestures. It has a default delegate that keep the current behavior.
2019-07-01 16:17:11 -07:00
Michael Goderbauer
f357f8d19e
Remove print (#35408) 2019-07-01 10:09:43 -07:00
Dan Field
3eb40925e5
Always test semantics (#35110)
Default `semanticsEnabled` to true for `testWidgets` and fix associated bugs
2019-06-28 12:40:23 -07:00