Justin McCandless
5c48d90691
Multiline Selection Menu Position Bug ( #36974 )
...
Fix bug where selection menu appeared at top of screen for multiline inputs.
2019-08-02 15:40:11 -07:00
MH Johnson
4a9b687a03
[Material] FAB refactor - remove unnecessary IconTheme ( #37269 )
...
* Remove unneeded IconTheme from FAB
2019-08-02 14:16:34 -04:00
chunhtai
5df17acb1f
add ontap to textformfield ( #37403 )
2019-08-02 10:34:39 -07:00
Hans Muller
873de56228
Update constructor APIs TooltipTheme, ToggleButtonsTheme, PopupMenuTheme ( #37338 )
...
* Update constructor APIs TooltipTheme, ToggleButtonsTheme, PopupMenuTheme
The constructor signatures for TooltipTheme, ToggleButtonsTheme, PopupMenuTheme have been incompatibly changed. They now require just one theme data parameter.
2019-08-02 10:11:38 -07:00
Justin McCandless
954714c967
Hide text selection handle after entering text ( #37436 )
...
The text caret wasn't being hidden after entering text, this fixes it.
2019-08-02 10:10:39 -07:00
Chris Yang
9553f8daa7
Extract common PlatformView functionality: Painting and Semantics ( #36955 )
...
* painting and semantics
* more comments
* fixing ci
* review fixes
* add assert for id
* rename custom layer factory to layer builder
* review updates
* partial review fixes
* some doc updates
* more doc updates
* only expose getter for id in PlatformViewController
* doc updates/removing all the references
* remove extra
* more doc updates
* some doc updates
* more doc fixes
* review fixes
2019-08-02 10:07:59 -07:00
chunhtai
eddcc6bb25
reland Enable selection by default for password text field and expose api to turn on and off context menu options ( #37324 )
2019-08-01 14:19:04 -07:00
Yegor
58e507ba15
Change the value of kMaxUnsignedSMI for the Web ( #37266 )
...
* Sync the value kMaxUnsignedSMI for the Web
* update events.dart docs
2019-08-01 13:37:15 -07:00
Tong Mu
5bb8d8fcde
Split Mouse from Listener ( #36217 )
...
- Splits on{Enter,Hover,Exit} from Listener to MouseRegion. Deprecated API is kept for compatibility.
- Splits on{Enter,Hover,Exit} from RenderPointerListener to RenderMouseRegion.
2019-08-01 11:06:50 -07:00
Yegor
ea32385162
Fix some tests now that the isMultiline flag is added to values ( #37328 )
2019-08-01 07:33:20 -07:00
Michael Goderbauer
e6dc6a8b5f
Animation API doc improvments ( #35919 )
2019-08-01 10:29:06 +02:00
Chris Yang
21d6d7efb2
Add comments to an Android Platform view gesture test case to explain the test ( #37322 )
2019-07-31 17:52:05 -07:00
Justin McCandless
fb2f3e580e
iOS 13 scrollbar ( #35829 )
...
You can drag the cupertinoscrollbar if you pass an active scrollcontroller to the scrollbar.
2019-07-31 15:52:51 -07:00
Shi-Hao Hong
28dd0fde3b
Clamp Scaffold's max body height when extendBody is true ( #37254 )
2019-07-31 13:42:55 -07:00
Jim Graham
76d13ab318
Reland: Optimize the transformRect and transformPoint methods in matrix_utils. ( #36396 ) ( #37275 )
...
Primarily these methods no longer allocate any objects other than their
return values.
Additionally, the math in the methods is reduced compared to the general
case math based on known input conditions.
Modified to no longer generate infinite values in some finite cases.
2019-07-31 13:25:45 -07:00
liyuqian
e77237d6d3
Reland "Fix the first frame logic in tracing and driver ( #35297 )" ( #37192 )
...
This relands https://github.com/flutter/flutter/pull/35297
The followings have been done to fix the broken tests:
1. Add `didSendFirstFrameRasterizedEvent` extension and its tests
2. Wait for `didSendFirstFrameRasterizedEvent` instead of
`didSendFirstFrameEvent` during start up tests
3. Mark missed (probably newly added) start up tests as flaky
2019-07-31 11:01:52 -07:00
Darren Austin
f0957abcd0
Made the snackbar fallback theme include a full inverse colorScheme. ( #37038 )
2019-07-31 10:43:59 -07:00
Michael Goderbauer
6ab2445ef5
Fix Textfields in Semantics Debugger ( #37158 )
2019-07-31 17:33:38 +02:00
Justin McCandless
d82bca2a31
Fix selection menu not showing after clear ( #37042 )
...
This allows the text selection menu to be shown after deleting all text in a text field.
2019-07-31 08:01:15 -07:00
Michael Goderbauer
9a01ed2a55
Revert "reland Enable selection by default for password text field and expose api to turn on and off context menu options ( #34676 ) ( #37183 )" ( #37295 )
...
This reverts commit 7eb09a842e406f15dccb5ac1fac2ec7f511708fb.
2019-07-31 15:34:22 +02:00
Kate Lovett
9bb7142ef7
Removing leftover skips. ( #37250 )
2019-07-30 14:45:00 -07:00
chunhtai
7eb09a842e
reland Enable selection by default for password text field and expose api to turn on and off context menu options ( #34676 ) ( #37183 )
...
This reverts commit 48c7090f3c2faa20499d2ae8ccca563138d0c215.
2019-07-30 14:19:10 -07:00
LongCatIsLooong
9357e70dfd
use FlutterError in MultiChildRenderObjectWidget ( #37187 )
2019-07-29 22:11:51 -07:00
knaeckeKami
9f0831624a
Add searchFieldLabel to SearchDelegate in order to show a custom hint ( #36409 )
...
* Add searchFieldLabel to SearchDelegate in order to show a custom hint label.
* Add support for specifying textInputAction and keyboardType in SearchDelegate
2019-07-29 15:35:40 -07:00
Justin McCandless
b2497822e8
Android visible password input type support ( #36695 )
...
Android devices can now use the VisibleText input keyboard type.
2019-07-29 15:15:57 -07:00
Justin McCandless
c8be195e95
Fix thumb size calculation ( #36887 )
...
Cupertino's thumb would jump up/down in size at the overscroll boundary, and this fixes it.
2019-07-29 10:33:53 -07:00
Tong Mu
24f483cf25
Redo: Modal dismissed by any button ( #36956 )
...
This PR makes ModalBarrier dismiss modal with any button press instead of primary button up, by making it use a private recognizer _AnyTapGestureRecognizer that is similar to TapGestureRecognizer but accepts gestures by any single button.
2019-07-28 21:44:21 -07:00
Kate Lovett
616794fca7
Re-land "Part 1: Skia Gold Testing" ( #36103 )
2019-07-28 12:26:06 -07:00
Shi-Hao Hong
c1a118bcc3
Add margins to tooltips ( #36963 )
...
* Add margin parameter to tooltips
* Improve tooltip tests to find the tooltip's `Container` instead of arbitrary number of parent calls
2019-07-27 15:20:44 -07:00
LongCatIsLooong
e4ebcdf6f4
use SizedBox instead of Container for building collapsed selection ( #37048 )
2019-07-27 11:48:24 -07:00
Dan Field
bf3a907ce7
Revert Optimize transformRect ( #37049 )
...
* Revert "Optimize the transformRect and transformPoint methods in matrix_utils. (#36396 )"
This reverts commit 9946f7cff9621bf23c22508e7b2529e4126f7f05.
* add test
2019-07-26 22:06:03 -07:00
chunhtai
48c7090f3c
Revert "Enable selection by default for password text field and expose api to turn on and off context menu options ( #34676 )" ( #37055 )
...
This reverts commit 0d0af31598f5ee0552529bfd3fdc35be1d8fe176.
2019-07-26 18:25:52 -07:00
Jonah Williams
3068fc4f7c
Revert "Fix the first frame logic in tracing and driver ( #35297 )" ( #37027 )
...
This reverts commit 68fc7231b33dcb3f7c9e705e321135f009afda49.
2019-07-26 13:08:36 -07:00
brettfingo
38fdf56c16
Fix slider preferred height ( #36028 )
...
[Material] Fix slider preferred height
2019-07-26 13:42:15 -04:00
LongCatIsLooong
9c8badd1b5
Add SliverLayoutBuilder ( #35941 )
2019-07-26 10:39:44 -07:00
lisa-liao
63992e4fde
Add PopupMenuTheme to enable theming color, shape, elevation, text style of Menu ( #36088 )
...
* [Menu] Create Menu theme
* [Menu] Create Menu theme
* [Menu] Formatting changes for Menu theme
* [Menu] Fix spacing difference in theme_data.dart.
* [Menu] Fix spacing difference in theme_data.dart.
* Specifying types
* Formatting changes
* Address PR feedback
* Formatting changes
* Address PR feedback
* Add inherited widget
* Add inherited widget
* Address PR feedback and add inherited widget.
* Formatting changes.
* Address PR feedback
* Address PR feedback
* Address PR feedback
* Address PR feedback
2019-07-26 13:09:33 -04:00
gaaclarke
9b150f134b
Sped up shader warmup by only drawing on a 100x100 surface ( #36482 )
...
Sped up shader warmup by only drawing on a 100x100 surface and doing
the draw calls on top of each other.
2019-07-26 10:05:40 -07:00
chunhtai
0d0af31598
Enable selection by default for password text field and expose api to turn on and off context menu options ( #34676 )
2019-07-26 10:03:30 -07:00
liyuqian
68fc7231b3
Fix the first frame logic in tracing and driver ( #35297 )
...
This should fix https://github.com/flutter/flutter/issues/31442 and https://github.com/flutter/flutter/issues/34867
2019-07-26 09:38:12 -07:00
Shi-Hao Hong
2e43b47008
[Material] ToggleButtons ( #34599 )
...
* Introduces ToggleButtons widget
* Introduces ToggleButtonsTheme inherited widget
* Introduces ThemeData.toggleButtonsTheme property
2019-07-26 09:26:15 -07:00
Shi-Hao Hong
f1e87c48ef
Clarify showDuration and waitDuration API docs and test behavior ( #36970 )
...
* Improve showDuration and waitDuration explanation and tests
* Add condition to test to ensure that tooltip does not show before long press duration is over
2019-07-26 09:24:54 -07:00
Jon Tippens
a3712e361b
Fix minor typos ( #36893 )
2019-07-25 11:48:22 -07:00
Shi-Hao Hong
dee8e4211e
[Material] Implement TooltipTheme and Tooltip.textStyle, update Tooltip defaults ( #36856 )
...
* Implement TooltipThemeData and TooltipTheme
* Add text style property
* Updated tooltip default colors for light and dark theme to match Material specification
2019-07-25 09:09:24 -07:00
Gary Qian
52c801dc4f
Add reference to StrutStyle from TextStyle ( #36867 )
2019-07-24 17:41:12 -07:00
Tong Mu
9cbac2a4ce
Revert "Dismiss modal with any button press ( #32770 )" ( #36877 )
...
This reverts commit 1aa4628fa27034deb68743d636be5aba04b4ad6f.
2019-07-24 14:26:46 -07:00
Shi-Hao Hong
aa6384cbac
Revert "[Material] Implement TooltipTheme and Tooltip.textStyle, fix Tooltip debugLabel, update Tooltip defaults ( #36030 )" ( #36851 )
...
This reverts commit 62158a1bae83aedcc88d66694010911a98fff84a.
2019-07-24 08:55:51 -07:00
Shi-Hao Hong
62158a1bae
[Material] Implement TooltipTheme and Tooltip.textStyle, fix Tooltip debugLabel, update Tooltip defaults ( #36030 )
...
* Implement TooltipThemeData and TooltipTheme
* Add tooltip text style property
* Update default tooltip text style and decoration to match Material specification
* Fix debugLabel incorrectly labeling "white" as "black", and vice versa by default
2019-07-24 08:24:09 -07:00
brandondiamond
e08538c38f
Update visual style of CupertinoSwitch to match iOS 13 ( #36087 )
2019-07-24 08:20:19 -07:00
Harsh Bhikadia
dfc636bdd4
doc : ReorderableListView - added youtube video from WidgetOfTheWeek series ( #36421 )
2019-07-24 08:05:42 -07:00
K. P. Sroka
1b57006c82
Prevents infinite loop in Table._computeColumnWidths ( #36262 )
2019-07-23 19:51:57 -07:00