3952 Commits

Author SHA1 Message Date
Janice Collins
5e39476aef
Remove workaround for markup stripping dartdoc bug (#20748)
* Remove workaround for dart-lang/dartdoc#1125

* Update update_icons.dart for optional const and to remove markup stripping workaround
2018-08-28 13:23:07 -07:00
Jonah Williams
3b309bda07
Add a localization for counter text, separate into own semantic node (#21029) 2018-08-28 12:39:24 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
David Shuckerow
458d0b3d21
Update the reorderable list to use the primary scroll controller when… (#20895) 2018-08-28 12:08:41 -06:00
Greg Spencer
7a07b28c93
Fix typo in AnimatedWidget (#21091) 2018-08-28 09:12:16 -07:00
Amir Hardon
c5b7766cbb
Re-land "Make AndroidView participate in gesture arenas." (#21097)
This re-lands commit c594696.

The original PR was breaking the integration test as while the
gesture was active the AndroidView's parent widget got rebuilt which
disposed the _AndroidViewGestureRecognizer and dropped pointer events
from that point on.

This change adds a unit test that reproduces the failure case, and
fixes it by not rebuilding the _AndroidViewGestureRecognizer if the
list of gesture recognizers did not change.
2018-08-28 08:52:46 -07:00
Michael Goderbauer
f88d2d9c12
Revert 20917 platform view arena (#21086)
This reverts commit c594696f0626e32dcd83d2a7d8c479460d475374.
2018-08-27 17:36:40 -07:00
amirh
c594696f06
Make AndroidView participate in gesture arenas. (#20917)
Pointer events are dispatched to the Android view only if it won
Flutter's gesture arena for the pointer.
Specific gestures that should be dispatched to the android view can be
specified with the gestureRecognizers parameter.
2018-08-27 15:07:19 -07:00
Viet Do
0b93911653
Add Cupertino Countdown Timer Picker (#20966)
Add a countdown timer picker as part of the Cupertino date picker.
2018-08-27 12:37:55 -07:00
Sebastian Podjasek
f8a2fc7c28 Implement resizeToAvoidBottomPadding in CupertinoPageScaffold (#20929) 2018-08-27 11:58:30 -07:00
amirh
688d96b652
Add a creation parameters argument to AndroidView. (#21067)
This allows to pass construction parameters for the embedded Android
view from the Dart side.
2018-08-27 11:24:54 -07:00
amirh
510c0eeaff
Don't ignore the ByteData buffer offset in StringCodec.decode(). (#21011) 2018-08-24 17:19:30 -07:00
liyuqian
5d6707b78e
Expose clipBehavior to more buttons (#20538)
This allows developers to control the clipBehavior of those buttons.
2018-08-24 13:53:54 -07:00
Mehmet Fidanboylu
ac8d442a6f
Fix Dart check failure. (#20995) 2018-08-24 10:15:05 -07:00
xster
c418b2f328
Auto populate nav bar title and previous from page route (#19637) 2018-08-23 18:24:30 -07:00
liyuqian
ce8ba6e8b3
Set the default clip to Clip.none again. (#20752)
This reverts commit 8de0e15e4fdd3a1be8878394a7f8c8bda948e59b and
updates the goldens versoin.

This requires https://github.com/flutter/flutter/pull/20751 to
land first.
2018-08-23 18:05:11 -07:00
jslavitz
3900d42bfa
Control, Shift and Arrow Key functionality for Chromebook (#20204)
* added keyboard functionatliy to android builds

* Added tests

* almost ready for review

* ready for review

* Fixes

* final comments

* final commit

* removing raw keyboard changes

* removing raw keyboard changes

* removing raw keyboard changes

* actual last commit

* fixed the imports

* a few more changes

* A few more changes

* a few changes

* Final changes

* Final changes2

* final actual commit for real

* final actual commit for real2

* final actual commit for real3

* final actual commit for real4

* final

* final 2

* f

* f2

* fin

* fin 2

* fin3

* fin4
2018-08-23 17:16:44 -07:00
amirh
1ba16d55f3
Don't size Android views to (0,0) (#20956)
Virtual displays must have a non zero size. This was causing a crash:
https://github.com/flutter/flutter/issues/20456
2018-08-23 12:29:29 -07:00
Jonah Williams
e235ccd76f
Support disabled animations (#20354) 2018-08-23 11:50:04 -07:00
Viet Do
8e70d54e81
add cupertino localizations (#20756)
add cupertino localizations abstract class and the default cupertino localizations in US English.
2018-08-23 10:10:57 -07:00
amirh
1fc7814bb1
Add a layoutDirection parameter to AndroidView (#20838) 2018-08-22 21:42:40 -07:00
Jonah Williams
09fe34708f
Add localization for expand icon collapse/expand tap hint (#20766) 2018-08-22 10:20:51 -07:00
sir-boformer
09e7902f5b Fix small TabBar inconsistencies (#20887)
Tabs are now padded by 16.0 on the left and right  (used to be 12.0).
2018-08-22 09:42:18 -07:00
amirh
e24ac50871
Add support for GestureArenaTeam captains. (#20883)
The team captain wins the arena on behalf of the team.
When any of the team members claims victory for the arena the captain
accepts the gesture.

This is used when embeddeding platform views - we allow configuring a
set of gestures that should be forwarded to the platform view.
We add the set of gesture recognizers to a GestureArenaTeam with a
captain, and if the captain accepts the gesture we forward it to the
platform view.
2018-08-22 09:31:56 -07:00
liyuqian
ee8754df4a
Add customBorder to InkWell so it can clip ShapeBorder (#20751)
This fixes #20483 by letting InkWell do its own clipping.

PathOp.intersect is not used because we have too many unit tests that rely on clipping (e.g., paints..clipXXX()..drawCircle())

The goldens are updated due to small AA changes of the additional clipPath.
2018-08-22 09:25:01 -07:00
Hans Muller
18e7549bc8
Update BottomNavigationBar.didUpdateWidget() (#20890)
BottomNavigationBar's state needs to update _backgroundColor when its configuration changes.
2018-08-21 17:10:31 -07:00
Ian Hickson
94f9604a96
Cleanup (#20754)
- remove an //ignore that is no longer needed
- fix some intrinsic methods that used the API incorrectly (shouldn't affect correctness but should make things a tiny bit more efficient)
- add some asserts to help track down bugs quicker
- update a TODO to point to the currently relevant bug
- fix some indenting
- improve the naming of some privates to improve readability
2018-08-21 14:02:48 -07:00
Ian Hickson
b7261586e5
Audit TODO syntax (#20837)
Fixes the pattern for some TODOs to match our style guide.

(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
ebeem
9d6d03fc08 Add ability to set collapse mode in flexible space bar (#18526)
* Add ability to set collapse mode in flexible space bar

* Add tests to collapse mode in flexible space bar

* Fix minor style nit

* Fix getting collapse mode does not handle unknown values

* Change const key to final in space bar collapse mode test

* Return null collapse padding if mode is unknown
2018-08-21 10:26:08 -07:00
Ian Hickson
ad1eaff45a
flutter analyze cleanup (#20490)
* `flutter analyze` cleanup

* Make `--dartdocs` work in all modes.
* Make `analyze-sample-code.dart` more resilient.
* Add a test for `analyze-sample-code.dart`.
* Minor cleanup in related code and files.

* Apply review comments

* Fix tests
2018-08-20 12:51:07 -07:00
Hans Muller
2ed8a50e7e
Fix (another) typo in InputDecorationTheme.debugFillProperties() (#20759) 2018-08-20 11:30:21 -07:00
David Shuckerow
a98bfd755c
Wrap the ReorderableList's children with a MergeSemantics (#20715) 2018-08-20 10:48:24 -07:00
Ian Hickson
8c79f40d71
Fixes resulting from audit of issues links (#20772)
* Fixes resulting from audit of issues links

I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.

* Update run_test.dart

skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00
matthew-carroll
3a4ae280e3
Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)
Deprecated CupertinoDialog in favor of a new widget called CupertinoPopupSurface. (#20397)
2018-08-17 15:02:39 -07:00
Janice Collins
82d43b952a
Use markdown table (#20721) 2018-08-17 14:36:24 -07:00
Ian Hickson
3acc278521
Documentation regarding tap gesture callbacks (#20647) 2018-08-17 14:31:35 -07:00
Jonah Williams
e56a73e42c
Add support for by word movement granularities to semantics (#19949) 2018-08-17 12:17:34 -07:00
xster
ea355c66df
Create a ValueListenableBuilder (#19729) 2018-08-15 19:22:08 -07:00
xster
ede7c15a2f
Add doc describing sliver children's lifecycle and persistence options (#19795) 2018-08-15 17:24:32 -07:00
matthew-carroll
21bc9f1b02
iOS Dialog blur, brightness, and layout (#18381)
Rewrote CupertinoAlertDialog to look nearly identical to an alert dialog in iOS. This includes considerations for blur, translucent white background color, button sizing, gap dividers between buttons, and text scaling layout behavior. (#18381)
2018-08-15 12:59:40 -07:00
Michael Goderbauer
4d9c3cc377
Always honor explicitly set keyboardType and inputAction for TextField (#20547)
With this change you can now create "wrapping" text fields that do not show the new line button:

```dart
new TextField(
  maxLines: null,
  keyboardType: TextInputType.text,
);
```
2018-08-15 11:35:49 -07:00
Colin Rofls
fa5374e871 Fix link to input_event_constants.fidl (#20588) 2018-08-15 00:58:29 -07:00
xster
168d6e3e6f
Follow up on #18424 comments (#20125) 2018-08-15 00:43:09 -07:00
Jonah Williams
8de0e15e4f
Revert to defaultClipBehavior (#20578) 2018-08-14 20:23:04 -07:00
Jonah Williams
4b6cc47338
add label to drawer and regression test cases (#20537) 2018-08-14 10:17:39 -07:00
Jonah Williams
33c4cd0f39
Add semantics to cupertino slider (#20476) 2018-08-13 23:43:49 -07:00
Viet Do
1057d39dd0
Support infinite scrolling for CupertinoPicker. (#19789)
Allows the cupertino picker to be scroll infinitely by adding builder.
2018-08-13 12:26:07 -07:00
creativecreatorormaybenot
9b309ba8b6 Addition of settings icons (#20515) 2018-08-13 11:36:44 -07:00
Greg Spencer
ba723b6038
Adding animation links for the *Transition widgets. (#20395)
This adds the animation links for illustrations of the Transition widgets, as well as adding a cross-references to the other transition widgets in the "See also" for each of their docs.
2018-08-12 16:01:39 -07:00
Mikkel Nygaard Ravn
1e565ec42d
Fix typo (#20423) 2018-08-10 13:13:54 +02:00