2772 Commits

Author SHA1 Message Date
Kaushik Iska
fc8b468d84 [macOS] Set the display refresh rate (flutter/engine#21095)
Fixes: https://github.com/flutter/flutter/issues/49222
2020-09-26 06:47:26 -07:00
Emmanuel Garcia
dbca16555e Support dragging native platform views (flutter/engine#21396) 2020-09-25 17:46:34 -07:00
Jenn Magder
cc6409ece6 Remove ASCII art from mDNS error log (flutter/engine#21397) 2020-09-25 11:34:26 -07:00
Alexander Brusher
2afe2bffaf Revert "Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (#20936)" (flutter/engine#21367)
This reverts commit 22e1f69704ed0f67b6b57d72197abac4a35f94b3.
2020-09-25 11:07:10 -07:00
Kaushik Iska
5f34b84423 Embedder API Support for display settings (flutter/engine#21355)
Embedders can now notify shell during startup about the various displays and their corresponding settings.
Adds a notion of Display update type which can later include chages to displays during runtime such as addition / removal / reconfiguration of displays.

We also remove the responsibility of providing the refresh rate from `vsync_waiter` to `DisplayManager`.
Rewires existing platform implementations of the said API to use `Shell::OnDisplayUpdate` to notify the display manager of the startup configuration.

DisplayManager is also thread-safe to account for rasterizer and UI thread accesses.
2020-09-25 11:04:10 -07:00
Dan Field
5e3ad78d3a Avoid sending a 0 DPR to framework (flutter/engine#21389)
* Avoid sending a 0 DPR to framework

* check width and height as well
2020-09-25 10:35:57 -07:00
George Wright
235133f27f Split out embedder_unittests test cases into GL and non-GL tests (flutter/engine#21386) 2020-09-24 17:02:01 -07:00
Robert Ancell
1e7257eb84 Detect errors encoding method channel responses (flutter/engine#21314) 2020-09-25 10:33:38 +12:00
stuartmorgan
e44461bafa Remove legacy C++ EncodableValue (flutter/engine#21359)
When the EncodableValue implementation changed, the old version was
temporarily kept behind an #ifdef to allow temporarily using the old
version, so that the roll would not be blocked. All known existing
clients have migrated, so the legacy version is no longer necessary.
2020-09-24 15:14:12 -07:00
Gary Qian
e714ae10db Locale -> LanguageRange conversion to be more general in Android platformResolvedLocale (flutter/engine#21350) 2020-09-23 21:52:02 -07:00
Jason Simmons
32fbdb6755 Fix boolean value checks in StandardMessageCodec (flutter/engine#21270)
Fixes https://github.com/flutter/flutter/issues/65619
2020-09-23 16:31:07 -07:00
Robert Ancell
4a218b9995 Fix segfault if engine is disposed with an uncompleted task. (flutter/engine#21234) 2020-09-24 11:29:38 +12:00
Tim Sneath
85f44f9584 Update FlutterViewController.mm (flutter/engine#21362)
Tweaked the label here a little for style ("apps", not "application" -- plural and shorter); and "launching" rather than "re-launching"?
2020-09-23 13:52:52 -07:00
xster
1644e2fbcf Re-land deprecate Android v1 embedding classes (flutter/engine#21347) 2020-09-23 11:25:20 -07:00
Jason Simmons
1158faf54c Retain the WindowInsetsAnimation callback if code shrinking is enabled (flutter/engine#21330) 2020-09-23 09:17:02 -07:00
Mehmet Fidanboylu
a5c9b5b79d Remove spurious semicolon (flutter/engine#21333) 2020-09-22 22:53:53 -07:00
Zachary Anderson
01982beebc Revert "Deprecate Android v1 embedding classes (#20868)" (flutter/engine#21338)
This reverts commit 7b1562112962b1b22926938fad6438279ed6467c.
2020-09-22 14:38:18 -07:00
lucasradaelli
82665a7450 [a11y] Flutter sends node roles as part of Fuchsia semantics updates. (flutter/engine#21329) 2020-09-22 13:57:02 -07:00
Felipe Archondo
aa6ea4bff5 [fuchsia] add frames_in_flight info to trace events (flutter/engine#21302)
No tests needed, since there is no change in functionality expected.
2020-09-22 16:02:49 -04:00
stuartmorgan
6cf89de868 [windows] Allow engine flags via environment vars (flutter/engine#21161)
Replaces the (temporary) compile-time option to pass engine switches
with the ability to pass them temporarily at runtime via environment
variables.

This is enabled only for debug/profile to avoid potential issues with
tampering with released applicaitons, but if there is a need for that in
the future it could be added (potentially with a whitelist, as is
currently used for Dart VM flags).

Windows portion of:
https://github.com/flutter/flutter/issues/38569
https://github.com/flutter/flutter/issues/60393
2020-09-22 12:34:24 -07:00
xster
aa3ac9e9aa Enforce exclusivity for activity and fragments attached to the FlutterEngine (flutter/engine#21272) 2020-09-22 10:34:52 -07:00
Dan Field
12edb1dee9 Relax test around a11y updates (flutter/engine#21311) 2020-09-22 01:32:02 -07:00
Jason Simmons
bc82ee9267 Disconnect the view's AndroidKeyProcessor when detaching from the engine (flutter/engine#21307) 2020-09-21 17:42:02 -07:00
George Wright
8d8efa6c9d [manual roll] Roll Fuchsia Linux SDK from K2Oiy-AYh... to 2rXyLF0YK (flutter/engine#21308) 2020-09-21 16:37:02 -07:00
LongCatIsLooong
1357779b57 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (flutter/engine#21303) 2020-09-21 15:27:02 -07:00
Chris Yang
73ae0bb94c Fix iOS platform view's mask view blocking touch events. (flutter/engine#21286) 2020-09-21 15:22:47 -07:00
George Wright
0b0fe27af8 Do not create a TestGLSurface for software-only rendering in EmbedderTest (flutter/engine#21301) 2020-09-21 15:22:03 -07:00
Jenn Magder
01d6878cc8 Dark mode friendly iOS debugging message (flutter/engine#21277) 2020-09-21 15:07:02 -07:00
xster
7b15621129 Deprecate Android v1 embedding classes (flutter/engine#20868) 2020-09-21 15:02:02 -07:00
George Wright
4375d79b8e Split out EmbedderTest{Context,Compositor} to handle software and GL separately (flutter/engine#20962) 2020-09-18 15:37:02 -07:00
LongCatIsLooong
f7449e0965 Implement iOS [UITextInput firstRectForRange:] with markedText (flutter/engine#19929) 2020-09-18 14:31:36 -07:00
Matej Knopp
62a0f720af Discard wrong size layer tree instead of rendering it (flutter/engine#21179) 2020-09-18 12:37:02 -07:00
Dan Field
d9bd7aff97 set old_gen_heap_size to half of available memory on iOS (flutter/engine#20472) 2020-09-18 12:32:02 -07:00
George Wright
82b966ba18 Disable ShellTest.SkipAndSubmitFrame for flakes (flutter/engine#21254) 2020-09-17 16:20:52 -07:00
Martin Kustermann
bbaa27cd9f Add --enable-isolate-groups to allowed flags in switches.cc (flutter/engine#21149)
This will allow customers to try out the lightweight isolate support in the Dart VM in AOT mode.

To be future proof, we also add the negative flags to the allow list, thereby allowing the Dart VM to
change the default in the future, while still allowing customers to opt out.

Issue b/158554251
2020-09-17 14:33:51 -07:00
Felipe Archondo
c58fbeb7a3 [fuchsia] set maxframesinflight to be configurable (flutter/engine#21152)
Add a new field, max_frames_in_flight, to FlutterRunnerProductConfiguration. This allows it to be configurable from Fuchsia.

Tests were added as well to verify the new behavior.
2020-09-17 15:41:03 -04:00
Gary Qian
b2a78b0db5 Remove extraneous window inset call on IME animation (flutter/engine#21213) 2020-09-16 14:04:50 -07:00
stuartmorgan
158f80097d Add an explicit API for font change notification (flutter/engine#21164)
Originally font change notification was handled by forwarding
WM_FONTCHANGE to the Flutter HWND, to avoid adding new API surface, but
that's not a good solution in a multi-window scenario, and it would
require a completely different solution for UWP. It also requires
non-obvious plumbing in the runner.

This replaces that with an explicit API, so that there's a clean and
obvious way for the runner to trigger this event.
2020-09-16 09:47:21 -07:00
Damian Wrobel
ededf03020 Add missing cstring header (fixes fl_renderer_wayland.cc) (flutter/engine#21217) 2020-09-16 09:07:01 -07:00
Jenn Magder
12c871ca5f Verify Flutter clang module, add hook for verifying consumer warnings (flutter/engine#21203) 2020-09-15 21:04:01 -07:00
William Wold
983b6a8636 Add Linux Wayland support (flutter/engine#20629) 2020-09-16 14:13:06 +12:00
Chris Bracken
5793be25e1 [darwin] Header #import hygiene (flutter/engine#21193)
This patch applies the following changes:

* Rename a stray .cc file to .mm (connection_collection.cc).
* Migrate Objective-C #includes to #import as per the style guide.
* #include/#import order updated to reflect the style guide order:
  associated header, system/standard library headers, library headers,
  platform-specific includes.
* Include cstring where we're using strlen.
* Add a missing copyright header in SemanticsObjectTest.mm.

Bugs: https://github.com/flutter/flutter/issues/60025
2020-09-15 18:44:09 -07:00
Hamdi Kahloun
489c648b42 Fix NPE in PlatformPlugin.getClipboardData() (flutter/engine#21189) 2020-09-15 17:00:57 -07:00
Emmanuel Garcia
3a7b283bb3 Account for current open image in FlutterImageView (flutter/engine#21191) 2020-09-15 14:10:55 -07:00
Justin McCandless
1ea1cf2f88 hasStrings Mac (flutter/engine#20531)
Adds the hasStrings method for Mac, and improves the state of unit testing on Mac.
2020-09-15 08:40:27 -07:00
Damian Wrobel
2c4ff91e3c Add missing <cstring> header for (strcmp, strrchr) (flutter/engine#21176)
Fixes the following compilation errors:
../../flutter/shell/platform/linux/fl_platform_plugin.cc:89:7: error: use of undeclared identifier 'strcmp'
  if (strcmp(format, kTextPlainFormat) != 0) {
      ^
../../flutter/shell/platform/linux/fl_platform_plugin.cc:127:7: error: use of undeclared identifier 'strcmp'
  if (strcmp(method, kSetClipboardDataMethod) == 0)
      ^
../../flutter/shell/platform/linux/fl_platform_plugin.cc:129:12: error: use of undeclared identifier 'strcmp'
  else if (strcmp(method, kGetClipboardDataMethod) == 0)
           ^
../../flutter/shell/platform/linux/fl_platform_plugin.cc:131:12: error: use of undeclared identifier 'strcmp'
  else if (strcmp(method, kSystemNavigatorPopMethod) == 0)
           ^
../../flutter/shell/platform/linux/fl_view.cc:194:7: error: use of undeclared identifier 'strcmp'
  if (strcmp(pspec->name, "scale-factor") == 0) {
      ^
../../flutter/shell/platform/linux/fl_engine.cc:67:18: error: use of undeclared identifier 'strrchr'
  gchar* match = strrchr(l, '@');
                 ^
../../flutter/shell/platform/linux/fl_engine.cc:75:11: error: use of undeclared identifier 'strrchr'
  match = strrchr(l, '.');
          ^
../../flutter/shell/platform/linux/fl_engine.cc:83:11: error: use of undeclared identifier 'strrchr'
  match = strrchr(l, '_');
          ^

Signed-off-by: Damian Wrobel <dwrobel@ertelnet.rybnik.pl>
2020-09-15 08:05:12 -07:00
kaisa695275735
85f1cd7356 delete opengl texture when it detatch from surfacetexture. (flutter/engine#18733) 2020-09-14 14:07:39 -07:00
renyou
7d8dc2aa24 Fix an include path to match the others. (flutter/engine#21148) 2020-09-14 10:06:44 -07:00
Greg Spencer
b78f92a7c5 Track lock key down state instead of lock state (flutter/engine#20836)
This converts the GTK keyboard code to track the key down states of the lock modifiers NumLock and CapsLock so that they represent the actual "down" state of the key, rather than the lock state itself.

GTK tracks the lock state, and Flutter expects the down state.
2020-09-13 14:44:25 -07:00
Chris Bracken
2586db3b22 Clean up C++ includes (flutter/engine#21127)
Cleans up header order/grouping for consistency: associated header, C/C++ system/standard library headers, library headers, platform-specific #includes.

Adds <cstring> where strlen, memcpy are being used: there are a bunch of places we use them transitively.

Applies linter-required cleanups. Disables linter on one file due to included RapidJson header. See https://github.com/flutter/flutter/issues/65676

This patch does not cover flutter/shell/platform/darwin. There's a separate, slightly more intensive cleanup for those in progress.
2020-09-11 21:18:35 -07:00